Re: Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47339/#review133162 --- Ship it! Ship It! - Alexander Rukletsov On May 13, 2016,

Re: Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47339/ --- (Updated May 13, 2016, 4:54 p.m.) Review request for mesos and Alexander

Re: Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Jan Schlicht
> On May 13, 2016, 3:16 p.m., Alexander Rukletsov wrote: > > src/slave/http.cpp, line 855 > > > > > > Do we need the first check given we explicitly requested `tokenize()` > > to split endpoint into two parts? > >

Re: Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Alexander Rukletsov
> On May 13, 2016, 1:16 p.m., Alexander Rukletsov wrote: > > src/slave/http.cpp, line 855 > > > > > > Do we need the first check given we explicitly requested `tokenize()` > > to split endpoint into two parts? > >

Re: Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47339/ --- (Updated May 13, 2016, 4:12 p.m.) Review request for mesos and Alexander

Re: Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Alexander Rukletsov
> On May 13, 2016, 10:47 a.m., Alexander Rukletsov wrote: > > src/slave/slave.hpp, line 475 > > > > > > `static`? > > Jan Schlicht wrote: > The function uses `slave->this().id` so it would be a bit inconvenient

Re: Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Jan Schlicht
> On May 13, 2016, 12:47 p.m., Alexander Rukletsov wrote: > > src/slave/slave.hpp, line 475 > > > > > > `static`? The function uses `slave->this().id` so it would be a bit inconvenient to make it static. - Jan

Re: Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47339/#review133075 --- src/slave/http.cpp (line 838)

Review Request 47339: Refactored URL path endpoint extraction.

2016-05-13 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47339/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos