Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-09-05 Thread haosdent huang
> On Aug. 22, 2016, 3:09 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp, > > lines 166-169 > > > > > > Realized an issue. What if the operator changes the flags to

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-09-04 Thread Jie Yu
> On Aug. 22, 2016, 3:09 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp, > > lines 166-169 > > > > > > Realized an issue. What if the operator changes the flags to

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-22 Thread haosdent huang
> On Aug. 22, 2016, 3:09 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp, > > lines 166-169 > > > > > > Realized an issue. What if the operator changes the flags to

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-22 Thread haosdent huang
> On Aug. 22, 2016, 3:04 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 553-559 > > > > > > I think these codes can be merged into a single line > >

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-22 Thread haosdent huang
> On Aug. 22, 2016, 2:52 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp, line 112 > > > > > > This comment needs to be updated. > > haosdent huang wrote: > My bad,

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-22 Thread haosdent huang
> On Aug. 22, 2016, 2:52 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp, line 112 > > > > > > This comment needs to be updated. My bad, let me fix it. - haosdent

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-22 Thread haosdent huang
> On Aug. 22, 2016, 3:09 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp, > > lines 166-169 > > > > > > Realized an issue. What if the operator changes the flags to

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-22 Thread haosdent huang
> On Aug. 22, 2016, 3:04 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 553-559 > > > > > > I think these codes can be merged into a single line > >

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-21 Thread Jie Yu
> On Aug. 22, 2016, 3:09 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp, > > lines 166-169 > > > > > > Realized an issue. What if the operator changes the flags to

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-21 Thread Qian Zhang
> On Aug. 22, 2016, 11:09 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp, > > lines 166-169 > > > > > > Realized an issue. What if the operator changes the flags to

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review146267 --- Fix it, then Ship it! I made some adjustments while

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-21 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review146283 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-21 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review146281 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 21, 2016, 9:29 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 21, 2016, 9:13 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review146248 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 20, 2016, 9:20 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 18, 2016, 4:09 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-17 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 17, 2016, 5:43 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 15, 2016, 1:09 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-14 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 15, 2016, 3:20 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-13 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review145698 --- Fix it, then Ship it!

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-11 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 11, 2016, 2:19 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 10, 2016, 4:32 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 9, 2016, 6:40 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-07 Thread Qian Zhang
> On July 27, 2016, 10:05 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 494 > > > > > > How do we recover this field `updatedLimit`? I mean during agent > >

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 7, 2016, 4:26 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review145030 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-04 Thread haosdent huang
> On July 27, 2016, 2:05 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 494 > > > > > > How do we recover this field `updatedLimit`? I mean during agent > >

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-03 Thread Qian Zhang
> On July 27, 2016, 10:05 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 494 > > > > > > How do we recover this field `updatedLimit`? I mean during agent > >

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 3, 2016, 5:58 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 3, 2016, 5:16 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-02 Thread haosdent huang
> On July 27, 2016, 2:05 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 494 > > > > > > How do we recover this field `updatedLimit`? I mean during agent > >

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-02 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 2, 2016, 5:48 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-01 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 2, 2016, 3:52 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-31 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated July 31, 2016, 5:49 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-28 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review143903 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review143517 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-26 Thread haosdent huang
> On July 26, 2016, 1:40 a.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 498 > > > > > > ``` > > if (info->updatedLimit || limit > currentLimit.get()) { > >

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated July 26, 2016, 5:13 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-26 Thread Qian Zhang
> On July 26, 2016, 9:40 a.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 498 > > > > > > ``` > > if (info->updatedLimit || limit > currentLimit.get()) { > >

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review143465 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review143397 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review143379 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated July 21, 2016, 7:10 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-14 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated July 15, 2016, 3:33 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-14 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated July 14, 2016, 5:29 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review141594 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review141593 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp

Review Request 49851: Implemented `MemorySubsystem`.

2016-07-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository: