Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/
---

(Updated Feb. 1, 2017, 9:11 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Removed 'mediaType' from 'ManifestList' and 'Manifest' as per the latest OCI 
image spec.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

Add protobuf messages for OCI image spec.


Diffs (updated)
-

  include/mesos/oci/spec.hpp PRE-CREATION 
  include/mesos/oci/spec.proto PRE-CREATION 
  src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 

Diff: https://reviews.apache.org/r/52349/diff/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/#review161867
---


Ship it!




Ship It!

- Jie Yu


On Jan. 9, 2017, 7:21 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52349/
> ---
> 
> (Updated Jan. 9, 2017, 7:21 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add protobuf messages for OCI image spec.
> 
> 
> Diffs
> -
> 
>   include/mesos/oci/spec.hpp PRE-CREATION 
>   include/mesos/oci/spec.proto PRE-CREATION 
>   src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 
> 
> Diff: https://reviews.apache.org/r/52349/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/#review160872
---


Ship it!




Ship It!

- Gilbert Song


On Jan. 8, 2017, 11:21 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52349/
> ---
> 
> (Updated Jan. 8, 2017, 11:21 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add protobuf messages for OCI image spec.
> 
> 
> Diffs
> -
> 
>   include/mesos/oci/spec.hpp PRE-CREATION 
>   include/mesos/oci/spec.proto PRE-CREATION 
>   src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 
> 
> Diff: https://reviews.apache.org/r/52349/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/
---

(Updated Jan. 9, 2017, 3:21 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Addressed Jie's comments.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

Add protobuf messages for OCI image spec.


Diffs (updated)
-

  include/mesos/oci/spec.hpp PRE-CREATION 
  include/mesos/oci/spec.proto PRE-CREATION 
  src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 

Diff: https://reviews.apache.org/r/52349/diff/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/#review160842
---


Fix it, then Ship it!





include/mesos/oci/spec.proto (lines 33 - 45)


See my comments below. No need for these two.



include/mesos/oci/spec.proto (line 68)


I would move this out to top level. Similar to what they did in go.

https://github.com/opencontainers/image-spec/blob/master/specs-go/v1/manifest_list.go

This way, it's more consistent with upstream.



include/mesos/oci/spec.proto (line 72)


Add a NOTE here.



include/mesos/oci/spec.proto (line 81)


I'd pull this up to the top level and rename it to ManifestDescriptor.



include/mesos/oci/spec.proto (line 144)


Given that we need to parse manually anyway, we can just use a repeated 
string here:
```
repeated string exposedPorts;
```



include/mesos/oci/spec.proto (line 152)


Ditto. Can this just be a repeated string?


- Jie Yu


On Jan. 3, 2017, 1:54 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52349/
> ---
> 
> (Updated Jan. 3, 2017, 1:54 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add protobuf messages for OCI image spec.
> 
> 
> Diffs
> -
> 
>   include/mesos/oci/spec.hpp PRE-CREATION 
>   include/mesos/oci/spec.proto PRE-CREATION 
>   src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 
> 
> Diff: https://reviews.apache.org/r/52349/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Qian Zhang]

> On Dec. 16, 2016, 8:32 a.m., Jie Yu wrote:
> > include/mesos/oci/spec.proto, line 90
> > 
> >
> > How do we support parsing `annotations`?
> > 
> > Should we use a different name so we can do manual parsing?
> > 
> > Also, i'd like to introduce a common `Label` message instead of 
> > `EntryWithStringValue`
> 
> Qian Zhang wrote:
> > How do we support parsing `annotations`?
> 
> That's the suggested way to handle `map` in protobuf, see 
> https://developers.google.com/protocol-buffers/docs/proto#maps (the backwards 
> compatible way) for details, I think `annotations` will be automatically 
> parsed in this way.
> 
> > Also, i'd like to introduce a common `Label` message instead of 
> `EntryWithStringValue`
> 
> Do you mean we rename `EntryWithStringValue` to `Label` and define it in 
> a common place rather than in this file?
> 
> Jie Yu wrote:
> Ah, didn't realize that Map is already supported in proto2. We definitely 
> need to add parsing support for that (i.e., json -> protobuf). Not sure how 
> backwards compatibility will be handled. However, if it is used in agent 
> only, it should not be a problem.
> 
> Qian Zhang wrote:
> The protobuf that we are using (protobuf-2.6.1) does not support `map`, 
> as MPark mentioned in the dev list, we need to upgrade to protobuf 3.0.0 to 
> have `map` support. Do you think we need to do the upgrade right away, or we 
> can use the backwards compatible way mentioned in the above link first in 
> this project and do the upgrade later?

Let's follow the similar way of https://reviews.apache.org/r/47199/ to do the 
manual parsing for now, and in future when we upgrade the protobuf to a newer 
version in Mesos to support `Map`, we can remove that manual parsing logic and 
just use the `Map` keyword.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/#review159391
---


On Jan. 3, 2017, 9:53 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52349/
> ---
> 
> (Updated Jan. 3, 2017, 9:53 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add protobuf messages for OCI image spec.
> 
> 
> Diffs
> -
> 
>   include/mesos/oci/spec.hpp PRE-CREATION 
>   include/mesos/oci/spec.proto PRE-CREATION 
>   src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 
> 
> Diff: https://reviews.apache.org/r/52349/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/
---

(Updated Jan. 3, 2017, 9:53 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Addressed Jie and Avinash's comments.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

Add protobuf messages for OCI image spec.


Diffs (updated)
-

  include/mesos/oci/spec.hpp PRE-CREATION 
  include/mesos/oci/spec.proto PRE-CREATION 
  src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 

Diff: https://reviews.apache.org/r/52349/diff/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Qian Zhang]

> On Dec. 16, 2016, 8:32 a.m., Jie Yu wrote:
> > include/mesos/oci/spec.proto, line 90
> > 
> >
> > How do we support parsing `annotations`?
> > 
> > Should we use a different name so we can do manual parsing?
> > 
> > Also, i'd like to introduce a common `Label` message instead of 
> > `EntryWithStringValue`
> 
> Qian Zhang wrote:
> > How do we support parsing `annotations`?
> 
> That's the suggested way to handle `map` in protobuf, see 
> https://developers.google.com/protocol-buffers/docs/proto#maps (the backwards 
> compatible way) for details, I think `annotations` will be automatically 
> parsed in this way.
> 
> > Also, i'd like to introduce a common `Label` message instead of 
> `EntryWithStringValue`
> 
> Do you mean we rename `EntryWithStringValue` to `Label` and define it in 
> a common place rather than in this file?
> 
> Jie Yu wrote:
> Ah, didn't realize that Map is already supported in proto2. We definitely 
> need to add parsing support for that (i.e., json -> protobuf). Not sure how 
> backwards compatibility will be handled. However, if it is used in agent 
> only, it should not be a problem.

The protobuf that we are using (protobuf-2.6.1) does not support `map`, as 
MPark mentioned in the dev list, we need to upgrade to protobuf 3.0.0 to have 
`map` support. Do you think we need to do the upgrade right away, or we can use 
the backwards compatible way mentioned in the above link first in this project 
and do the upgrade later?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/#review159391
---


On Dec. 11, 2016, 10:15 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52349/
> ---
> 
> (Updated Dec. 11, 2016, 10:15 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add protobuf messages for OCI image spec.
> 
> 
> Diffs
> -
> 
>   include/mesos/oci/spec.hpp PRE-CREATION 
>   include/mesos/oci/spec.proto PRE-CREATION 
>   src/Makefile.am a4c03c2b918816e6dd8872d37e5208f055619c47 
> 
> Diff: https://reviews.apache.org/r/52349/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Jie Yu]

> On Dec. 16, 2016, 12:32 a.m., Jie Yu wrote:
> > include/mesos/oci/spec.proto, line 64
> > 
> >
> > No need for the `Image` prefix here.
> 
> Qian Zhang wrote:
> Do you mean we name it as `ManifestList`? But it seems not consistent 
> with what we did for Appc and Docker, we have the name like `ImageManifest` 
> in both Appc spec and Docker and spec.

image is in the package namespace already. We don't do that for docker or appc


> On Dec. 16, 2016, 12:32 a.m., Jie Yu wrote:
> > include/mesos/oci/spec.proto, line 90
> > 
> >
> > How do we support parsing `annotations`?
> > 
> > Should we use a different name so we can do manual parsing?
> > 
> > Also, i'd like to introduce a common `Label` message instead of 
> > `EntryWithStringValue`
> 
> Qian Zhang wrote:
> > How do we support parsing `annotations`?
> 
> That's the suggested way to handle `map` in protobuf, see 
> https://developers.google.com/protocol-buffers/docs/proto#maps (the backwards 
> compatible way) for details, I think `annotations` will be automatically 
> parsed in this way.
> 
> > Also, i'd like to introduce a common `Label` message instead of 
> `EntryWithStringValue`
> 
> Do you mean we rename `EntryWithStringValue` to `Label` and define it in 
> a common place rather than in this file?

Ah, didn't realize that Map is already supported in proto2. We definitely need 
to add parsing support for that (i.e., json -> protobuf). Not sure how 
backwards compatibility will be handled. However, if it is used in agent only, 
it should not be a problem.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/#review159391
---


On Dec. 11, 2016, 2:15 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52349/
> ---
> 
> (Updated Dec. 11, 2016, 2:15 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add protobuf messages for OCI image spec.
> 
> 
> Diffs
> -
> 
>   include/mesos/oci/spec.hpp PRE-CREATION 
>   include/mesos/oci/spec.proto PRE-CREATION 
>   src/Makefile.am a4c03c2b918816e6dd8872d37e5208f055619c47 
> 
> Diff: https://reviews.apache.org/r/52349/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Qian Zhang]

> On Dec. 16, 2016, 8:32 a.m., Jie Yu wrote:
> > include/mesos/oci/spec.proto, line 64
> > 
> >
> > No need for the `Image` prefix here.

Do you mean we name it as `ManifestList`? But it seems not consistent with what 
we did for Appc and Docker, we have the name like `ImageManifest` in both Appc 
spec and Docker and spec.


> On Dec. 16, 2016, 8:32 a.m., Jie Yu wrote:
> > include/mesos/oci/spec.proto, line 90
> > 
> >
> > How do we support parsing `annotations`?
> > 
> > Should we use a different name so we can do manual parsing?
> > 
> > Also, i'd like to introduce a common `Label` message instead of 
> > `EntryWithStringValue`

> How do we support parsing `annotations`?

That's the suggested way to handle `map` in protobuf, see 
https://developers.google.com/protocol-buffers/docs/proto#maps (the backwards 
compatible way) for details, I think `annotations` will be automatically parsed 
in this way.

> Also, i'd like to introduce a common `Label` message instead of 
> `EntryWithStringValue`

Do you mean we rename `EntryWithStringValue` to `Label` and define it in a 
common place rather than in this file?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/#review159391
---


On Dec. 11, 2016, 10:15 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52349/
> ---
> 
> (Updated Dec. 11, 2016, 10:15 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add protobuf messages for OCI image spec.
> 
> 
> Diffs
> -
> 
>   include/mesos/oci/spec.hpp PRE-CREATION 
>   include/mesos/oci/spec.proto PRE-CREATION 
>   src/Makefile.am a4c03c2b918816e6dd8872d37e5208f055619c47 
> 
> Diff: https://reviews.apache.org/r/52349/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/#review159391
---




include/mesos/oci/spec.proto (line 17)


+1 using oci.spec.image.

Also, looks like they start to prefix with v1. Let's use that as well:
```
oci.spec.image.v1
```



include/mesos/oci/spec.proto (line 64)


No need for the `Image` prefix here.



include/mesos/oci/spec.proto (line 90)


How do we support parsing `annotations`?

Should we use a different name so we can do manual parsing?

Also, i'd like to introduce a common `Label` message instead of 
`EntryWithStringValue`


- Jie Yu


On Dec. 11, 2016, 2:15 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52349/
> ---
> 
> (Updated Dec. 11, 2016, 2:15 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add protobuf messages for OCI image spec.
> 
> 
> Diffs
> -
> 
>   include/mesos/oci/spec.hpp PRE-CREATION 
>   include/mesos/oci/spec.proto PRE-CREATION 
>   src/Makefile.am a4c03c2b918816e6dd8872d37e5208f055619c47 
> 
> Diff: https://reviews.apache.org/r/52349/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/#review158819
---


Fix it, then Ship it!




Ship It!


include/mesos/oci/spec.proto (line 17)


Should have pointed this out earlier. Sorry. We probably should have 
`oci.spec.image` since these protobufs are specific to the image specification. 

Not sure we will have protobufs for the run-time spec but I think it might 
be helpful to explicit about the namespaces here since the specifications for 
image and run-time are distinct. 

This would also imply that we might want to change the name of the files? 
Maybe spec_image.proto


- Avinash sridharan


On Dec. 11, 2016, 2:15 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52349/
> ---
> 
> (Updated Dec. 11, 2016, 2:15 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add protobuf messages for OCI image spec.
> 
> 
> Diffs
> -
> 
>   include/mesos/oci/spec.hpp PRE-CREATION 
>   include/mesos/oci/spec.proto PRE-CREATION 
>   src/Makefile.am a4c03c2b918816e6dd8872d37e5208f055619c47 
> 
> Diff: https://reviews.apache.org/r/52349/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/
---

(Updated Dec. 11, 2016, 10:15 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Addressed Avinash's commentes.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

Add protobuf messages for OCI image spec.


Diffs (updated)
-

  include/mesos/oci/spec.hpp PRE-CREATION 
  include/mesos/oci/spec.proto PRE-CREATION 
  src/Makefile.am a4c03c2b918816e6dd8872d37e5208f055619c47 

Diff: https://reviews.apache.org/r/52349/diff/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/#review158194
---




include/mesos/oci/spec.proto (line 24)


Might want to add a comment highlgihting the possible media types:
https://github.com/opencontainers/image-spec/blob/master/media-types.md



include/mesos/oci/spec.proto (line 59)


This represents a media-type. In the comments we should highlight the OCI 
MIME type of this message. Will be easier for readers to correlate the message.



include/mesos/oci/spec.proto (line 93)


Ditto on highlighting the OCI MIME type.



include/mesos/oci/spec.proto (line 106)


Ditto on highlighting the OCI MIME type.


- Avinash sridharan


On Dec. 3, 2016, 1:50 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52349/
> ---
> 
> (Updated Dec. 3, 2016, 1:50 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add protobuf messages for OCI image spec.
> 
> 
> Diffs
> -
> 
>   include/mesos/oci/spec.hpp PRE-CREATION 
>   include/mesos/oci/spec.proto PRE-CREATION 
>   src/Makefile.am 85eda538caf39f81f052896e744b7b0c724f81bb 
> 
> Diff: https://reviews.apache.org/r/52349/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/
---

(Updated Dec. 3, 2016, 9:50 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
---

Add protobuf messages for OCI image spec.


Diffs
-

  include/mesos/oci/spec.hpp PRE-CREATION 
  include/mesos/oci/spec.proto PRE-CREATION 
  src/Makefile.am 85eda538caf39f81f052896e744b7b0c724f81bb 

Diff: https://reviews.apache.org/r/52349/diff/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/
---

(Updated Nov. 29, 2016, 10:15 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-5011
https://issues.apache.org/jira/browse/MESOS-5011


Repository: mesos


Description
---

Add protobuf messages for OCI image spec.


Diffs (updated)
-

  include/mesos/oci/spec.hpp PRE-CREATION 
  include/mesos/oci/spec.proto PRE-CREATION 
  src/Makefile.am 85eda538caf39f81f052896e744b7b0c724f81bb 

Diff: https://reviews.apache.org/r/52349/diff/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/
---

(Updated Nov. 25, 2016, 3:47 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-5011
https://issues.apache.org/jira/browse/MESOS-5011


Repository: mesos


Description
---

Add protobuf messages for OCI image spec.


Diffs (updated)
-

  include/mesos/oci/spec.hpp PRE-CREATION 
  include/mesos/oci/spec.proto PRE-CREATION 
  src/Makefile.am 5e0b8406f7f624bd8b03ff76b887f20e22fc66e0 

Diff: https://reviews.apache.org/r/52349/diff/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/
---

(Updated Sept. 29, 2016, 10:50 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased and updated Makefile.am


Bugs: MESOS-5011
https://issues.apache.org/jira/browse/MESOS-5011


Repository: mesos


Description
---

Add protobuf messages for OCI image spec.


Diffs (updated)
-

  include/mesos/oci/spec.hpp PRE-CREATION 
  include/mesos/oci/spec.proto PRE-CREATION 
  src/Makefile.am f093000e0282a8d5ac17e7ba33711690ccdfe68a 

Diff: https://reviews.apache.org/r/52349/diff/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 52349: Add protobuf messages for OCI image spec.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/
---

(Updated Sept. 29, 2016, 11:16 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Enabled building protobuf in Makefile.


Bugs: MESOS-5011
https://issues.apache.org/jira/browse/MESOS-5011


Repository: mesos


Description
---

Add protobuf messages for OCI image spec.


Diffs (updated)
-

  include/mesos/oci/spec.hpp PRE-CREATION 
  include/mesos/oci/spec.proto PRE-CREATION 
  src/Makefile.am fba488f9d676851dd046a8b8c7dd175b3c0d9ef0 

Diff: https://reviews.apache.org/r/52349/diff/


Testing
---


Thanks,

Qian Zhang

Review Request 52349: Add protobuf messages for OCI image spec.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-5011
https://issues.apache.org/jira/browse/MESOS-5011


Repository: mesos


Description
---

Add protobuf messages for OCI image spec.


Diffs
-

  include/mesos/oci/spec.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/52349/diff/


Testing
---


Thanks,

Qian Zhang