Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-03-15 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review169049 --- Ship it! Ship It! - Jiang Yan Xu On March 2, 2017, 10:07

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-03-03 Thread Jiang Yan Xu
> On Nov. 1, 2016, 10:08 p.m., Jie Yu wrote: > > The agent subsystems is a hack to me. I think we should consider support > > running systemd (or other init system) to manage agent process and put it > > under proper cgroup using the init system, rather than doing it ourself. > > Anindya

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-03-03 Thread Jie Yu
> On Nov. 2, 2016, 5:08 a.m., Jie Yu wrote: > > The agent subsystems is a hack to me. I think we should consider support > > running systemd (or other init system) to manage agent process and put it > > under proper cgroup using the init system, rather than doing it ourself. > > Anindya Sinha

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-03-03 Thread Jiang Yan Xu
> On Nov. 1, 2016, 10:08 p.m., Jie Yu wrote: > > The agent subsystems is a hack to me. I think we should consider support > > running systemd (or other init system) to manage agent process and put it > > under proper cgroup using the init system, rather than doing it ourself. > > Anindya

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-03-03 Thread Jie Yu
> On Nov. 2, 2016, 5:08 a.m., Jie Yu wrote: > > The agent subsystems is a hack to me. I think we should consider support > > running systemd (or other init system) to manage agent process and put it > > under proper cgroup using the init system, rather than doing it ourself. > > Anindya Sinha

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-03-03 Thread Jiang Yan Xu
> On Nov. 1, 2016, 10:08 p.m., Jie Yu wrote: > > The agent subsystems is a hack to me. I think we should consider support > > running systemd (or other init system) to manage agent process and put it > > under proper cgroup using the init system, rather than doing it ourself. > > Anindya

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-03-03 Thread Jie Yu
> On Nov. 2, 2016, 5:08 a.m., Jie Yu wrote: > > The agent subsystems is a hack to me. I think we should consider support > > running systemd (or other init system) to manage agent process and put it > > under proper cgroup using the init system, rather than doing it ourself. > > Anindya Sinha

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-03-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review167806 --- Patch looks great! Reviews applied: [53369] Passed command:

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-03-02 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/ --- (Updated March 3, 2017, 6:07 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-03-02 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review167767 --- Fix it, then Ship it! The suggested snippet should fix the

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-03-02 Thread Anindya Sinha
> On March 2, 2017, 9:51 a.m., Jiang Yan Xu wrote: > > src/slave/main.cpp > > Lines 170 (patched) > > > > > > The following is cleaner: > > > > ``` > > Try assignCgroups(const string& subsystems); > >

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-03-02 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/ --- (Updated March 2, 2017, 8:36 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-03-02 Thread Jiang Yan Xu
> On Nov. 1, 2016, 10:08 p.m., Jie Yu wrote: > > The agent subsystems is a hack to me. I think we should consider support > > running systemd (or other init system) to manage agent process and put it > > under proper cgroup using the init system, rather than doing it ourself. > > Anindya

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-03-02 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review167662 --- Fix it, then Ship it! src/slave/main.cpp Lines 170 (patched)

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-03-01 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review167640 --- Patch looks great! Reviews applied: [53369] Passed command:

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-03-01 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/ --- (Updated March 1, 2017, 5:57 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-02-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review166908 --- Patch looks great! Reviews applied: [53369] Passed command:

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2017-02-27 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/ --- (Updated Feb. 27, 2017, 5:47 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2016-11-03 Thread Jiang Yan Xu
> On Nov. 1, 2016, 10:08 p.m., Jie Yu wrote: > > The agent subsystems is a hack to me. I think we should consider support > > running systemd (or other init system) to manage agent process and put it > > under proper cgroup using the init system, rather than doing it ourself. > > Anindya

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2016-11-02 Thread Anindya Sinha
> On Nov. 2, 2016, 5:08 a.m., Jie Yu wrote: > > The agent subsystems is a hack to me. I think we should consider support > > running systemd (or other init system) to manage agent process and put it > > under proper cgroup using the init system, rather than doing it ourself. Agreed. But since

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2016-11-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review154537 --- Patch looks great! Reviews applied: [53369] Passed command:

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

2016-11-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review154512 --- The agent subsystems is a hack to me. I think we should consider

Review Request 53369: Agent cgroup assignment should precede agent initialization.

2016-11-01 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-6523