Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2017-02-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/ --- (Updated Feb. 5, 2017, 6:21 p.m.) Review request for mesos, Daniel Pravat and J

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2017-02-05 Thread Michael Park
> On Feb. 5, 2017, 1:03 a.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/os/lseek.hpp, line 26 > > > > > > Since the Windows signature uses `long` instead of `off_t`, I wonder if > > it is appropriate to do

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2017-02-05 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/#review164278 --- Fix it, then Ship it! 3rdparty/stout/include/Makefile.am (line

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2017-02-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/ --- (Updated Feb. 4, 2017, 5:38 p.m.) Review request for mesos, Daniel Pravat and J

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2017-01-09 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/ --- (Updated Jan. 9, 2017, 6:47 p.m.) Review request for mesos, Daniel Pravat and J

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2016-12-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/ --- (Updated Dec. 21, 2016, 3:42 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2016-12-20 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/ --- (Updated Dec. 20, 2016, 2:31 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2016-12-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/ --- (Updated Dec. 15, 2016, 5:50 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2016-12-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/ --- (Updated Dec. 14, 2016, 3:50 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2016-12-14 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/#review159206 --- Ship it! Ship It! - Daniel Pravat On Dec. 13, 2016, 9:01 p.m

Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2016-12-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/ --- Review request for mesos. Repository: mesos Description --- Introduced a