Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2017-02-05 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54592/
---

(Updated Feb. 5, 2017, 6:21 p.m.)


Review request for mesos, Daniel Pravat and Joris Van Remoortere.


Changes
---

Addressed Alex's comments.


Repository: mesos


Description
---

Introduced an `os::lseek` abstraction in stout.


Diffs (updated)
-

  3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82 
  3rdparty/stout/include/stout/os.hpp ed6fec3ac1c1f9dfb0585178401f4b552822a0a1 
  3rdparty/stout/include/stout/os/lseek.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/54592/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2017-02-05 Thread Michael Park 


> On Feb. 5, 2017, 1:03 a.m., Alex Clemmer wrote:
> > 3rdparty/stout/include/stout/os/lseek.hpp, line 26
> > 
> >
> > Since the Windows signature uses `long` instead of `off_t`, I wonder if 
> > it is appropriate to do a `static_assert` to verify they're appropriately 
> > convertable?

Well, we'd get an error if it's not anyway. Specifically, in the `_lseek` call.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54592/#review164278
---


On Feb. 4, 2017, 5:38 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54592/
> ---
> 
> (Updated Feb. 4, 2017, 5:38 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced an `os::lseek` abstraction in stout.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82 
>   3rdparty/stout/include/stout/os.hpp 
> ed6fec3ac1c1f9dfb0585178401f4b552822a0a1 
>   3rdparty/stout/include/stout/os/lseek.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54592/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2017-02-05 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54592/#review164278
---


Fix it, then Ship it!





3rdparty/stout/include/Makefile.am (line 83)


Should this be fixed?



3rdparty/stout/include/stout/os/lseek.hpp (line 22)


Should we include `try.hpp` and `error.hpp` here also?



3rdparty/stout/include/stout/os/lseek.hpp (line 26)


Since the Windows signature uses `long` instead of `off_t`, I wonder if it 
is appropriate to do a `static_assert` to verify they're appropriately 
convertable?


- Alex Clemmer


On Feb. 5, 2017, 1:38 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54592/
> ---
> 
> (Updated Feb. 5, 2017, 1:38 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced an `os::lseek` abstraction in stout.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82 
>   3rdparty/stout/include/stout/os.hpp 
> ed6fec3ac1c1f9dfb0585178401f4b552822a0a1 
>   3rdparty/stout/include/stout/os/lseek.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54592/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2017-02-04 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54592/
---

(Updated Feb. 4, 2017, 5:38 p.m.)


Review request for mesos, Daniel Pravat and Joris Van Remoortere.


Changes
---

Rebased.


Repository: mesos


Description
---

Introduced an `os::lseek` abstraction in stout.


Diffs (updated)
-

  3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82 
  3rdparty/stout/include/stout/os.hpp ed6fec3ac1c1f9dfb0585178401f4b552822a0a1 
  3rdparty/stout/include/stout/os/lseek.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/54592/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2017-01-09 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54592/
---

(Updated Jan. 9, 2017, 6:47 p.m.)


Review request for mesos, Daniel Pravat and Joris Van Remoortere.


Changes
---

Rebased.


Repository: mesos


Description
---

Introduced an `os::lseek` abstraction in stout.


Diffs (updated)
-

  3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82 
  3rdparty/stout/include/stout/os.hpp ed6fec3ac1c1f9dfb0585178401f4b552822a0a1 
  3rdparty/stout/include/stout/os/lseek.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/54592/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2016-12-21 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54592/
---

(Updated Dec. 21, 2016, 3:42 p.m.)


Review request for mesos, Daniel Pravat and Joris Van Remoortere.


Changes
---

Rebased.


Repository: mesos


Description
---

Introduced an `os::lseek` abstraction in stout.


Diffs (updated)
-

  3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82 
  3rdparty/stout/include/stout/os.hpp ed6fec3ac1c1f9dfb0585178401f4b552822a0a1 
  3rdparty/stout/include/stout/os/lseek.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/54592/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2016-12-20 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54592/
---

(Updated Dec. 20, 2016, 2:31 p.m.)


Review request for mesos and Daniel Pravat.


Repository: mesos


Description
---

Introduced an `os::lseek` abstraction in stout.


Diffs (updated)
-

  3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82 
  3rdparty/stout/include/stout/os.hpp 63265eed28d7345dfa18ac1c5a22ef58a7902c62 
  3rdparty/stout/include/stout/os/lseek.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/54592/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2016-12-15 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54592/
---

(Updated Dec. 15, 2016, 5:50 p.m.)


Review request for mesos and Daniel Pravat.


Repository: mesos


Description
---

Introduced an `os::lseek` abstraction in stout.


Diffs
-

  3rdparty/stout/include/Makefile.am 56c44911ff7015d5825a93ce7a898a60c8624ee7 
  3rdparty/stout/include/stout/os.hpp 63265eed28d7345dfa18ac1c5a22ef58a7902c62 
  3rdparty/stout/include/stout/os/lseek.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/54592/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2016-12-14 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54592/
---

(Updated Dec. 14, 2016, 3:50 p.m.)


Review request for mesos and Daniel Pravat.


Repository: mesos


Description
---

Introduced an `os::lseek` abstraction in stout.


Diffs (updated)
-

  3rdparty/stout/include/Makefile.am 56c44911ff7015d5825a93ce7a898a60c8624ee7 
  3rdparty/stout/include/stout/os.hpp 63265eed28d7345dfa18ac1c5a22ef58a7902c62 
  3rdparty/stout/include/stout/os/lseek.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/54592/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2016-12-14 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54592/#review159206
---


Ship it!




Ship It!

- Daniel Pravat


On Dec. 13, 2016, 9:01 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54592/
> ---
> 
> (Updated Dec. 13, 2016, 9:01 p.m.)
> 
> 
> Review request for mesos and Daniel Pravat.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced an `os::lseek` abstraction in stout.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/Makefile.am fc020bbf65030eb69a42d5c402e38ecb145f4c0f 
>   3rdparty/stout/include/stout/os.hpp 
> cdcbbf488d110e33e796fb0b7414793391761abf 
>   3rdparty/stout/include/stout/os/lseek.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54592/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2016-12-13 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54592/
---

Review request for mesos.


Repository: mesos


Description
---

Introduced an `os::lseek` abstraction in stout.


Diffs
-

  3rdparty/stout/include/Makefile.am fc020bbf65030eb69a42d5c402e38ecb145f4c0f 
  3rdparty/stout/include/stout/os.hpp cdcbbf488d110e33e796fb0b7414793391761abf 
  3rdparty/stout/include/stout/os/lseek.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/54592/diff/


Testing
---


Thanks,

Michael Park