Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

[Kevin Klues]

> On Jan. 9, 2017, 8:24 p.m., Kevin Klues wrote:
> > What is the reason for this change? It seems much more intuitive for me to 
> > have a simple build directive that we simply remove once of the rename is 
> > complete, compared to a custom install-hook that creates a symlink.
> 
> James Peach wrote:
> The rationale is that we don't need to spend time and space building annd 
> installing an extra binary.

OK. Can you at least retain the comment for:
```
# TODO(tomxing): Remove this binary once the
# slave->agent rename is complete(MESOS-3782).
```

so taht we don't forget to remove the install-hook once the full rename is done.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54613/#review160958
---


On Jan. 9, 2017, 8:02 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54613/
> ---
> 
> (Updated Jan. 9, 2017, 8:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Alex Clemmer, Joseph Wu, Michael 
> Park, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6772
> https://issues.apache.org/jira/browse/MESOS-6772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Install a symlink rather than building mesos-slave twice.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 
> 
> Diff: https://reviews.apache.org/r/54613/diff/
> 
> 
> Testing
> ---
> 
> Make install:
> ```
> [jpeach@jpeach mesos.git]$ ls -l /opt/mesos/sbin/
> total 10448
> -rwxr-xr-x 1 root root 5116104 Dec  9 15:27 mesos-agent*
> -rwxr-xr-x 1 root root 5539096 Dec  9 15:27 mesos-master*
> lrwxrwxrwx 1 root root  11 Dec  9 15:27 mesos-slave -> mesos-agent*
> ```
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

[James Peach]

> On Jan. 9, 2017, 8:24 p.m., Kevin Klues wrote:
> > What is the reason for this change? It seems much more intuitive for me to 
> > have a simple build directive that we simply remove once of the rename is 
> > complete, compared to a custom install-hook that creates a symlink.

The rationale is that we don't need to spend time and space building annd 
installing an extra binary.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54613/#review160958
---


On Jan. 9, 2017, 8:02 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54613/
> ---
> 
> (Updated Jan. 9, 2017, 8:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Alex Clemmer, Joseph Wu, Michael 
> Park, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6772
> https://issues.apache.org/jira/browse/MESOS-6772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Install a symlink rather than building mesos-slave twice.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 
> 
> Diff: https://reviews.apache.org/r/54613/diff/
> 
> 
> Testing
> ---
> 
> Make install:
> ```
> [jpeach@jpeach mesos.git]$ ls -l /opt/mesos/sbin/
> total 10448
> -rwxr-xr-x 1 root root 5116104 Dec  9 15:27 mesos-agent*
> -rwxr-xr-x 1 root root 5539096 Dec  9 15:27 mesos-master*
> lrwxrwxrwx 1 root root  11 Dec  9 15:27 mesos-slave -> mesos-agent*
> ```
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54613/#review160958
---



What is the reason for this change? It seems much more intuitive for me to have 
a simple build directive that we simply remove once of the rename is complete, 
compared to a custom install-hook that creates a symlink.

- Kevin Klues


On Jan. 9, 2017, 8:02 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54613/
> ---
> 
> (Updated Jan. 9, 2017, 8:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Alex Clemmer, Joseph Wu, Michael 
> Park, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6772
> https://issues.apache.org/jira/browse/MESOS-6772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Install a symlink rather than building mesos-slave twice.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 
> 
> Diff: https://reviews.apache.org/r/54613/diff/
> 
> 
> Testing
> ---
> 
> Make install:
> ```
> [jpeach@jpeach mesos.git]$ ls -l /opt/mesos/sbin/
> total 10448
> -rwxr-xr-x 1 root root 5116104 Dec  9 15:27 mesos-agent*
> -rwxr-xr-x 1 root root 5539096 Dec  9 15:27 mesos-master*
> lrwxrwxrwx 1 root root  11 Dec  9 15:27 mesos-slave -> mesos-agent*
> ```
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54613/
---

(Updated Jan. 9, 2017, 8:02 p.m.)


Review request for mesos, Benjamin Bannier, Alex Clemmer, Joseph Wu, Michael 
Park, Vinod Kone, and Jiang Yan Xu.


Changes
---

Make change suggested by bbannier.


Bugs: MESOS-6772
https://issues.apache.org/jira/browse/MESOS-6772


Repository: mesos


Description
---

Install a symlink rather than building mesos-slave twice.


Diffs (updated)
-

  src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 

Diff: https://reviews.apache.org/r/54613/diff/


Testing
---

Make install:
```
[jpeach@jpeach mesos.git]$ ls -l /opt/mesos/sbin/
total 10448
-rwxr-xr-x 1 root root 5116104 Dec  9 15:27 mesos-agent*
-rwxr-xr-x 1 root root 5539096 Dec  9 15:27 mesos-master*
lrwxrwxrwx 1 root root  11 Dec  9 15:27 mesos-slave -> mesos-agent*
```


Thanks,

James Peach

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

[James Peach]

> On Dec. 20, 2016, 1:54 p.m., Benjamin Bannier wrote:
> > src/Makefile.am, line 2453
> > 
> >
> > Not yours, but since you touch this it would be great if you could make 
> > these independent commands (i.e., remove the ` &&` here).
> > 
> > I added more cleanups here, https://reviews.apache.org/r/54896/.

Done.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54613/#review159714
---


On Jan. 9, 2017, 8:02 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54613/
> ---
> 
> (Updated Jan. 9, 2017, 8:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Alex Clemmer, Joseph Wu, Michael 
> Park, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6772
> https://issues.apache.org/jira/browse/MESOS-6772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Install a symlink rather than building mesos-slave twice.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 
> 
> Diff: https://reviews.apache.org/r/54613/diff/
> 
> 
> Testing
> ---
> 
> Make install:
> ```
> [jpeach@jpeach mesos.git]$ ls -l /opt/mesos/sbin/
> total 10448
> -rwxr-xr-x 1 root root 5116104 Dec  9 15:27 mesos-agent*
> -rwxr-xr-x 1 root root 5539096 Dec  9 15:27 mesos-master*
> lrwxrwxrwx 1 root root  11 Dec  9 15:27 mesos-slave -> mesos-agent*
> ```
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54613/#review160927
---


Ship it!




Ship It!

- Michael Park


On Dec. 19, 2016, 4:11 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54613/
> ---
> 
> (Updated Dec. 19, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Alex Clemmer, Joseph Wu, Michael 
> Park, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6772
> https://issues.apache.org/jira/browse/MESOS-6772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Install a symlink rather than building mesos-slave twice.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 0f62ec70816e8b48e19d35036285656a6e7cd02b 
> 
> Diff: https://reviews.apache.org/r/54613/diff/
> 
> 
> Testing
> ---
> 
> Make install:
> ```
> [jpeach@jpeach mesos.git]$ ls -l /opt/mesos/sbin/
> total 10448
> -rwxr-xr-x 1 root root 5116104 Dec  9 15:27 mesos-agent*
> -rwxr-xr-x 1 root root 5539096 Dec  9 15:27 mesos-master*
> lrwxrwxrwx 1 root root  11 Dec  9 15:27 mesos-slave -> mesos-agent*
> ```
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54613/#review159750
---



Patch looks great!

Reviews applied: [54613]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Dec. 20, 2016, 12:11 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54613/
> ---
> 
> (Updated Dec. 20, 2016, 12:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Alex Clemmer, Joseph Wu, Michael 
> Park, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6772
> https://issues.apache.org/jira/browse/MESOS-6772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Install a symlink rather than building mesos-slave twice.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 0f62ec70816e8b48e19d35036285656a6e7cd02b 
> 
> Diff: https://reviews.apache.org/r/54613/diff/
> 
> 
> Testing
> ---
> 
> Make install:
> ```
> [jpeach@jpeach mesos.git]$ ls -l /opt/mesos/sbin/
> total 10448
> -rwxr-xr-x 1 root root 5116104 Dec  9 15:27 mesos-agent*
> -rwxr-xr-x 1 root root 5539096 Dec  9 15:27 mesos-master*
> lrwxrwxrwx 1 root root  11 Dec  9 15:27 mesos-slave -> mesos-agent*
> ```
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54613/#review159714
---


Ship it!





src/Makefile.am (line 2446)


Not yours, but since you touch this it would be great if you could make 
these independent commands (i.e., remove the ` &&` here).

I added more cleanups here, https://reviews.apache.org/r/54896/.


- Benjamin Bannier


On Dec. 20, 2016, 1:11 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54613/
> ---
> 
> (Updated Dec. 20, 2016, 1:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Alex Clemmer, Joseph Wu, Michael 
> Park, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6772
> https://issues.apache.org/jira/browse/MESOS-6772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Install a symlink rather than building mesos-slave twice.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 0f62ec70816e8b48e19d35036285656a6e7cd02b 
> 
> Diff: https://reviews.apache.org/r/54613/diff/
> 
> 
> Testing
> ---
> 
> Make install:
> ```
> [jpeach@jpeach mesos.git]$ ls -l /opt/mesos/sbin/
> total 10448
> -rwxr-xr-x 1 root root 5116104 Dec  9 15:27 mesos-agent*
> -rwxr-xr-x 1 root root 5539096 Dec  9 15:27 mesos-master*
> lrwxrwxrwx 1 root root  11 Dec  9 15:27 mesos-slave -> mesos-agent*
> ```
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

[James Peach]

> On Dec. 19, 2016, 8:33 a.m., Jiang Yan Xu wrote:
> > Will we still be able to get the symlink uninstalled? If so then LGTM.

I removed the symlink in `make uninstall`, though there's a lot of other cruft 
left behind.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54613/#review159591
---


On Dec. 20, 2016, 12:11 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54613/
> ---
> 
> (Updated Dec. 20, 2016, 12:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Alex Clemmer, Joseph Wu, Michael 
> Park, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6772
> https://issues.apache.org/jira/browse/MESOS-6772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Install a symlink rather than building mesos-slave twice.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 0f62ec70816e8b48e19d35036285656a6e7cd02b 
> 
> Diff: https://reviews.apache.org/r/54613/diff/
> 
> 
> Testing
> ---
> 
> Make install:
> ```
> [jpeach@jpeach mesos.git]$ ls -l /opt/mesos/sbin/
> total 10448
> -rwxr-xr-x 1 root root 5116104 Dec  9 15:27 mesos-agent*
> -rwxr-xr-x 1 root root 5539096 Dec  9 15:27 mesos-master*
> lrwxrwxrwx 1 root root  11 Dec  9 15:27 mesos-slave -> mesos-agent*
> ```
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54613/
---

(Updated Dec. 20, 2016, 12:11 a.m.)


Review request for mesos, Benjamin Bannier, Alex Clemmer, Joseph Wu, Michael 
Park, Vinod Kone, and Jiang Yan Xu.


Bugs: MESOS-6772
https://issues.apache.org/jira/browse/MESOS-6772


Repository: mesos


Description
---

Install a symlink rather than building mesos-slave twice.


Diffs (updated)
-

  src/Makefile.am 0f62ec70816e8b48e19d35036285656a6e7cd02b 

Diff: https://reviews.apache.org/r/54613/diff/


Testing
---

Make install:
```
[jpeach@jpeach mesos.git]$ ls -l /opt/mesos/sbin/
total 10448
-rwxr-xr-x 1 root root 5116104 Dec  9 15:27 mesos-agent*
-rwxr-xr-x 1 root root 5539096 Dec  9 15:27 mesos-master*
lrwxrwxrwx 1 root root  11 Dec  9 15:27 mesos-slave -> mesos-agent*
```


Thanks,

James Peach

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54613/#review159591
---



Will we still be able to get the symlink uninstalled? If so then LGTM.

- Jiang Yan Xu


On Dec. 19, 2016, 12:32 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54613/
> ---
> 
> (Updated Dec. 19, 2016, 12:32 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Alex Clemmer, Joseph Wu, Michael 
> Park, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6772
> https://issues.apache.org/jira/browse/MESOS-6772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Install a symlink rather than building mesos-slave twice.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a4c03c2b918816e6dd8872d37e5208f055619c47 
> 
> Diff: https://reviews.apache.org/r/54613/diff/
> 
> 
> Testing
> ---
> 
> Make install:
> ```
> [jpeach@jpeach mesos.git]$ ls -l /opt/mesos/sbin/
> total 10448
> -rwxr-xr-x 1 root root 5116104 Dec  9 15:27 mesos-agent*
> -rwxr-xr-x 1 root root 5539096 Dec  9 15:27 mesos-master*
> lrwxrwxrwx 1 root root  11 Dec  9 15:27 mesos-slave -> mesos-agent*
> ```
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54613/#review158920
---



Patch looks great!

Reviews applied: [54613]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Dec. 12, 2016, 5:10 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54613/
> ---
> 
> (Updated Dec. 12, 2016, 5:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Alex Clemmer, Joseph Wu, and 
> Michael Park.
> 
> 
> Bugs: MESOS-6772
> https://issues.apache.org/jira/browse/MESOS-6772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Install a symlink rather than building mesos-slave twice.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a4c03c2b918816e6dd8872d37e5208f055619c47 
> 
> Diff: https://reviews.apache.org/r/54613/diff/
> 
> 
> Testing
> ---
> 
> Make install:
> ```
> [jpeach@jpeach mesos.git]$ ls -l /opt/mesos/sbin/
> total 10448
> -rwxr-xr-x 1 root root 5116104 Dec  9 15:27 mesos-agent*
> -rwxr-xr-x 1 root root 5539096 Dec  9 15:27 mesos-master*
> lrwxrwxrwx 1 root root  11 Dec  9 15:27 mesos-slave -> mesos-agent*
> ```
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 54613: Install a symlink rather than building mesos-slave twice.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54613/
---

Review request for mesos, Benjamin Bannier, Alex Clemmer, and Joseph Wu.


Bugs: MESOS-6772
https://issues.apache.org/jira/browse/MESOS-6772


Repository: mesos


Description
---

Install a symlink rather than building mesos-slave twice.


Diffs
-

  src/Makefile.am a4c03c2b918816e6dd8872d37e5208f055619c47 

Diff: https://reviews.apache.org/r/54613/diff/


Testing
---

Make install:
```
[jpeach@jpeach mesos.git]$ ls -l /opt/mesos/sbin/
total 10448
-rwxr-xr-x 1 root root 5116104 Dec  9 15:27 mesos-agent*
-rwxr-xr-x 1 root root 5539096 Dec  9 15:27 mesos-master*
lrwxrwxrwx 1 root root  11 Dec  9 15:27 mesos-slave -> mesos-agent*
```


Thanks,

James Peach