Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/#review168758 --- Patch looks great! Reviews applied: [56665, 5, 56667, 56753,

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/ --- (Updated March 13, 2017, 12:03 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/#review168656 --- Patch looks great! Reviews applied: [56665, 5, 56667, 56753,

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/#review168653 --- src/authentication/executor/jwt_secret_generator.hpp Lines 17-18

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/#review168648 --- Ship it! Ship It! - Vinod Kone On March 10, 2017, 11:27

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/ --- (Updated March 10, 2017, 12:27 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/#review168562 --- src/authentication/executor/jwt_secret_generator.cpp Lines 39

Re: Review Request 56754: Implemented a JWT secret generator.

> On March 7, 2017, 7:55 p.m., Greg Mann wrote: > > src/tests/secret_generator_tests.cpp > > Lines 55 (patched) > > > > > > Is the `Option::none()` necessary? I think the `value` member > > would be

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/ --- (Updated March 8, 2017, 3:26 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 56754: Implemented a JWT secret generator.

> On March 7, 2017, 8:55 p.m., Greg Mann wrote: > > src/tests/secret_generator_tests.cpp > > Lines 55 (patched) > > > > > > Is the `Option::none()` necessary? I think the `value` member > > would be

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/#review168175 --- Fix it, then Ship it! Looking good! Just a few small comments

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/ --- (Updated March 7, 2017, 4:40 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/ --- (Updated March 7, 2017, 4:36 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 56754: Implemented a JWT secret generator.

> On March 3, 2017, 7:48 a.m., Greg Mann wrote: > > src/authentication/executor/jwt_secret_generator.hpp > > Lines 40 (patched) > > > > > > Use `override` instead of `virtual` here? > > Jan Schlicht wrote: > Do

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/#review168017 --- Patch looks great! Reviews applied: [56623, 56617, 56618, 56901,

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/ --- (Updated March 6, 2017, 3:57 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 56754: Implemented a JWT secret generator.

> On March 3, 2017, 8:48 a.m., Greg Mann wrote: > > src/authentication/executor/jwt_secret_generator.hpp > > Lines 40 (patched) > > > > > > Use `override` instead of `virtual` here? Do we use that for destructors as

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/#review167735 --- Looks good, thanks Jan! A few comments below.

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/ --- (Updated Feb. 28, 2017, 2:39 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/#review166381 --- Patch looks great! Reviews applied: [56623, 56617, 56618, 56901,

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/ --- (Updated Feb. 22, 2017, 3:29 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/ --- (Updated Feb. 16, 2017, 3:55 p.m.) Review request for mesos and Greg Mann.

Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/ --- Review request for mesos and Greg Mann. Bugs: MESOS-7000