Re: Review Request 59015: Implemented passing docker config depended methods.

2017-05-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59015/#review175833 --- Ship it! Ship It! - Vinod Kone On May 23, 2017, 5:54 p.m.,

Re: Review Request 59015: Implemented passing docker config depended methods.

2017-05-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59015/ --- (Updated May 23, 2017, 10:54 a.m.) Review request for mesos, Adam B, Chun-Hung

Re: Review Request 59015: Implemented passing docker config depended methods.

2017-05-22 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59015/#review175746 --- Ship it! Ship It! - Chun-Hung Hsiao On May 22, 2017, 5:59

Re: Review Request 59015: Implemented passing docker config depended methods.

2017-05-22 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59015/#review175742 --- Fix it, then Ship it!

Re: Review Request 59015: Implemented passing docker config depended methods.

2017-05-12 Thread Gilbert Song
> On May 10, 2017, 3:13 p.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > > Lines 87 (patched) > > > > > > s/Secret::Value/JSON::Object/ > > > > This file

Re: Review Request 59015: Implemented passing docker config depended methods.

2017-05-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59015/#review174580 ---

Re: Review Request 59015: Implemented passing docker config depended methods.

2017-05-10 Thread Gilbert Song
> On May 9, 2017, 12:19 a.m., Jie Yu wrote: > > As we discussed offline, let's not mess the URI struct. Instead, passing > > the secret to the fetcher using an function parameter in the `fetch` > > method. This will be useful in the future also because fetcher other URIs > > might need secret

Re: Review Request 59015: Implemented passing docker config depended methods.

2017-05-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59015/ --- (Updated May 10, 2017, 5:47 a.m.) Review request for mesos, Adam B, Chun-Hung