Re: Review Request 60508: Fixed Attributes comparison.

2017-08-03 Thread Ilya Pronin
> On Aug. 2, 2017, 6:56 p.m., Anand Mazumdar wrote: > > include/mesos/v1/attributes.hpp > > Lines 95 (patched) > > > > > > Can we add a comment for posterity on the usage of `contains` and how > > does it differ

Re: Review Request 60508: Fixed Attributes comparison.

2017-08-03 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60508/ --- (Updated Aug. 3, 2017, 1:11 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 60508: Fixed Attributes comparison.

2017-08-02 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60508/#review182010 --- Fix it, then Ship it! Looks good, just some minor comments.

Re: Review Request 60508: Fixed Attributes comparison.

2017-06-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60508/#review179181 --- Bad patch! Reviews applied: [60508] Failed command: python

Review Request 60508: Fixed Attributes comparison.

2017-06-28 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60508/ --- Review request for mesos, Benjamin Mahler and Vinod Kone. Bugs: MESOS-1216