Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 29, 2017, 3:13 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 29, 2017, 3:12 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 29, 2017, 2:36 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review189460 --- Fix it, then Ship it!

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 27, 2017, 9:04 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 26, 2017, 10:49 p.m., Greg Mann wrote: > > include/mesos/resource_provider/resource_provider.proto > > Line 66 (original), 72 (patched) > > > > > > Do you want to use `OFFER_OPERATION` here instead? Or, do

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review189478 --- src/messages/messages.proto Lines 649 (patched)

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 27, 2017, 12:58 p.m.) Review request for mesos, Benjamin

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 16, 2017, 6:33 p.m., Greg Mann wrote: > > src/messages/messages.proto > > Lines 637-638 (patched) > > > > > > I think that this list should include pending operations, but should > > _not_ include

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review189354 --- include/mesos/mesos.proto Lines 2157 (patched)

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 16, 2017, 6:33 p.m., Greg Mann wrote: > > src/messages/messages.proto > > Lines 637-638 (patched) > > > > > > I think that this list should include pending operations, but should > > _not_ include

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 16, 2017, 6:33 p.m., Greg Mann wrote: > > src/messages/messages.proto > > Lines 637-638 (patched) > > > > > > I think that this list should include pending operations, but should > > _not_ include

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 23, 2017, 11:33 p.m., Gaston Kleiman wrote: > > include/mesos/v1/mesos.proto > > Lines 2136 (patched) > > > > > > I think that "info" is a bit too generic. What about "operation_info" > > or "operation"?

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review189004 --- include/mesos/v1/mesos.proto Lines 2136 (patched)

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 18, 2017, 8:21 p.m., Chun-Hung Hsiao wrote: > > include/mesos/v1/mesos.proto > > Lines 2170 (patched) > > > > > > This protobuf is exposed to RP API. Do we want an RP to be aware of the > > scheduler? Do

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 18, 2017, 4:04 a.m., Chun-Hung Hsiao wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 47-48 (original), 47-48 (patched) > > > > > > Do we need to expose `framework_id` to RP if

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 19, 2017, 11:50 a.m., Benjamin Bannier wrote: > > include/mesos/mesos.proto > > Lines 2199-2201 (patched) > > > > > > We will also need to model the case where an offer operation succeeds > > only

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188668 --- include/mesos/mesos.proto Lines 2199-2201 (patched)

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 19, 2017, 12:08 a.m.) Review request for mesos, Benjamin

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 17, 2017, 5:51 p.m., Greg Mann wrote: > > include/mesos/mesos.proto > > Lines 2187-2195 (patched) > > > > > > We also need to include a unique UUID for each operation status update, > > so that the

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188565 --- Since we're designing the RP API, I'd prefer to only expose

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188451 --- include/mesos/resource_provider/resource_provider.proto Lines

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 17, 2017, 10:10 p.m.) Review request for mesos, Benjamin

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 17, 2017, 10:02 p.m., Greg Mann wrote: > > include/mesos/mesos.proto > > Lines 2178 (patched) > > > > > > Let's make this `optional` to handle cases where we send > > `OfferOperationStatus` messages

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188403 --- include/mesos/mesos.proto Lines 2178 (patched)

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 17, 2017, 8:10 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188366 --- src/resource_provider/validation.cpp Line 59 (original), 59

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 16, 2017, 6:33 p.m., Greg Mann wrote: > > src/messages/messages.proto > > Lines 637-638 (patched) > > > > > > I think that this list should include pending operations, but should > > _not_ include

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 17, 2017, 6:52 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 17, 2017, 6:49 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 17, 2017, 6:49 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 17, 2017, 5:59 p.m., Greg Mann wrote: > > src/messages/messages.proto > > Lines 633-639 (patched) > > > > > > I think we also need to include this field in the > > `ReregisterSlaveMessage`, right? That

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 17, 2017, 5:59 p.m., Greg Mann wrote: > > src/messages/messages.proto > > Lines 633-639 (patched) > > > > > > I think we also need to include this field in the > > `ReregisterSlaveMessage`, right? That

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188350 --- src/messages/messages.proto Lines 633-639 (patched)

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188340 --- include/mesos/mesos.proto Lines 2187-2195 (patched)

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 17, 2017, 3:45 p.m., Jan Schlicht wrote: > > include/mesos/mesos.proto > > Lines 2187-2195 (patched) > > > > > > Is the master supposed to keep a `map > Offer::Operation>`? If not,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188286 --- include/mesos/mesos.proto Lines 2187-2195 (patched)

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 17, 2017, 1:17 p.m., James DeFelice wrote: > > include/mesos/mesos.proto > > Lines 111 (patched) > > > > > > unique in the context of the framework? or universally unique? in the context of the framework.

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188305 --- include/mesos/mesos.proto Lines 111 (patched)

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188280 --- FAIL: Some Mesos tests failed. Reviews applied: `['62974',

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 17, 2017, 5:08 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 16, 2017, 6:33 p.m., Greg Mann wrote: > > src/messages/messages.proto > > Lines 643-648 (patched) > > > > > > I think that we need to include the agent’s clock value in this > > message. When the master

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 16, 2017, 9:31 p.m., Gaston Kleiman wrote: > > include/mesos/v1/mesos.proto > > Lines 2129 (patched) > > > > > > should this be a state or status? I remove the `state` because it can be derived from

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 16, 2017, 6:33 p.m., Greg Mann wrote: > > src/messages/messages.proto > > Lines 637-638 (patched) > > > > > > I think that this list should include pending operations, but should > > _not_ include

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188246 --- PASS: Mesos patch 63001 was successfully built and tested.

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188243 --- Patch looks great! Reviews applied: [62974, 63001] Passed

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188235 --- PASS: Mesos patch 63001 was successfully built and tested.

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188215 --- include/mesos/v1/mesos.proto Lines 2129 (patched)

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188213 --- include/mesos/resource_provider/resource_provider.proto Lines 91

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 16, 2017, 7:09 p.m., Greg Mann wrote: > > src/messages/messages.proto > > Lines 665 (patched) > > > > > > Do we want to follow the `_info` naming scheme even though the message > > isn't called

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188194 --- src/messages/messages.proto Lines 665 (patched)

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188162 --- include/mesos/v1/mesos.proto Lines 2124 (patched)

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 16, 2017, 6:32 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 16, 2017, 6:16 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 16, 2017, 10:56 a.m., Jan Schlicht wrote: > > src/messages/messages.proto > > Lines 643-648 (patched) > > > > > > For certain operations like `CREATE_VOLUME` the resources that resulted > > from applying

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188147 --- src/messages/messages.proto Lines 633 (patched)

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 16, 2017, 12:56 p.m., Jan Schlicht wrote: > > src/messages/messages.proto > > Lines 643-648 (patched) > > > > > > For certain operations like `CREATE_VOLUME` the resources that resulted > > from applying

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188116 --- include/mesos/v1/resource_provider/resource_provider.proto Lines

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188081 --- PASS: Mesos patch 63001 was successfully built and tested.

Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Gaston Kleiman,