Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.

> On Nov. 10, 2017, 2:42 p.m., Jan Schlicht wrote: > > src/master/master.cpp > > Lines 9910-9919 (patched) > > > > > > This should be part of `Slave::apply`, as the exact same code is used > > again in

Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63689/#review190715 --- Fix it, then Ship it! src/master/master.cpp Lines 9910-9919

Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63689/#review190662 --- FAIL: Failed to apply the dependent review: 59988. Failed

Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63689/ --- (Updated Nov. 10, 2017, 1:24 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.

> On Nov. 9, 2017, 9:08 a.m., Jan Schlicht wrote: > > src/master/master.cpp > > Lines 10966-10971 (patched) > > > > > > `Master::_apply` will currently always call `Slave::apply`. This means > > that the changes

Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63689/#review190556 --- src/master/master.cpp Lines 10966-10971 (patched)

Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63689/#review190554 --- PASS: Mesos patch 63689 was successfully built and tested.

Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63689/#review190552 --- Patch looks great! Reviews applied: [63689] Passed command:

Review Request 63689: Used `Master::_apply` consistently for all offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63689/ --- Review request for mesos, Benjamin Bannier and Jan Schlicht. Bugs: MESOS-7235