Re: Review Request 65125: Added a helper function for resource provider tests.

2018-01-17 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65125/
---

(Updated Jan. 17, 2018, 2:43 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Rebased and addressed issues.


Bugs: MESOS-8445
https://issues.apache.org/jira/browse/MESOS-8445


Repository: mesos


Description
---

Added a helper function for resource provider tests.


Diffs (updated)
-

  src/tests/api_tests.cpp 6faefc92318c2db0e611d60f187738d0cbb269ff 
  src/tests/mesos.hpp 16c75bb0ca570dfb7089743344cf38acdb517705 
  src/tests/resource_provider_manager_tests.cpp 
d80823c47963e969113dae3623b18b7639c890fc 
  src/tests/slave_tests.cpp 59e3065ad9aadbd90cdfd32e830b433b88d6de86 


Diff: https://reviews.apache.org/r/65125/diff/3/

Changes: https://reviews.apache.org/r/65125/diff/2-3/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 65125: Added a helper function for resource provider tests.

2018-01-17 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65125/#review195551
---


Fix it, then Ship it!





src/tests/mesos.hpp
Lines 3110 (patched)


Let's return an `Owned` here.


- Benjamin Bannier


On Jan. 15, 2018, 3:50 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65125/
> ---
> 
> (Updated Jan. 15, 2018, 3:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8445
> https://issues.apache.org/jira/browse/MESOS-8445
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a helper function for resource provider tests.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp fb45879310faf7edc7d101be206d49de89819c18 
>   src/tests/mesos.hpp 16c75bb0ca570dfb7089743344cf38acdb517705 
>   src/tests/resource_provider_manager_tests.cpp 
> d80823c47963e969113dae3623b18b7639c890fc 
>   src/tests/slave_tests.cpp 59e3065ad9aadbd90cdfd32e830b433b88d6de86 
> 
> 
> Diff: https://reviews.apache.org/r/65125/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65125: Added a helper function for resource provider tests.

2018-01-15 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65125/#review195413
---




src/tests/resource_provider_manager_tests.cpp
Lines 130 (patched)


We still have a lot of repeated code creating these test endpoint 
detectors. I'd suggest moving this into e.g., `tests/mesos.hpp`.

This would allow us to remove more duplication.


- Benjamin Bannier


On Jan. 12, 2018, 3:15 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65125/
> ---
> 
> (Updated Jan. 12, 2018, 3:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8445
> https://issues.apache.org/jira/browse/MESOS-8445
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a helper function for resource provider tests.
> 
> 
> Diffs
> -
> 
>   src/tests/resource_provider_manager_tests.cpp 
> d80823c47963e969113dae3623b18b7639c890fc 
> 
> 
> Diff: https://reviews.apache.org/r/65125/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Review Request 65125: Added a helper function for resource provider tests.

2018-01-12 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65125/
---

Review request for mesos, Benjamin Bannier and Jie Yu.


Repository: mesos


Description
---

Added a helper function for resource provider tests.


Diffs
-

  src/tests/resource_provider_manager_tests.cpp 
d80823c47963e969113dae3623b18b7639c890fc 


Diff: https://reviews.apache.org/r/65125/diff/1/


Testing
---

make check


Thanks,

Jan Schlicht