Re: Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

2018-02-14 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65550/#review197510 --- Ship it! Ship It! - Qian Zhang On Feb. 13, 2018, 7:13 a.m.,

Re: Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

2018-02-12 Thread Gaston Kleiman
> On Feb. 12, 2018, 12:13 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp > > Line 349 (original), 349 (patched) > > > > > > Not yours, but I think we can kill this. I think this was added pre > > mult

Re: Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

2018-02-12 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65550/ --- (Updated Feb. 12, 2018, 3:13 p.m.) Review request for mesos, Anand Mazumdar, Qi

Re: Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

2018-02-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65550/#review197304 --- Fix it, then Ship it! src/launcher/default_executor.cpp Line 3

Re: Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

2018-02-09 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65550/ --- (Updated Feb. 9, 2018, 10:35 p.m.) Review request for mesos, Anand Mazumdar, Qi

Re: Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

2018-02-09 Thread Gaston Kleiman
> On Feb. 9, 2018, 6:36 p.m., Joseph Wu wrote: > > src/launcher/default_executor.cpp > > Lines 539-546 (original), 537 (patched) > > > > > > Since the guard above was removed, this CHECK could potentially be hit > >

Re: Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

2018-02-09 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65550/#review197223 --- src/launcher/default_executor.cpp Lines 539-546 (original), 537 (

Re: Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

2018-02-09 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65550/#review197217 --- src/launcher/default_executor.cpp Lines 539-546 (original), 537 (

Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

2018-02-07 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65550/ --- Review request for mesos, Anand Mazumdar, Qian Zhang, and Vinod Kone. Bugs: MES