Re: Review Request 66311: Implement recovery of resource provider manager.

> On April 19, 2018, 6 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/registrar.cpp > > Lines 193-203 (original), 194-203 (patched) > > > > > > How about moving this into

Re: Review Request 66311: Implement recovery of resource provider manager.

> On April 19, 2018, 8 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 237 (patched) > > > > > > `::recover` This is not used anywhere else in this file, let's just keep this instance

Re: Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/ --- (Updated April 19, 2018, 2:29 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/#review201488 --- src/resource_provider/manager.cpp Lines 89 (patched)

Re: Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/#review200898 --- PASS: Mesos patch 66311 was successfully built and tested.

Re: Review Request 66311: Implement recovery of resource provider manager.

> On April 10, 2018, 3:05 nachm., Jan Schlicht wrote: > > src/resource_provider/registrar.cpp > > Lines 97 (patched) > > > > > > `Registry` is in scope here and used without the namespace in other > > parts of this

Re: Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/ --- (Updated April 11, 2018, 9:30 a.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 66311: Implement recovery of resource provider manager.

> On April 10, 2018, 3:05 p.m., Jan Schlicht wrote: > > Thank you for your comments. I have some issues updating the patch in reviewboard at this time, will retry later. Please see my responses below. > On April 10, 2018, 3:05 p.m., Jan Schlicht wrote: > > src/resource_provider/manager.cpp >

Re: Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/#review200814 --- PASS: Mesos patch 66311 was successfully built and tested.

Re: Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/#review200734 --- src/resource_provider/manager.cpp Lines 65 (patched)

Re: Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/ --- (Updated April 10, 2018, 2:07 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/#review200735 --- Bad patch! Reviews applied: [66311, 66310, 66309, 66308] Failed

Re: Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/#review200729 --- FAIL: Failed to apply the dependent review: 66310. Failed

Re: Review Request 66311: Implement recovery of resource provider manager.

> On April 6, 2018, 4:22 p.m., Benjamin Bannier wrote: > > src/resource_provider/manager.cpp > > Lines 261-263 (patched) > > > > > > The used endpoint detector currently cannot deal with this which can > > e.g.,

Re: Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/ --- (Updated April 9, 2018, 12:29 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/#review200650 --- src/resource_provider/manager.cpp Lines 261-263 (patched)

Re: Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/#review200118 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8735