Re: Review Request 66875: Added an hourly timer for docker store pull latency.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66875/#review205144
---


Fix it, then Ship it!





src/slave/containerizer/mesos/provisioner/docker/store.cpp
Lines 40 (patched)


Why do we need this header file?



src/slave/containerizer/mesos/provisioner/docker/store.cpp
Lines 104-106 (patched)


A space missed between `)` and `:`.

And can we merge these 3 line codes into 2 lines?
```
Metrics() : image_pull(
  "containerizer/mesos/provisioner/docker_store/image_pull", 
Hours(1))
```



src/slave/containerizer/mesos/provisioner/docker/store.cpp
Lines 111 (patched)


Kill this blank line.


- Qian Zhang


On June 21, 2018, 2:26 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66875/
> ---
> 
> (Updated June 21, 2018, 2:26 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6451
> https://issues.apache.org/jira/browse/MESOS-6451
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added pull latency tracking for docker store, which can tell
> us both latency distribution of pull as well as number of pulls.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 6e7dc44321bff3198e5ffe69be1ba329be3ee31e 
> 
> 
> Diff: https://reviews.apache.org/r/66875/diff/3/
> 
> 
> Testing
> ---
> 
> Ran agent in command line and trigger several launches through 
> `mesos-execute`, observed following metrics from agent endpoint:
> 
> ```
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms": 3619.53408,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/count": 2,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/max": 
> 4208.662016,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/min": 
> 3619.53408,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p50": 
> 3914.098048,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p90": 
> 4149.7492224,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p95": 
> 4179.2056192,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p99": 
> 4202.77073664,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p999": 
> 4208.072888064,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p": 
> 4208.6031032064,
> ```
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66875/#review205121
---



PASS: Mesos patch 66875 was successfully built and tested.

Reviews applied: `['53105', '66875']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66875

- Mesos Reviewbot Windows


On June 20, 2018, 11:26 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66875/
> ---
> 
> (Updated June 20, 2018, 11:26 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6451
> https://issues.apache.org/jira/browse/MESOS-6451
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added pull latency tracking for docker store, which can tell
> us both latency distribution of pull as well as number of pulls.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 6e7dc44321bff3198e5ffe69be1ba329be3ee31e 
> 
> 
> Diff: https://reviews.apache.org/r/66875/diff/3/
> 
> 
> Testing
> ---
> 
> Ran agent in command line and trigger several launches through 
> `mesos-execute`, observed following metrics from agent endpoint:
> 
> ```
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms": 3619.53408,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/count": 2,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/max": 
> 4208.662016,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/min": 
> 3619.53408,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p50": 
> 3914.098048,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p90": 
> 4149.7492224,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p95": 
> 4179.2056192,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p99": 
> 4202.77073664,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p999": 
> 4208.072888064,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p": 
> 4208.6031032064,
> ```
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66875/
---

(Updated June 20, 2018, 11:26 a.m.)


Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Qian Zhang.


Changes
---

Qian's comments.


Bugs: MESOS-6451
https://issues.apache.org/jira/browse/MESOS-6451


Repository: mesos


Description
---

This patch added pull latency tracking for docker store, which can tell
us both latency distribution of pull as well as number of pulls.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
6e7dc44321bff3198e5ffe69be1ba329be3ee31e 


Diff: https://reviews.apache.org/r/66875/diff/3/

Changes: https://reviews.apache.org/r/66875/diff/2-3/


Testing (updated)
---

Ran agent in command line and trigger several launches through `mesos-execute`, 
observed following metrics from agent endpoint:

```
  "containerizer/mesos/provisioner/docker_store/image_pull_ms": 3619.53408,
  "containerizer/mesos/provisioner/docker_store/image_pull_ms/count": 2,
  "containerizer/mesos/provisioner/docker_store/image_pull_ms/max": 4208.662016,
  "containerizer/mesos/provisioner/docker_store/image_pull_ms/min": 3619.53408,
  "containerizer/mesos/provisioner/docker_store/image_pull_ms/p50": 3914.098048,
  "containerizer/mesos/provisioner/docker_store/image_pull_ms/p90": 
4149.7492224,
  "containerizer/mesos/provisioner/docker_store/image_pull_ms/p95": 
4179.2056192,
  "containerizer/mesos/provisioner/docker_store/image_pull_ms/p99": 
4202.77073664,
  "containerizer/mesos/provisioner/docker_store/image_pull_ms/p999": 
4208.072888064,
  "containerizer/mesos/provisioner/docker_store/image_pull_ms/p": 
4208.6031032064,
```


Thanks,

Zhitao Li

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66875/#review205053
---




src/slave/containerizer/mesos/provisioner/docker/store.cpp
Lines 86 (patched)


I'd name it 
`image_pull("containerizer/mesos/provisioner/docker_store/image_pull", 
Hours(1))`


- Qian Zhang


On May 22, 2018, 1:16 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66875/
> ---
> 
> (Updated May 22, 2018, 1:16 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6451
> https://issues.apache.org/jira/browse/MESOS-6451
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added pull latency tracking for docker store, which can tell
> us both latency distribution of pull as well as number of pulls.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 8b3f07f5027cb90d4b4ed401960494709d3eda5f 
> 
> 
> Diff: https://reviews.apache.org/r/66875/diff/2/
> 
> 
> Testing
> ---
> 
> Ran agent in command line and trigger several launches through 
> `mesos-execute`, observed following metrics from agent endpoint:
> 
> ```
>   "containerizer/mesos/docker_store/pull_ms": 4084.254208,
>   "containerizer/mesos/docker_store/pull_ms/count": 2,
>   "containerizer/mesos/docker_store/pull_ms/max": 4084.254208,
>   "containerizer/mesos/docker_store/pull_ms/min": 3525.044736,
>   "containerizer/mesos/docker_store/pull_ms/p50": 3804.649472,
>   "containerizer/mesos/docker_store/pull_ms/p90": 4028.3332608,
>   "containerizer/mesos/docker_store/pull_ms/p95": 4056.2937344,
>   "containerizer/mesos/docker_store/pull_ms/p99": 4078.66211328,
>   "containerizer/mesos/docker_store/pull_ms/p999": 4083.694998528,
>   "containerizer/mesos/docker_store/pull_ms/p": 4084.1982870528,
> ```
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

[Jason Lai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66875/#review204958
---


Ship it!




Ship It!

- Jason Lai


On May 21, 2018, 5:16 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66875/
> ---
> 
> (Updated May 21, 2018, 5:16 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6451
> https://issues.apache.org/jira/browse/MESOS-6451
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added pull latency tracking for docker store, which can tell
> us both latency distribution of pull as well as number of pulls.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 8b3f07f5027cb90d4b4ed401960494709d3eda5f 
> 
> 
> Diff: https://reviews.apache.org/r/66875/diff/2/
> 
> 
> Testing
> ---
> 
> Ran agent in command line and trigger several launches through 
> `mesos-execute`, observed following metrics from agent endpoint:
> 
> ```
>   "containerizer/mesos/docker_store/pull_ms": 4084.254208,
>   "containerizer/mesos/docker_store/pull_ms/count": 2,
>   "containerizer/mesos/docker_store/pull_ms/max": 4084.254208,
>   "containerizer/mesos/docker_store/pull_ms/min": 3525.044736,
>   "containerizer/mesos/docker_store/pull_ms/p50": 3804.649472,
>   "containerizer/mesos/docker_store/pull_ms/p90": 4028.3332608,
>   "containerizer/mesos/docker_store/pull_ms/p95": 4056.2937344,
>   "containerizer/mesos/docker_store/pull_ms/p99": 4078.66211328,
>   "containerizer/mesos/docker_store/pull_ms/p999": 4083.694998528,
>   "containerizer/mesos/docker_store/pull_ms/p": 4084.1982870528,
> ```
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66875/#review202200
---



Patch looks great!

Reviews applied: [53105, 66875]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 30, 2018, 4:32 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66875/
> ---
> 
> (Updated April 30, 2018, 4:32 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-6451
> https://issues.apache.org/jira/browse/MESOS-6451
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added pull latency tracking for docker store, which can tell
> us both latency distribution of pull as well as number of pulls.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 8b3f07f5027cb90d4b4ed401960494709d3eda5f 
> 
> 
> Diff: https://reviews.apache.org/r/66875/diff/2/
> 
> 
> Testing
> ---
> 
> Ran agent in command line and trigger several launches through 
> `mesos-execute`, observed following metrics from agent endpoint:
> 
> ```
>   "containerizer/mesos/docker_store/pull_ms": 4084.254208,
>   "containerizer/mesos/docker_store/pull_ms/count": 2,
>   "containerizer/mesos/docker_store/pull_ms/max": 4084.254208,
>   "containerizer/mesos/docker_store/pull_ms/min": 3525.044736,
>   "containerizer/mesos/docker_store/pull_ms/p50": 3804.649472,
>   "containerizer/mesos/docker_store/pull_ms/p90": 4028.3332608,
>   "containerizer/mesos/docker_store/pull_ms/p95": 4056.2937344,
>   "containerizer/mesos/docker_store/pull_ms/p99": 4078.66211328,
>   "containerizer/mesos/docker_store/pull_ms/p999": 4083.694998528,
>   "containerizer/mesos/docker_store/pull_ms/p": 4084.1982870528,
> ```
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66875/#review202196
---



PASS: Mesos patch 66875 was successfully built and tested.

Reviews applied: `['53105', '66875']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66875

- Mesos Reviewbot Windows


On May 1, 2018, 1:32 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66875/
> ---
> 
> (Updated May 1, 2018, 1:32 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-6451
> https://issues.apache.org/jira/browse/MESOS-6451
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added pull latency tracking for docker store, which can tell
> us both latency distribution of pull as well as number of pulls.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 8b3f07f5027cb90d4b4ed401960494709d3eda5f 
> 
> 
> Diff: https://reviews.apache.org/r/66875/diff/2/
> 
> 
> Testing
> ---
> 
> Ran agent in command line and trigger several launches through 
> `mesos-execute`, observed following metrics from agent endpoint:
> 
> ```
>   "containerizer/mesos/docker_store/pull_ms": 4084.254208,
>   "containerizer/mesos/docker_store/pull_ms/count": 2,
>   "containerizer/mesos/docker_store/pull_ms/max": 4084.254208,
>   "containerizer/mesos/docker_store/pull_ms/min": 3525.044736,
>   "containerizer/mesos/docker_store/pull_ms/p50": 3804.649472,
>   "containerizer/mesos/docker_store/pull_ms/p90": 4028.3332608,
>   "containerizer/mesos/docker_store/pull_ms/p95": 4056.2937344,
>   "containerizer/mesos/docker_store/pull_ms/p99": 4078.66211328,
>   "containerizer/mesos/docker_store/pull_ms/p999": 4083.694998528,
>   "containerizer/mesos/docker_store/pull_ms/p": 4084.1982870528,
> ```
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66875/#review202178
---



Bad patch!

Reviews applied: [66875, 53105, 54987, 54986, 66871, 53267]

Failed command: python support/apply-reviews.py -n -r 53267

Error:
2018-05-01 01:16:36 URL:https://reviews.apache.org/r/53267/diff/raw/ 
[2883/2883] -> "53267.patch" [1]
error: patch failed: src/master/metrics.hpp:196
error: src/master/metrics.hpp: patch does not apply
error: patch failed: src/master/metrics.cpp:458
error: src/master/metrics.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/22331/console

- Mesos Reviewbot


On April 30, 2018, 4:32 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66875/
> ---
> 
> (Updated April 30, 2018, 4:32 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-6451
> https://issues.apache.org/jira/browse/MESOS-6451
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added pull latency tracking for docker store, which can tell
> us both latency distribution of pull as well as number of pulls.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 8b3f07f5027cb90d4b4ed401960494709d3eda5f 
> 
> 
> Diff: https://reviews.apache.org/r/66875/diff/1/
> 
> 
> Testing
> ---
> 
> Ran agent in command line and trigger several launches through 
> `mesos-execute`, observed following metrics from agent endpoint:
> 
> ```
>   "containerizer/mesos/docker_store/pull_ms": 4084.254208,
>   "containerizer/mesos/docker_store/pull_ms/count": 2,
>   "containerizer/mesos/docker_store/pull_ms/max": 4084.254208,
>   "containerizer/mesos/docker_store/pull_ms/min": 3525.044736,
>   "containerizer/mesos/docker_store/pull_ms/p50": 3804.649472,
>   "containerizer/mesos/docker_store/pull_ms/p90": 4028.3332608,
>   "containerizer/mesos/docker_store/pull_ms/p95": 4056.2937344,
>   "containerizer/mesos/docker_store/pull_ms/p99": 4078.66211328,
>   "containerizer/mesos/docker_store/pull_ms/p999": 4083.694998528,
>   "containerizer/mesos/docker_store/pull_ms/p": 4084.1982870528,
> ```
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66875/#review202176
---



FAIL: Failed to apply the dependent review: 53267.

Failed command: `python.exe .\support\apply-reviews.py -n -r 53267`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66875

Relevant logs:

- 
[apply-review-53267-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66875/logs/apply-review-53267-stdout.log):

```
error: patch failed: src/master/metrics.hpp:196
error: src/master/metrics.hpp: patch does not apply
error: patch failed: src/master/metrics.cpp:458
error: src/master/metrics.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On April 30, 2018, 11:32 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66875/
> ---
> 
> (Updated April 30, 2018, 11:32 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-6451
> https://issues.apache.org/jira/browse/MESOS-6451
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added pull latency tracking for docker store, which can tell
> us both latency distribution of pull as well as number of pulls.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 8b3f07f5027cb90d4b4ed401960494709d3eda5f 
> 
> 
> Diff: https://reviews.apache.org/r/66875/diff/1/
> 
> 
> Testing
> ---
> 
> Ran agent in command line and trigger several launches through 
> `mesos-execute`, observed following metrics from agent endpoint:
> 
> ```
>   "containerizer/mesos/docker_store/pull_ms": 4084.254208,
>   "containerizer/mesos/docker_store/pull_ms/count": 2,
>   "containerizer/mesos/docker_store/pull_ms/max": 4084.254208,
>   "containerizer/mesos/docker_store/pull_ms/min": 3525.044736,
>   "containerizer/mesos/docker_store/pull_ms/p50": 3804.649472,
>   "containerizer/mesos/docker_store/pull_ms/p90": 4028.3332608,
>   "containerizer/mesos/docker_store/pull_ms/p95": 4056.2937344,
>   "containerizer/mesos/docker_store/pull_ms/p99": 4078.66211328,
>   "containerizer/mesos/docker_store/pull_ms/p999": 4083.694998528,
>   "containerizer/mesos/docker_store/pull_ms/p": 4084.1982870528,
> ```
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66875/
---

(Updated April 30, 2018, 4:32 p.m.)


Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Bugs: MESOS-6451
https://issues.apache.org/jira/browse/MESOS-6451


Repository: mesos


Description
---

This patch added pull latency tracking for docker store, which can tell
us both latency distribution of pull as well as number of pulls.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
8b3f07f5027cb90d4b4ed401960494709d3eda5f 


Diff: https://reviews.apache.org/r/66875/diff/1/


Testing (updated)
---

Ran agent in command line and trigger several launches through `mesos-execute`, 
observed following metrics from agent endpoint:

```
  "containerizer/mesos/docker_store/pull_ms": 4084.254208,
  "containerizer/mesos/docker_store/pull_ms/count": 2,
  "containerizer/mesos/docker_store/pull_ms/max": 4084.254208,
  "containerizer/mesos/docker_store/pull_ms/min": 3525.044736,
  "containerizer/mesos/docker_store/pull_ms/p50": 3804.649472,
  "containerizer/mesos/docker_store/pull_ms/p90": 4028.3332608,
  "containerizer/mesos/docker_store/pull_ms/p95": 4056.2937344,
  "containerizer/mesos/docker_store/pull_ms/p99": 4078.66211328,
  "containerizer/mesos/docker_store/pull_ms/p999": 4083.694998528,
  "containerizer/mesos/docker_store/pull_ms/p": 4084.1982870528,
```


Thanks,

Zhitao Li

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66875/
---

(Updated April 30, 2018, 3:36 p.m.)


Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Bugs: MESOS-6451
https://issues.apache.org/jira/browse/MESOS-6451


Repository: mesos


Description
---

This patch added pull latency tracking for docker store, which can tell
us both latency distribution of pull as well as number of pulls.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
8b3f07f5027cb90d4b4ed401960494709d3eda5f 


Diff: https://reviews.apache.org/r/66875/diff/1/


Testing
---


Thanks,

Zhitao Li

Review Request 66875: Added an hourly timer for docker store pull latency.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66875/
---

Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Repository: mesos


Description
---

This patch added pull latency tracking for docker store, which can tell
us both latency distribution of pull as well as number of pulls.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
8b3f07f5027cb90d4b4ed401960494709d3eda5f 


Diff: https://reviews.apache.org/r/66875/diff/1/


Testing
---


Thanks,

Zhitao Li