Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69273/#review210559 --- Ship it! src/tests/slave_recovery_tests.cpp Lines 4822

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69273/#review210550 --- PASS: Mesos patch 69273 was successfully built and tested.

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-14 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69273/#review210544 --- src/tests/slave_recovery_tests.cpp Lines 4822 (patched)

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-14 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69273/ --- (Updated Nov. 14, 2018, 3:23 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-13 Thread Joseph Wu
> On Nov. 7, 2018, 1:44 p.m., Joseph Wu wrote: > > src/tests/slave_recovery_tests.cpp > > Line 4827 (original), 4841-4845 (patched) > > > > > > There is always a non-zero delay between the agent's startup and > >

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-12 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69273/#review210476 --- PASS: Mesos patch 69273 was successfully built and tested.

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-12 Thread Benno Evers
> On Nov. 7, 2018, 9:44 p.m., Joseph Wu wrote: > > src/tests/slave_recovery_tests.cpp > > Line 4739 (original), 4742 (patched) > > > > > > Now that the clock is paused, we should deterministically not get extra >

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-12 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69273/ --- (Updated Nov. 12, 2018, 2:33 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-07 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69273/#review210383 --- src/tests/slave_recovery_tests.cpp Line 4739 (original), 4742

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69273/#review210371 --- PASS: Mesos patch 69273 was successfully built and tested.

Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-07 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69273/ --- Review request for mesos, Greg Mann and Joseph Wu. Bugs: MESOS-9358