Re: Review Request 69571: Made master process all authorization results for `LAUNCH_GROUP`.

2018-12-18 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69571/#review211395 --- Ship it! Ship It! - Jan Schlicht On Dec. 17, 2018, 11:58

Re: Review Request 69571: Made master process all authorization results for `LAUNCH_GROUP`.

2018-12-17 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69571/ --- (Updated Dec. 17, 2018, 10:58 p.m.) Review request for mesos, Benjamin

Re: Review Request 69571: Made master process all authorization results for `LAUNCH_GROUP`.

2018-12-17 Thread Chun-Hung Hsiao
> On Dec. 17, 2018, 11:53 a.m., Jan Schlicht wrote: > > src/master/master.cpp > > Line 4758 (original), 4758 (patched) > > > > > > I don't see how this is an improvement over using `std::deque`. We > > still need

Re: Review Request 69571: Made master process all authorization results for `LAUNCH_GROUP`.

2018-12-17 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69571/#review211353 --- src/master/master.cpp Line 4758 (original), 4758 (patched)

Review Request 69571: Made master process all authorization results for `LAUNCH_GROUP`.

2018-12-16 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69571/ --- Review request for mesos, Benjamin Bannier, Greg Mann, and Till Toenshoff.