Re: Review Request 71205: Switched commit hooks to pre-commit.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/
---

(Updated Sept. 10, 2019, 12:02 p.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Do not run pylint on CLI-related files

These files require certain packages to be installed. Previously mesos-style 
solved this by by executing special scripts which set up the virtual envs in 
which pylint could be run. Since pylint is also run as part of the test suite 
of these scripts we now remove the external linting here since it the effort 
exceeds the benefit.


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch switches commit hooks to be orchestrated by the pre-commit
tool mirroring the previous linters invoked through git commit
hooks (orchestrated by `support/mesos-style.py` or standalone hooks).

Using pre-commit removes the burden of maintaining
`support/mesos-style.py`, making sure that hooks have the expected
environment (e.g., Python version, Node installed). Additionally,
upstream provides a number of additional linters which are not hard to
add to Mesos' hooks.


Diffs (updated)
-

  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/pre-commit-config.yaml PRE-CREATION 
  support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/setup-dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71205/diff/12/

Changes: https://reviews.apache.org/r/71205/diff/11-12/


Testing
---

* used successfully for a couple of months


Thanks,

Benjamin Bannier

Re: Review Request 71205: Switched commit hooks to pre-commit.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/
---

(Updated Aug. 28, 2019, 11:04 a.m.)


Review request for mesos and Till Toenshoff.


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch switches commit hooks to be orchestrated by the pre-commit
tool mirroring the previous linters invoked through git commit
hooks (orchestrated by `support/mesos-style.py` or standalone hooks).

Using pre-commit removes the burden of maintaining
`support/mesos-style.py`, making sure that hooks have the expected
environment (e.g., Python version, Node installed). Additionally,
upstream provides a number of additional linters which are not hard to
add to Mesos' hooks.


Diffs (updated)
-

  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/pre-commit-config.yaml PRE-CREATION 
  support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/setup-dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71205/diff/10/

Changes: https://reviews.apache.org/r/71205/diff/9-10/


Testing
---

* used successfully for a couple of months


Thanks,

Benjamin Bannier

Re: Review Request 71205: Switched commit hooks to pre-commit.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/#review217461
---


Fix it, then Ship it!





support/setup-dev.bat
Lines 59 (patched)


s/mlink/mklink/


- Joseph Wu


On Aug. 27, 2019, 1:08 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71205/
> ---
> 
> (Updated Aug. 27, 2019, 1:08 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch switches commit hooks to be orchestrated by the pre-commit
> tool mirroring the previous linters invoked through git commit
> hooks (orchestrated by `support/mesos-style.py` or standalone hooks).
> 
> Using pre-commit removes the burden of maintaining
> `support/mesos-style.py`, making sure that hooks have the expected
> environment (e.g., Python version, Node installed). Additionally,
> upstream provides a number of additional linters which are not hard to
> add to Mesos' hooks.
> 
> 
> Diffs
> -
> 
>   docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/pre-commit-config.yaml PRE-CREATION 
>   support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/setup-dev.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71205/diff/9/
> 
> 
> Testing
> ---
> 
> * used successfully for a couple of months
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71205: Switched commit hooks to pre-commit.

[Benjamin Bannier]

> On Aug. 26, 2019, 8:51 p.m., Till Toenshoff wrote:
> > When running the script, I noticed this
> > ```
> > [INFO] Installing environment for local.
> > [INFO] Once installed this environment will be reused.
> > [INFO] This may take a few minutes...
> > [INFO] Installing environment for local.
> > [INFO] Once installed this environment will be reused.
> > [INFO] This may take a few minutes...
> > ```
> > Why do we seemingly repeat that step? After this all further steps were non 
> > duplicated.

This is triggered by `pre-commit install-hooks` and seems to be a quirk of how 
`local` environments are set up. I am not sure there is anything we could or 
even should do about it.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/#review217439
---


On Aug. 27, 2019, 10:08 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71205/
> ---
> 
> (Updated Aug. 27, 2019, 10:08 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch switches commit hooks to be orchestrated by the pre-commit
> tool mirroring the previous linters invoked through git commit
> hooks (orchestrated by `support/mesos-style.py` or standalone hooks).
> 
> Using pre-commit removes the burden of maintaining
> `support/mesos-style.py`, making sure that hooks have the expected
> environment (e.g., Python version, Node installed). Additionally,
> upstream provides a number of additional linters which are not hard to
> add to Mesos' hooks.
> 
> 
> Diffs
> -
> 
>   docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/pre-commit-config.yaml PRE-CREATION 
>   support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/setup-dev.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71205/diff/9/
> 
> 
> Testing
> ---
> 
> * used successfully for a couple of months
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71205: Switched commit hooks to pre-commit.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/
---

(Updated Aug. 27, 2019, 10:08 a.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Address comments from Till


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch switches commit hooks to be orchestrated by the pre-commit
tool mirroring the previous linters invoked through git commit
hooks (orchestrated by `support/mesos-style.py` or standalone hooks).

Using pre-commit removes the burden of maintaining
`support/mesos-style.py`, making sure that hooks have the expected
environment (e.g., Python version, Node installed). Additionally,
upstream provides a number of additional linters which are not hard to
add to Mesos' hooks.


Diffs (updated)
-

  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/pre-commit-config.yaml PRE-CREATION 
  support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/setup-dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71205/diff/9/

Changes: https://reviews.apache.org/r/71205/diff/8-9/


Testing
---

* used successfully for a couple of months


Thanks,

Benjamin Bannier

Re: Review Request 71205: Switched commit hooks to pre-commit.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/#review217439
---


Fix it, then Ship it!




When running the script, I noticed this
```
[INFO] Installing environment for local.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for local.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
```
Why do we seemingly repeat that step? After this all further steps were non 
duplicated.


docs/advanced-contribution.md
Line 67 (original), 68 (patched)


"The hooks are set up with `./support/setup_dev.sh`"

We have to invoke it, so it does not really do much automatically, I'ld 
argue.



support/setup-dev.sh
Lines 57 (patched)


We generally strive for capitalizing product names - so let's have it this 
`Mesos` way everywhere please :)



support/setup-dev.sh
Lines 62 (patched)


Shouldnt there be an `exit(1)` here so we spare our users three more error 
messages?


- Till Toenshoff


On Aug. 20, 2019, 11:48 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71205/
> ---
> 
> (Updated Aug. 20, 2019, 11:48 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch switches commit hooks to be orchestrated by the pre-commit
> tool mirroring the previous linters invoked through git commit
> hooks (orchestrated by `support/mesos-style.py` or standalone hooks).
> 
> Using pre-commit removes the burden of maintaining
> `support/mesos-style.py`, making sure that hooks have the expected
> environment (e.g., Python version, Node installed). Additionally,
> upstream provides a number of additional linters which are not hard to
> add to Mesos' hooks.
> 
> 
> Diffs
> -
> 
>   docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/pre-commit-config.yaml PRE-CREATION 
>   support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/setup-dev.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71205/diff/8/
> 
> 
> Testing
> ---
> 
> * used successfully for a couple of months
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71205: Switched commit hooks to pre-commit.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/
---

(Updated Aug. 20, 2019, 1:48 p.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Rebase


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch switches commit hooks to be orchestrated by the pre-commit
tool mirroring the previous linters invoked through git commit
hooks (orchestrated by `support/mesos-style.py` or standalone hooks).

Using pre-commit removes the burden of maintaining
`support/mesos-style.py`, making sure that hooks have the expected
environment (e.g., Python version, Node installed). Additionally,
upstream provides a number of additional linters which are not hard to
add to Mesos' hooks.


Diffs (updated)
-

  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/pre-commit-config.yaml PRE-CREATION 
  support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/setup-dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71205/diff/8/

Changes: https://reviews.apache.org/r/71205/diff/7-8/


Testing
---

* used successfully for a couple of months


Thanks,

Benjamin Bannier

Re: Review Request 71205: Switched commit hooks to pre-commit.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/#review217283
---


Ship it!




Ship It!

- Benno Evers


On Aug. 19, 2019, 7:20 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71205/
> ---
> 
> (Updated Aug. 19, 2019, 7:20 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch switches commit hooks to be orchestrated by the pre-commit
> tool mirroring the previous linters invoked through git commit
> hooks (orchestrated by `support/mesos-style.py` or standalone hooks).
> 
> Using pre-commit removes the burden of maintaining
> `support/mesos-style.py`, making sure that hooks have the expected
> environment (e.g., Python version, Node installed). Additionally,
> upstream provides a number of additional linters which are not hard to
> add to Mesos' hooks.
> 
> 
> Diffs
> -
> 
>   docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/pre-commit-config.yaml PRE-CREATION 
>   support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/setup-dev.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71205/diff/7/
> 
> 
> Testing
> ---
> 
> * used successfully for a couple of months
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71205: Switched commit hooks to pre-commit.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/
---

(Updated Aug. 19, 2019, 9:20 a.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Rebase; install config via link to allow for untracked modifications


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch switches commit hooks to be orchestrated by the pre-commit
tool mirroring the previous linters invoked through git commit
hooks (orchestrated by `support/mesos-style.py` or standalone hooks).

Using pre-commit removes the burden of maintaining
`support/mesos-style.py`, making sure that hooks have the expected
environment (e.g., Python version, Node installed). Additionally,
upstream provides a number of additional linters which are not hard to
add to Mesos' hooks.


Diffs (updated)
-

  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/pre-commit-config.yaml PRE-CREATION 
  support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/setup-dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71205/diff/7/

Changes: https://reviews.apache.org/r/71205/diff/6-7/


Testing
---

* used successfully for a couple of months


Thanks,

Benjamin Bannier

Re: Review Request 71205: Switched commit hooks to pre-commit.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/#review217266
---


Ship it!




The pre-commit install was a bit non-obvious to me, I needed to do `sudo 
python3 -m pip install pre-commit`. that's more a `pre-commit` docs issue 
however.

- James Peach


On July 30, 2019, 9:01 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71205/
> ---
> 
> (Updated July 30, 2019, 9:01 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch switches commit hooks to be orchestrated by the pre-commit
> tool mirroring the previous linters invoked through git commit
> hooks (orchestrated by `support/mesos-style.py` or standalone hooks).
> 
> Using pre-commit removes the burden of maintaining
> `support/mesos-style.py`, making sure that hooks have the expected
> environment (e.g., Python version, Node installed). Additionally,
> upstream provides a number of additional linters which are not hard to
> add to Mesos' hooks.
> 
> 
> Diffs
> -
> 
>   .pre-commit-config.yaml PRE-CREATION 
>   docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
>   support/setup_dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/setup_dev.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71205/diff/6/
> 
> 
> Testing
> ---
> 
> * used successfully for a couple of months
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>