[GitHub] spark pull request: [SPARK-3594] [PySpark] [SQL] take more rows to...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2716#issuecomment-58615814 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/344/consoleFull) for PR 2716 at commit

[GitHub] spark pull request: [SPARK-3594] [PySpark] [SQL] take more rows to...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2716#issuecomment-58615995 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2924] Required by scala 2.11, only one ...

2014-10-10 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2750#issuecomment-58615984 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3594] [PySpark] [SQL] take more rows to...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2716#issuecomment-58615990 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21572/consoleFull) for PR 2716 at commit

[GitHub] spark pull request: [SPARK-2924] Required by scala 2.11, only one ...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2750#issuecomment-58616220 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21576/consoleFull) for PR 2750 at commit

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2344#issuecomment-58616217 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21577/consoleFull) for PR 2344 at commit

[GitHub] spark pull request: [SPARK-3896] checkSpeculatableTasks fask quit ...

2014-10-10 Thread shijinkui
GitHub user shijinkui opened a pull request: https://github.com/apache/spark/pull/2751 [SPARK-3896] checkSpeculatableTasks fask quit loop; checkSpeculatableTasks is expensive 1. invoking checkSpeculatableTasks is expensive, once true then return true 2. import section

[GitHub] spark pull request: [SPARK-3896] Pool#checkSpeculatableTasks fask ...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2751#issuecomment-58617197 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3896] Pool#checkSpeculatableTasks fask ...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2751#issuecomment-58617192 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3739] [SQL] Update the split num base o...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2589#issuecomment-58617264 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: fixed dynamic pagerank vertex update computati...

2014-10-10 Thread planvin
Github user planvin commented on the pull request: https://github.com/apache/spark/pull/2738#issuecomment-58617277 I am clearly missing something here. Sorry for that. I am closing the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-3739] [SQL] Update the split num base o...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2589#issuecomment-58617261 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21575/consoleFull) for PR 2589 at commit

[GitHub] spark pull request: fixed dynamic pagerank vertex update computati...

2014-10-10 Thread planvin
Github user planvin closed the pull request at: https://github.com/apache/spark/pull/2738 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3343] [SQL] Add serde support for CTAS

2014-10-10 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/2570#discussion_r18690123 --- Diff: sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala --- @@ -211,7 +211,11 @@ class

[GitHub] spark pull request: SPARK-3807: SparkSql does not work for tables ...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2674#issuecomment-58617474 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-3807: SparkSql does not work for tables ...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2674#issuecomment-58617467 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21573/consoleFull) for PR 2674 at commit

[GitHub] spark pull request: [SPARK-2805] Upgrade Akka to 2.3.4

2014-10-10 Thread pwendell
GitHub user pwendell opened a pull request: https://github.com/apache/spark/pull/2752 [SPARK-2805] Upgrade Akka to 2.3.4 This is a second rev of the Akka upgrade (earlier merged, but reverted). I made a slight modification which is that I also upgrade Hive to deal with a

[GitHub] spark pull request: [SPARK-3888] [PySpark] limit the memory used b...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2743#issuecomment-58617749 **[Tests timed out](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/343/consoleFull)** for PR 2743 at commit

[GitHub] spark pull request: [SPARK-2805] Upgrade Akka to 2.3.4

2014-10-10 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2752#issuecomment-58617755 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2805] Upgrade Akka to 2.3.4

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2752#issuecomment-58617902 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21578/consoleFull) for PR 2752 at commit

[GitHub] spark pull request: [SPARK-2924] Required by scala 2.11, only one ...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2750#issuecomment-58618269 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2924] Required by scala 2.11, only one ...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2750#issuecomment-58618260 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21574/consoleFull) for PR 2750 at commit

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2344#issuecomment-58619034 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2344#issuecomment-58619031 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21577/consoleFull) for PR 2344 at commit

[GitHub] spark pull request: [SPARK-3812] [BUILD] Adapt maven build to publ...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2673#issuecomment-58619871 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21579/consoleFull) for PR 2673 at commit

[GitHub] spark pull request: [SPARK-2924] Required by scala 2.11, only one ...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2750#issuecomment-58620288 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21576/consoleFull) for PR 2750 at commit

[GitHub] spark pull request: [SPARK-2924] Required by scala 2.11, only one ...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2750#issuecomment-58620295 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3453] Netty-based BlockTransferService,...

2014-10-10 Thread aarondav
GitHub user aarondav opened a pull request: https://github.com/apache/spark/pull/2753 [SPARK-3453] Netty-based BlockTransferService, extracted from Spark core This PR encapsulates #2330, which is itself a continuation of #2240. The first goal of this PR is to provide an alternate,

[GitHub] spark pull request: [SPARK-3453] Netty-based BlockTransferService,...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2753#issuecomment-58620672 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21580/consoleFull) for PR 2753 at commit

[GitHub] spark pull request: [SPARK-3453] Netty-based BlockTransferService,...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2753#issuecomment-58620770 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3453] Netty-based BlockTransferService,...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2753#issuecomment-58620769 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21580/consoleFull) for PR 2753 at commit

[GitHub] spark pull request: [SPARK-3897]format example code and explicit v...

2014-10-10 Thread shijinkui
GitHub user shijinkui opened a pull request: https://github.com/apache/spark/pull/2754 [SPARK-3897]format example code and explicit val instead of var You can merge this pull request into a Git repository by running: $ git pull https://github.com/shijinkui/spark

[GitHub] spark pull request: [SPARK-3897]format example code and explicit v...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2754#issuecomment-58621250 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3897]format example code and explicit v...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2754#issuecomment-58621255 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3453] Netty-based BlockTransferService,...

2014-10-10 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/2753#issuecomment-58621380 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3453] Netty-based BlockTransferService,...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2753#issuecomment-58621442 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21581/consoleFull) for PR 2753 at commit

[GitHub] spark pull request: [SPARK-3887] Send stracktrace in ConnectionMan...

2014-10-10 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/2741#issuecomment-58621671 It's really helpful :+1: Just a small question: Should specify charset when converting between bytes and String, or Spark always assumes the environment uses UTF8? ---

[GitHub] spark pull request: [SPARK-3889] Attempt to avoid SIGBUS by not mm...

2014-10-10 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/2742#issuecomment-58621877 Added a non-configurable version of the memory map pathway, with the threshold you suggested (2MB, the size of a hugepage). Note that this fix will also be included in

[GitHub] spark pull request: [SPARK-3889] Attempt to avoid SIGBUS by not mm...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2742#issuecomment-58622268 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21583/consoleFull) for PR 2742 at commit

[GitHub] spark pull request: [SPARK-3453] Netty-based BlockTransferService,...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2753#issuecomment-58622482 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2805] Upgrade Akka to 2.3.4

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2752#issuecomment-58622515 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21578/consoleFull) for PR 2752 at commit

[GitHub] spark pull request: [SPARK-2805] Upgrade Akka to 2.3.4

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2752#issuecomment-58622520 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2805] Upgrade Akka to 2.3.4

2014-10-10 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2752#issuecomment-58622871 Okay let's see if this does better with the nightly maven builds. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-2805] Upgrade Akka to 2.3.4

2014-10-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2752 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3343] [SQL] Add serde support for CTAS

2014-10-10 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/2570#discussion_r18692067 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -117,8 +117,10 @@ case class

[GitHub] spark pull request: [SPARK-3897]format example code and explicit v...

2014-10-10 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/2754#discussion_r18692509 --- Diff: examples/src/main/scala/org/apache/spark/examples/LocalALS.scala --- @@ -31,9 +31,12 @@ import cern.jet.math._ */ object LocalALS {

[GitHub] spark pull request: [SPARK-3897]format example code and explicit v...

2014-10-10 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/2754#discussion_r18692540 --- Diff: examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala --- @@ -127,12 +127,12 @@ object FeederActor { * A sample

[GitHub] spark pull request: [SPARK-2750] support https in spark web ui

2014-10-10 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/1980#discussion_r18692553 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -205,10 +231,74 @@ private[spark] object JettyUtils extends Logging {

[GitHub] spark pull request: [SPARK-2750] support https in spark web ui

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1980#issuecomment-58624892 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21584/consoleFull) for PR 1980 at commit

[GitHub] spark pull request: [SPARK-3562]Periodic cleanup event logs

2014-10-10 Thread viper-kun
Github user viper-kun commented on the pull request: https://github.com/apache/spark/pull/2471#issuecomment-58624839 @mattf @vanzin is this ok to go ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-3453] Netty-based BlockTransferService,...

2014-10-10 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/2753#issuecomment-58624889 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3812] [BUILD] Adapt maven build to publ...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2673#issuecomment-58625132 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21579/consoleFull) for PR 2673 at commit

[GitHub] spark pull request: [SPARK-3812] [BUILD] Adapt maven build to publ...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2673#issuecomment-58625140 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3343] [SQL] Add serde support for CTAS

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2570#issuecomment-58625852 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21586/consoleFull) for PR 2570 at commit

[GitHub] spark pull request: [SPARK-3453] Netty-based BlockTransferService,...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2753#issuecomment-58626122 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3343] [SQL] Add serde support for CTAS

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2570#issuecomment-58626811 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21587/consoleFull) for PR 2570 at commit

[GitHub] spark pull request: [SPARK-3897]format example code and explicit v...

2014-10-10 Thread shijinkui
Github user shijinkui commented on a diff in the pull request: https://github.com/apache/spark/pull/2754#discussion_r18693582 --- Diff: examples/src/main/scala/org/apache/spark/examples/LocalALS.scala --- @@ -31,9 +31,12 @@ import cern.jet.math._ */ object LocalALS {

[GitHub] spark pull request: [SPARK-3897]format example code and explicit v...

2014-10-10 Thread shijinkui
Github user shijinkui commented on a diff in the pull request: https://github.com/apache/spark/pull/2754#discussion_r18693711 --- Diff: examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala --- @@ -127,12 +127,12 @@ object FeederActor { * A sample

[GitHub] spark pull request: [SPARK-3889] Attempt to avoid SIGBUS by not mm...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2742#issuecomment-58627794 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3889] Attempt to avoid SIGBUS by not mm...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2742#issuecomment-58627787 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21583/consoleFull) for PR 2742 at commit

[GitHub] spark pull request: [SPARK-3889] Attempt to avoid SIGBUS by not mm...

2014-10-10 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2742#issuecomment-58628192 LGTM. Merged. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-3719][CORE]:complete/failed stages is...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2574#issuecomment-58628221 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21588/consoleFull) for PR 2574 at commit

[GitHub] spark pull request: [SPARK-3897]format example code and explicit v...

2014-10-10 Thread shijinkui
Github user shijinkui commented on the pull request: https://github.com/apache/spark/pull/2754#issuecomment-58628292 this format only in example module, cannot effect the other module our coding habit is formatting after modify by the way. if there are several difference

[GitHub] spark pull request: [SPARK-3897]format example code and explicit v...

2014-10-10 Thread shijinkui
Github user shijinkui commented on the pull request: https://github.com/apache/spark/pull/2754#issuecomment-58628485 @srowen can u review the other PR #2751 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3889] Attempt to avoid SIGBUS by not mm...

2014-10-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2742 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3453] Netty-based BlockTransferService,...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2753#issuecomment-58628677 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21581/consoleFull) for PR 2753 at commit

[GitHub] spark pull request: [SPARK-3453] Netty-based BlockTransferService,...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2753#issuecomment-58628684 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3887] Send stracktrace in ConnectionMan...

2014-10-10 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2741#issuecomment-58628876 Changes lgtm overall. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-3343] [SQL] Add serde support for CTAS

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2570#issuecomment-58628891 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3343] [SQL] Add serde support for CTAS

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2570#issuecomment-58628884 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21586/consoleFull) for PR 2570 at commit

[GitHub] spark pull request: [SPARK-3121] Wrong implementation of implicit ...

2014-10-10 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/2712#issuecomment-58629065 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3343] [SQL] Add serde support for CTAS

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2570#issuecomment-58630045 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21587/consoleFull) for PR 2570 at commit

[GitHub] spark pull request: [SPARK-3343] [SQL] Add serde support for CTAS

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2570#issuecomment-58630054 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3812] [BUILD] Adapt maven build to publ...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2673#issuecomment-58631408 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21589/consoleFull) for PR 2673 at commit

[GitHub] spark pull request: [SPARK-3812] [BUILD] Adapt maven build to publ...

2014-10-10 Thread ScrapCodes
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/2673#issuecomment-58631368 @pwendell I tried maven shade plugin to somehow work as effective pom generator, but that does not happen unless we have dependencies apart from the project's itself

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2344#discussion_r18695986 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -220,20 +220,44 @@ trait HiveTypeCoercion {

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2344#discussion_r18696379 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -220,20 +220,44 @@ trait HiveTypeCoercion {

[GitHub] spark pull request: [SPARK-3719][CORE]:complete/failed stages is...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2574#issuecomment-58634418 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3719][CORE]:complete/failed stages is...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2574#issuecomment-58634416 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21588/consoleFull) for PR 2574 at commit

[GitHub] spark pull request: [SPARK-2750] support https in spark web ui

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1980#issuecomment-58636687 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2750] support https in spark web ui

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1980#issuecomment-58636685 **[Tests timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21584/consoleFull)** for PR 1980 at commit

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2344#discussion_r18697748 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -56,7 +60,9 @@ case class Cast(child: Expression,

[GitHub] spark pull request: [SPARK-3812] [BUILD] Adapt maven build to publ...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2673#issuecomment-58637193 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3812] [BUILD] Adapt maven build to publ...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2673#issuecomment-58637190 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21589/consoleFull) for PR 2673 at commit

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2344#discussion_r18698063 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnStats.scala --- @@ -190,6 +190,24 @@ private[sql] class StringColumnStats extends

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2344#discussion_r18698218 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala --- @@ -376,8 +395,8 @@ private[sql] sealed abstract class

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2344#issuecomment-58639081 Left some minor comments, otherwise LGTM. Also, do we want to add Python API in this PR or a separate one? --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2344#issuecomment-58646718 I can see most of the reviews are focused on comparing and ordering. I'd like to fix those comparing rules in a separated PR. I tested what you declared here the

[GitHub] spark pull request: SPARK-3807: SparkSql does not work for tables ...

2014-10-10 Thread chiragaggarwal
Github user chiragaggarwal commented on the pull request: https://github.com/apache/spark/pull/2674#issuecomment-58647328 Incorporated the review comments and also added a test case --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: SPARK-3807: SparkSql does not work for tables ...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2674#issuecomment-58647819 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21590/consoleFull) for PR 2674 at commit

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2344#issuecomment-58651729 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21591/consoleFull) for PR 2344 at commit

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/2344#discussion_r18704345 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -220,20 +220,44 @@ trait HiveTypeCoercion {

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2344#issuecomment-58652251 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21592/consoleFull) for PR 2344 at commit

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2344#issuecomment-58654642 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21593/consoleFull) for PR 2344 at commit

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/2344#discussion_r18705174 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -220,20 +220,44 @@ trait HiveTypeCoercion {

[GitHub] spark pull request: [SPARK-2805] Upgrade Akka to 2.3.4

2014-10-10 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/2752#issuecomment-58655305 This will cause some bug. It seems to be related to `akka.remote.retry-gate-closed-for` configuration the log: ``` 14/10/10 20:56:03 WARN

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2344#issuecomment-58655469 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2344#issuecomment-58655457 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21591/consoleFull) for PR 2344 at commit

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2344#issuecomment-58656118 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21592/consoleFull) for PR 2344 at commit

[GitHub] spark pull request: [SPARK-3407][SQL]Add Date type support

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2344#issuecomment-58656123 Test FAILed. Refer to this link for build results (access rights to CI server needed):

  1   2   3   4   >