[GitHub] spark pull request: [MLLIB] SPARK-5491 (ex SPARK-1473): Chi-square...

2015-02-02 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/1484#issuecomment-72528593 Yes, it would be nice to add feature discretization to MLlib. We had a PP, but as you've tried it doesn't scale well. I don't have concrete scalable algorithms in mind

[GitHub] spark pull request: SPARK-4585. Spark dynamic executor allocation ...

2015-02-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4051#issuecomment-72530870 Alright, in summary, the proposal here is to default the min to 0 and the max to Int.Max, and add a new `initialExecutors` config that defaults to the min. On second

[GitHub] spark pull request: SPARK-5500. Document that feeding hadoopFile i...

2015-02-02 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/4293#issuecomment-72534397 @sryza the fact that we have a test case failing I think is enough of a reason to not do something too drastic here. How about just changing it to logWarning for now?

[GitHub] spark pull request: Add a config option to print DAG.

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4257#issuecomment-72534355 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-5500. Document that feeding hadoopFile i...

2015-02-02 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/4293#issuecomment-72534424 Looks like the test failures are legit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-3629][Doc] improve spark on yarn doc

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2813#issuecomment-72534368 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Update ec2-scripts.md

2015-02-02 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/4300#issuecomment-72534476 LGTM. Another thing we could do is just remove the `--spark-version` option since it defaults to the latest release of Spark. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-5158] [core] [security] Spark standalon...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4106#issuecomment-72534474 [Test build #26533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26533/consoleFull) for PR 4106 at commit

[GitHub] spark pull request: Disabling Utils.chmod700 for Windows

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4299#issuecomment-72540524 [Test build #26540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26540/consoleFull) for PR 4299 at commit

[GitHub] spark pull request: [SPARK-2309][MLlib] Multinomial Logistic Regre...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3833#issuecomment-72540606 [Test build #26531 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26531/consoleFull) for PR 3833 at commit

[GitHub] spark pull request: [SPARK-5470][Core]use defaultClassLoader to lo...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4258#issuecomment-72543087 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5461] [graphx] Add isCheckpointed, getC...

2015-02-02 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/4253#issuecomment-72544829 That latest test passing was before I added the class tag to firstParent; the next will be with the class tag added. --- If your project is set up for it, you can

[GitHub] spark pull request: [WIP][SPARK-5501][SPARK-5420][SQL] Write suppo...

2015-02-02 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/4294#discussion_r23961901 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api.scala --- @@ -171,6 +171,33 @@ private[sql] trait DataFrameSpecificApi { def

[GitHub] spark pull request: [WIP][SPARK-5501][SPARK-5420][SQL] Write suppo...

2015-02-02 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/4294#discussion_r23961862 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api.scala --- @@ -171,6 +171,33 @@ private[sql] trait DataFrameSpecificApi { def

[GitHub] spark pull request: [SQL] Correct the default size of TimestampTyp...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4314#issuecomment-72547711 [Test build #26546 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26546/consoleFull) for PR 4314 at commit

[GitHub] spark pull request: [branch-1.0][SPARK-4355] ColumnStatisticsAggre...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3850#issuecomment-72547861 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [branch-1.0][SPARK-4355] ColumnStatisticsAggre...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3850#issuecomment-72547846 [Test build #26529 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26529/consoleFull) for PR 3850 at commit

[GitHub] spark pull request: SPARK-5425: Use synchronised methods in system...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4220#issuecomment-72549138 I've merged this PR into `branch-1.1` (1.1.2), so feel free to close it (GitHub won't auto-close PRs that are opened against maintenance branches). --- If your

[GitHub] spark pull request: [SPARK-2309][MLlib] Multinomial Logistic Regre...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3833#issuecomment-72550665 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2309][MLlib] Multinomial Logistic Regre...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3833#issuecomment-72550651 [Test build #26543 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26543/consoleFull) for PR 3833 at commit

[GitHub] spark pull request: Spark 3883: SSL support for HttpServer and Akk...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3571#issuecomment-72552049 [Test build #26548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26548/consoleFull) for PR 3571 at commit

[GitHub] spark pull request: [MLLIB] SPARK-5491 (ex SPARK-1473): Chi-square...

2015-02-02 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/1484#issuecomment-72528802 Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [MLLIB] SPARK-5491 (ex SPARK-1473): Chi-square...

2015-02-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1484 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4979][MLLIB] Streaming logisitic regres...

2015-02-02 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4306#issuecomment-72530762 LGTM except minor inline comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: SPARK-5500. Document that feeding hadoopFile i...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4293#issuecomment-72530752 [Test build #26525 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26525/consoleFull) for PR 4293 at commit

[GitHub] spark pull request: SPARK-5500. Document that feeding hadoopFile i...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4293#issuecomment-72530765 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5461] [graphx] Add isCheckpointed, getC...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4253#issuecomment-72532830 [Test build #26526 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26526/consoleFull) for PR 4253 at commit

[GitHub] spark pull request: SPARK-2149. [MLLIB] Univariate kernel density ...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1093#issuecomment-72534517 [Test build #26534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26534/consoleFull) for PR 1093 at commit

[GitHub] spark pull request: [SPARK-4874] [CORE] Collect record count metri...

2015-02-02 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/4067#discussion_r23958696 --- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala --- @@ -47,9 +49,13 @@ private[spark] class CacheManager(blockManager: BlockManager) extends

[GitHub] spark pull request: Disabling Utils.chmod700 for Windows

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4299#discussion_r23958649 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -282,7 +282,9 @@ private[spark] object Utils extends Logging { if

[GitHub] spark pull request: Disabling Utils.chmod700 for Windows

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4299#issuecomment-72544592 I built this branch under Windows and tested it out using `spark-shell`; I was able to reproduce the original bug and can confirm that this patch fixes it, so I'm

[GitHub] spark pull request: [SPARK-5461] [graphx] Add isCheckpointed, getC...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4253#issuecomment-72544680 [Test build #26526 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26526/consoleFull) for PR 4253 at commit

[GitHub] spark pull request: [SPARK-4631][streaming][FIX] Wait for a receiv...

2015-02-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4270 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SQL] Correct the default size of TimestampTyp...

2015-02-02 Thread yhuai
GitHub user yhuai opened a pull request: https://github.com/apache/spark/pull/4314 [SQL] Correct the default size of TimestampType and expose NumericType You can merge this pull request into a Git repository by running: $ git pull https://github.com/yhuai/spark minor

[GitHub] spark pull request: SPARK-5425: Use synchronised methods in system...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4221#issuecomment-72549252 Let's leave this PR open for a few days until we complete the 1.2.1 release voting, then I'll merge it into `branch-1.2` (1.2.2). --- If your project is set up for

[GitHub] spark pull request: Spark 3883: SSL support for HttpServer and Akk...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3571#issuecomment-72551467 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-4874] [CORE] Collect record count metri...

2015-02-02 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4067#discussion_r23951392 --- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala --- @@ -47,9 +49,13 @@ private[spark] class CacheManager(blockManager: BlockManager)

[GitHub] spark pull request: [SPARK-2309][MLlib] Multinomial Logistic Regre...

2015-02-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/3833#discussion_r23954862 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -18,30 +18,42 @@ package

[GitHub] spark pull request: SPARK-4585. Spark dynamic executor allocation ...

2015-02-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4051 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: Disabling Utils.chmod700 for Windows

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4299#issuecomment-72538475 Ah, the Git timeout problem resurfaces once again :(. Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: Update ec2-scripts.md

2015-02-02 Thread MiguelPeralvo
Github user MiguelPeralvo commented on the pull request: https://github.com/apache/spark/pull/4300#issuecomment-72542008 I think that's even a better option. I'm happy to propose it. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: Spark 3883: SSL support for HttpServer and Akk...

2015-02-02 Thread jacek-lewandowski
Github user jacek-lewandowski commented on the pull request: https://github.com/apache/spark/pull/3571#issuecomment-72544044 @JoshRosen I've just added the documentation. I hope there is enough of it :) --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: Spark 3883: SSL support for HttpServer and Akk...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3571#issuecomment-72544031 [Test build #26544 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26544/consoleFull) for PR 3571 at commit

[GitHub] spark pull request: Add example that reads a local file, writes to...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3347#issuecomment-72545572 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Add example that reads a local file, writes to...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3347#issuecomment-72545561 [Test build #26532 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26532/consoleFull) for PR 3347 at commit

[GitHub] spark pull request: [SPARK-5341] Use maven coordinates as dependen...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4215#discussion_r23962899 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala --- @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Doc] Minor: Fixes several formatting issues

2015-02-02 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/4316 [Doc] Minor: Fixes several formatting issues Fixes several minor formatting issues in the [Continuous Compilation] [1] section. [1]:

[GitHub] spark pull request: Disabling Utils.chmod700 for Windows

2015-02-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4299 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-5425: Use synchronised methods in system...

2015-02-02 Thread jacek-lewandowski
Github user jacek-lewandowski closed the pull request at: https://github.com/apache/spark/pull/4220 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request: [SQL] Correct the default size of TimestampTyp...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4314#issuecomment-72549399 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Spark 3883: SSL support for HttpServer and Akk...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3571#issuecomment-72549420 @jacek-lewandowski Thanks for adding docs; I'll look over them now. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: Spark 3883: SSL support for HttpServer and Akk...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/3571#discussion_r23964277 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -142,9 +148,39 @@ import org.apache.spark.network.sasl.SecretKeyHolder *

[GitHub] spark pull request: [WIP][SPARK-5501][SPARK-5420][SQL] Write suppo...

2015-02-02 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/4294#discussion_r23953370 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -334,6 +335,71 @@ class SQLContext(@transient val sparkContext:

[GitHub] spark pull request: [SPARK-2309][MLlib] Multinomial Logistic Regre...

2015-02-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/3833#discussion_r23954570 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala --- @@ -18,30 +18,42 @@ package

[GitHub] spark pull request: [SPARK-5173]support python application running...

2015-02-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3976#issuecomment-72531678 Alright, LGTM thanks a lot @lianhuiwang I'm merging this into master. We can fix the SPARK_HOME issue separately. --- If your project is set up for it, you can reply

[GitHub] spark pull request: SPARK-5500. Document that feeding hadoopFile i...

2015-02-02 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/4293#discussion_r23956870 --- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala --- @@ -29,16 +29,14 @@ import org.apache.hadoop.mapreduce.lib.input.{CombineFileSplit,

[GitHub] spark pull request: [SPARK-5514] DataFrame.collect should call exe...

2015-02-02 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/4313 [SPARK-5514] DataFrame.collect should call executeCollect You can merge this pull request into a Git repository by running: $ git pull https://github.com/rxin/spark SPARK-5514 Alternatively you

[GitHub] spark pull request: [SPARK-5388] Provide a stable application subm...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4216#issuecomment-72541454 [Test build #26541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26541/consoleFull) for PR 4216 at commit

[GitHub] spark pull request: [SPARK-5470][Core]use defaultClassLoader to lo...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4258#issuecomment-72543067 [Test build #26528 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26528/consoleFull) for PR 4258 at commit

[GitHub] spark pull request: [SPARK-2309][MLlib] Multinomial Logistic Regre...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3833#issuecomment-72543176 [Test build #26543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26543/consoleFull) for PR 3833 at commit

[GitHub] spark pull request: [SPARK-5461] [graphx] Add isCheckpointed, getC...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4253#issuecomment-72543219 [Test build #26542 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26542/consoleFull) for PR 4253 at commit

[GitHub] spark pull request: [WIP][SPARK-5501][SPARK-5420][SQL] Write suppo...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4294#issuecomment-72544929 [Test build #26545 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26545/consoleFull) for PR 4294 at commit

[GitHub] spark pull request: [WIP][SPARK-5501][SPARK-5420][SQL] Write suppo...

2015-02-02 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/4294#discussion_r23961981 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala --- @@ -618,8 +619,84 @@ class DataFrame protected[sql]( */ @Experimental

[GitHub] spark pull request: [SPARK-5212][SQL] Add support of schema-less, ...

2015-02-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4014 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3039] [BUILD] Spark assembly for new ha...

2015-02-02 Thread medale
GitHub user medale opened a pull request: https://github.com/apache/spark/pull/4315 [SPARK-3039] [BUILD] Spark assembly for new hadoop API (hadoop 2) contai... ...ns avro-mapred for hadoop 1 API had been marked as resolved but did not work for at least some builds due

[GitHub] spark pull request: Spark 3883: SSL support for HttpServer and Akk...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3571#issuecomment-72551042 [Test build #26544 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26544/consoleFull) for PR 3571 at commit

[GitHub] spark pull request: [SPARK-1406] Mllib pmml model export

2015-02-02 Thread selvinsource
Github user selvinsource commented on the pull request: https://github.com/apache/spark/pull/3062#issuecomment-72551243 Either approach has its pros and cons and I don't have a strong argument in favor of any of the two. R, for instance, use a similar approach to what I have

[GitHub] spark pull request: Spark 3883: SSL support for HttpServer and Akk...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/3571#discussion_r23964702 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -142,9 +148,39 @@ import org.apache.spark.network.sasl.SecretKeyHolder *

[GitHub] spark pull request: [WIP][SPARK-5501][SPARK-5420][SQL] Write suppo...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4294#issuecomment-72552424 [Test build #26545 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26545/consoleFull) for PR 4294 at commit

[GitHub] spark pull request: [WIP][SPARK-5501][SPARK-5420][SQL] Write suppo...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4294#issuecomment-72552433 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-1406] Mllib pmml model export

2015-02-02 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/3062#issuecomment-72552402 The R case is slightly different because the `pmml` package is maintained separately from other packages. @srowen , are you okay with the interface I proposed? --- If

[GitHub] spark pull request: [SPARK-4874] [CORE] Collect record count metri...

2015-02-02 Thread sryza
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/4067#discussion_r23951634 --- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala --- @@ -47,9 +49,13 @@ private[spark] class CacheManager(blockManager: BlockManager) extends

[GitHub] spark pull request: [SPARK-5530] Add executor container to executo...

2015-02-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4309 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-5500. Document that feeding hadoopFile i...

2015-02-02 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/4293#issuecomment-72538956 Ah, so the failing tests expose the possibility that someone could write their own `InputFormat` that doesn't reuse a single object, and caching that would be fine. So

[GitHub] spark pull request: [SPARK-4631][streaming][FIX] Wait for a receiv...

2015-02-02 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/4270#issuecomment-72539246 Merging this. Thanks for catching and fixing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5341] Use maven coordinates as dependen...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4215#discussion_r23962607 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala --- @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: Spark 3883: SSL support for HttpServer and Akk...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3571#issuecomment-72551055 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4874] [CORE] Collect record count metri...

2015-02-02 Thread ksakellis
Github user ksakellis commented on a diff in the pull request: https://github.com/apache/spark/pull/4067#discussion_r23953114 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -472,12 +512,12 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: SPARK-5425: Use synchronised methods in system...

2015-02-02 Thread jacek-lewandowski
Github user jacek-lewandowski commented on the pull request: https://github.com/apache/spark/pull/4220#issuecomment-72529009 @JoshRosen is it ok to go now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-2309][MLlib] Multinomial Logistic Regre...

2015-02-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/3833#discussion_r23954974 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/regression/GeneralizedLinearAlgorithm.scala --- @@ -107,6 +124,12 @@ abstract class

[GitHub] spark pull request: [SPARK-5173]support python application running...

2015-02-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3976#issuecomment-72532026 Ok LGTM thanks a lot @lianhuiwang I'm merging this into master. We can fix the SPARK_HOME issue separately later. Could you file a JIRA for it? --- If your project

[GitHub] spark pull request: [SPARK-5461] [graphx] Add isCheckpointed, getC...

2015-02-02 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/4253#issuecomment-72532059 That last commit added the transient tag back and uses firstParent in isCheckpointed, per @mengxr 's suggestion. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-5003][SQL]cast support date data type

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3839#issuecomment-72533555 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5521] PCA wrapper for easy transform ve...

2015-02-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4304#discussion_r23957512 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/PCA.scala --- @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-5425: Use synchronised methods in system...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4220#issuecomment-72540322 @jacek-lewandowski This looks good to me, so I'll merge it in a few minutes. It looks like your PRs against the other branches have also been updated, so I'll pull

[GitHub] spark pull request: [SPARK-1406] Mllib pmml model export

2015-02-02 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/3062#issuecomment-72540267 @srowen @selvinsource From user perspective, this is the code they need to export a model to PMML: ~~~ import org.apache.spark.mllib.export.ModelExporter

[GitHub] spark pull request: Update ec2-scripts.md

2015-02-02 Thread MiguelPeralvo
Github user MiguelPeralvo commented on the pull request: https://github.com/apache/spark/pull/4300#issuecomment-72543263 I've amended the commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-5212][SQL] Add support of schema-less, ...

2015-02-02 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/4014#issuecomment-72546189 Thanks! Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5383][SQL] Support alias for udtfs

2015-02-02 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/4186#discussion_r23963316 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUdfs.scala --- @@ -321,6 +324,18 @@ private[hive] case class HiveGenericUdtf(

[GitHub] spark pull request: [SPARK-3039] [BUILD] Spark assembly for new ha...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4315#issuecomment-72548453 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5383][SQL] Support alias for udtfs

2015-02-02 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/4186#issuecomment-72548543 Thanks for working on this! I agree with @chenghao-intel, can't you just convert it to a Generate instead of leaving it inside of a `Project` clause?

[GitHub] spark pull request: SPARK-5425: Use synchronised methods in system...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4222#issuecomment-72548525 I've merged this into `master` (1.3.0). Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SQL] Correct the default size of TimestampTyp...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4314#issuecomment-72549392 [Test build #26546 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26546/consoleFull) for PR 4314 at commit

[GitHub] spark pull request: Spark 3883: SSL support for HttpServer and Akk...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/3571#discussion_r23964014 --- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala --- @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request: [SPARK-5530] Add executor container to executo...

2015-02-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4309#issuecomment-72532674 Merging into master thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Disabling Utils.chmod700 for Windows

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4299#issuecomment-72533691 [Test build #26527 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26527/consoleFull) for PR 4299 at commit

[GitHub] spark pull request: [SPARK-5470][Core]use defaultClassLoader to lo...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4258#issuecomment-72533654 [Test build #26528 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26528/consoleFull) for PR 4258 at commit

[GitHub] spark pull request: [SPARK-2309][MLlib] Multinomial Logistic Regre...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3833#issuecomment-72533636 [Test build #26531 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26531/consoleFull) for PR 3833 at commit

[GitHub] spark pull request: [SPARK-4874] [CORE] Collect record count metri...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4067#issuecomment-72533681 [Test build #26530 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26530/consoleFull) for PR 4067 at commit

[GitHub] spark pull request: Disabling Utils.chmod700 for Windows

2015-02-02 Thread MartinWeindel
Github user MartinWeindel commented on the pull request: https://github.com/apache/spark/pull/4299#issuecomment-72538918 Am 02.02.2015 um 22:07 schrieb UCB AMPLab: Test FAILed. Refer to this link for build results (access rights to CI server needed):

  1   2   3   4   5   6   7   8   9   >