Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4294#discussion_r23961862
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/api.scala ---
@@ -171,6 +171,33 @@ private[sql] trait DataFrameSpecificApi {
def saveAsTable(tableName: String): Unit
@Experimental
+ def saveAsTable(tableName: String, dataSourceName: String, options:
(String, String)*): Unit
+
+ @Experimental
+ def saveAsTable(
+ tableName: String,
+ dataSourceName: String,
+ options: java.util.Map[String, String]): Unit
+
+ @Experimental
+ def save(path: String): Unit
+
+ @Experimental
+ def save(path: String, overwrite: Boolean): Unit
+
+ @Experimental
+ def save(
+ dataSourceName: String,
+ overwrite: Boolean,
+ options: (String, String)*): Unit
--- End diff --
i think this one might be ambiguous with the other save.
u'd want to declare something like
```scala
def save(
dataSourceName: String,
overwrite: Boolean,
option: (String, String),
options: (String, String)*): Unit
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
