[GitHub] spark pull request: [docs][minor] Fixed sample code in SQLContext ...

2015-03-16 Thread tarfaa
GitHub user tarfaa opened a pull request: https://github.com/apache/spark/pull/5051 [docs][minor] Fixed sample code in SQLContext scaladoc Error in the code sample of the `implicits` object in `SQLContext`. You can merge this pull request into a Git repository by running: $

[GitHub] spark pull request: jetty-security also needed for SPARK_PREPEND_C...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5052#issuecomment-81935826 [Test build #28670 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28670/consoleFull) for PR 5052 at commit

[GitHub] spark pull request: [SPARK-2691][Mesos] Support for Mesos DockerIn...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3074#issuecomment-81968390 [Test build #28679 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28679/consoleFull) for PR 3074 at commit

[GitHub] spark pull request: SPARK-6338 [CORE] Use standard temp dir mechan...

2015-03-16 Thread sryza
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/5029#discussion_r26535444 --- Diff: external/kafka/src/test/scala/org/apache/spark/streaming/kafka/ReliableKafkaStreamSuite.scala --- @@ -68,10 +67,7 @@ class ReliableKafkaStreamSuite

[GitHub] spark pull request: [SPARK-6284][MESOS] Add mesos role, principal ...

2015-03-16 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/4960#issuecomment-81975220 @realoptimal you did indeed found a problem about roles, I only tried it with seeing the framework registered with the right role and tasks launched, but didn't try it

[GitHub] spark pull request: SPARK-6338 [CORE] Use standard temp dir mechan...

2015-03-16 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/5029#discussion_r26535552 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertIntoHiveTableSuite.scala --- @@ -136,6 +135,7 @@ class InsertIntoHiveTableSuite extends

[GitHub] spark pull request: SPARK-6338 [CORE] Use standard temp dir mechan...

2015-03-16 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/5029#discussion_r26535518 --- Diff: external/kafka/src/test/scala/org/apache/spark/streaming/kafka/ReliableKafkaStreamSuite.scala --- @@ -68,10 +67,7 @@ class ReliableKafkaStreamSuite

[GitHub] spark pull request: [SPARK-1303] [MLLIB] Added discretization capa...

2015-03-16 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/216#issuecomment-81983258 @LIDIAgroup Sorry that I don't have enough bandwidth to review this PR. Since there are unresolved performance issues, do you mind closing this PR for now? I recommend

[GitHub] spark pull request: SPARK-6338 [CORE] Use standard temp dir mechan...

2015-03-16 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/5029#discussion_r26536957 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertIntoHiveTableSuite.scala --- @@ -136,6 +135,7 @@ class InsertIntoHiveTableSuite extends

[GitHub] spark pull request: [SPARK-6327] [PySpark] fix launch spark-submit...

2015-03-16 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/5019#issuecomment-81983845 OK, get it, thanks a lot. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2087] [SQL] Multiple thriftserver sessi...

2015-03-16 Thread chenghao-intel
Github user chenghao-intel closed the pull request at: https://github.com/apache/spark/pull/4382 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request: jetty-security also needed for SPARK_PREPEND_C...

2015-03-16 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/5052#issuecomment-82005866 @JoshRosen I couldn't think of anything, but to be honest I didn't really rack my brain too hard since its just a developer util. I'm open to any suggestions ... ---

[GitHub] spark pull request: [MLLib]SPARK-6348:Enable useFeatureScaling in ...

2015-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5055#issuecomment-82028025 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [MLLib]SPARK-6348:Enable useFeatureScaling in ...

2015-03-16 Thread tanyinyan
GitHub user tanyinyan opened a pull request: https://github.com/apache/spark/pull/5055 [MLLib]SPARK-6348:Enable useFeatureScaling in SVMWithSGD set useFeatureScaling true in SVMWithSGD, the problem describled in jira (https://issues.apache.org/jira/browse/SPARK-6348) You can merge

[GitHub] spark pull request: [SPARK-6222][STREAMING] Make sure batches are ...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4964#issuecomment-82034249 [Test build #28687 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28687/consoleFull) for PR 4964 at commit

[GitHub] spark pull request: [SPARK-6222][STREAMING] Make sure batches are ...

2015-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4964#issuecomment-82034264 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6222][STREAMING] Make sure batches are ...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4964#issuecomment-82033606 [Test build #28687 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28687/consoleFull) for PR 4964 at commit

[GitHub] spark pull request: [MLLIB] SPARK-4231, SPARK-3066: Add RankingMet...

2015-03-16 Thread debasish83
Github user debasish83 commented on a diff in the pull request: https://github.com/apache/spark/pull/3098#discussion_r26545110 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/MovieLensALS.scala --- @@ -18,14 +18,14 @@ package org.apache.spark.examples.mllib

[GitHub] spark pull request: [SPARK-5084][SQL]Replaces TestHiveContext.conf...

2015-03-16 Thread baishuo
Github user baishuo commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-82051247 had modify the Title of this PR @marmbrus @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-6372] [core] Propagate --conf to child ...

2015-03-16 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/5057 [SPARK-6372] [core] Propagate --conf to child processes. And add unit test. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vanzin/spark

[GitHub] spark pull request: [SPARK-6211][Streaming] Add Python Kafka API u...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4961#issuecomment-82051582 [Test build #28689 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28689/consoleFull) for PR 4961 at commit

[GitHub] spark pull request: [SPARK-5084][SQL]Replaces TestHiveContext.conf...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-82051855 [Test build #28690 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28690/consoleFull) for PR 3895 at commit

[GitHub] spark pull request: [SPARK-6356][SQL] Support the ROLLUP/CUBE/GROU...

2015-03-16 Thread watermen
Github user watermen commented on the pull request: https://github.com/apache/spark/pull/5045#issuecomment-82056296 @yhuai This patch supports two syntaxs. One is also supported by HiveContext. ``` GROUP BY expression list WITH ROLLUP GROUP BY expression list WITH CUBE

[GitHub] spark pull request: [SPARK-6371] [build] Update version to 1.4.0-S...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5056#issuecomment-82076232 [Test build #28686 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28686/consoleFull) for PR 5056 at commit

[GitHub] spark pull request: [SPARK-6371] [build] Update version to 1.4.0-S...

2015-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5056#issuecomment-82076300 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6299][CORE] ClassNotFoundException in s...

2015-03-16 Thread swkimme
Github user swkimme commented on the pull request: https://github.com/apache/spark/pull/5046#issuecomment-82075586 @rxin I tried to add a simple test like ``` test(collecting objects of class defined in repl - shuffling) { val output =

[GitHub] spark pull request: [SPARK-6325] [core,yarn] Do not change target ...

2015-03-16 Thread ksakellis
Github user ksakellis commented on a diff in the pull request: https://github.com/apache/spark/pull/5018#discussion_r26529056 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -340,7 +341,11 @@ class

[GitHub] spark pull request: [docs][minor] Fixed sample code in SQLContext ...

2015-03-16 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/5051#issuecomment-81953680 Mind including [SQL] in the title so that this gets properly sorted? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-6222][STREAMING] Make sure batches are ...

2015-03-16 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/4964#discussion_r26530402 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/JobGenerator.scala --- @@ -254,39 +271,97 @@ class JobGenerator(jobScheduler:

[GitHub] spark pull request: [SPARK-6284][MESOS] Add mesos role, principal ...

2015-03-16 Thread realoptimal
Github user realoptimal commented on the pull request: https://github.com/apache/spark/pull/4960#issuecomment-81959279 Also if Slave resources are all of the default type, i.e. *. The framework should be still be able to use those resources even with spark.mesos.role != * --- If

[GitHub] spark pull request: [SPARK-6325] [core,yarn] Do not change target ...

2015-03-16 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/5018#issuecomment-81959272 That method looks correct given the scaladoc describing it. Note that user code has two ways of affecting that method: `SparkContext.requestExecutors`, which

[GitHub] spark pull request: [SPARK-6325] [core,yarn] Do not change target ...

2015-03-16 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/5018#issuecomment-81964335 (Just for completeness: `SparkContext` actually doesn't directly affect the bookkeeping in `ExecutorAllocationManager`, which can be seen as a separate issue. Meaning my

[GitHub] spark pull request: SPARK-6338 [CORE] Use standard temp dir mechan...

2015-03-16 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/5029#issuecomment-81966491 What's the advantage of a parent directory created with `createTempDir` when we're already using `File.createTempFile`? --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-2691][Mesos] Support for Mesos DockerIn...

2015-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3074#issuecomment-81968401 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2691][Mesos] Support for Mesos DockerIn...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3074#issuecomment-81968372 [Test build #28679 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28679/consoleFull) for PR 3074 at commit

[GitHub] spark pull request: SPARK-6338 [CORE] Use standard temp dir mechan...

2015-03-16 Thread sryza
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/5029#discussion_r26535353 --- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala --- @@ -370,7 +369,7 @@ class UtilsSuite extends FunSuite with ResetSystemProperties {

[GitHub] spark pull request: SPARK-6338 [CORE] Use standard temp dir mechan...

2015-03-16 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/5029#issuecomment-81978100 LGTM (btw you're my hero). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5843] Allowing map-side combine to be s...

2015-03-16 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/4634#issuecomment-81977973 @mccheah can you make the couple minor changes I suggested? Other than that, this change lgtm. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-6327] [PySpark] fix launch spark-submit...

2015-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5019 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: jetty-security also needed for SPARK_PREPEND_C...

2015-03-16 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/5052#issuecomment-81989542 Is there an easy way to add a regression test for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-6325] [core,yarn] Do not change target ...

2015-03-16 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/5018#issuecomment-81999174 I have two main concerns about this patch. The first is that I think the logic in `CoarseGrainedSchedulerBackend` and `ExecutorAllocationManager` is

[GitHub] spark pull request: [SPARK-6025] [MLlib] Add helper method evaluat...

2015-03-16 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/4906#issuecomment-8238 It's hard to state a hard cutoff for task size, but the Spark programming guide recommends tasks larger than about 20 KB are probably worth optimizing [by

[GitHub] spark pull request: [SPARK-2087] [SQL] Multiple thriftserver sessi...

2015-03-16 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/4382#issuecomment-82003000 Closing it since #4885 has been merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6226][MLLIB] add save/load in PySpark's...

2015-03-16 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/5049#issuecomment-82011218 @mengxr Don't we need extra unittest? Does doctest well enough? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-6299][CORE] ClassNotFoundException in s...

2015-03-16 Thread swkimme
Github user swkimme commented on the pull request: https://github.com/apache/spark/pull/5046#issuecomment-82017037 @rxin Sure, I'll try to add some test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4894][mllib] Added Bernoulli option to ...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4087#issuecomment-82025636 [Test build #28685 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28685/consoleFull) for PR 4087 at commit

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-03-16 Thread baishuo
Github user baishuo commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-82048390 thank you @liancheng , I had study baishuo/spark#2 , and I think that is good :) @marmbrus --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-6211][Streaming] Add Python Kafka API u...

2015-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4961#issuecomment-82054252 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6211][Streaming] Add Python Kafka API u...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4961#issuecomment-82054204 [Test build #28683 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28683/consoleFull) for PR 4961 at commit

[GitHub] spark pull request: [MLLIB] [spark-2352] Implementation of an Arti...

2015-03-16 Thread debasish83
Github user debasish83 commented on the pull request: https://github.com/apache/spark/pull/1290#issuecomment-82057716 @avulanov could you please point me to a stable branch that I can experiment with..I am focused on collaborative filtering and implemented various matrix

[GitHub] spark pull request: [Core][minor] imporve the getCacheLocs method ...

2015-03-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/5043#discussion_r26545744 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -188,14 +188,13 @@ class DAGScheduler(

[GitHub] spark pull request: [SPARK-6222][STREAMING] Make sure batches are ...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4964#issuecomment-82060498 [Test build #28693 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28693/consoleFull) for PR 4964 at commit

[GitHub] spark pull request: [SPARK-5124][Core] A standard RPC interface an...

2015-03-16 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/4588#issuecomment-82060820 I added a non-blocking method `def asyncSetupEndpointRefByUrl(url: String): Future[RpcEndpointRef]` so that people can retrieve `RpcEndpointRef` in the message loop.

[GitHub] spark pull request: [Spark-5068][SQL]Fix bug query data when path ...

2015-03-16 Thread lazyman500
GitHub user lazyman500 opened a pull request: https://github.com/apache/spark/pull/5059 [Spark-5068][SQL]Fix bug query data when path doesn't exist for HiveContext This RP follow up PR #3907 #3891 #4356. According to @marmbrus @liancheng 's comment,I try to use fs.globStatus

[GitHub] spark pull request: [SPARK-4894][mllib] Added Bernoulli option to ...

2015-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4087#issuecomment-82072739 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5084][SQL]Replaces TestHiveContext.conf...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-82080400 [Test build #28690 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28690/consoleFull) for PR 3895 at commit

[GitHub] spark pull request: [SPARK-5084][SQL]Replaces TestHiveContext.conf...

2015-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-82080453 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6226][MLLIB] add save/load in PySpark's...

2015-03-16 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5049#discussion_r26547652 --- Diff: python/pyspark/mllib/common.py --- @@ -70,8 +70,8 @@ def _py2java(sc, obj): obj = _to_java_object_rdd(obj) elif isinstance(obj,

[GitHub] spark pull request: [SPARK-6226][MLLIB] add save/load in PySpark's...

2015-03-16 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/5049#issuecomment-82079679 Not necessary. doctests are examples+unittests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6299][CORE] ClassNotFoundException in s...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5046#issuecomment-82079122 [Test build #28695 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28695/consoleFull) for PR 5046 at commit

[GitHub] spark pull request: [SPARK-6025] [MLlib] Add helper method evaluat...

2015-03-16 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4906#discussion_r26539505 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/model/treeEnsembleModels.scala --- @@ -108,6 +110,58 @@ class GradientBoostedTreesModel(

[GitHub] spark pull request: [SPARK-6025] [MLlib] Add helper method evaluat...

2015-03-16 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4906#discussion_r26539550 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/model/treeEnsembleModels.scala --- @@ -108,6 +110,58 @@ class GradientBoostedTreesModel(

[GitHub] spark pull request: [SPARK-3382][MLLIB] GradientDescent convergenc...

2015-03-16 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3636#discussion_r26540822 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala --- @@ -219,4 +265,39 @@ object GradientDescent extends Logging {

[GitHub] spark pull request: [SPARK-3382][MLLIB] GradientDescent convergenc...

2015-03-16 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3636#discussion_r26540817 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala --- @@ -219,4 +265,39 @@ object GradientDescent extends Logging {

[GitHub] spark pull request: [SPARK-3382][MLLIB] GradientDescent convergenc...

2015-03-16 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/3636#issuecomment-82005205 With this change, we should probably constrain convergenceTol to be in [0, 1]. Could you please add that to the doc add a check in setConvergenceTol? Also,

[GitHub] spark pull request: [SPARK-3382][MLLIB] GradientDescent convergenc...

2015-03-16 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3636#discussion_r26540819 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala --- @@ -219,4 +265,39 @@ object GradientDescent extends Logging {

[GitHub] spark pull request: [SPARK-6211][Streaming] Add Python Kafka API u...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4961#issuecomment-82015600 [Test build #28683 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28683/consoleFull) for PR 4961 at commit

[GitHub] spark pull request: [SPARK-4894][mllib] Added Bernoulli option to ...

2015-03-16 Thread leahmcguire
Github user leahmcguire commented on a diff in the pull request: https://github.com/apache/spark/pull/4087#discussion_r26542594 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala --- @@ -156,9 +181,14 @@ object NaiveBayesModel extends

[GitHub] spark pull request: [SPARK-6371] [build] Update version to 1.4.0-S...

2015-03-16 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/5056 [SPARK-6371] [build] Update version to 1.4.0-SNAPSHOT. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vanzin/spark SPARK-6371 Alternatively

[GitHub] spark pull request: [Core][minor] imporve the getCacheLocs method ...

2015-03-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/5043#discussion_r26544667 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -188,14 +188,13 @@ class DAGScheduler(

[GitHub] spark pull request: [SPARK-5124][Core] A standard RPC interface an...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4588#issuecomment-82058962 [Test build #28692 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28692/consoleFull) for PR 4588 at commit

[GitHub] spark pull request: [SPARK-6372] [core] Propagate --conf to child ...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5057#issuecomment-82083653 [Test build #28691 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28691/consoleFull) for PR 5057 at commit

[GitHub] spark pull request: [SPARK-6372] [core] Propagate --conf to child ...

2015-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5057#issuecomment-82083697 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6299][CORE] ClassNotFoundException in s...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5046#issuecomment-82082655 [Test build #28696 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28696/consoleFull) for PR 5046 at commit

[GitHub] spark pull request: [SPARK-6313] Add config option to disable file...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5036#issuecomment-82004900 [Test build #28682 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28682/consoleFull) for PR 5036 at commit

[GitHub] spark pull request: [SPARK-6313] Add config option to disable file...

2015-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5036#issuecomment-82004907 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6325] [core,yarn] Do not change target ...

2015-03-16 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/5018#issuecomment-82024746 +1 to this code being confusing and overly complicated. There are 3 places tracking executor state (ExecutorAllocationManager, CoarseGrainedSchedulerBackend and

[GitHub] spark pull request: [SPARK-5376][Mesos] MesosExecutor should have ...

2015-03-16 Thread jongyoul
Github user jongyoul commented on the pull request: https://github.com/apache/spark/pull/4170#issuecomment-82031855 @tnachen @elyast I made a new issue about configuring mesos executor cores. https://issues.apache.org/jira/browse/SPARK-6350 --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-6222][STREAMING] Make sure batches are ...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4964#issuecomment-82041518 [Test build #28688 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28688/consoleFull) for PR 4964 at commit

[GitHub] spark pull request: [SPARK-6372] [core] Propagate --conf to child ...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5057#issuecomment-82054615 [Test build #28691 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28691/consoleFull) for PR 5057 at commit

[GitHub] spark pull request: [SPARK-5084][SQL]Replaces TestHiveContext.conf...

2015-03-16 Thread baishuo
Github user baishuo commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-82054358 @marmbrus no problem, let me resolve the conflicts :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [Core][minor] imporve the getCacheLocs method ...

2015-03-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/5043#discussion_r26546179 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -188,14 +188,13 @@ class DAGScheduler(

[GitHub] spark pull request: [SPARK-6374] [MLlib] add get for GeneralizedLi...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5058#issuecomment-82062795 [Test build #28694 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28694/consoleFull) for PR 5058 at commit

[GitHub] spark pull request: [SPARK-6356][SQL] Support the ROLLUP/CUBE/GROU...

2015-03-16 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/5045#discussion_r26546512 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -102,4 +102,8 @@ class CheckAnalysis {

[GitHub] spark pull request: [SPARK-6356][SQL] Support the ROLLUP/CUBE/GROU...

2015-03-16 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/5045#discussion_r26546785 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -179,6 +179,7 @@ case class Expand(

[GitHub] spark pull request: [SPARK-6356][SQL] Support the ROLLUP/CUBE/GROU...

2015-03-16 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/5045#discussion_r26546771 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -179,6 +179,7 @@ case class Expand(

[GitHub] spark pull request: [MLLIB] [spark-2352] Implementation of an Arti...

2015-03-16 Thread debasish83
Github user debasish83 commented on the pull request: https://github.com/apache/spark/pull/1290#issuecomment-82070543 Also how is this https://github.com/apache/spark/pull/3222 different ? I am confused for autoencoder which one is a better start... --- If your project is set up for

[GitHub] spark pull request: [Spark-5068][SQL]Fix bug query data when path ...

2015-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5059#issuecomment-82072538 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6211][Streaming] Add Python Kafka API u...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4961#issuecomment-82081257 [Test build #28689 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28689/consoleFull) for PR 4961 at commit

[GitHub] spark pull request: [SPARK-6222][STREAMING] Make sure batches are ...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4964#issuecomment-82081843 [Test build #28693 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28693/consoleFull) for PR 4964 at commit

[GitHub] spark pull request: [SPARK-6211][Streaming] Add Python Kafka API u...

2015-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4961#issuecomment-82081327 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6222][STREAMING] Make sure batches are ...

2015-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4964#issuecomment-82081893 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6226][MLLIB] add save/load in PySpark's...

2015-03-16 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/5049#discussion_r26542049 --- Diff: python/pyspark/mllib/common.py --- @@ -70,8 +70,8 @@ def _py2java(sc, obj): obj = _to_java_object_rdd(obj) elif

[GitHub] spark pull request: [SPARK-6211][Streaming] Add Python Kafka API u...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4961#issuecomment-82017408 [Test build #28684 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28684/consoleFull) for PR 4961 at commit

[GitHub] spark pull request: [SPARK-4894][mllib] Added Bernoulli option to ...

2015-03-16 Thread leahmcguire
Github user leahmcguire commented on a diff in the pull request: https://github.com/apache/spark/pull/4087#discussion_r26543828 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala --- @@ -35,26 +39,30 @@ import org.apache.spark.sql.{DataFrame,

[GitHub] spark pull request: jetty-security also needed for SPARK_PREPEND_C...

2015-03-16 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/5052#issuecomment-82028679 Doh, I looked at this too quickly and somehow mixed this up with one of the user classpath first options. This looks good to me, too. --- If your project is set up

[GitHub] spark pull request: [SPARK-2087] [SQL] Multiple thriftserver sessi...

2015-03-16 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/4885#issuecomment-82034566 Thank you very much @liancheng, I will create another PR for the requirements that we discussed above, and also the minor issues. --- If your project is set up

[GitHub] spark pull request: [SPARK-6211][Streaming] Add Python Kafka API u...

2015-03-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4961#issuecomment-82039773 [Test build #28684 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28684/consoleFull) for PR 4961 at commit

[GitHub] spark pull request: [SPARK-6211][Streaming] Add Python Kafka API u...

2015-03-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4961#issuecomment-82039843 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6211][Streaming] Add Python Kafka API u...

2015-03-16 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/4961#issuecomment-82047655 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

  1   2   3   4   5   >