[GitHub] spark pull request: [SPARK-9384] [core] Easier setting of executor...

2015-08-11 Thread markgrover
Github user markgrover commented on a diff in the pull request: https://github.com/apache/spark/pull/7739#discussion_r36826550 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -479,6 +484,23 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Loggi

[GitHub] spark pull request: [SPARK-9740] [SPARK-9592] [SQL] Change the def...

2015-08-11 Thread ggupta81
Github user ggupta81 commented on a diff in the pull request: https://github.com/apache/spark/pull/8113#discussion_r36826491 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala --- @@ -630,59 +632,114 @@ case class CombineSetsAndSumFunc

[GitHub] spark pull request: [SPARK-9816][SQL] Support BinaryType in Concat

2015-08-11 Thread maropu
Github user maropu closed the pull request at: https://github.com/apache/spark/pull/8099 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: SPARK-9790: [YARN] Expose in WebUI if NodeMana...

2015-08-11 Thread markgrover
Github user markgrover commented on the pull request: https://github.com/apache/spark/pull/8093#issuecomment-130159464 Thanks for the review, @squito. I did consider that as well. The UI listens to whatever is sent as `SparkListenerTaskEnd` message by the DAGScheduler::handleTaskCompl

[GitHub] spark pull request: [SPARK-9750][MLlib] Improve equals on SparseMa...

2015-08-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8042#issuecomment-130159360 @feynmanliang The contract for Java's `Object` is that `a.equals(b)` implies `a.hashCode == b.hashCode`. So usually we need to implement both. The problem with `hashCode`

[GitHub] spark pull request: SPARK-9545, SPARK-9547: Use Maven in PRB if ti...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7878#issuecomment-130157632 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7542][SQL] Support off-heap buffer in U...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8068#issuecomment-130156962 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7542][SQL] Support off-heap buffer in U...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8068#issuecomment-130156894 [Test build #40570 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40570/console) for PR 8068 at commit [`ff698fa`](https://github.

[GitHub] spark pull request: [SPARK-9740] [SQL] Change the default behavior...

2015-08-11 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8113#discussion_r36825930 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala --- @@ -630,59 +632,114 @@ case class CombineSetsAndSumFunctio

[GitHub] spark pull request: SPARK-9790: [YARN] Expose in WebUI if NodeMana...

2015-08-11 Thread markgrover
Github user markgrover commented on a diff in the pull request: https://github.com/apache/spark/pull/8093#discussion_r36825910 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -435,19 +437,24 @@ private[yarn] class YarnAllocator( //

[GitHub] spark pull request: SPARK-9790: [YARN] Expose in WebUI if NodeMana...

2015-08-11 Thread markgrover
Github user markgrover commented on a diff in the pull request: https://github.com/apache/spark/pull/8093#discussion_r36825911 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -423,6 +424,7 @@ private[yarn] class YarnAllocator( for (com

[GitHub] spark pull request: SPARK-9545, SPARK-9547: Use Maven in PRB if ti...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7878#issuecomment-130156154 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: SPARK-9545, SPARK-9547: Use Maven in PRB if ti...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7878#issuecomment-130156164 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9713] [ML] Document SparkR MLlib glm() ...

2015-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8085 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9713] [ML] Document SparkR MLlib glm() ...

2015-08-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8085#issuecomment-130156074 Merged into master and branch-1.5. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: SPARK-9545, SPARK-9547: Use Maven in PRB if ti...

2015-08-11 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/7878#issuecomment-130156023 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9805] [MLLIB] [PYTHON] [STREAMING] Adde...

2015-08-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8087#issuecomment-130155885 What if `condition` requires at least one batch to work correctly? This is not the case for streaming ML algorithms, but I'm not sure for other streaming unit tests. --

[GitHub] spark pull request: [SPARK-9740] [SQL] Change the default behavior...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8113#issuecomment-130155854 [Test build #40589 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40589/consoleFull) for PR 8113 at commit [`15c9e31`](https://gith

[GitHub] spark pull request: [SPARK-9740] [SQL] Change the default behavior...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8113#issuecomment-130155782 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9740] [SQL] Change the default behavior...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8113#issuecomment-130155769 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9740] [SQL] Change the default behavior...

2015-08-11 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8113#issuecomment-130155568 @hvanhovell Alright. I added the `ignoreNulls` flag. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] spark pull request: [SPARK-1517] Refactor release scripts to facil...

2015-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7411 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-1517] Refactor release scripts to facil...

2015-08-11 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/7411#issuecomment-130155218 Okay will merge this - I've been keeping things in a separate repo and it's much better to have it in the upstream in case others want to modify it. --- If your projec

[GitHub] spark pull request: [SPARK-9827] [SQL] fix fd leak in UnsafeRowSer...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8116#issuecomment-130154323 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-4131][SQL] support writing data into th...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4380#issuecomment-130154342 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9805] [MLLIB] [PYTHON] [STREAMING] Adde...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8087#issuecomment-130153820 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9827] [SQL] fix fd leak in UnsafeRowSer...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8116#issuecomment-130153739 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4131][SQL] support writing data into th...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4380#issuecomment-130153749 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9747] [SQL] Avoid starving an unsafe op...

2015-08-11 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8038#issuecomment-130153744 ``` [error] /home/jenkins/workspace/NewSparkPullRequestBuilder/sql/core/src/test/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIteratorSuite.scala:4

[GitHub] spark pull request: [SPARK-9827] [SQL] fix fd leak in UnsafeRowSer...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8116#issuecomment-130153735 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-4131][SQL] support writing data into th...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4380#issuecomment-130153737 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-4131][SQL] support writing data into th...

2015-08-11 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/4380#issuecomment-130153626 Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-4131][SQL] support writing data into th...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4380#issuecomment-130153233 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-4131][SQL] support writing data into th...

2015-08-11 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/4380#issuecomment-130152470 yes, since we upgrade the hive version to 1.2.1, we should adapt the token tree in hiveql, the old one is not correct in 1.2.1. Updated --- If your project is set up for

[GitHub] spark pull request: [SPARK-4131][SQL] support writing data into th...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4380#issuecomment-130151463 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4131][SQL] support writing data into th...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4380#issuecomment-130151421 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9747] [SQL] Avoid starving an unsafe op...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8038#issuecomment-130150506 [Test build #1470 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1470/console) for PR 8038 at commit [`d4dc9ca`](https://github

[GitHub] spark pull request: [SPARK-9854] [SQL] RuleExecutor.timeMap should...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8120#issuecomment-130150558 [Test build #1472 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1472/consoleFull) for PR 8120 at commit [`615d08e`](https://git

[GitHub] spark pull request: [SPARK-9854] [SQL] RuleExecutor.timeMap should...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8120#issuecomment-130150533 [Test build #1471 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1471/consoleFull) for PR 8120 at commit [`615d08e`](https://git

[GitHub] spark pull request: [SPARK-9649] Fix flaky test MasterSuite again ...

2015-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8084 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-130150454 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-130150422 [Test build #40581 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40581/console) for PR 7957 at commit [`4cd4fad`](https://github.

[GitHub] spark pull request: [SPARK-9805] [MLLIB] [PYTHON] [STREAMING] Adde...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8087#issuecomment-130150414 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9805] [MLLIB] [PYTHON] [STREAMING] Adde...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8087#issuecomment-130150407 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9805] [MLLIB] [PYTHON] [STREAMING] Adde...

2015-08-11 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8087#issuecomment-130150269 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9649] Fix flaky test MasterSuite again ...

2015-08-11 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8084#issuecomment-130150255 LGTM, so I'm going to merge this to master and branch-1.5. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] spark pull request: [SPARK-9854] [SQL] RuleExecutor.timeMap should...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8120#issuecomment-130149388 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9854] [SQL] RuleExecutor.timeMap should...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8120#issuecomment-130149410 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9854] [SQL] RuleExecutor.timeMap should...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8120#issuecomment-130149352 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9805] [MLLIB] [PYTHON] [STREAMING] Adde...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8087#issuecomment-130149344 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9854] [SQL] RuleExecutor.timeMap should...

2015-08-11 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8120#issuecomment-130149300 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9805] [MLLIB] [PYTHON] [STREAMING] Adde...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8087#issuecomment-130148853 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9805] [MLLIB] [PYTHON] [STREAMING] Adde...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8087#issuecomment-130148813 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9574][Streaming]Remove unnecessary cont...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8069#issuecomment-130148732 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9592] [SQL] Fixed First and Last aggreg...

2015-08-11 Thread ggupta81
Github user ggupta81 commented on the pull request: https://github.com/apache/spark/pull/7928#issuecomment-130148639 correct. I will make the changes you have suggested and update the pull request. On Wed, Aug 12, 2015 at 8:38 AM, Yin Huai wrote: > @ggupta81

[GitHub] spark pull request: [SPARK-9580] [SQL] [WIP] Replace singletons in...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8111#issuecomment-130146649 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9854] [SQL] RuleExecutor.timeMap should...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8120#issuecomment-130145766 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9649] Fix flaky test MasterSuite again ...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8084#issuecomment-130145729 [Test build #1466 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1466/console) for PR 8084 at commit [`026f628`](https://github

[GitHub] spark pull request: [SPARK-9854] [SQL] RuleExecutor.timeMap should...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8120#issuecomment-130145288 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9854] [SQL] RuleExecutor.timeMap should...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8120#issuecomment-130145274 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-130145006 [Test build #40581 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40581/consoleFull) for PR 7957 at commit [`4cd4fad`](https://gith

[GitHub] spark pull request: [SPARK-9854] [SQL] RuleExecutor.timeMap should...

2015-08-11 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8120#issuecomment-130144784 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9854] [SQL] RuleExecutor.timeMap should...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8120#issuecomment-130144544 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9649] Fix flaky test MasterSuite again ...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8084#issuecomment-130144657 [Test build #40580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40580/consoleFull) for PR 8084 at commit [`026f628`](https://gith

[GitHub] spark pull request: [SPARK-9689][SQL]Fix bug of not invalidate the...

2015-08-11 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8023#discussion_r36823588 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -565,6 +565,7 @@ abstract class HadoopFsRelation private[sql](m

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-13010 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-130144415 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9689][SQL]Fix bug of not invalidate the...

2015-08-11 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8023#discussion_r36823532 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -565,6 +565,7 @@ abstract class HadoopFsRelation private[sql](m

[GitHub] spark pull request: [SPARK-8889] [Core]: Fix for OOM for graph cre...

2015-08-11 Thread rekhajoshm
Github user rekhajoshm commented on the pull request: https://github.com/apache/spark/pull/7602#issuecomment-130144282 Thanks @srowen @andrewor14 updated push with tested UISelenium version which consistently passes (tested more than 20 times). I was curious to know why concise versi

[GitHub] spark pull request: [SPARK-8889] [Core]: Fix for OOM for graph cre...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7602#issuecomment-130144078 [Test build #40579 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40579/consoleFull) for PR 7602 at commit [`eee1733`](https://gith

[GitHub] spark pull request: [SPARK-9805] [MLLIB] [PYTHON] [STREAMING] Adde...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8087#issuecomment-130143998 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9805] [MLLIB] [PYTHON] [STREAMING] Adde...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8087#issuecomment-130143989 [Test build #40578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40578/console) for PR 8087 at commit [`48f43c8`](https://github.

[GitHub] spark pull request: [SPARK-9805] [MLLIB] [PYTHON] [STREAMING] Adde...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8087#issuecomment-130143930 [Test build #40578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40578/consoleFull) for PR 8087 at commit [`48f43c8`](https://gith

[GitHub] spark pull request: [SPARK-9634][SPARK-9323][SQL] cleanup unnecess...

2015-08-11 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/7957#issuecomment-130143971 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9828] [PySpark] Mutable values should n...

2015-08-11 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/8110#issuecomment-130143654 @mengxr tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9649] Fix flaky test MasterSuite again ...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8084#issuecomment-130143114 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9805] [MLLIB] [PYTHON] [STREAMING] Adde...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8087#issuecomment-130143144 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9592] [SQL] Fixed First and Last aggreg...

2015-08-11 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/7928#issuecomment-130143124 @ggupta81 We are having a new implementation of aggregate functions in 1.5.0. The last function having problem in your case is our old implementation. Let's fix it and I w

[GitHub] spark pull request: [SPARK-8889] [Core]: Fix for OOM for graph cre...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7602#issuecomment-130143174 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9854] [SQL] RuleExecutor.timeMap should...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8120#issuecomment-130143082 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9854] [SQL] RuleExecutor.timeMap should...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8120#issuecomment-130143141 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9649] Fix flaky test MasterSuite again ...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8084#issuecomment-130143175 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9805] [MLLIB] [PYTHON] [STREAMING] Adde...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8087#issuecomment-130143106 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8889] [Core]: Fix for OOM for graph cre...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7602#issuecomment-130143123 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9592] [SQL] Fixed First and Last aggreg...

2015-08-11 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/7928#discussion_r36823318 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala --- @@ -746,13 +746,11 @@ case class Last(child: Expression) e

[GitHub] spark pull request: [SPARK-5754] [yarn] Spark Driver/Executor cmd ...

2015-08-11 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/8053#issuecomment-130142600 This looks like it's going in the right direction. In your previous patch, you mentioned that `quoteForBatchScript` didn't escape `%` characters; is that not needed?

[GitHub] spark pull request: [SPARK-9854] [SQL] RuleExecutor.timeMap should...

2015-08-11 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8120#issuecomment-130142542 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9649] Fix flaky test MasterSuite again ...

2015-08-11 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8084#issuecomment-130142459 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9649] Fix flaky test MasterSuite again ...

2015-08-11 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8084#issuecomment-130142470 Wow, this has been the unluckiest PR when it comes to flakiness :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] spark pull request: [SPARK-9854] [SQL] RuleExecutor.timeMap should...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8120#issuecomment-130142409 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-5754] [yarn] Spark Driver/Executor cmd ...

2015-08-11 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8053#discussion_r36823225 --- Diff: yarn/src/main/scala/org/apache/spark/launcher/YarnCommandBuilderUtils.scala --- @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] spark pull request: [SPARK-5754] [yarn] Spark Driver/Executor cmd ...

2015-08-11 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8053#discussion_r36823207 --- Diff: yarn/src/main/scala/org/apache/spark/launcher/YarnCommandBuilderUtils.scala --- @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] spark pull request: [SPARK-5754] [yarn] Spark Driver/Executor cmd ...

2015-08-11 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8053#discussion_r36823191 --- Diff: yarn/src/main/scala/org/apache/spark/launcher/YarnCommandBuilderUtils.scala --- @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] spark pull request: [SPARK-5754] [yarn] Spark Driver/Executor cmd ...

2015-08-11 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8053#discussion_r36823172 --- Diff: yarn/src/main/scala/org/apache/spark/launcher/YarnCommandBuilderUtils.scala --- @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] spark pull request: [SPARK-7736] [core] [yarn] Make pyspark fail Y...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7751#issuecomment-130142037 [Test build #40576 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40576/consoleFull) for PR 7751 at commit [`d6667da`](https://gith

[GitHub] spark pull request: [SPARK-9649] Fix flaky test MasterSuite again ...

2015-08-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8084#issuecomment-130142016 [Test build #1465 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1465/console) for PR 8084 at commit [`026f628`](https://github

[GitHub] spark pull request: [SPARK-5754] [yarn] Spark Driver/Executor cmd ...

2015-08-11 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8053#discussion_r36823066 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -21,6 +21,8 @@ import java.io.File import java.util.regex.Matc

[GitHub] spark pull request: [SPARK-7736] [core] [yarn] Make pyspark fail Y...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7751#issuecomment-130141555 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7736] [core] [yarn] Make pyspark fail Y...

2015-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7751#issuecomment-130141543 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9827] [SQL] fix fd leak in UnsafeRowSer...

2015-08-11 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8116#issuecomment-130141381 The basic fix here looks good to me, although you might consider using the TaskContext callback approach to ensure eventual cleanup. We do this inside of the UnsafeExt

<    1   2   3   4   5   6   7   8   9   10   >