[GitHub] spark pull request: [SPARK-9818][SQL][WIP]Revert SPARK-6136 to ena...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8101#issuecomment-131078391 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9720] [ML] Identifiable types need UID ...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8062#issuecomment-131077894 [Test build #40862 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40862/console) for PR 8062 at commit

[GitHub] spark pull request: [SPARK-9818][SQL][WIP]Revert SPARK-6136 to ena...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8101#issuecomment-131078332 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9818][SQL][WIP]Revert SPARK-6136 to ena...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8101#issuecomment-131079069 [Test build #40865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40865/consoleFull) for PR 8101 at commit

[GitHub] spark pull request: [SPARK-9720] [ML] Identifiable types need UID ...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8062#issuecomment-131078172 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9969][YARN] Remove old MR classpath API...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8192#issuecomment-131079718 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9969][YARN] Remove old MR classpath API...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8192#issuecomment-131079681 **[Test build #40855 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40855/console)** for PR 8192 at commit

[GitHub] spark pull request: [SPARK-8839][SQL]High concurrence will also ca...

2015-08-14 Thread SaintBacchus
Github user SaintBacchus commented on the pull request: https://github.com/apache/spark/pull/7889#issuecomment-131079850 @zsxwing hive had a configuration named `hive.server2.thrift.max.worker.threads` which had already limit the concurrence. But my problem was not caused by

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-14 Thread MechCoder
GitHub user MechCoder opened a pull request: https://github.com/apache/spark/pull/8197 [SPARK-9906] [ML] User guide for LogisticRegressionSummary User guide for LogisticRegression summaries You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131081002 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131081029 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-14 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37068027 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,141 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. + +Once

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131082736 [Test build #40866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40866/consoleFull) for PR 8197 at commit

[GitHub] spark pull request: [SPARK-9818][SQL][WIP]Revert SPARK-6136 to ena...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8101#issuecomment-131083370 [Test build #40865 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40865/console) for PR 8101 at commit

[GitHub] spark pull request: [SPARK-9818][SQL][WIP]Revert SPARK-6136 to ena...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8101#issuecomment-131083481 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131084755 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131084684 [Test build #40866 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40866/console) for PR 8197 at commit

[GitHub] spark pull request: [SPARK-9974] [BUILD] [SQL] Makes sure com.twit...

2015-08-14 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/8198 [SPARK-9974] [BUILD] [SQL] Makes sure com.twitter:parquet-hadoop-bundle:1.6.0 is in SBT assembly jar You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-9924] [WEB UI] Don't schedule checkForL...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8153#issuecomment-131085200 [Test build #40857 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40857/console) for PR 8153 at commit

[GitHub] spark pull request: [SPARK-8118] [SQL] Redirects Parquet JUL logge...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8196#issuecomment-131085214 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9974] [BUILD] [SQL] Makes sure com.twit...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8198#issuecomment-131085221 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9974] [BUILD] [SQL] Makes sure com.twit...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8198#issuecomment-131085204 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8118] [SQL] Redirects Parquet JUL logge...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8196#issuecomment-131085228 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9924] [WEB UI] Don't schedule checkForL...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8153#issuecomment-131085236 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8118] [SQL] Redirects Parquet JUL logge...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8196#issuecomment-131085620 [Test build #40868 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40868/consoleFull) for PR 8196 at commit

[GitHub] spark pull request: [SPARK-9960][GraphX] sendMessage type fix in L...

2015-08-14 Thread farseer90718
GitHub user farseer90718 opened a pull request: https://github.com/apache/spark/pull/8188 [SPARK-9960][GraphX] sendMessage type fix in LabelPropagation.scala You can merge this pull request into a Git repository by running: $ git pull https://github.com/farseer90718/spark

[GitHub] spark pull request: [SPARK-9960][GraphX] sendMessage type fix in L...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8188#issuecomment-130988499 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8839][SQL]High concurrence will also ca...

2015-08-14 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/7889#issuecomment-130995540 I suspect #8185 fixes this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-9867][SQL] Move utilities for binary da...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8122#issuecomment-130997284 [Test build #1598 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1598/consoleFull) for PR 8122 at commit

[GitHub] spark pull request: [SPARK-9923][Core]: ShuffleMapStage.numAvailab...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8183#issuecomment-130997230 [Test build #1597 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1597/consoleFull) for PR 8183 at commit

[GitHub] spark pull request: [SPARK-9828] [PySpark] Mutable values should n...

2015-08-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8110#issuecomment-130997299 @davies does this look good to you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-9828] [PySpark] Mutable values should n...

2015-08-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8110#issuecomment-130998940 I discussed with @mengxr offline about this. It seems to me it is safer to not use {} at all (i.e. always immutable) in the arguments, even if the docstring is slightly

[GitHub] spark pull request: [MINOR] [SQL] Fix sphinx warnings in PySpark S...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8171#issuecomment-130998985 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9828] [PySpark] Mutable values should n...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8110#issuecomment-131001632 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9828] [PySpark] Mutable values should n...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8110#issuecomment-131001616 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9828] [PySpark] Mutable values should n...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8110#issuecomment-131003161 [Test build #40852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40852/consoleFull) for PR 8110 at commit

[GitHub] spark pull request: correct buffer size

2015-08-14 Thread viper-kun
GitHub user viper-kun opened a pull request: https://github.com/apache/spark/pull/8189 correct buffer size No need multiply columnType.defaultSize here, we have done it In ColumnBuilder class. buffer = ByteBuffer.allocate(4 + size * columnType.defaultSize) You can merge

[GitHub] spark pull request: [SPARK 9902] [MLlib] [WIP] Add Java and Python...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8154#issuecomment-130993769 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK 9902] [MLlib] [WIP] Add Java and Python...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8154#issuecomment-130993714 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK 9902] [MLlib] [WIP] Add Java and Python...

2015-08-14 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8154#issuecomment-130993052 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-9958][SQL]Make HiveThriftServer2Listene...

2015-08-14 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/8185#issuecomment-130993748 LGTM. Merging to master and branch-1.5. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK 9902] [MLlib] [WIP] Add Java and Python...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8154#issuecomment-130994884 [Test build #40850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40850/consoleFull) for PR 8154 at commit

[GitHub] spark pull request: [SPARK-9958][SQL]Make HiveThriftServer2Listene...

2015-08-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-9960][GraphX] sendMessage type fix in L...

2015-08-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8188#issuecomment-130996960 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [MINOR] [SQL] Fix sphinx warnings in PySpark S...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8171#issuecomment-131000555 [Test build #40851 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40851/consoleFull) for PR 8171 at commit

[GitHub] spark pull request: [SPARK-9828] [PySpark] Mutable values should n...

2015-08-14 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/8110#issuecomment-131001038 Hmm.. those are just docstrings, but I'll still change them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK 9902] [MLlib] [WIP] Add Java and Python...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8154#issuecomment-131000846 [Test build #40850 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40850/console) for PR 8154 at commit

[GitHub] spark pull request: [SPARK-9961] [MLLIB] minor clean-up of SPARK-9...

2015-08-14 Thread mengxr
GitHub user mengxr opened a pull request: https://github.com/apache/spark/pull/8190 [SPARK-9961] [MLLIB] minor clean-up of SPARK-9661 Some minor clean-ups after SPARK-9661. See my inline comments. @MechCoder @jkbradley You can merge this pull request into a Git repository by

[GitHub] spark pull request: [MINOR] [SQL] Fix sphinx warnings in PySpark S...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8171#issuecomment-131005715 [Test build #40851 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40851/console) for PR 8171 at commit

[GitHub] spark pull request: [MINOR] [SQL] Fix sphinx warnings in PySpark S...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8171#issuecomment-131005846 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9961] [MLLIB] minor clean-up of SPARK-9...

2015-08-14 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8190#discussion_r37055236 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/Statistics.scala --- @@ -221,9 +221,7 @@ object Statistics { def kolmogorovSmirnovTest(

[GitHub] spark pull request: [SPARK-9961] [MLLIB] minor clean-up of SPARK-9...

2015-08-14 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8190#discussion_r37055243 --- Diff: mllib/src/test/java/org/apache/spark/mllib/clustering/JavaLDASuite.java --- @@ -110,8 +112,8 @@ public void distributedLDAModel() {

[GitHub] spark pull request: [SPARK-9949] [SQL] Fix TakeOrderedAndProject's...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8179#issuecomment-131010145 [Test build #40849 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40849/console) for PR 8179 at commit

[GitHub] spark pull request: correct buffer size

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8189#issuecomment-130988913 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: correct buffer size

2015-08-14 Thread viper-kun
Github user viper-kun commented on the pull request: https://github.com/apache/spark/pull/8189#issuecomment-130988766 @liancheng @scwf is it OK? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [MINOR] [SQL] Fix sphinx warnings in PySpark S...

2015-08-14 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8171#issuecomment-130992739 This is the generated html doc: ![screen shot 2015-08-13 at 11 35 10

[GitHub] spark pull request: [SPARK 9902] [MLlib] [WIP] Add Java and Python...

2015-08-14 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8154#issuecomment-130992944 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [MINOR] [SQL] Fix sphinx warnings in PySpark S...

2015-08-14 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/8171#issuecomment-130998266 I used asterisks as done in pyspark/mllib/clustering . Hopefully it should look good now. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [MINOR] [SQL] Fix sphinx warnings in PySpark S...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8171#issuecomment-130998954 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9828] [PySpark] Mutable values should n...

2015-08-14 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8110#issuecomment-131000551 @MechCoder I searched `={}` and `=[]` in the codebase and found one more: ~~~ ml/pipeline.py:__init__(self, stages=[]) ml/pipeline.py:

[GitHub] spark pull request: [SPARK 9902] [MLlib] [WIP] Add Java and Python...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8154#issuecomment-131001051 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: correct buffer size

2015-08-14 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/8189#issuecomment-131002972 Could you file a JIRA ticket and update the PR title to [SPARK-] [SQL] title? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-9961] [MLLIB] minor clean-up of SPARK-9...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8190#issuecomment-131006185 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9961] [MLLIB] minor clean-up of SPARK-9...

2015-08-14 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8190#discussion_r37055242 --- Diff: mllib/src/test/java/org/apache/spark/mllib/clustering/JavaLDASuite.java --- @@ -44,9 +46,9 @@ public void setUp() { sc = new

[GitHub] spark pull request: [SPARK-9961] [MLLIB] minor clean-up of SPARK-9...

2015-08-14 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8190#discussion_r37055235 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala --- @@ -674,10 +674,9 @@ class DistributedLDAModel private[clustering] (

[GitHub] spark pull request: [SPARK-9961] [MLLIB] minor clean-up of SPARK-9...

2015-08-14 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8190#discussion_r37055244 --- Diff: mllib/src/test/java/org/apache/spark/mllib/clustering/JavaLDASuite.java --- @@ -126,8 +128,12 @@ public Boolean call(Tuple2Long, Vector tuple2) {

[GitHub] spark pull request: [SPARK-9961] [MLLIB] minor clean-up of SPARK-9...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8190#issuecomment-131006165 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9961] [MLLIB] minor clean-up of SPARK-9...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8190#issuecomment-131006707 [Test build #40853 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40853/consoleFull) for PR 8190 at commit

[GitHub] spark pull request: [SPARK-9828] [PySpark] Mutable values should n...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8110#issuecomment-131009118 [Test build #40852 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40852/console) for PR 8110 at commit

[GitHub] spark pull request: [SPARK-9828] [PySpark] Mutable values should n...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8110#issuecomment-131009277 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9949] [SQL] Fix TakeOrderedAndProject's...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8179#issuecomment-131010330 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Spark-9028] [ML] Add CountVectorizer as an es...

2015-08-14 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7388#discussion_r37051774 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizerModel.scala --- @@ -19,45 +19,133 @@ package org.apache.spark.ml.feature

[GitHub] spark pull request: [Spark-9028] [ML] Add CountVectorizer as an es...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7388#issuecomment-131104711 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9923][Core]: ShuffleMapStage.numAvailab...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8183#issuecomment-131104476 [Test build #1599 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1599/console) for PR 8183 at commit

[GitHub] spark pull request: [SPARK-9966][STREAMING] Handle couple of corne...

2015-08-14 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/8199#issuecomment-131105211 I will take care of the nits and merge it tomorrow. Thanks @dragos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-9968][STREAMING] Reduced time spent wit...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8204#issuecomment-131106254 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/8193#issuecomment-131106600 Hey @yjshen, I noticed that both this PR and #8132 are closed and code is cleaned. Seems to be misoperation? Your original PR branches still exist in your own repo

[GitHub] spark pull request: [SPARK-9439] [wip] [yarn] External shuffle ser...

2015-08-14 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/7943#discussion_r37075795 --- Diff: network/shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java --- @@ -81,7 +142,18 @@ public void

[GitHub] spark pull request: [Spark-9028] [ML] Add CountVectorizer as an es...

2015-08-14 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/7388#issuecomment-131104897 Thanks @jkbradley for the update. Copy the comment of Joseph from https://github.com/hhbyyh/spark/pull/3 to here: Updates: Renamed minCount to

[GitHub] spark pull request: [SPARK-8887][SQL]Explicit define which data ty...

2015-08-14 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/8201#issuecomment-131106915 This is exactly the same as #8132, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Spark-9028] [ML] Add CountVectorizer as an es...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7388#issuecomment-131104756 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9439] [wip] [yarn] External shuffle ser...

2015-08-14 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/7943#discussion_r37076729 --- Diff: network/shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java --- @@ -81,7 +142,18 @@ public void

[GitHub] spark pull request: [SPARK-9966][STREAMING] Handle couple of corne...

2015-08-14 Thread dragos
Github user dragos commented on a diff in the pull request: https://github.com/apache/spark/pull/8199#discussion_r37077457 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/scheduler/rate/PIDRateEstimatorSuite.scala --- @@ -36,72 +36,89 @@ class PIDRateEstimatorSuite

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37078760 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-9867][SQL] Move utilities for binary da...

2015-08-14 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/8122#issuecomment-131117757 If no problem, could you merge this? cc: @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9968][STREAMING] Reduced time spent wit...

2015-08-14 Thread tdas
GitHub user tdas opened a pull request: https://github.com/apache/spark/pull/8204 [SPARK-9968][STREAMING] Reduced time spent within synchronized block to prevent lock starvation When the rate limiter is actually limiting the rate at which data is inserted into the buffer, the

[GitHub] spark pull request: [SPARK-9968][STREAMING] Reduced time spent wit...

2015-08-14 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/8204#issuecomment-131105660 @zsxwing Could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9968][STREAMING] Reduced time spent wit...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8204#issuecomment-131106215 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37075991 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -59,6 +59,30 @@ trait PredicateHelper { }

[GitHub] spark pull request: [SPARK-8887][SQL]Explicit define which data ty...

2015-08-14 Thread yjshen
Github user yjshen commented on the pull request: https://github.com/apache/spark/pull/8201#issuecomment-131107262 yes, it's the same, I mistakenly deleted them both on github, and reopened a new PR here --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-9968][STREAMING] Reduced time spent wit...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8204#issuecomment-131107483 [Test build #40882 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40882/consoleFull) for PR 8204 at commit

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37076313 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -59,6 +59,30 @@ trait PredicateHelper { }

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37077029 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed

[GitHub] spark pull request: [Spark-9028] [ML] Add CountVectorizer as an es...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7388#issuecomment-131104930 [Test build #40881 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40881/consoleFull) for PR 7388 at commit

[GitHub] spark pull request: [SPARK-9966][STREAMING] Handle couple of corne...

2015-08-14 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/8199#discussion_r37075326 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/scheduler/rate/PIDRateEstimatorSuite.scala --- @@ -36,72 +36,89 @@ class PIDRateEstimatorSuite

[GitHub] spark pull request: [SPARK-9966][STREAMING] Handle couple of corne...

2015-08-14 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/8199#discussion_r37075294 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/rate/RateEstimator.scala --- @@ -61,7 +60,8 @@ object RateEstimator { val

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37078486 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -59,6 +59,30 @@ trait PredicateHelper { }

[GitHub] spark pull request: [SPARK-8887][SQL]Explicit define which data ty...

2015-08-14 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/8201#issuecomment-131107787 OK. This LGTM, but I'd like to ask @rxin for a final review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37076618 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -59,6 +59,30 @@ trait PredicateHelper { }

[GitHub] spark pull request: [SPARK-9439] [wip] [yarn] External shuffle ser...

2015-08-14 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/7943#discussion_r37077151 --- Diff: network/shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/ExecutorShuffleInfo.java --- @@ -34,7 +37,11 @@ /** Shuffle

  1   2   3   4   5   6   7   8   9   >