[GitHub] spark pull request: Update version to 1.6.0-SNAPSHOT.

2015-09-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/8350#issuecomment-140562180 No problem - I should have caught it earlier. Hopefully people didn't spin too many cycles on this. On Tue, Sep 15, 2015 at 12:56 AM, Sean Owen wrote:

[GitHub] spark pull request: [DOCS] Small fixes to Spark on Yarn doc

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8762#issuecomment-140561059 [Test build #1759 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1759/console) for PR 8762 at commit [`00e36b2`](https://github

[GitHub] spark pull request: [SPARK-10077][DOCS][ML] Add package info for j...

2015-09-15 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/8740#issuecomment-140560938 Sure, I'll try and compile the java test code tonight. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-9926] [SPARK-10340] [SQL] Use S3 bulk l...

2015-09-15 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8512#discussion_r39570929 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkS3Util.scala --- @@ -0,0 +1,299 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] spark pull request: SPARK-10611 Clone Configuration for each task ...

2015-09-15 Thread mingyukim
Github user mingyukim commented on a diff in the pull request: https://github.com/apache/spark/pull/8763#discussion_r39570848 --- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala --- @@ -230,12 +251,16 @@ class NewHadoopRDD[K, V]( super.persist(storageLevel

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-09-15 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-140557486 Is there a reason to not do all of this in the optimizer? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: SPARK-10611 Clone Configuration for each task ...

2015-09-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8763#discussion_r39570540 --- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala --- @@ -230,12 +251,16 @@ class NewHadoopRDD[K, V]( super.persist(storageLevel

[GitHub] spark pull request: [SPARK-9926] [SPARK-10340] [SQL] Use S3 bulk l...

2015-09-15 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8512#discussion_r39569881 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkS3Util.scala --- @@ -0,0 +1,299 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] spark pull request: [SPARK-10419] [SQL] Adding SQLServer support f...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8575#issuecomment-140555713 [Test build #42506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42506/consoleFull) for PR 8575 at commit [`643a47d`](https://gith

[GitHub] spark pull request: [SPARK-10419] [SQL] Adding SQLServer support f...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8575#issuecomment-140555215 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10419] [SQL] Adding SQLServer support f...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8575#issuecomment-140555181 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9926] [SPARK-10340] [SQL] Use S3 bulk l...

2015-09-15 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8512#discussion_r39569223 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkS3Util.scala --- @@ -0,0 +1,299 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] spark pull request: [SPARK-10419] [SQL] Adding SQLServer support f...

2015-09-15 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8575#issuecomment-140554616 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...

2015-09-15 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-140554525 Is there a way to add a test for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10180] [SQL] JDBC datasource are not pr...

2015-09-15 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8743#issuecomment-140554359 Will this case be covered by the end-to-end docker tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark pull request: [SPARK-10180] [SQL] JDBC datasource are not pr...

2015-09-15 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8743#issuecomment-140554041 Please update the pull request description to describe the changes in this patch. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] spark pull request: [SPARK-10599] Lower communication for block ma...

2015-09-15 Thread avulanov
Github user avulanov commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-140554085 Thank you for the update. Indeed, the tests take finite time to finish now. Let's add @mengxr to the discussion. Distributed matrix multiplication makes sense w

[GitHub] spark pull request: SPARK-10611 Clone Configuration for each task ...

2015-09-15 Thread mingyukim
Github user mingyukim commented on a diff in the pull request: https://github.com/apache/spark/pull/8763#discussion_r39568729 --- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala --- @@ -230,12 +251,16 @@ class NewHadoopRDD[K, V]( super.persist(storageLevel

[GitHub] spark pull request: [SPARK-10114][SQL] Add optional getters to the...

2015-09-15 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8312#issuecomment-140553856 @rxin @marmbrus, do we want this syntactic sugar? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark pull request: SPARK-10611 Clone Configuration for each task ...

2015-09-15 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8763#discussion_r39568176 --- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala --- @@ -230,12 +251,16 @@ class NewHadoopRDD[K, V]( super.persist(storageLevel

[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

2015-09-15 Thread GayathriMurali
Github user GayathriMurali commented on the pull request: https://github.com/apache/spark/pull/8647#issuecomment-140552289 Removed astype implementation added self.cast(dataType) return. Made similar changes to groupby as well --- If your project is set up for it, you can reply to th

[GitHub] spark pull request: [SPARK-10618] [Mesos] Refactoring coarsed-grai...

2015-09-15 Thread SleepyThread
Github user SleepyThread commented on the pull request: https://github.com/apache/spark/pull/8771#issuecomment-140548388 @andrewor14 Can you please take a look at it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140545384 [Test build #42504 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42504/consoleFull) for PR 8676 at commit [`ee7b842`](https://gith

[GitHub] spark pull request: [SPARK-10511][BUILD] Reset git repository befo...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8774#issuecomment-140545407 [Test build #1758 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1758/console) for PR 8774 at commit [`a954b2a`](https://github

reviews@spark.apache.org

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8544#issuecomment-140541470 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

reviews@spark.apache.org

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8544#issuecomment-140542590 [Test build #42505 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42505/consoleFull) for PR 8544 at commit [`4dcb78a`](https://gith

[GitHub] spark pull request: [SPARK-9926] [SPARK-10340] [SQL] Use S3 bulk l...

2015-09-15 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8512#issuecomment-140541517 ![image](https://cloud.githubusercontent.com/assets/2072857/9890056/8825c09c-5bb2-11e5-9a2a-df2e0e239e06.png) @piaozhexiu Sorry if I miss anything. I am trying to catch

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140541508 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

reviews@spark.apache.org

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8544#issuecomment-140541511 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140541446 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8673] [launcher] API and infrastructure...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7052#issuecomment-140540655 [Test build #42503 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42503/consoleFull) for PR 7052 at commit [`bf92906`](https://gith

[GitHub] spark pull request: [SPARK-8542][MLlib]PMML export for Decision Tr...

2015-09-15 Thread selvinsource
Github user selvinsource commented on the pull request: https://github.com/apache/spark/pull/7842#issuecomment-140540576 Yeah, I am planning to review what @JasmineGeorge did soon, I have been a bit busy lately. --- If your project is set up for it, you can reply to this email and ha

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140539473 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

reviews@spark.apache.org

2015-09-15 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/8544#issuecomment-140538998 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: [SPARK-8673] [launcher] API and infrastructure...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7052#issuecomment-140536820 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8673] [launcher] API and infrastructure...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7052#issuecomment-140536842 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10279][MLlib][PySpark][Docs] Add @since...

2015-09-15 Thread noel-smith
Github user noel-smith commented on the pull request: https://github.com/apache/spark/pull/8689#issuecomment-140536184 These changes are already included in #8685. Can probably drop this PR and merge SPARK-10279 with SPARK-10278. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-8673] [launcher] API and infrastructure...

2015-09-15 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/7052#issuecomment-140536179 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: [SPARK-10300] [build] [tests] Add support for ...

2015-09-15 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/8437#issuecomment-140536012 For the curious, the issue is that the junit test runners (both surefire and the sbt one) need the tag classes around or they'll throw an error, and that happens when bui

reviews@spark.apache.org

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8544#issuecomment-140534458 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

reviews@spark.apache.org

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8544#issuecomment-140534456 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

reviews@spark.apache.org

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8544#issuecomment-140534372 [Test build #42496 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42496/console) for PR 8544 at commit [`4dcb78a`](https://github.

[GitHub] spark pull request: [SPARK-10278][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on the pull request: https://github.com/apache/spark/pull/8685#issuecomment-140533249 Just minor fixes needed - change `addedversion` to `versionadded` + one version number alteration. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-10278][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8685#discussion_r39562007 --- Diff: python/pyspark/mllib/util.py --- @@ -235,6 +248,8 @@ def save(self, sc, path): class Loader(object): """ Mixin for classes

[GitHub] spark pull request: [SPARK-10278][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8685#discussion_r39562037 --- Diff: python/pyspark/mllib/util.py --- @@ -280,15 +297,21 @@ def _load_java(cls, sc, path): return java_obj.load(sc._jsc.sc(), path)

[GitHub] spark pull request: [SPARK-10278][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8685#discussion_r39562027 --- Diff: python/pyspark/mllib/util.py --- @@ -256,6 +271,8 @@ class JavaLoader(Loader): """ Mixin for classes which can load saved models

[GitHub] spark pull request: [SPARK-10278][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8685#discussion_r39561998 --- Diff: python/pyspark/mllib/util.py --- @@ -222,9 +231,13 @@ class JavaSaveable(Saveable): """ Mixin for models that provide save() thr

[GitHub] spark pull request: [SPARK-10278][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8685#discussion_r39561981 --- Diff: python/pyspark/mllib/util.py --- @@ -197,6 +204,8 @@ def loadVectors(sc, path): class Saveable(object): """ Mixin for model

[GitHub] spark pull request: [SPARK-10278][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8685#discussion_r39561958 --- Diff: python/pyspark/mllib/util.py --- @@ -32,6 +32,8 @@ class MLUtils(object): """ Helper methods to load, save and pre-process

[GitHub] spark pull request: [SPARK-10278][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8685#discussion_r39561631 --- Diff: python/pyspark/mllib/tree.py --- @@ -431,6 +461,8 @@ class GradientBoostedTrees(object): Learning algorithm for a gradient boosted

[GitHub] spark pull request: [SPARK-10475][SQL] improve column prunning for...

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8644 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10278][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8685#discussion_r39561561 --- Diff: python/pyspark/mllib/tree.py --- @@ -418,6 +446,8 @@ class GradientBoostedTreesModel(TreeEnsembleModel, JavaLoader): .. note:: Experimen

[GitHub] spark pull request: [SPARK-10278][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8685#discussion_r39561531 --- Diff: python/pyspark/mllib/tree.py --- @@ -252,6 +276,8 @@ class RandomForest(object): Learning algorithm for a random forest model for c

[GitHub] spark pull request: [SPARK-10475][SQL] improve column prunning for...

2015-09-15 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/8644#issuecomment-140530139 Thanks, merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10278][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8685#discussion_r39561422 --- Diff: python/pyspark/mllib/tree.py --- @@ -30,6 +30,11 @@ class TreeEnsembleModel(JavaModelWrapper, JavaSaveable): +"""TreeEnse

[GitHub] spark pull request: [SPARK-10278][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8685#discussion_r39561444 --- Diff: python/pyspark/mllib/tree.py --- @@ -72,7 +80,10 @@ class DecisionTreeModel(JavaModelWrapper, JavaSaveable, JavaLoader): .. note:: Exper

[GitHub] spark pull request: [SPARK-10278][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8685#discussion_r39561473 --- Diff: python/pyspark/mllib/tree.py --- @@ -115,6 +133,8 @@ class DecisionTree(object): Learning algorithm for a decision tree model for c

[GitHub] spark pull request: [SPARK-10278][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8685#discussion_r39561501 --- Diff: python/pyspark/mllib/tree.py --- @@ -239,6 +261,8 @@ class RandomForestModel(TreeEnsembleModel, JavaLoader): .. note:: Experimental

[GitHub] spark pull request: [SPARK-10437][SQL] Support aggregation express...

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8599 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10437][SQL] Support aggregation express...

2015-09-15 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/8599#issuecomment-140528995 Thanks, merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10278][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8685#discussion_r39560663 --- Diff: python/pyspark/mllib/tree.py --- @@ -90,16 +101,23 @@ def predict(self, x): else: return self.call("predict", _conve

[GitHub] spark pull request: SPARK-10611 Clone Configuration for each task ...

2015-09-15 Thread mingyukim
Github user mingyukim commented on a diff in the pull request: https://github.com/apache/spark/pull/8763#discussion_r39560543 --- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala --- @@ -230,12 +251,16 @@ class NewHadoopRDD[K, V]( super.persist(storageLevel

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140526528 [Test build #1760 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1760/console) for PR 8676 at commit [`ee7b842`](https://github

[GitHub] spark pull request: [SPARK-10595] [ML] [MLLIB] [DOCS] Various ML g...

2015-09-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8752#discussion_r39559676 --- Diff: docs/mllib-feature-extraction.md --- @@ -506,7 +523,7 @@ v_N [`ElementwiseProduct`](api/scala/index.html#org.apache.spark.mllib.feat

[GitHub] spark pull request: [SPARK-10595] [ML] [MLLIB] [DOCS] Various ML g...

2015-09-15 Thread feynmanliang
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8752#issuecomment-140526380 LGTM after changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-10595] [ML] [MLLIB] [DOCS] Various ML g...

2015-09-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8752#discussion_r39559560 --- Diff: docs/ml-features.md --- @@ -123,12 +123,21 @@ for features_label in rescaledData.select("features", "label").take(3): ## Word2Vec

[GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7884#issuecomment-140525616 [Test build #42502 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42502/consoleFull) for PR 7884 at commit [`f53436a`](https://gith

[GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7884#issuecomment-140524918 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10277][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on the pull request: https://github.com/apache/spark/pull/8684#issuecomment-140524867 Looks good - just need to replace `addedversion` with `versionadded` in the class docstrings. --- If your project is set up for it, you can reply to this email and h

[GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7884#issuecomment-140524944 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...

2015-09-15 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/7884#discussion_r39558685 --- Diff: project/MimaExcludes.scala --- @@ -73,7 +81,11 @@ object MimaExcludes { "org.apache.spark.ml.regression.LeastSquaresCostFun.this"),

[GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...

2015-09-15 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/7884#discussion_r39558681 --- Diff: project/MimaExcludes.scala --- @@ -73,7 +81,11 @@ object MimaExcludes { "org.apache.spark.ml.regression.LeastSquaresCostFun.this"),

[GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7884#issuecomment-140524068 [Test build #42501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42501/consoleFull) for PR 7884 at commit [`e792b6a`](https://gith

[GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7884#issuecomment-140523818 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7884#issuecomment-140523797 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10595] [ML] [MLLIB] [DOCS] Various ML g...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8752#issuecomment-140522423 [Test build #42500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42500/consoleFull) for PR 8752 at commit [`91f4edd`](https://gith

[GitHub] spark pull request: [SPARK-10277][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8684#discussion_r39558433 --- Diff: python/pyspark/mllib/regression.py --- @@ -640,6 +736,8 @@ class StreamingLinearRegressionWithSGD(StreamingLinearAlgorithm): :param: num

[GitHub] spark pull request: [SPARK-10277][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8684#discussion_r39558391 --- Diff: python/pyspark/mllib/regression.py --- @@ -571,8 +641,29 @@ def load(cls, sc, path): class IsotonicRegression(object): +"

[GitHub] spark pull request: [SPARK-10277][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8684#discussion_r39558375 --- Diff: python/pyspark/mllib/regression.py --- @@ -523,6 +586,8 @@ class IsotonicRegressionModel(Saveable, Loader): ... rmtree(path)

[GitHub] spark pull request: [SPARK-10277][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8684#discussion_r39558409 --- Diff: python/pyspark/mllib/regression.py --- @@ -590,10 +681,13 @@ class StreamingLinearAlgorithm(object): Base class that has to be inherited

[GitHub] spark pull request: [SPARK-10277][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8684#discussion_r39558359 --- Diff: python/pyspark/mllib/regression.py --- @@ -445,8 +497,19 @@ def load(cls, sc, path): class RidgeRegressionWithSGD(object): +

[GitHub] spark pull request: [SPARK-10277][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8684#discussion_r39558311 --- Diff: python/pyspark/mllib/regression.py --- @@ -326,8 +361,19 @@ def load(cls, sc, path): class LassoWithSGD(object): +"""

[GitHub] spark pull request: [SPARK-10277][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8684#discussion_r39558335 --- Diff: python/pyspark/mllib/regression.py --- @@ -428,14 +474,20 @@ class RidgeRegressionModel(LinearRegressionModelBase): True >>> abs

[GitHub] spark pull request: [SPARK-10277][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8684#discussion_r39558268 --- Diff: python/pyspark/mllib/regression.py --- @@ -198,8 +215,20 @@ def _regression_train_wrapper(train_func, modelClass, data, initial_weights):

[GitHub] spark pull request: [SPARK-10277][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8684#discussion_r39558296 --- Diff: python/pyspark/mllib/regression.py --- @@ -309,14 +338,20 @@ class LassoModel(LinearRegressionModelBase): True >>> abs(lrm.predi

[GitHub] spark pull request: [SPARK-10277][MLlib][PySpark] Add @since annot...

2015-09-15 Thread noel-smith
Github user noel-smith commented on a diff in the pull request: https://github.com/apache/spark/pull/8684#discussion_r39558247 --- Diff: python/pyspark/mllib/regression.py --- @@ -162,14 +173,20 @@ class LinearRegressionModel(LinearRegressionModelBase): True >>> a

[GitHub] spark pull request: [SPARK-9652][CORE] Added method for Avro file ...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7971#issuecomment-140521868 [Test build #42499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42499/consoleFull) for PR 7971 at commit [`386b8db`](https://gith

[GitHub] spark pull request: [SPARK-10300] [build] [tests] Add support for ...

2015-09-15 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/8437#issuecomment-140521556 Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark pull request: [SPARK-10595] [ML] [MLLIB] [DOCS] Various ML g...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8752#issuecomment-140520533 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140520458 [Test build #1760 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1760/consoleFull) for PR 8676 at commit [`ee7b842`](https://git

[GitHub] spark pull request: [SPARK-10595] [ML] [MLLIB] [DOCS] Various ML g...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8752#issuecomment-140520578 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140520174 (Oops spoke too soon - I will merge after tests pass) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] spark pull request: [SPARK-10300] [build] [tests] Add support for ...

2015-09-15 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8437#issuecomment-140520203 Shall we revert the PR first? It is blocking other PRs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140520067 Thanks. Merging this in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-10595] [ML] [MLLIB] [DOCS] Various ML g...

2015-09-15 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8752#issuecomment-140519878 @feynmanliang Thanks for reviewing. Just updated per your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] spark pull request: [SPARK-10300] [build] [tests] Add support for ...

2015-09-15 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/8437#issuecomment-140519235 This seems to have caused PR tests to start failing... I'll try things locally again and revert the patch if needed. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7884#issuecomment-140519144 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7884#issuecomment-140519058 [Test build #42497 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42497/console) for PR 7884 at commit [`8d6de99`](https://github.

[GitHub] spark pull request: SPARK-10611 Clone Configuration for each task ...

2015-09-15 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/8763#issuecomment-140519129 Oh, nevermind, sorry, this is off by default. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7884#issuecomment-140519146 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

<    1   2   3   4   5   6   7   8   >