[GitHub] spark pull request: [SPARK-10723] Add reduceOption API to RDD

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8845#issuecomment-141873682 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-10721 Log warning when file deletion fai...

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141854906 [Test build #42741 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42741/console) for PR 8843 at commit

[GitHub] spark pull request: SPARK-10721 Log warning when file deletion fai...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141854944 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-10721 Log warning when file deletion fai...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141854943 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-10721 Log warning when file deletion fai...

2015-09-20 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141857434 I think for most the places, Spark application shutdown hook will finally delete all temp files when application is exited, so temporary not deleted files will

[GitHub] spark pull request: [SPARK-10631][Documentation, MLlib, PySpark]Ad...

2015-09-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8834 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-10329 Cost RDD in k-means|| initializati...

2015-09-20 Thread HuJiayin
Github user HuJiayin commented on the pull request: https://github.com/apache/spark/pull/8546#issuecomment-141855212 On the other hand, newcenters will cause a sudden increasing of memory usage, though call clear immediately, but i think it waits for GC to clear. Newcenter will still

[GitHub] spark pull request: [SPARKR][SPARK-10711] Do not assume spark.subm...

2015-09-20 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/8832#issuecomment-141860945 @falaki , are you using RStudio, where spark-submit is not involved? I don't think we can simply set a default value. Because it is possible that the default

[GitHub] spark pull request: [SPARK-10630][SQL] Add a createDataFrame API t...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8779#issuecomment-141860923 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10630][SQL] Add a createDataFrame API t...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8779#issuecomment-141860916 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10631][Documentation, MLlib, PySpark]Ad...

2015-09-20 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8834#issuecomment-141883020 LGTM. Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-10630][SQL] Add a createDataFrame API t...

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8779#issuecomment-141861793 [Test build #42744 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42744/consoleFull) for PR 8779 at commit

[GitHub] spark pull request: SPARK-10721 Log warning when file deletion fai...

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141869884 [Test build #42743 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42743/console) for PR 8843 at commit

[GitHub] spark pull request: SPARK-10721 Log warning when file deletion fai...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141869917 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-10721 Log warning when file deletion fai...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141869918 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10458] [Spark Core] Added isStopped() m...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8749#issuecomment-141870296 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10458] [Spark Core] Added isStopped() m...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8749#issuecomment-141870307 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10458] [Spark Core] Added isStopped() m...

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8749#issuecomment-141870449 [Test build #42745 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42745/consoleFull) for PR 8749 at commit

[GitHub] spark pull request: [SPARK-10539][SQL]Project should not be pushed...

2015-09-20 Thread yjshen
Github user yjshen commented on the pull request: https://github.com/apache/spark/pull/8742#issuecomment-141873047 Thanks @yhuai, I'll close this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-10539][SQL]Project should not be pushed...

2015-09-20 Thread yjshen
Github user yjshen closed the pull request at: https://github.com/apache/spark/pull/8742 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10630][SQL] Add a createDataFrame API t...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8779#issuecomment-141873094 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10630][SQL] Add a createDataFrame API t...

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8779#issuecomment-141873059 [Test build #42744 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42744/console) for PR 8779 at commit

[GitHub] spark pull request: [SPARK-10630][SQL] Add a createDataFrame API t...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8779#issuecomment-141873095 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10723] Add reduceOption API to RDD

2015-09-20 Thread Attsun1031
GitHub user Attsun1031 opened a pull request: https://github.com/apache/spark/pull/8845 [SPARK-10723] Add reduceOption API to RDD This is PR for https://issues.apache.org/jira/browse/SPARK-10723 Question When I ran tests, mima binary compatibility test failed

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141834046 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141834264 [Test build #42733 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42733/console) for PR 8843 at commit

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141834267 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10718] [BUILD] Check License should not...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8842#issuecomment-141836044 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10718] [BUILD] Check License should not...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8842#issuecomment-141836042 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10317] [Core] Compatibility between his...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8758#issuecomment-141836211 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10317] [Core] Compatibility between his...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8758#issuecomment-141836212 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9570][Docs][YARN]Consistent recommendat...

2015-09-20 Thread nssalian
Github user nssalian commented on the pull request: https://github.com/apache/spark/pull/8385#issuecomment-141837563 That's pretty much all I could find. The rest seem to be code pointing to the option of using yarn-cluster, yarn-client and how Spark parses them. Please let me

[GitHub] spark pull request: [SPARK-10718] [BUILD] Check License should not...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8842#issuecomment-141837666 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10718] [BUILD] Check License should not...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8842#issuecomment-141837665 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141839809 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10718] [BUILD] Check License should not...

2015-09-20 Thread rekhajoshm
Github user rekhajoshm commented on the pull request: https://github.com/apache/spark/pull/8842#issuecomment-141838427 Thanks @srowen for your comments. While it is regex, bit different, the other folders you highlight needs exclusion.For example local-* are test resource

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141840585 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141840578 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141840420 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141840689 [Test build #42731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42731/console) for PR 8843 at commit

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141840713 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141840712 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141840693 [Test build #42737 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42737/consoleFull) for PR 8843 at commit

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141841297 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9852] Let reduce tasks fetch multiple m...

2015-09-20 Thread mateiz
GitHub user mateiz opened a pull request: https://github.com/apache/spark/pull/8844 [SPARK-9852] Let reduce tasks fetch multiple map output partitions This makes two changes: - Allow reduce tasks to fetch multiple map output partitions -- this is a pretty small change to

[GitHub] spark pull request: [SPARK-9852] Let reduce tasks fetch multiple m...

2015-09-20 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/8844#issuecomment-141841616 @shivaram, @JoshRosen, @zsxwing this may be relevant to you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141841610 [Test build #42738 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42738/consoleFull) for PR 8843 at commit

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141834159 [Test build #42733 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42733/consoleFull) for PR 8843 at commit

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141834051 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141834266 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10718] [BUILD] Check License should not...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8842#issuecomment-141835816 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10718] [BUILD] Check License should not...

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8842#issuecomment-141835821 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10718] [BUILD] Check License should not...

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8842#issuecomment-141836094 [Test build #42735 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42735/consoleFull) for PR 8842 at commit

[GitHub] spark pull request: [SPARK-10317] [Core] Compatibility between his...

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8758#issuecomment-141836181 [Test build #42730 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42730/console) for PR 8758 at commit

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141840201 [Test build #42736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42736/consoleFull) for PR 8843 at commit

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141839816 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141840419 [Test build #42736 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42736/console) for PR 8843 at commit

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141840422 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141840888 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141840889 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141840887 [Test build #42737 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42737/console) for PR 8843 at commit

[GitHub] spark pull request: [SPARK-10685] [SPARK-8632] [SQL] [PYSPARK] Pyt...

2015-09-20 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/8833#discussion_r39935553 --- Diff: python/pyspark/sql/functions.py --- @@ -1414,7 +1414,7 @@ def __init__(self, func, returnType, name=None): def _create_judf(self, name):

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141841307 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141841694 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9852] Let reduce tasks fetch multiple m...

2015-09-20 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/8844#discussion_r39935722 --- Diff: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala --- @@ -474,9 +495,9 @@ class DAGSchedulerSuite test("run

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141841693 [Test build #42738 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42738/console) for PR 8843 at commit

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141841695 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-20 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-141816181 Sounds good, there's a logic to it then, gotcha. I figured as much. Leave it, of course. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-10317] [Core] Compatibility between his...

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8758#issuecomment-141821158 [Test build #42730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42730/consoleFull) for PR 8758 at commit

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/8843#discussion_r39933416 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java --- @@ -73,7 +76,9 @@ public void loadNext() throws

[GitHub] spark pull request: [SPARK-10718] [BUILD] Check License should not...

2015-09-20 Thread rekhajoshm
Github user rekhajoshm commented on the pull request: https://github.com/apache/spark/pull/8842#issuecomment-141831005 Ok @srowen .If you both review, validate its not correct/needed, thats fine. @rxin imo more than how the configuration is done or whether call should ever be

[GitHub] spark pull request: [SPARK-10718] [BUILD] Check License should not...

2015-09-20 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8842#issuecomment-141832701 Yeah I'm mixing up a few things here. You're right none of them do have header files. I think the template files should have the same header IMHO unless there's some

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141811855 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/8843#discussion_r39932951 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java --- @@ -73,7 +76,9 @@ public void loadNext() throws

[GitHub] spark pull request: [SPARK-10317] [Core] Compatibility between his...

2015-09-20 Thread rekhajoshm
Github user rekhajoshm commented on the pull request: https://github.com/apache/spark/pull/8758#issuecomment-141820647 The PySpark unit test fail does not seem related to this pull. ``` ImportError: cannot import name UserClass at

[GitHub] spark pull request: [SPARK-10317] [Core] Compatibility between his...

2015-09-20 Thread rekhajoshm
Github user rekhajoshm commented on the pull request: https://github.com/apache/spark/pull/8758#issuecomment-141820656 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141824612 [Test build #42731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42731/consoleFull) for PR 8843 at commit

[GitHub] spark pull request: [SPARK-8542][MLlib]PMML export for Decision Tr...

2015-09-20 Thread selvinsource
Github user selvinsource commented on the pull request: https://github.com/apache/spark/pull/7842#issuecomment-141826772 Exported models (regression and classification trees) look good now: the validator generates the same results as spark. Some minor comments: - I would

[GitHub] spark pull request: [SPARK-10662][DOCS] Code snippets are not prop...

2015-09-20 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8795#issuecomment-141827574 The whitespace at the ends of the lines doesn't matter functionally either way and don't really need 'fixing'. The minor drawback to making such a change is spurious

[GitHub] spark pull request: [SPARK-10706] [MLLIB] Add java wrapper for ran...

2015-09-20 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8841#issuecomment-141811616 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/8843#discussion_r39932392 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java --- @@ -73,7 +76,9 @@ public void loadNext() throws

[GitHub] spark pull request: [SPARK-10718] [BUILD] Check License should not...

2015-09-20 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8842#issuecomment-141817811 @rekhajoshm why do you need this change? This file is mostly run by Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-9987][SQL]Implement the local Aggregate...

2015-09-20 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8769#issuecomment-141821739 Actually can you close this one? I was thinking it'd make more sense to only keep the Tungsten version here ... --- If your project is set up for it, you can reply to

[GitHub] spark pull request: Log error when spill file wasn't deleted

2015-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8843#issuecomment-141826639 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10662][DOCS] Code snippets are not prop...

2015-09-20 Thread jaceklaskowski
Github user jaceklaskowski commented on the pull request: https://github.com/apache/spark/pull/8795#issuecomment-141827044 I disagree with not accepting this change in this version **with** the superfluous spaces at the end of lines removed -- they're simply a garbage (and should not

<    1   2