[GitHub] spark pull request: [SPARK-10966] Codegen framework cleanup

2015-10-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9006#discussion_r41345507 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -112,21 +115,21 @@ class CodeGenContext

[GitHub] spark pull request: [SPARK-10887] [SQL] Build HashedRelation outsi...

2015-10-06 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8953#discussion_r41345489 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/local/HashJoinNode.scala --- @@ -24,19 +24,33 @@ import org.apache.spark.sql.execution.jo

[GitHub] spark pull request: [SPARK-10412][SQL] report memory usage for tun...

2015-10-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8931#issuecomment-146058733 [Test build #43312 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43312/consoleFull) for PR 8931 at commit [`59a23f7`](https://gith

[GitHub] spark pull request: [SPARK-10955][streaming] Disable dynamic alloc...

2015-10-06 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/8998#issuecomment-146058498 Other than that its LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10955][streaming] Disable dynamic alloc...

2015-10-06 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/8998#issuecomment-146058443 @harishreedharan you missed one small point, probably because i edited the comment later. Could you also add "See the programming guide for enabling the Write Ahead Log" .

[GitHub] spark pull request: [SPARK-10966] Codegen framework cleanup

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9006#issuecomment-146058206 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10966] Codegen framework cleanup

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9006#issuecomment-146058223 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10966] Codegen framework cleanup

2015-10-06 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9006#issuecomment-146058203 /cc @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request: [SPARK-10966] Codegen framework cleanup

2015-10-06 Thread marmbrus
GitHub user marmbrus opened a pull request: https://github.com/apache/spark/pull/9006 [SPARK-10966] Codegen framework cleanup This PR is mostly cosmetic and cleans up some warts in codegen (nearly all of which were inherited from the original quasiquote version). - Add lines nu

[GitHub] spark pull request: [SPARK-10412][SQL] report memory usage for tun...

2015-10-06 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/8931#issuecomment-146057863 cc @andrewor14 @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-10412][SQL] report memory usage for tun...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8931#issuecomment-146057707 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10412][SQL] report memory usage for tun...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8931#issuecomment-146057685 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10955][streaming] Disable dynamic alloc...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8998#issuecomment-146053148 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10955][streaming] Disable dynamic alloc...

2015-10-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8998#issuecomment-146053087 [Test build #43308 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43308/console) for PR 8998 at commit [`2733d94`](https://github.

[GitHub] spark pull request: [SPARK-10955][streaming] Disable dynamic alloc...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8998#issuecomment-146053150 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43

[GitHub] spark pull request: [SPARK-9774][ML][PYSPARK] Add python api for m...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8214#issuecomment-146050621 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9774][ML][PYSPARK] Add python api for m...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8214#issuecomment-146050622 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43

[GitHub] spark pull request: [SPARK-9774][ML][PYSPARK] Add python api for m...

2015-10-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8214#issuecomment-146050436 [Test build #43309 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43309/console) for PR 8214 at commit [`9d5a8d5`](https://github.

[GitHub] spark pull request: [SPARK-10752][SPARKR] Implement corr() and cov...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8869#issuecomment-146049574 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10752][SPARKR] Implement corr() and cov...

2015-10-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8869#issuecomment-146049566 [Test build #43311 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43311/console) for PR 8869 at commit [`ac2fd32`](https://github.

[GitHub] spark pull request: [SPARK-10752][SPARKR] Implement corr() and cov...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8869#issuecomment-146049577 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43

[GitHub] spark pull request: [SPARK-10752][SPARKR] Implement corr() and cov...

2015-10-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8869#issuecomment-146049134 [Test build #43311 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43311/consoleFull) for PR 8869 at commit [`ac2fd32`](https://gith

[GitHub] spark pull request: [SPARK-10752][SPARKR] Implement corr() and cov...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8869#issuecomment-146048920 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10752][SPARKR] Implement corr() and cov...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8869#issuecomment-146048909 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10752][SPARKR] Implement corr() and cov...

2015-10-06 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/8869#issuecomment-146048835 rebased to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: [SPARK-10337][SQL] fix hive views on non-hive-...

2015-10-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8990#issuecomment-146048553 [Test build #43310 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43310/consoleFull) for PR 8990 at commit [`c388717`](https://gith

[GitHub] spark pull request: [SPARK-10887] [SQL] Build HashedRelation outsi...

2015-10-06 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8953#discussion_r41342262 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/local/BinaryHashJoinNode.scala --- @@ -0,0 +1,102 @@ +/* +* Licensed to the Apach

[GitHub] spark pull request: [SPARK-8673] [launcher] API and infrastructure...

2015-10-06 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/7052#issuecomment-146048342 Test failures seem to be caused by SPARK-10964. I'll rerun the tests once that one is fixed. --- If your project is set up for it, you can reply to this email and have y

[GitHub] spark pull request: [SPARK-10887] [SQL] Build HashedRelation outsi...

2015-10-06 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8953#discussion_r41342201 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/local/BinaryHashJoinNode.scala --- @@ -0,0 +1,102 @@ +/* +* Licensed to the Apach

[GitHub] spark pull request: [SPARK-9774][ML][PYSPARK] Add python api for m...

2015-10-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8214#issuecomment-146048093 [Test build #43309 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43309/consoleFull) for PR 8214 at commit [`9d5a8d5`](https://gith

[GitHub] spark pull request: [SPARK-8654][SQL] Fix Analysis exception when ...

2015-10-06 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/8983#issuecomment-146047895 @marmbrus Thanks a lot michael for looking into this. I debugged hive to understand the behaviour and would like to share my findings. I wanted to make

[GitHub] spark pull request: [SPARK-10337][SQL] fix hive views on non-hive-...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8990#issuecomment-146047882 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10337][SQL] fix hive views on non-hive-...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8990#issuecomment-146047865 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10887] [SQL] Build HashedRelation outsi...

2015-10-06 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8953#discussion_r41341938 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala --- @@ -26,7 +26,10 @@ abstract cl

[GitHub] spark pull request: [SPARK-10836] [SparkR] Added sort(x, decreasin...

2015-10-06 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/8920#issuecomment-146047500 yes, that sounds good, thanks @NarineK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] spark pull request: [SPARK-9774][ML][PYSPARK] Add python api for m...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8214#issuecomment-146047306 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9774][ML][PYSPARK] Add python api for m...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8214#issuecomment-146047272 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9774][ML][PYSPARK] Add python api for m...

2015-10-06 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/8214#issuecomment-146046936 re-ping @mengxr / @jkbradley (updated against master). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-9718][ML] linear regression training su...

2015-10-06 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/8564#issuecomment-146046549 Sounds good, I'll try and simplify this code when I get some spare cycles. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] spark pull request: [SPARK-10958] Use json4s 3.3.0. DefaultFormats...

2015-10-06 Thread tylerprete
Github user tylerprete commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-146045293 I understand. Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10955][streaming] Disable dynamic alloc...

2015-10-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8998#issuecomment-146045188 [Test build #43308 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43308/consoleFull) for PR 8998 at commit [`2733d94`](https://gith

[GitHub] spark pull request: [SPARK-10955][streaming] Disable dynamic alloc...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8998#issuecomment-146044934 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43

[GitHub] spark pull request: [SPARK-10955][streaming] Disable dynamic alloc...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8998#issuecomment-146044933 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10955][streaming] Disable dynamic alloc...

2015-10-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8998#issuecomment-146044862 [Test build #43306 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43306/console) for PR 8998 at commit [`eaa48cc`](https://github.

[GitHub] spark pull request: [SPARK-10955][streaming] Disable dynamic alloc...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8998#issuecomment-14608 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10955][streaming] Disable dynamic alloc...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8998#issuecomment-146044433 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10888] [SparkR] Added as.DataFrame as a...

2015-10-06 Thread NarineK
Github user NarineK commented on the pull request: https://github.com/apache/spark/pull/8952#issuecomment-146044270 I see, yeah, it seems that it should be alphabetically. I can fix it, thnx --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] spark pull request: [SPARK-10941] [SQL] Refactor AggregateFunction...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8973#issuecomment-146043665 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10941] [SQL] Refactor AggregateFunction...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8973#issuecomment-146043668 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43

[GitHub] spark pull request: [SPARK-10941] [SQL] Refactor AggregateFunction...

2015-10-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8973#issuecomment-146043554 [Test build #43303 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43303/console) for PR 8973 at commit [`a489d65`](https://github.

[GitHub] spark pull request: [SPARK-10836] [SparkR] Added sort(x, decreasin...

2015-10-06 Thread NarineK
Github user NarineK commented on the pull request: https://github.com/apache/spark/pull/8920#issuecomment-146043419 and I can leave only: @param col A character or Column object vector indicating the fields to sort on for col --- If your project is set up for it, you ca

[GitHub] spark pull request: [SPARK-10812] [yarn] Fix shutdown of token ren...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8996#issuecomment-146043128 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10812] [yarn] Fix shutdown of token ren...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8996#issuecomment-146043129 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43

[GitHub] spark pull request: [SPARK-10812] [yarn] Fix shutdown of token ren...

2015-10-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8996#issuecomment-146043059 [Test build #43300 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43300/console) for PR 8996 at commit [`216099c`](https://github.

[GitHub] spark pull request: [SPARK-10836] [SparkR] Added sort(x, decreasin...

2015-10-06 Thread NarineK
Github user NarineK commented on the pull request: https://github.com/apache/spark/pull/8920#issuecomment-146042798 Hi Felix, so do you suggest to change the comment with smth like: #' @param decreasing A logical argument indicating sorting order for columns when a

[GitHub] spark pull request: [SPARK-10964] [yarn] Correctly register the AM...

2015-10-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9005#issuecomment-146040532 [Test build #43307 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43307/consoleFull) for PR 9005 at commit [`515e318`](https://gith

[GitHub] spark pull request: [SPARK-10964] [yarn] Correctly register the AM...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9005#issuecomment-146038742 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10964] [yarn] Correctly register the AM...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9005#issuecomment-146038706 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10964] [yarn] Correctly register the AM...

2015-10-06 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9005#issuecomment-146038244 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark pull request: [SPARK-10622] [core] [yarn] Differentiate dead...

2015-10-06 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/8887#issuecomment-146038074 Ping. I'd like to get this in soon, so if I don't hear back I'll assume no one has any remaining feedback. --- If your project is set up for it, you can reply to this em

[GitHub] spark pull request: [SPARK-10964] [yarn] Correctly register the AM...

2015-10-06 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/9005 [SPARK-10964] [yarn] Correctly register the AM with the driver. The `self` method returns null when called from the constructor; instead, registration should happen in the `onStart` method, at

[GitHub] spark pull request: [SPARK-10964] [yarn] Correctly register the AM...

2015-10-06 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9005#issuecomment-146037641 /cc @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-06 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/8997#discussion_r41338088 --- Diff: R/pkg/R/DataFrame.R --- @@ -1881,3 +1881,34 @@ setMethod("as.data.frame", collect(x) } ) + +#' The s

[GitHub] spark pull request: [SPARK-10337][SQL] fix hive views on non-hive-...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8990#issuecomment-146037100 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43

[GitHub] spark pull request: [SPARK-10836] [SparkR] Added sort(x, decreasin...

2015-10-06 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/8920#issuecomment-146037178 This is in reference to the previous doc line which says: ``` #' @param col A character or Column object vector indicating the fields to sort on ``` s

[GitHub] spark pull request: [SPARK-10337][SQL] fix hive views on non-hive-...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8990#issuecomment-146037099 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10337][SQL] fix hive views on non-hive-...

2015-10-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8990#issuecomment-146037066 [Test build #43301 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43301/console) for PR 8990 at commit [`8e1e4b8`](https://github.

[GitHub] spark pull request: [SPARK-10836] [SparkR] Added sort(x, decreasin...

2015-10-06 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/8920#issuecomment-146036999 Hi Narine - it looks like the `decreasing` param is only supported with `col` is a character vector right? it might help to point that out if an user is trying pass

[GitHub] spark pull request: [SPARK-10885][Streaming]Display the failed out...

2015-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8950 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10955][streaming] Disable dynamic alloc...

2015-10-06 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/8998#discussion_r41337758 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala --- @@ -564,6 +564,12 @@ class StreamingContext private[streaming] (

[GitHub] spark pull request: [SPARK-10955][streaming] Disable dynamic alloc...

2015-10-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8998#issuecomment-146036378 [Test build #43306 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43306/consoleFull) for PR 8998 at commit [`eaa48cc`](https://gith

[GitHub] spark pull request: [SPARK-10955][streaming] Disable dynamic alloc...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8998#issuecomment-146035327 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10955][streaming] Disable dynamic alloc...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8998#issuecomment-146035309 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-06 Thread adrian555
Github user adrian555 commented on a diff in the pull request: https://github.com/apache/spark/pull/8997#discussion_r41336967 --- Diff: R/pkg/R/DataFrame.R --- @@ -1881,3 +1881,34 @@ setMethod("as.data.frame", collect(x) } ) + +#' The spe

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-06 Thread adrian555
Github user adrian555 commented on a diff in the pull request: https://github.com/apache/spark/pull/8997#discussion_r41336776 --- Diff: R/pkg/R/DataFrame.R --- @@ -1881,3 +1881,34 @@ setMethod("as.data.frame", collect(x) } ) + +#' The spe

[GitHub] spark pull request: [SPARK-10952] Only add hive to classpath if HI...

2015-10-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8994#issuecomment-146034836 [Test build #43305 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43305/consoleFull) for PR 8994 at commit [`72b88b2`](https://gith

[GitHub] spark pull request: [SPARK-10836] [SparkR] Added sort(x, decreasin...

2015-10-06 Thread NarineK
Github user NarineK commented on the pull request: https://github.com/apache/spark/pull/8920#issuecomment-146034183 Hi @felixcheung , I try to say it at param description: @param decreasing A logical argument indicating sorting order for columns which are specified

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-06 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/8997#discussion_r41336332 --- Diff: R/pkg/R/DataFrame.R --- @@ -1881,3 +1881,34 @@ setMethod("as.data.frame", collect(x) } ) + +#' The s

[GitHub] spark pull request: [SPARK-10955][streaming] Disable dynamic alloc...

2015-10-06 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/8998#issuecomment-146033999 Checking which types of dstreams are used and what configurations are used and accordingly throwing errors seems to be complicated and brittle. I think its best to throw a

[GitHub] spark pull request: [SPARK-10952] Only add hive to classpath if HI...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8994#issuecomment-146033825 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10952] Only add hive to classpath if HI...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8994#issuecomment-146033842 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10836] [SparkR] Added sort(x, decreasin...

2015-10-06 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/8920#discussion_r41336150 --- Diff: R/pkg/R/DataFrame.R --- @@ -1290,8 +1290,10 @@ setClassUnion("characterOrColumn", c("character", "Column")) #' Sort a DataFrame by the spec

[GitHub] spark pull request: [SPARK-10836] [SparkR] Added sort(x, decreasin...

2015-10-06 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/8920#issuecomment-146033787 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-10905][SparkR]: Export freqItems() for ...

2015-10-06 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/8962#discussion_r41335997 --- Diff: R/pkg/R/DataFrame.R --- @@ -1873,3 +1872,30 @@ setMethod("as.data.frame", collect(x) } ) + +#' freqI

[GitHub] spark pull request: [SPARK-10955][streaming] Disable dynamic alloc...

2015-10-06 Thread harishreedharan
Github user harishreedharan commented on the pull request: https://github.com/apache/spark/pull/8998#issuecomment-146033142 @tdas What do you think about the above? If you still think we should just make it a warn, I will make the change. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-10905][SparkR]: Export freqItems() for ...

2015-10-06 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/8962#discussion_r41335940 --- Diff: R/pkg/R/DataFrame.R --- @@ -1873,3 +1872,30 @@ setMethod("as.data.frame", collect(x) } ) + +#' freqI

[GitHub] spark pull request: [SPARK-10952] Only add hive to classpath if HI...

2015-10-06 Thread kevincox
Github user kevincox commented on a diff in the pull request: https://github.com/apache/spark/pull/8994#discussion_r41335754 --- Diff: build/sbt --- @@ -20,10 +20,12 @@ # When creating new tests for Spark SQL Hive, the HADOOP_CLASSPATH must contain the hive jars so # that

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8997#issuecomment-146031813 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43

[GitHub] spark pull request: [SPARK-10617] [SQL] Fixed AddMonths leap year ...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9004#issuecomment-146031856 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8997#issuecomment-146031812 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8997#issuecomment-146031725 [Test build #43304 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43304/console) for PR 8997 at commit [`5f3f262`](https://github.

[GitHub] spark pull request: [SPARK-10617] [SQL] Fixed AddMonths leap year ...

2015-10-06 Thread alexrovner
GitHub user alexrovner opened a pull request: https://github.com/apache/spark/pull/9004 [SPARK-10617] [SQL] Fixed AddMonths leap year calculations You can merge this pull request into a Git repository by running: $ git pull https://github.com/alexrovner/spark SPARK-10617-fix-

[GitHub] spark pull request: [SPARK-8514] LU factorization on BlockMatrix

2015-10-06 Thread nilmeier
Github user nilmeier commented on the pull request: https://github.com/apache/spark/pull/8563#issuecomment-146030749 Okay @dbtsai, will do. I'll try to get it updated before the weekend for you. Thanks for the review! Cheers, J --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-1267][PYSPARK] Adds pip installer for p...

2015-10-06 Thread alope107
Github user alope107 commented on a diff in the pull request: https://github.com/apache/spark/pull/8318#discussion_r41334727 --- Diff: python/pyspark/pyspark_version.py --- @@ -0,0 +1,17 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contr

[GitHub] spark pull request: [SPARK-1267][PYSPARK] Adds pip installer for p...

2015-10-06 Thread alope107
Github user alope107 commented on a diff in the pull request: https://github.com/apache/spark/pull/8318#discussion_r41334652 --- Diff: python/setup.py --- @@ -0,0 +1,18 @@ +#!/usr/bin/env python + +from setuptools import setup + +exec(compile(open("pyspark/pyspar

[GitHub] spark pull request: [SPARK-10779][PYSPARK][MLLIB] Set initialModel...

2015-10-06 Thread evanyc15
Github user evanyc15 commented on the pull request: https://github.com/apache/spark/pull/8967#issuecomment-146029714 Jenkins test this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8997#issuecomment-146029314 [Test build #43304 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43304/consoleFull) for PR 8997 at commit [`5f3f262`](https://gith

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8997#issuecomment-146027677 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8997#issuecomment-146027649 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10885][Streaming]Display the failed out...

2015-10-06 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/8950#issuecomment-146027302 LGTM. Merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

<    1   2   3   4   5   6   >