[GitHub] spark pull request: [SPARK-11206] Support SQL UI on the history se...

2015-11-17 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9297#issuecomment-157465545 Looks ok to me, mostly nits remaining. It would be nice if someone could confirm that the change in how SQL events are delivered is fine. --- If your project is set up f

[GitHub] spark pull request: [SPARK-11769] [ML] Add save, load to all basic...

2015-11-17 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9755#issuecomment-157465519 OK hopefully good pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: [SPARK-11206] Support SQL UI on the history se...

2015-11-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9297#discussion_r45100247 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala --- @@ -289,6 +311,38 @@ private[sql] class SQLListener(conf: SparkConf)

[GitHub] spark pull request: [SPARK-11206] Support SQL UI on the history se...

2015-11-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9297#discussion_r45100140 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala --- @@ -289,6 +311,38 @@ private[sql] class SQLListener(conf: SparkConf)

[GitHub] spark pull request: [WIP] [SPARK-11327] Mesos Dispatcher does not ...

2015-11-17 Thread jayv
Github user jayv commented on the pull request: https://github.com/apache/spark/pull/9752#issuecomment-157464149 This problem is discussed here: https://issues.apache.org/jira/browse/SPARK-11327 --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] spark pull request: [SPARK-11740][Streaming]Fix the race condition...

2015-11-17 Thread harishreedharan
Github user harishreedharan commented on a diff in the pull request: https://github.com/apache/spark/pull/9707#discussion_r45099938 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala --- @@ -187,16 +187,27 @@ class CheckpointWriter( private var st

[GitHub] spark pull request: [SPARK-11206] Support SQL UI on the history se...

2015-11-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9297#discussion_r45099809 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala --- @@ -126,31 +144,25 @@ private[sql] object SQLMetrics { *

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-17 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-157463352 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-11769] [ML] Add save, load to all basic...

2015-11-17 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9755#issuecomment-157463001 Don't commit yet. I just realized I forgot to overload the load method, so it's not Java compatible. --- If your project is set up for it, you can reply to this emai

[GitHub] spark pull request: [SPARK-11753][SQL] Make allowNonNumericNumbers...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9759#issuecomment-157462797 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11753][SQL] Make allowNonNumericNumbers...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9759#issuecomment-157462796 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11753][SQL] Make allowNonNumericNumbers...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9759#issuecomment-157462487 **[Test build #46093 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46093/consoleFull)** for PR 9759 at commit [`b2a835d`](https://git

[GitHub] spark pull request: [SPARK-11206] Support SQL UI on the history se...

2015-11-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9297#discussion_r45099150 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -54,6 +57,8 @@ private[spark] object JsonProtocol { private implicit

[GitHub] spark pull request: [SPARK-11206] Support SQL UI on the history se...

2015-11-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9297#discussion_r45099070 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -19,7 +19,8 @@ package org.apache.spark.util import java.util.{Properti

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-157462338 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-157462342 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11692][SQL] Support for Parquet logical...

2015-11-17 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9658#issuecomment-157461363 > But it doesn't cover nested fields, e.g. an array field of JSON/BSON elements. That is an unfortunate limitation of our metadata, but it does seem like it could b

[GitHub] spark pull request: [SPARK-11740][Streaming]Fix the race condition...

2015-11-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/9707#discussion_r45098598 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala --- @@ -187,16 +187,27 @@ class CheckpointWriter( private var stopped =

[GitHub] spark pull request: [SPARK-11740][Streaming]Fix the race condition...

2015-11-17 Thread harishreedharan
Github user harishreedharan commented on a diff in the pull request: https://github.com/apache/spark/pull/9707#discussion_r45098059 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala --- @@ -187,16 +187,27 @@ class CheckpointWriter( private var st

[GitHub] spark pull request: [SPARK-11766] [MLLIB] add toJson/fromJson to V...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9751 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11206] Support SQL UI on the history se...

2015-11-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9297#discussion_r45096999 --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala --- @@ -127,6 +130,11 @@ private[spark] object SparkUI { val DEFAULT_RETAINED_STAGES = 10

[GitHub] spark pull request: [SPARK-11206] Support SQL UI on the history se...

2015-11-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9297#discussion_r45096760 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala --- @@ -131,6 +135,17 @@ case class SparkListenerApplicationEnd(time: Long) exten

[GitHub] spark pull request: [SPARK-9065][Streaming][PySpark] Add MessageHa...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9742#issuecomment-157457926 **[Test build #46097 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46097/consoleFull)** for PR 9742 at commit [`f7ad2e3`](https://gith

[GitHub] spark pull request: [SPARK-11206] Support SQL UI on the history se...

2015-11-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9297#discussion_r45096704 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala --- @@ -131,6 +135,17 @@ case class SparkListenerApplicationEnd(time: Long) exten

[GitHub] spark pull request: [SPARK-11766] [MLLIB] add toJson/fromJson to V...

2015-11-17 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9751#issuecomment-157457850 Merging with master and branch-1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11206] Support SQL UI on the history se...

2015-11-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9297#discussion_r45096381 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala --- @@ -19,18 +19,22 @@ package org.apache.spark.scheduler import java.

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-17 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-157457125 Let me take a look at `test_kafka_direct_stream_foreach_get_offsetRanges` --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-17 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-157457151 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-157456927 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-157456926 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9065][Streaming][PySpark] Add MessageHa...

2015-11-17 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9742#issuecomment-157455910 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-10155][SQL]Change SqlParser to object t...

2015-11-17 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/8357#issuecomment-157455774 > Will this patch slowdown query parsing in case of concurrent requests? I think so. Do you concern about the performance of parsing query? I assume executing qu

[GitHub] spark pull request: [SPARK-11740][Streaming]Fix the race condition...

2015-11-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/9707#discussion_r45095289 --- Diff: python/pyspark/streaming/tests.py --- @@ -699,11 +698,11 @@ def check_output(n): # Verify that getOrCreate() uses existing SparkContext

[GitHub] spark pull request: [SPARK-11695][CORE] Set s3a credentials

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9663 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11744][Launcher] Fix print version thro...

2015-11-17 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/9721#issuecomment-157455058 Thanks @jerryshao and @vanzin for resolving this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] spark pull request: [SPARK-11744][Launcher] Fix print version thro...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9721 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11695][CORE] Set s3a credentials

2015-11-17 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9663#issuecomment-157454611 Merging to master / 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-11275][SQL] Reimplement Expand as a Gen...

2015-11-17 Thread aray
Github user aray closed the pull request at: https://github.com/apache/spark/pull/9429 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] spark pull request: [SPARK-11275][SQL] Reimplement Expand as a Gen...

2015-11-17 Thread aray
Github user aray commented on the pull request: https://github.com/apache/spark/pull/9429#issuecomment-157453036 I'm going to close this PR in favor of just fixing the current implementation for now since it has recently become more optimized with support for unsafe rows. Thanks every

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-17 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9367#issuecomment-157453097 @choochootrain Please open a pr for master branch (this is our typical workflow). So, we can fix it in master and branch-1.6. I'd prefer fixing master and branch 1.6 first

[GitHub] spark pull request: [SPARK-11744][Launcher] Fix print version thro...

2015-11-17 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9721#issuecomment-157452874 Merging to master/1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-17 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9367#discussion_r45093937 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskResultGetterSuite.scala --- @@ -119,5 +123,64 @@ class TaskResultGetterSuite extends SparkFunSuite

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-17 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-157451685 pyspark tests, always flaky... retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-17 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9367#issuecomment-157451535 @choochootrain We should also open a PR for master, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-11781][SPARKR] SparkR has problem in in...

2015-11-17 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9769#issuecomment-157447807 Could you describe the problem a bit more ? Was it that raw vectors were being treated as lists ? Just curious how raw vectors differ from int vectors etc. --- If you

[GitHub] spark pull request: [SPARK-11773][SPARKR] Implement collection fun...

2015-11-17 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9764#issuecomment-157447254 LGTM. Thanks @sun-rui I checked some docs and it doesn't look like either of these verbs conflict with R's base package. Could you also double check ? --- If

[GitHub] spark pull request: [SPARK-11081] Shade Jersey and javax.rs.ws

2015-11-17 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9615#issuecomment-157445574 I did not remove the old jersey *classes*, just the `META-INF/services` entries. The classes are still there, and it seems the code is smart enough to figure out the impl

[GitHub] spark pull request: [SPARK-11756][SPARKR] Fix use of aliases - Spa...

2015-11-17 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9750#issuecomment-157445230 cc @sun-rui --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-17 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-157445082 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11725][SQL] correctly handle null input...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9770#issuecomment-157442853 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11725][SQL] correctly handle null input...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9770#issuecomment-157442850 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11725][SQL] correctly handle null input...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9770#issuecomment-157442620 **[Test build #46088 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46088/consoleFull)** for PR 9770 at commit [`e258b6c`](https://git

[GitHub] spark pull request: [SPARK-8658] [SQL] [FOLLOW-UP] AttributeRefere...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9761#issuecomment-157440630 **[Test build #46095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46095/consoleFull)** for PR 9761 at commit [`b2e354a`](https://gith

[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling

2015-11-17 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-157440817 @cloud-fan I am wondering if this will be merged soon? I am not sure if I should fix a couple of self join issues before your merge. Or I should not waste ti

[GitHub] spark pull request: [SPARK-8658] [SQL] [FOLLOW-UP] AttributeRefere...

2015-11-17 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9761#issuecomment-157434770 Ok. I will also add three more lines for covering the new `hashCode` and `equals` functions. --- If your project is set up for it, you can reply to this email and h

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-157431769 **[Test build #46094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46094/consoleFull)** for PR 9165 at commit [`7c84c24`](https://gith

[GitHub] spark pull request: [SPARK-11753][SQL] Make allowNonNumericNumbers...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9759#issuecomment-157428770 **[Test build #46093 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46093/consoleFull)** for PR 9759 at commit [`b2a835d`](https://gith

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-157428635 **[Test build #46092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46092/consoleFull)** for PR 7753 at commit [`0c1241c`](https://gith

[GitHub] spark pull request: rmse was wrongly calculated

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9771#issuecomment-157428328 **[Test build #2081 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2081/consoleFull)** for PR 9771 at commit [`4cee53c`](https://gi

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread jbonofre
Github user jbonofre commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-157427101 Cleanup and rebase --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread jbonofre
Github user jbonofre commented on a diff in the pull request: https://github.com/apache/spark/pull/9165#discussion_r45083392 --- Diff: core/src/main/resources/org/apache/spark/ui/static/sorttable.js --- @@ -169,7 +169,7 @@ sorttable = { for (var i=0; i

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9165#discussion_r45082916 --- Diff: core/src/main/resources/org/apache/spark/ui/static/sorttable.js --- @@ -169,7 +169,7 @@ sorttable = { for (var i=0; i

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9367#issuecomment-157422891 [Test build #2080 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2080/console) for PR 9367 at commit [`fadf2ca`](https://github

[GitHub] spark pull request: rmse was wrongly calculated

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9771#issuecomment-157421857 **[Test build #2081 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2081/consoleFull)** for PR 9771 at commit [`4cee53c`](https://git

[GitHub] spark pull request: [SPARK-8658] [SQL] [FOLLOW-UP] AttributeRefere...

2015-11-17 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/9761#issuecomment-157421827 This change looks good to me. The failing test is not valid anymore and should be changed to verify that the hash codes are not equal. --- If your project is set up for

[GitHub] spark pull request: rmse was wrongly calculated

2015-11-17 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9771#issuecomment-157421443 LGTM. This is on the border of needing a JIRA IMHO. https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-11191] [SQL] [FOLLOW-UP] Cleans up unne...

2015-11-17 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9737#issuecomment-157421259 Also backported to branch-1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9367#issuecomment-157421084 [Test build #2079 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2079/console) for PR 9367 at commit [`fadf2ca`](https://github

[GitHub] spark pull request: [SPARK-11057] [SQL] Add correlation and covari...

2015-11-17 Thread NarineK
Github user NarineK commented on the pull request: https://github.com/apache/spark/pull/9366#issuecomment-157420688 can someone from Spark SQL committers or experts also look at this ? --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...

2015-11-17 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9733#issuecomment-157419417 You don't need a new PR, just push a new commit here. It's better, as it preserves the history of the discussion. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-11057] [SQL] Add correlation and covari...

2015-11-17 Thread NarineK
Github user NarineK commented on the pull request: https://github.com/apache/spark/pull/9366#issuecomment-157419321 yes, there is even a test case which covers that case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-157418522 **[Test build #46091 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46091/consoleFull)** for PR 7753 at commit [`75e63c3`](https://git

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-157418537 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-157418529 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-157417841 **[Test build #46091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46091/consoleFull)** for PR 7753 at commit [`75e63c3`](https://gith

[GitHub] spark pull request: [SPARK-11281][SPARKR] Add tests covering the i...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9743#issuecomment-157415577 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11281][SPARKR] Add tests covering the i...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9743#issuecomment-157415572 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11281][SPARKR] Add tests covering the i...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9743#issuecomment-157415429 **[Test build #46089 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46089/consoleFull)** for PR 9743 at commit [`0508988`](https://git

[GitHub] spark pull request: [SPARK-8658] [SQL] [FOLLOW-UP] AttributeRefere...

2015-11-17 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9761#issuecomment-157414057 @nongli I saw you have a related discussion with @chenghao-intel . The failed test case was introduced in your PR https://github.com/apache/spark/pull/9480. I am not

[GitHub] spark pull request: [SPARK-11725][SQL] correctly handle null input...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9770#issuecomment-157410913 **[Test build #46090 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46090/consoleFull)** for PR 9770 at commit [`a8a3067`](https://gith

[GitHub] spark pull request: [SPARK-11281][SPARKR] Add tests covering the i...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9743#issuecomment-157409861 **[Test build #46089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46089/consoleFull)** for PR 9743 at commit [`0508988`](https://gith

[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...

2015-11-17 Thread somideshmukh
Github user somideshmukh commented on the pull request: https://github.com/apache/spark/pull/9733#issuecomment-157408424 OK,I will remove non-DDL statements and create new pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] spark pull request: [SPARK-11281][SPARKR] Add tests covering the i...

2015-11-17 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/9743#discussion_r45074174 --- Diff: R/pkg/inst/tests/test_sparkSQL.R --- @@ -294,9 +294,21 @@ test_that("create DataFrame with complex types", { test_that("create DataFrame from a

[GitHub] spark pull request: rmse was wrongly calculated

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9771#issuecomment-157403077 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: rmse was wrongly calculated

2015-11-17 Thread vivkul
GitHub user vivkul opened a pull request: https://github.com/apache/spark/pull/9771 rmse was wrongly calculated It was multiplying with U instaed of dividing by U You can merge this pull request into a Git repository by running: $ git pull https://github.com/vivkul/spark patch-

[GitHub] spark pull request: [SPARK-11725][SQL] correctly handle null input...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9770#issuecomment-157401188 **[Test build #46088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46088/consoleFull)** for PR 9770 at commit [`e258b6c`](https://gith

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-157398361 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157400218 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157400223 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11725][SQL] correctly handle null input...

2015-11-17 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9770#issuecomment-157398240 cc @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-157397991 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11725][SQL] correctly handle null input...

2015-11-17 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/9770 [SPARK-11725][SQL] correctly handle null inputs for UDF If user use primitive parameters in UDF, there is no way for him to do the null-check for primitive inputs, so we are assuming the primitive

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-157397746 **[Test build #46087 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46087/consoleFull)** for PR 9732 at commit [`3012bfd`](https://git

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157399730 **[Test build #46083 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46083/consoleFull)** for PR 9726 at commit [`37fa83f`](https://git

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-157399487 **[Test build #2078 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2078/consoleFull)** for PR 9165 at commit [`5526031`](https://gi

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-157398049 **[Test build #46085 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46085/consoleFull)** for PR 9165 at commit [`5526031`](https://git

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-157398356 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-157397984 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7012][SQL] Add support for NOT NULL mod...

2015-11-17 Thread sabhyankar
Github user sabhyankar commented on a diff in the pull request: https://github.com/apache/spark/pull/8746#discussion_r45070100 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/DDLTestSuite.scala --- @@ -113,4 +113,23 @@ class DDLTestSuite extends DataSourceTest with

[GitHub] spark pull request: [SPARK-11447][SQL] change NullType to StringTy...

2015-11-17 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/9720#discussion_r45069001 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -280,6 +280,12 @@ object HiveTypeCoercion {

<    3   4   5   6   7   8   9   10   >