[GitHub] spark pull request: [SPARK-12158] [R] [SQL] Fix 'sample' functions...

2015-12-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10160#issuecomment-162286394 @felixcheung @sun-rui Thank you! Based on your comments, I did the changes. Please review the changes. : ) --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-12153][MLlib]add support of arbitrary l...

2015-12-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10152#discussion_r46768448 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -281,16 +280,17 @@ class Word2Vec extends Serializable with Logging {

[GitHub] spark pull request: [SPARK-12048][SQL] Prevent to close JDBC resou...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10101#issuecomment-162313589 **[Test build #2174 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2174/consoleFull)** for PR 10101 at commit

[GitHub] spark pull request: [SPARK-12048][SQL] Prevent to close JDBC resou...

2015-12-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10101#issuecomment-162327169 Merged to master/1.6/1.5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12048][SQL] Prevent to close JDBC resou...

2015-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10101 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11955][SQL] Mark optional fields in mer...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9940#issuecomment-162329133 **[Test build #47241 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47241/consoleFull)** for PR 9940 at commit

[GitHub] spark pull request: [SPARK-12159] [ML] Add user guide section for ...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10166#issuecomment-162334282 **[Test build #47245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47245/consoleFull)** for PR 10166 at commit

[GitHub] spark pull request: [SPARK-12103][Streaming][Kafka][Doc] document ...

2015-12-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10132#issuecomment-162319460 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-162324292 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12117][SQL] Fix ignored column aliases ...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10140#issuecomment-162335400 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12117][SQL] Fix ignored column aliases ...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10140#issuecomment-162335396 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-162326618 **[Test build #47238 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47238/consoleFull)** for PR 10058 at commit

[GitHub] spark pull request: [SPARK-11530] [MLLIB] Return eigenvalues with ...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9736#issuecomment-162322073 **[Test build #2175 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2175/consoleFull)** for PR 9736 at commit

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-162324290 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-162324277 **[Test build #47237 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47237/consoleFull)** for PR 10058 at commit

[GitHub] spark pull request: [SPARK-12074] Avoid memory copy involving Byte...

2015-12-06 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/10069#issuecomment-162328379 Will create new one when SPARK-12060 is put back. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12117][SQL] Fix ignored column aliases ...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10140#issuecomment-162328393 **[Test build #47240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47240/consoleFull)** for PR 10140 at commit

[GitHub] spark pull request: [SPARK-12074] Avoid memory copy involving Byte...

2015-12-06 Thread tedyu
Github user tedyu closed the pull request at: https://github.com/apache/spark/pull/10069 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12056][CORE] Part 2 Create a TaskAttemp...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10164#issuecomment-162329841 **[Test build #47242 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47242/consoleFull)** for PR 10164 at commit

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-162334416 **[Test build #47244 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47244/consoleFull)** for PR 10165 at commit

[GitHub] spark pull request: [SPARK-12159] [ML] Add user guide section for ...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10166#issuecomment-162335063 **[Test build #47245 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47245/consoleFull)** for PR 10166 at commit

[GitHub] spark pull request: [SPARK-12159] [ML] Add user guide section for ...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10166#issuecomment-162335095 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12159] [ML] Add user guide section for ...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10166#issuecomment-162335094 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12117][SQL] Fix ignored column aliases ...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10140#issuecomment-162327639 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12117][SQL] Fix ignored column aliases ...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10140#issuecomment-162327637 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12056][CORE] Part 2 Create a TaskAttemp...

2015-12-06 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/10164#issuecomment-162329570 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12056][CORE] Part 2 Create a TaskAttemp...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10164#issuecomment-162330015 **[Test build #47243 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47243/consoleFull)** for PR 10164 at commit

[GitHub] spark pull request: [SPARK-12159] [ML] Add user guide section for ...

2015-12-06 Thread BenFradet
GitHub user BenFradet opened a pull request: https://github.com/apache/spark/pull/10166 [SPARK-12159] [ML] Add user guide section for IndexToString transformer Comments welcome. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-11955][SQL] Mark optional fields in mer...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9940#issuecomment-162336101 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11955][SQL] Mark optional fields in mer...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9940#issuecomment-162336100 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12074] Avoid memory copy involving Byte...

2015-12-06 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/10069#issuecomment-162324872 With change in BlockManager.scala, BlockManagerReplicationSuite passes - Thanks to Shixiong's fix in SPARK-12084 ``` BlockManagerReplicationSuite: - get peers

[GitHub] spark pull request: [SPARK-9026] [SPARK-4514] Modifications to Job...

2015-12-06 Thread reggert
Github user reggert commented on the pull request: https://github.com/apache/spark/pull/9264#issuecomment-162326651 All I want for Christmas is a code review. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12158] [R] [SQL] Fix 'sample' functions...

2015-12-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10160#issuecomment-162328075 @felixcheung I am not sure if we need to add a test case for `sample`. Normally, using a specific seed is the common way to verify the result of `sample`. The

[GitHub] spark pull request: [SPARK-11955][SQL] Mark optional fields in mer...

2015-12-06 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/9940#issuecomment-162329711 ping @liancheng I tried to update this for your suggestions. Now the metadata will be removed before saving Parquet file. Besides, I also add more test cases.

[GitHub] spark pull request: [SPARK-11955][SQL] Mark optional fields in mer...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9940#issuecomment-162335953 **[Test build #47241 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47241/consoleFull)** for PR 9940 at commit

[GitHub] spark pull request: [SPARK-12048][SQL] Prevent to close JDBC resou...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10101#issuecomment-162320823 **[Test build #2174 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2174/consoleFull)** for PR 10101 at commit

[GitHub] spark pull request: [SPARK-12102][SQL] Cast a non-nullable struct ...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10156#issuecomment-162321855 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12102][SQL] Cast a non-nullable struct ...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10156#issuecomment-162321854 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12102][SQL] Cast a non-nullable struct ...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10156#issuecomment-162321822 **[Test build #47235 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47235/consoleFull)** for PR 10156 at commit

[GitHub] spark pull request: [SPARK-12117][SQL] Fix ignored column aliases ...

2015-12-06 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10140#issuecomment-162327757 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12056][CORE] Part 2 Create a TaskAttemp...

2015-12-06 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/spark/pull/10164 [SPARK-12056][CORE] Part 2 Create a TaskAttemptContext only after calling setConf This is continuation of SPARK-12056 where change is applied to SqlNewHadoopRDD.scala @andrewor14 FYI

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-06 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/10165 [SPARK-12164] [SQL] Display the binary/encoded values When the dataset is encoded, the existing display looks strange. Decimal format is not common when the type is binary. ```

[GitHub] spark pull request: [SPARK-12117][SQL] Fix ignored column aliases ...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10140#issuecomment-162335191 **[Test build #47240 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47240/consoleFull)** for PR 10140 at commit

[GitHub] spark pull request: [SPARK-12056][CORE] Part 2 Create a TaskAttemp...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10164#issuecomment-16233 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12153][MLlib]add support of arbitrary l...

2015-12-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10152#discussion_r46768436 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -469,7 +469,32 @@ class Word2VecModel private[spark] (

[GitHub] spark pull request: [SPARK-11530] [MLLIB] Return eigenvalues with ...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9736#issuecomment-162313493 **[Test build #2175 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2175/consoleFull)** for PR 9736 at commit

[GitHub] spark pull request: [SPARK-12153][MLlib]add support of arbitrary l...

2015-12-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10152#discussion_r46768439 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -555,6 +614,14 @@ class Word2VecModel private[spark] ( (word,

[GitHub] spark pull request: [SPARK-12158] [R] [SQL] Fix 'sample' functions...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10160#issuecomment-162317352 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12158] [R] [SQL] Fix 'sample' functions...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10160#issuecomment-162317319 **[Test build #47236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47236/consoleFull)** for PR 10160 at commit

[GitHub] spark pull request: [SPARK-12158] [R] [SQL] Fix 'sample' functions...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10160#issuecomment-162317351 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12158] [R] [SQL] Fix 'sample' functions...

2015-12-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10160#issuecomment-162286420 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12158] [R] [SQL] Fix 'sample' functions...

2015-12-06 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/10160#issuecomment-162289399 looks good! could you think of the best way to add a test for not setting seed? hmm.. perhaps the loop I use in #9549? --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-162314208 **[Test build #47237 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47237/consoleFull)** for PR 10058 at commit

[GitHub] spark pull request: [SPARK-12102][SQL] Cast a non-nullable struct ...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10156#issuecomment-162313874 **[Test build #47235 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47235/consoleFull)** for PR 10156 at commit

[GitHub] spark pull request: [SPARK-12158] [R] [SQL] Fix 'sample' functions...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10160#issuecomment-162313901 **[Test build #47236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47236/consoleFull)** for PR 10160 at commit

[GitHub] spark pull request: Update StructType.scala

2015-12-06 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10141#discussion_r46781460 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala --- @@ -40,7 +40,8 @@ import

[GitHub] spark pull request: [SPARK-12056][CORE] Part 2 Create a TaskAttemp...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10164#issuecomment-162336847 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12160][MLLIB] Use SQLContext.getOrCreat...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10161#issuecomment-162344223 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-162344227 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-06 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-162396682 Shoud we print the decoded values(user objects) in `Dataset.show`? cc @marmbrus @rxin --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-12044] [SparkR] Fix usage of isnan, isN...

2015-12-06 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/10037#issuecomment-162385822 Thanks for your help @sun-rui @felixcheung @shivaram . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12152][PROJECT-INFRA] Speed up Scalasty...

2015-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11102] [SQL] Uninformative exception wh...

2015-12-06 Thread zjffdu
Github user zjffdu commented on the pull request: https://github.com/apache/spark/pull/9490#issuecomment-162402210 @yhuai @liancheng any more comments ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12060][CORE] Avoid memory copy in JavaS...

2015-12-06 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/10167 [SPARK-12060][CORE] Avoid memory copy in JavaSerializerInstance.serialize Merged #10051 again since #10083 is resolved. This reverts commit 328b757d5d4486ea3c2e246780792d7a57ee85e5. You

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-162397994 **[Test build #47249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47249/consoleFull)** for PR 10058 at commit

[GitHub] spark pull request: [SPARK-11593][SQL] Replace catalyst converter ...

2015-12-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/9565#discussion_r46784210 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala --- @@ -66,980 +85,305 @@ case class ScalaUDF( */

[GitHub] spark pull request: Fix kstreaming war

2015-12-06 Thread microwishing
GitHub user microwishing opened a pull request: https://github.com/apache/spark/pull/10168 Fix kstreaming war You can merge this pull request into a Git repository by running: $ git pull https://github.com/microwishing/spark FIX_KSTREAMING_WAR Alternatively you can review

[GitHub] spark pull request: Fix kstreaming war

2015-12-06 Thread microwishing
Github user microwishing commented on the pull request: https://github.com/apache/spark/pull/10168#issuecomment-162402045 wrong PR. sorry --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: Fix kstreaming war

2015-12-06 Thread microwishing
Github user microwishing closed the pull request at: https://github.com/apache/spark/pull/10168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-11102] [SQL] Uninformative exception wh...

2015-12-06 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9490#issuecomment-162402641 @zjffdu How about we revisit it after we release 1.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-12152][PROJECT-INFRA] Speed up Scalasty...

2015-12-06 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10151#issuecomment-162386145 We can handle retention of the output in a followup, since it'd probably be best to also do it for Java, Python, and R style checks. Therefore, I'm going to merge

[GitHub] spark pull request: [SPARK-12159] [ML] Add user guide section for ...

2015-12-06 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/10166#issuecomment-162386176 It might be useful to also document the different ways "missing" labels can be handled - what are your thoughts? --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2015-12-06 Thread lianhuiwang
Github user lianhuiwang commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-162396051 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12161][SQL] Ignore order of predicates ...

2015-12-06 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10163#issuecomment-162397946 This is a great feature! Can we implement it in individual expressions instead of centralizing them in `LogicalPlan.samResult`? A lof of commutative operators need

[GitHub] spark pull request: [SPARK-12060][CORE] Avoid memory copy in JavaS...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10167#issuecomment-162397948 **[Test build #47248 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47248/consoleFull)** for PR 10167 at commit

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-162400140 I have the exact same question when calling the show function. From the perspectives of users, they might not care the encoded values at all when calling the

[GitHub] spark pull request: [SPARK-12056][CORE] Part 2 Create a TaskAttemp...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10164#issuecomment-162336631 **[Test build #47243 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47243/consoleFull)** for PR 10164 at commit

[GitHub] spark pull request: [SPARK-12056][CORE] Part 2 Create a TaskAttemp...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10164#issuecomment-162336667 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12160][MLLIB] Use SQLContext.getOrCreat...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10161#issuecomment-162339217 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12160][MLLIB] Use SQLContext.getOrCreat...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10161#issuecomment-162339214 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12160][MLLIB] Use SQLContext.getOrCreat...

2015-12-06 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10161#issuecomment-162339359 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12138] [SQL] Escape \u in the generated...

2015-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10155 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12138] [SQL] Escape \u in the generated...

2015-12-06 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10155#issuecomment-162337908 Will also merge it to branch 1.5. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12138] [SQL] Escape \u in the generated...

2015-12-06 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10155#issuecomment-162337974 I have also merged it to branch 1.5. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12102][SQL] Cast a non-nullable struct ...

2015-12-06 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/10156#issuecomment-162349876 @yhuai Hi Yin, Thanks for your comments. In this fix, we are only changing the nullability of the value for comparision purpose to see if the left and right types

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2015-12-06 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/10154#discussion_r46776484 --- Diff: core/src/test/resources/HistoryServerExpectations/executor_list_json_expectation.json --- @@ -4,11 +4,13 @@ "rddBlocks" : 8,

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-162337267 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-162337247 **[Test build #47238 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47238/consoleFull)** for PR 10058 at commit

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-162337266 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12160][MLLIB] Use SQLContext.getOrCreat...

2015-12-06 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10161#issuecomment-162337271 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12160][MLLIB] Use SQLContext.getOrCreat...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10161#issuecomment-162339966 **[Test build #47247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47247/consoleFull)** for PR 10161 at commit

[GitHub] spark pull request: [SPARK-7857][MLLIB] Prevent IDFModel from retu...

2015-12-06 Thread karlhigley
Github user karlhigley closed the pull request at: https://github.com/apache/spark/pull/9843 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12056][CORE] Part 2 Create a TaskAttemp...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10164#issuecomment-162336846 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12056][CORE] Part 2 Create a TaskAttemp...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10164#issuecomment-162336815 **[Test build #47242 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47242/consoleFull)** for PR 10164 at commit

[GitHub] spark pull request: [SPARK-12138] [SQL] Escape \u in the generated...

2015-12-06 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10155#issuecomment-162337764 Thanks. LGTM. Merging to master and branch 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12102][SQL] Cast a non-nullable struct ...

2015-12-06 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/10156#discussion_r46774393 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -91,7 +91,7 @@ trait CaseWhenLike extends

[GitHub] spark pull request: [SPARK-12160][MLLIB] Use SQLContext.getOrCreat...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10161#issuecomment-162344068 **[Test build #47247 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47247/consoleFull)** for PR 10161 at commit

[GitHub] spark pull request: [SPARK-12160][MLLIB] Use SQLContext.getOrCreat...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10161#issuecomment-162344222 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-162343924 **[Test build #47244 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47244/consoleFull)** for PR 10165 at commit

[GitHub] spark pull request: [SPARK-11593][SQL] Replace catalyst converter ...

2015-12-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/9565#discussion_r46785072 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala --- @@ -66,980 +85,305 @@ case class ScalaUDF( */

  1   2   >