Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166400018
**[Test build #48122 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48122/consoleFull)**
for PR 10384 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166400134
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10407#issuecomment-166406625
Good catch, this change looks fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10407#issuecomment-166408094
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10407#issuecomment-166408093
**[Test build #48125 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48125/consoleFull)**
for PR 10407 at commit
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/10388#issuecomment-166407905
@marmbrus : Can you help take a look at this PR? Thanks for your review.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10407#issuecomment-166408095
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10402#discussion_r48186892
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -421,6 +460,19 @@ case class CumeDist()
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10418#issuecomment-166408025
**[Test build #48124 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48124/consoleFull)**
for PR 10418 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10057#issuecomment-166413509
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10311#issuecomment-166413616
Thanks, merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10373
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ajbozarth commented on the pull request:
https://github.com/apache/spark/pull/10154#issuecomment-166418393
And here's screenshots of completed only being colored when comparing to
active or failed, examples with both color choices.
:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10057#discussion_r48192495
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterPersistenceEngine.scala
---
@@ -53,9 +53,12 @@ private[spark] trait
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10416#issuecomment-166429971
This isn't vs master, and is a duplicate. Please close this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10411#issuecomment-166430031
**[Test build #48130 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48130/consoleFull)**
for PR 10411 at commit
GitHub user Schadix opened a pull request:
https://github.com/apache/spark/pull/10416
[SPARK-12453] [Streaming] Spark Streaming Kinesis Example broken due â¦
â¦to wrong AWS Java SDK version
Fix successfully tested by me.
Maybe the tests have to be improved as they passed
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166388345
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10385#issuecomment-166393943
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10385#issuecomment-166393679
**[Test build #48120 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48120/consoleFull)**
for PR 10385 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166400137
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48183908
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -59,7 +59,7 @@ abstract class RuleExecutor[TreeType <:
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/10156#issuecomment-166403008
@cloud-fan thanks.. rebasing to newer code helps :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48183993
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -69,6 +71,13 @@ object DefaultOptimizer extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10407#issuecomment-166407814
**[Test build #48125 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48125/consoleFull)**
for PR 10407 at commit
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10418#issuecomment-166407785
I am wondering if we only need to show the SQL usage? For DF version, we
have API doc (maybe that is good enough for now).
---
If your project is set up for it, you can
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10418#issuecomment-166411445
I see. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10393#issuecomment-166415241
I think its fine to have this stuff in physical plans. I actually added
the `!` when I was debugging problems with the query planner (i.e. it was
producing spark
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/9593#issuecomment-166381528
LGTM. Ping @tdas to take a final look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10057#discussion_r48175719
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcher.scala
---
@@ -50,7 +50,11 @@ private[mesos] class
Github user ajbozarth commented on the pull request:
https://github.com/apache/spark/pull/10154#issuecomment-166408671
![screen shot
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-166408658
@hvanhovell Regarding the doc, we can acknowledge them (Hive and Presto) in
the scala doc.
---
If your project is set up for it, you can reply to this email and have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10057#issuecomment-166413505
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ajbozarth commented on the pull request:
https://github.com/apache/spark/pull/10154#issuecomment-166419895
I didn't do screen shots of no color for completed, overall I am personally
a fan of switch the green to completed and making coloring completed
conditional on an
GitHub user ZacharySBrown opened a pull request:
https://github.com/apache/spark/pull/10419
[SPARK-12468] [Pyspark]
This addresses an issue where `extractParamMap()` method for a model that
has been fit returns an empty dictionary, e.g. (from the [Pyspark ML API
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10414#issuecomment-166431476
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/10284#issuecomment-166386063
See
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48119/consoleFull
---
If your project is set up for it, you can reply to this email and have your
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48178585
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -105,6 +112,14 @@ class RegressionMetrics @Since("1.2.0") (
Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/10292#issuecomment-166396719
@ScrapCodes - yes, we are building Spark on top of this change and it is
working correctly.
---
If your project is set up for it, you can reply to this
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10284#issuecomment-166401444
I've opened #10417 to fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/10417
[SPARK-12466] Fix harmless NPE in tests
```
[info] ReplayListenerSuite:
[info] - Simple replay (58 milliseconds)
java.lang.NullPointerException
at
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r48183738
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -464,6 +465,27 @@ object OptimizeIn extends
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10399#issuecomment-166403849
Decimal is a private class. We should not expose it to users until we have
audited the API.
---
If your project is set up for it, you can reply to this email and
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10331#discussion_r48184650
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -83,6 +84,16 @@ class Dataset[T] private[sql](
*/
private[sql] val
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10392#issuecomment-166407388
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10418#discussion_r48186455
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -44,6 +46,9 @@ case class Size(child:
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10388#issuecomment-166408282
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10407#issuecomment-166423976
@echoTomei it's failing style tests because there's a whitespace at the end
of the line
---
If your project is set up for it, you can reply to this email and have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10419#issuecomment-166428318
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48194955
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48194924
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48194995
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10331#issuecomment-166380661
**[Test build #48117 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48117/consoleFull)**
for PR 10331 at commit
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-166384678
@hvanhovell I just created
https://issues.apache.org/jira/browse/SPARK-12455 for adding doc. Can you also
put SPARK-12455 in the jira title?
---
If your project is set
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166388741
Yeah, this looks fine. I wonder if there's something safer that we can do
in the future. What I want is the following but I don't think scalastyle is
powerful
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10413#issuecomment-166388703
@srowen I've been thinking about all the RDD APIs last night, and one
thought I have is that if the goal is to push more people towards
DataFrame/Dataset, then maybe it
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10385#issuecomment-166388556
**[Test build #48120 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48120/consoleFull)**
for PR 10385 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-166400507
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48184082
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -28,11 +28,13 @@ import
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-166403465
I think we need more design work before we implement this. I'm not a huge
fan of the current UDT API and I think we will replace it in Spark 2.0.
---
If your
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/10418
[SPARK-12457] [SQL] Add ExpressionDescription to collection functions.
Feeling a little bit guilty to pick the one with the least functions. : )
One question to @yhuai : when users
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10407#issuecomment-166406368
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10057#issuecomment-166413261
**[Test build #48121 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48121/consoleFull)**
for PR 10057 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10373#issuecomment-166413378
Thanks, merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10393#discussion_r48191121
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -307,6 +307,7 @@ case class MapPartitions[T, U](
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10057#discussion_r48192141
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkCuratorUtil.scala ---
@@ -35,8 +35,11 @@ private[spark] object SparkCuratorUtil extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166389342
**[Test build #48122 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48122/consoleFull)**
for PR 10384 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10413#issuecomment-166389536
I think it probably cuts the other way - if you want people to use
dataframes then keeping the RDDs as-is is not that important. I don't see that
RDDs are going away
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10417#issuecomment-166404483
**[Test build #48123 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48123/consoleFull)**
for PR 10417 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10418#issuecomment-166423844
**[Test build #48129 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48129/consoleFull)**
for PR 10418 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10057#discussion_r48192593
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkCuratorUtil.scala ---
@@ -35,8 +35,11 @@ private[spark] object SparkCuratorUtil extends
Github user BenFradet commented on the pull request:
https://github.com/apache/spark/pull/10385#issuecomment-166427396
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10331#issuecomment-166430547
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48195057
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -75,6 +78,16 @@ private[sql] object JDBCRelation
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10057#discussion_r48172947
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcher.scala
---
@@ -50,7 +50,11 @@ private[mesos] class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10331#issuecomment-166380809
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10331#issuecomment-166380806
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-166385561
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10284#issuecomment-166385160
@tedyu would you mind pointing me to the jenkins page?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user tribbloid commented on the pull request:
https://github.com/apache/spark/pull/8785#issuecomment-166392614
Sorry I misunderstood your intention on previous comments, now both problem
should be fixed: toSeq is removed and single line of code in brackets are
pulled up.
---
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-166392842
I guess you also need to put `extended` like the example `Upper` given by
@yhuai ?
---
If your project is set up for it, you can reply to this email and have your
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10391#issuecomment-166404830
+1 to moving the test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10388#issuecomment-166410817
**[Test build #48127 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48127/consoleFull)**
for PR 10388 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10392#issuecomment-166410688
**[Test build #48126 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48126/consoleFull)**
for PR 10392 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10311
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10418#issuecomment-166416596
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10393#discussion_r48191985
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -307,6 +307,7 @@ case class MapPartitions[T, U](
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10057#discussion_r48192082
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcher.scala
---
@@ -50,7 +50,10 @@ private[mesos] class
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/10385#issuecomment-166420976
Added Java and Python examples.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10154#issuecomment-166430919
I think green makes more sense for completed, and blue for active, yes. My
hesitation is just that you'll end up with the completed column always sticking
out since it
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10416#issuecomment-166387366
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10368#issuecomment-166387458
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10368#issuecomment-166387455
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10368#issuecomment-166387289
**[Test build #48119 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48119/consoleFull)**
for PR 10368 at commit
1 - 100 of 550 matches
Mail list logo
