[GitHub] spark pull request: [SPARK-12659] fix NPE in UnsafeExternalSorter ...

2016-01-05 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10606#discussion_r48912881 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java --- @@ -223,14 +227,9 @@ public void loadNext() {

[GitHub] spark pull request: [SPARK-12379][ML][MLLIB] Copy GBT implementati...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10607#issuecomment-169171784 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3873] [core] Import ordering fixes.

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10578#issuecomment-169172279 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12630][DOC] Update param descriptions

2016-01-05 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/10598#discussion_r48913054 --- Diff: python/pyspark/mllib/classification.py --- @@ -94,16 +94,18 @@ class LogisticRegressionModel(LinearClassificationModel):

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-01-05 Thread vectorijk
Github user vectorijk commented on the pull request: https://github.com/apache/spark/pull/10527#issuecomment-169172817 cc @cloud-fan @marmbrus @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12593][SQL][WIP] Converts resolved logi...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10541#issuecomment-168982479 **[Test build #48763 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48763/consoleFull)** for PR 10541 at commit

[GitHub] spark pull request: [SPARK-12539][SQL] support writing bucketed ta...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10498#issuecomment-168982645 **[Test build #48765 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48765/consoleFull)** for PR 10498 at commit

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10583#issuecomment-168984129 **[Test build #48766 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48766/consoleFull)** for PR 10583 at commit

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-168985619 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-168985593 **[Test build #48762 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48762/consoleFull)** for PR 10570 at commit

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-168985620 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12632][Python][Make Parameter Descripti...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10602#issuecomment-168986043 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12632][Python][Make Parameter Descripti...

2016-01-05 Thread vijaykiran
Github user vijaykiran commented on a diff in the pull request: https://github.com/apache/spark/pull/10602#discussion_r48839934 --- Diff: python/pyspark/mllib/fpm.py --- @@ -130,15 +133,22 @@ def train(cls, data, minSupport=0.1, maxPatternLength=10, maxLocalProjDBSize=320

[GitHub] spark pull request: [SPARK-12632][Python][Make Parameter Descripti...

2016-01-05 Thread vijaykiran
Github user vijaykiran commented on a diff in the pull request: https://github.com/apache/spark/pull/10602#discussion_r48839858 --- Diff: python/pyspark/mllib/fpm.py --- @@ -68,11 +68,14 @@ def train(cls, data, minSupport=0.3, numPartitions=-1): """

[GitHub] spark pull request: [SPARK-11373] [CORE] Add metrics to the Histor...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9571#issuecomment-168988730 **[Test build #48768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48768/consoleFull)** for PR 9571 at commit

[GitHub] spark pull request: [SPARK-12632][Python][Make Parameter Descripti...

2016-01-05 Thread somideshmukh
GitHub user somideshmukh opened a pull request: https://github.com/apache/spark/pull/10602 [SPARK-12632][Python][Make Parameter Descriptions Consistent for PySpark MLlib FPM and Recommendation] Made changes in FPM file ,Recommendation file doesnot contain param changes You can

[GitHub] spark pull request: [SPARK-11315] [YARN] Add YARN extension servic...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8744#issuecomment-168988728 **[Test build #48769 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48769/consoleFull)** for PR 8744 at commit

[GitHub] spark pull request: [SPARK-1537] [YARN] Add history provider for Y...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10545#issuecomment-168990626 **[Test build #48767 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48767/consoleFull)** for PR 10545 at commit

[GitHub] spark pull request: [STREAMING][DOCS][EXAMPLES] Minor fixes

2016-01-05 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/10603 [STREAMING][DOCS][EXAMPLES] Minor fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaceklaskowski/spark

[GitHub] spark pull request: [SPARK-11315] [YARN] Add YARN extension servic...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8744#issuecomment-168991865 **[Test build #48769 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48769/consoleFull)** for PR 8744 at commit

[GitHub] spark pull request: [SPARK-11315] [YARN] Add YARN extension servic...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8744#issuecomment-168991988 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12504][SQL] Masking credentials in the ...

2016-01-05 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10452#issuecomment-169192724 Thanks, merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3873] [sql] Import ordering fixes.

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10573 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12504][SQL] Masking credentials in the ...

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10452 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12581][SQL] Support case-sensitive tabl...

2016-01-05 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/10523#issuecomment-169193276 @yhuai Yes, quoted tables in postgres are always case-sensitive. We need to support case-insensitive table names? Table names in sparksql

[GitHub] spark pull request: [SPARK-11696] [ML, MLlib] Optimization: Extend...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9667#issuecomment-169193588 I see. Adding this seems reasonable since some spark.ml algorithms depend on these APIs. However, I want to avoid breaking the public optimization APIs in

[GitHub] spark pull request: [SPARK-11696] [ML, MLlib] Optimization: Extend...

2016-01-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9667#discussion_r48920477 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala --- @@ -133,7 +133,7 @@ class GradientDescent private[spark]

[GitHub] spark pull request: [SPARK-11696] [ML, MLlib] Optimization: Extend...

2016-01-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9667#discussion_r48920506 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala --- @@ -178,7 +178,7 @@ object GradientDescent extends Logging {

[GitHub] spark pull request: [SPARK-11696] [ML, MLlib] Optimization: Extend...

2016-01-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9667#discussion_r48920464 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala --- @@ -122,8 +122,8 @@ class GradientDescent private[spark]

[GitHub] spark pull request: [SPARK-12644][SQL] Update parquet reader to be...

2016-01-05 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/10593#discussion_r48920875 --- Diff: core/src/test/scala/org/apache/spark/Benchmark.scala --- @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10583#issuecomment-169196055 cc @cloud-fan can you take a look at this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-12591][Streaming]Register OpenHashMapBa...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10609#issuecomment-169196126 **[Test build #48808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48808/consoleFull)** for PR 10609 at commit

[GitHub] spark pull request: [SPARK-11531] [ML] : SparseVector error Msg

2016-01-05 Thread rekhajoshm
Github user rekhajoshm commented on the pull request: https://github.com/apache/spark/pull/9525#issuecomment-169196705 Thanks @jkbradley might have missed it or thought it was under discussion.updated.thanks --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-12640][SQL] Add simple benchmarking uti...

2016-01-05 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/10589#discussion_r48921242 --- Diff: core/src/test/scala/org/apache/spark/Benchmark.scala --- @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/10583#discussion_r48921238 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -587,6 +586,13 @@ class Analyzer(

[GitHub] spark pull request: [SPARK-3873] [core] Import ordering fixes.

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10578#issuecomment-169197671 **[Test build #48799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48799/consoleFull)** for PR 10578 at commit

[GitHub] spark pull request: [SPARK-3873] [core] Import ordering fixes.

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10578#issuecomment-169198124 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3873] [core] Import ordering fixes.

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10578#issuecomment-169198126 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12400][Shuffle] Avoid generating temp s...

2016-01-05 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/10376#issuecomment-169198730 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12539][SQL] support writing bucketed ta...

2016-01-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10498#discussion_r48921611 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/bucket.scala --- @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12400][Shuffle] Avoid generating temp s...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10376#issuecomment-169200095 **[Test build #48809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48809/consoleFull)** for PR 10376 at commit

<    4   5   6   7   8   9