[GitHub] spark pull request: [SPARK-12799] Simplify various string output f...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10757#issuecomment-176620209 **[Test build #50356 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50356/consoleFull)** for PR 10757 at commit

[GitHub] spark pull request: [SPARK-13043][SQL] Implement remaining catalys...

2016-01-28 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10961#discussion_r51232647 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java --- @@ -126,12 +147,25 @@ public ArrayData copy() {

[GitHub] spark pull request: [SPARK-13050] [Build] Scalatest tags fail buil...

2016-01-28 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10954#issuecomment-176619493 @vanzin I see, thanks for the explanation! Then this LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-13043][SQL] Implement remaining catalys...

2016-01-28 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10961#discussion_r51232603 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java --- @@ -126,12 +147,25 @@ public ArrayData copy() {

[GitHub] spark pull request: [SPARK-13031] [SQL] cleanup codegen and improv...

2016-01-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10977#issuecomment-176619981 The issue here is that we want test cases that are targeted for specific problems, and the Hive ones are not (they are just a giant blackbox we took to bootstrap

[GitHub] spark pull request: [SPARK-11691][SQL] Allow to specify compressio...

2016-01-28 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/9657#discussion_r51233196 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ResolvedDataSource.scala --- @@ -235,11 +236,18 @@ object ResolvedDataSource

[GitHub] spark pull request: [SPARK-13043][SQL] Implement remaining catalys...

2016-01-28 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10961#discussion_r51233211 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVectorUtils.java --- @@ -59,19 +62,44 @@ public static Object

[GitHub] spark pull request: [SPARK-13043][SQL] Implement remaining catalys...

2016-01-28 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10961#discussion_r51233270 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVectorUtils.java --- @@ -59,19 +62,44 @@ public static Object

[GitHub] spark pull request: [SPARK-12656] [SQL] Implement Intersect with L...

2016-01-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10630#discussion_r51233323 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -315,4 +315,7 @@ abstract class BinaryNode

[GitHub] spark pull request: [SPARK-13047][PYSPARK][ML] Pyspark Params.hasP...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10962#issuecomment-176269418 **[Test build #50277 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50277/consoleFull)** for PR 10962 at commit

[GitHub] spark pull request: [SPARK-13047][PYSPARK][ML] Pyspark Params.hasP...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10962#issuecomment-176278153 **[Test build #50277 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50277/consoleFull)** for PR 10962 at commit

[GitHub] spark pull request: [SPARK-13047][PYSPARK][ML] Pyspark Params.hasP...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10962#issuecomment-176278457 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13020][SQL][test] fix random generator ...

2016-01-28 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10930#issuecomment-176297903 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176306010 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176306162 Just reverted all accidental formatting changes made by IntelliJ. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51160846 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -125,19 +125,15 @@ abstract class

[GitHub] spark pull request: [SPARK-12828][SQL]add natural join support

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10762#issuecomment-176310226 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13020][SQL][test] fix random generator ...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10930#issuecomment-176304810 **[Test build #50279 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50279/consoleFull)** for PR 10930 at commit

[GitHub] spark pull request: [SPARK-12749][SQL] add json option to parse fl...

2016-01-28 Thread blbradley
Github user blbradley commented on the pull request: https://github.com/apache/spark/pull/10936#issuecomment-176321781 I had an unused import. My apologies! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12469][CORE][RFC/WIP] Add Consistent Ac...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10841#issuecomment-176324493 **[Test build #50284 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50284/consoleFull)** for PR 10841 at commit

[GitHub] spark pull request: [SPARK-13031] [SQL] cleanup codegen and improv...

2016-01-28 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10944#discussion_r51166567 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala --- @@ -172,38 +184,42 @@ case class Range( s"$number >

[GitHub] spark pull request: [SPARK-13031] [SQL] cleanup codegen and improv...

2016-01-28 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10944#discussion_r51166689 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala --- @@ -42,10 +44,16 @@ trait CodegenSupport extends SparkPlan {

[GitHub] spark pull request: [SPARK-13031] [SQL] cleanup codegen and improv...

2016-01-28 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/10944#issuecomment-176333057 The generated code has a ton of extra new lines. If this is easy to remove, it will help the debuggability of this. LGTM, feel free to address the comments in

[GitHub] spark pull request: [SPARK-12469][CORE][RFC/WIP] Add Consistent Ac...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10841#issuecomment-176334317 **[Test build #50285 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50285/consoleFull)** for PR 10841 at commit

[GitHub] spark pull request: [SPARK-12749][SQL] add json option to parse fl...

2016-01-28 Thread blbradley
Github user blbradley commented on the pull request: https://github.com/apache/spark/pull/10936#issuecomment-176338205 @rxin can you start the test again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12330] [MESOS] Fix mesos coarse mode cl...

2016-01-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10319#issuecomment-176338070 This still hasn't run tests yet because it's still failing scala style. Also it looks a little out of date. @drcrallen would you mind rebasing to master and fixing

[GitHub] spark pull request: [SPARK-13001] [CORE] [MESOS] Prevent getting o...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10924#issuecomment-176342191 **[Test build #50288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50288/consoleFull)** for PR 10924 at commit

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176347265 **[Test build #2468 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2468/consoleFull)** for PR 10968 at commit

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176357187 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-01-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r51176492 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MiscFunctionsSuite.scala --- @@ -132,4 +132,49 @@ class

[GitHub] spark pull request: [SPARK-13053] Unignore tests in InternalAccumu...

2016-01-28 Thread andrewor14
GitHub user andrewor14 opened a pull request: https://github.com/apache/spark/pull/10969 [SPARK-13053] Unignore tests in InternalAccumulatorSuite These were ignored because they are incorrectly written; they don't actually trigger stage retries, which is what the tests are testing.

[GitHub] spark pull request: [SPARK-13043][SQL] Implement remaining catalys...

2016-01-28 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10961#discussion_r51167501 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java --- @@ -170,7 +204,14 @@ public float getFloat(int ordinal) {

[GitHub] spark pull request: [SPARK-13053] [TEST] Unignore tests in Interna...

2016-01-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10969#issuecomment-176334105 @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13001] [CORE] [MESOS] Prevent getting o...

2016-01-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10924#issuecomment-176336086 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11938][ML] Expose numFeatures in all ML...

2016-01-28 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/9936#issuecomment-176340916 It seems like there is a lot of duplicated just calls to Java & PyDoc could we maybe make a HasNumFeatures or similar (similar to how we do this for params which we use

[GitHub] spark pull request: [SPARK-13001] [CORE] [MESOS] Prevent getting o...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10924#issuecomment-176343159 **[Test build #50288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50288/consoleFull)** for PR 10924 at commit

[GitHub] spark pull request: [SPARK-12463][SPARK-12464][SPARK-12465][SPARK-...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10057#issuecomment-176343442 **[Test build #50289 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50289/consoleFull)** for PR 10057 at commit

[GitHub] spark pull request: [SPARK-13001] [CORE] [MESOS] Prevent getting o...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10924#issuecomment-176343179 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13001] [CORE] [MESOS] Prevent getting o...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10924#issuecomment-176343174 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12828][SQL]add natural join support

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10762#issuecomment-176355030 **[Test build #50282 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50282/consoleFull)** for PR 10762 at commit

[GitHub] spark pull request: [SPARK-12828][SQL]add natural join support

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10762#issuecomment-176355331 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176358419 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-01-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r51175633 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -453,3 +455,131 @@ case class Murmur3Hash(children:

[GitHub] spark pull request: [SPARK-13043][SQL] Implement remaining catalys...

2016-01-28 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10961#discussion_r51168028 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java --- @@ -217,6 +269,41 @@ public final long getLong(int

[GitHub] spark pull request: [SPARK-12463][SPARK-12464][SPARK-12465][SPARK-...

2016-01-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10057#issuecomment-176339334 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13053] [TEST] Unignore tests in Interna...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10969#issuecomment-176340712 **[Test build #50286 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50286/consoleFull)** for PR 10969 at commit

[GitHub] spark pull request: [SPARK-13043][SQL] Implement remaining catalys...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10961#issuecomment-176348260 **[Test build #50287 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50287/consoleFull)** for PR 10961 at commit

[GitHub] spark pull request: [SPARK-12828][SQL]add natural join support

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10762#issuecomment-176355327 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176356482 **[Test build #50283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50283/consoleFull)** for PR 10968 at commit

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176357192 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12828][SQL]add natural join support

2016-01-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10762#discussion_r51175030 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -104,6 +105,9 @@ trait CheckAnalysis {

[GitHub] spark pull request: Fix for [SPARK-12854][SQL] Implement complex t...

2016-01-28 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10946#issuecomment-176438432 I dug into the logs and it looks like the horizontal ellipsis character (…) is breaking the test triggering code because we didn't handle / escape / strip Unicode

[GitHub] spark pull request: [SPARK-12926][SQL] SQLContext to display warni...

2016-01-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10849 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13031] [SQL] cleanup codegen and improv...

2016-01-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10944 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13050] [Build] Scalatest tags fail buil...

2016-01-28 Thread ajbozarth
Github user ajbozarth commented on the pull request: https://github.com/apache/spark/pull/10954#issuecomment-176439956 Also looping in @rxin and @JoshRosen since they were in on #10851 which caused this --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-12656] [SQL] Implement Intersect with L...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10630#issuecomment-176441985 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12656] [SQL] Implement Intersect with L...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10630#issuecomment-176441989 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10873] Support column sort and search f...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10648#issuecomment-176443208 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10873] Support column sort and search f...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10648#issuecomment-176443210 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176443933 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Fix for [SPARK-12854][SQL] Implement complex t...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10946#issuecomment-176444050 **[Test build #2470 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2470/consoleFull)** for PR 10946 at commit

[GitHub] spark pull request: [SPARK-12330] [MESOS] Fix mesos coarse mode cl...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10319#issuecomment-176444359 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12330] [MESOS] Fix mesos coarse mode cl...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10319#issuecomment-176443848 **[Test build #50300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50300/consoleFull)** for PR 10319 at commit

[GitHub] spark pull request: [SPARK-12330] [MESOS] Fix mesos coarse mode cl...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10319#issuecomment-176444360 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12330] [MESOS] Fix mesos coarse mode cl...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10319#issuecomment-176444351 **[Test build #50300 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50300/consoleFull)** for PR 10319 at commit

[GitHub] spark pull request: [SPARK-12963] Improve performance of stat func...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176451454 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12963] Improve performance of stat func...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176451450 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-9835] [ML] Implement IterativelyReweigh...

2016-01-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10639 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13020][SQL][test] fix random generator ...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10930#issuecomment-176459290 **[Test build #50305 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50305/consoleFull)** for PR 10930 at commit

[GitHub] spark pull request: [SPARK-13029][ml] fix a logistic regression is...

2016-01-28 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/10940#issuecomment-176459204 @iyounus Ideally, it will be great that `intercept=true`, we keep the current behavior which is constant column doesn't have any predictive power. --- If your project

[GitHub] spark pull request: [SPARK-12962] [SQL] [PySpark] PySpark support ...

2016-01-28 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/10876#issuecomment-176470354 @davies corr was added? https://github.com/apache/spark/blob/master/python/pyspark/sql/functions.py#L251 --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-12914] [SQL] generate aggregation with ...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10855#issuecomment-176470765 **[Test build #50307 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50307/consoleFull)** for PR 10855 at commit

[GitHub] spark pull request: [SPARK-12469][CORE][RFC/WIP] Add Consistent Ac...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10841#issuecomment-176470853 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12469][CORE][RFC/WIP] Add Consistent Ac...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10841#issuecomment-176470848 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13067][SQL] workaround for a weird scal...

2016-01-28 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10970#issuecomment-176475787 CC @davies @yhuai @marmbrus @davies can you try it out locally? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-13067][SQL] workaround for a weird scal...

2016-01-28 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/10970 [SPARK-13067][SQL] workaround for a weird scala reflection problem A simple workaround to avoid getting parameter types when convert a logical plan to json。 You can merge this pull request

[GitHub] spark pull request: [SPARK-13020][SQL][test] fix random generator ...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10930#issuecomment-176477579 **[Test build #50311 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50311/consoleFull)** for PR 10930 at commit

[GitHub] spark pull request: [SPARK-12914] [SQL] generate aggregation with ...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10855#issuecomment-176478326 **[Test build #50307 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50307/consoleFull)** for PR 10855 at commit

[GitHub] spark pull request: Fix for [SPARK-12854][SQL] Implement complex t...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10946#issuecomment-176478351 **[Test build #2470 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2470/consoleFull)** for PR 10946 at commit

[GitHub] spark pull request: [SPARK-12914] [SQL] generate aggregation with ...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10855#issuecomment-176478372 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12914] [SQL] generate aggregation with ...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10855#issuecomment-176478369 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12469][CORE][RFC/WIP] Add Consistent Ac...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10841#issuecomment-176300048 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12469][CORE][RFC/WIP] Add Consistent Ac...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10841#issuecomment-176300027 **[Test build #50278 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50278/consoleFull)** for PR 10841 at commit

[GitHub] spark pull request: [SPARK-12469][CORE][RFC/WIP] Add Consistent Ac...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10841#issuecomment-176300039 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176304119 @rxin Updated, thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12269][Streaming][Kinesis] Update aws-j...

2016-01-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10256#issuecomment-176305142 I think that's OK. I was intending to propose a series of dependency updates for 2.x like this sort of thing. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-10777] [SQL] Resolve Aliases in the Gro...

2016-01-28 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10967#issuecomment-176439624 I'm not sure we want this. Neither oracle nor SQL server support it and you can already use numbers to refer to things from the select clause in a group by. --- If

[GitHub] spark pull request: [SPARK-13047][PYSPARK][ML] Pyspark Params.hasP...

2016-01-28 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/10962#issuecomment-176439329 Maybe @davies or @jkbradley could take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12989] [SQL] Delaying Alias Cleanup aft...

2016-01-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10963#discussion_r51194112 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -872,7 +872,8 @@ class Analyzer( if

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176443884 **[Test build #50297 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50297/consoleFull)** for PR 10960 at commit

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176443931 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12989] [SQL] Delaying Alias Cleanup aft...

2016-01-28 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10963#discussion_r51194963 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -872,7 +872,8 @@ class Analyzer( if

[GitHub] spark pull request: [SPARK-12963] Improve performance of stat func...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176452126 **[Test build #50304 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50304/consoleFull)** for PR 10960 at commit

[GitHub] spark pull request: [SPARK-13029][ml] fix a logistic regression is...

2016-01-28 Thread iyounus
Github user iyounus commented on the pull request: https://github.com/apache/spark/pull/10940#issuecomment-176454056 @dbtsai Linear regression also has similar issues. There, "normal" and "l-gbfs" solvers treat this case differently (and incorrectly). The other problem there is that

[GitHub] spark pull request: [SPARK-12799] Simplify various string output f...

2016-01-28 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10757#issuecomment-176466748 It took me sometime to fix those R test failures. Hopefully the last commit fixes everything (finger crossed). --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-7675][ML][PYSpark] sparkml params type ...

2016-01-28 Thread sethah
Github user sethah commented on the pull request: https://github.com/apache/spark/pull/9581#issuecomment-176473073 I am thinking about how we can avoid getting `java.lang.ClassCastException` when passing incorrect `Param` types through to Scala. Is there any reason we cannot make

[GitHub] spark pull request: [SPARK-12963] Improve performance of stat func...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176475892 **[Test build #50304 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50304/consoleFull)** for PR 10960 at commit

[GitHub] spark pull request: [SPARK-12401][SQL] Add integration tests for p...

2016-01-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10596 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176436538 **[Test build #50297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50297/consoleFull)** for PR 10960 at commit

[GitHub] spark pull request: [SPARK-13031] [SQL] cleanup codegen and improv...

2016-01-28 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10944#discussion_r51193347 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala --- @@ -172,38 +184,42 @@ case class Range( s"$number >

<    1   2   3   4   5   6   7   >