[GitHub] spark pull request: [SPARK-13840] [SQL] Split Optimizer Rule Colum...

2016-03-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-196701013 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13893][SQL] Remove SQLContext.catalog (...

2016-03-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11716#discussion_r56123870 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala --- @@ -113,8 +113,6 @@ class HiveContext private[hive]( @transient

[GitHub] spark pull request: [SPARK-13893][SQL] Remove SQLContext.catalog (...

2016-03-15 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11716#issuecomment-196699743 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11714#issuecomment-196699484 **[Test build #53175 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53175/consoleFull)** for PR 11714 at commit

[GitHub] spark pull request: [SPARK-13892][SQL] remove useless lateral view...

2016-03-15 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11715#issuecomment-196699290 Np --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13893][SQL] Remove SQLContext.catalog (...

2016-03-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11716#discussion_r56123783 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala --- @@ -113,8 +113,6 @@ class HiveContext private[hive]( @transient

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11714#issuecomment-196698564 I will not trigger more tests in this PR until the related PR is merged. Thanks! --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-13892][SQL] remove useless lateral view...

2016-03-15 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11715#issuecomment-196698397 Sorry I didn't know this feature, thanks for reminding! closing now --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-13892][SQL] remove useless lateral view...

2016-03-15 Thread cloud-fan
Github user cloud-fan closed the pull request at: https://github.com/apache/spark/pull/11715 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11714#issuecomment-196698066 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13893][SQL] Remove SQLContext.catalog (...

2016-03-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11716#issuecomment-196698067 cc @cloud-fan one more ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11714#issuecomment-196698065 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11714#issuecomment-196698060 **[Test build #53173 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53173/consoleFull)** for PR 11714 at commit

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11714#issuecomment-196697886 **[Test build #53173 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53173/consoleFull)** for PR 11714 at commit

[GitHub] spark pull request: [SPARK-13893][SQL] Remove SQLContext.catalog (...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11716#issuecomment-196697867 **[Test build #53174 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53174/consoleFull)** for PR 11716 at commit

[GitHub] spark pull request: [SPARK-13893][SQL] Remove SQLContext.catalog (...

2016-03-15 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/11716 [SPARK-13893][SQL] Remove SQLContext.catalog (internal method) ## What changes were proposed in this pull request? Our internal code can go through SessionState.catalog. This brings two small

[GitHub] spark pull request: [SPARK-8971][MLLIB][ML] Support balanced class...

2016-03-15 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/8112#issuecomment-196695062 @sethah I will take a look. I think this is an important feature to have. Could you update to sort out merge conflicts? --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-13642][Yarn] Changed the default applic...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11693#issuecomment-196694643 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13642][Yarn] Changed the default applic...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11693#issuecomment-196694646 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-13827[SQL] Can't add subquery to an oper...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11658#issuecomment-196694484 **[Test build #53172 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53172/consoleFull)** for PR 11658 at commit

[GitHub] spark pull request: [SPARK-13642][Yarn] Changed the default applic...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11693#issuecomment-196694492 **[Test build #53170 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53170/consoleFull)** for PR 11693 at commit

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11714#issuecomment-196693818 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11714#issuecomment-196693822 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11714#issuecomment-196693517 **[Test build #53166 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53166/consoleFull)** for PR 11714 at commit

[GitHub] spark pull request: SPARK-13827[SQL] Can't add subquery to an oper...

2016-03-15 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11658#issuecomment-19669 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13892][SQL] remove useless lateral view...

2016-03-15 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11715#issuecomment-196693380 @cloud-fan I think we need this for multi-insert queries, e.g.: `from tbl insert into tbl1 select * insert into tbl2 select * lateral view explode(y) where x <

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-196690788 **[Test build #53171 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53171/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11714#discussion_r5611 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala --- @@ -29,6 +29,7 @@ import

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11714#discussion_r56122162 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala --- @@ -46,15 +47,23 @@ abstract class

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11714#discussion_r56122167 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala --- @@ -98,7 +107,8 @@ abstract class RuleExecutor[TreeType

[GitHub] spark pull request: [SPARK-13890][SQL] Remove some internal classe...

2016-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11712 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12379][ML][MLLIB] Copy GBT implementati...

2016-03-15 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/10607#issuecomment-196690249 @sethah given it's a copy of MLLIb impl, and given test passes and the smaller spark-perf tests, I'm comfortable moving ahead. We should still run the larger scale

[GitHub] spark pull request: [SPARK-13890][SQL] Remove some internal classe...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11712#issuecomment-196690170 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-15 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-196690176 test it please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13890][SQL] Remove some internal classe...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11712#issuecomment-196690172 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-15 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-196690164 I'll create new JIRA on params overriding. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13890][SQL] Remove some internal classe...

2016-03-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11712#issuecomment-196690053 Thanks - going to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13456][SQL] fix creating encoders for c...

2016-03-15 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11410#issuecomment-196690093 Hi @retronym , your idea looks good, but in our situation, we only have a class name string and it's not that easy to get the line object. BTW the REPL classes are

[GitHub] spark pull request: [SPARK-13890][SQL] Remove some internal classe...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11712#issuecomment-196690024 **[Test build #53161 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53161/consoleFull)** for PR 11712 at commit

[GitHub] spark pull request: [SPARK-13642][Yarn] Changed the default applic...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11693#issuecomment-196689449 **[Test build #53170 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53170/consoleFull)** for PR 11693 at commit

[GitHub] spark pull request: [SPARK-13642][Yarn] Changed the default applic...

2016-03-15 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/11693#issuecomment-196687932 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13207][SQL][BRANCH-1.6] Make partitioni...

2016-03-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11697#issuecomment-196685295 I've merged this in branch-1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13207][SQL][BRANCH-1.6] Make partitioni...

2016-03-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11697#issuecomment-196685350 (You'd need to close this) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12719][SQL] SQL generation support for ...

2016-03-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11696#issuecomment-196685214 @cloud-fan the logic looks good to me. I left some comments -- try make this understandable (by adding more comments or renaming some functions) for people that

[GitHub] spark pull request: [SPARK-12719][SQL] SQL generation support for ...

2016-03-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11696#discussion_r56120708 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala --- @@ -354,59 +425,54 @@ class SQLBuilder(logicalPlan: LogicalPlan, sqlContext:

[GitHub] spark pull request: [SPARK-12719][SQL] SQL generation support for ...

2016-03-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11696#discussion_r56120740 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala --- @@ -229,6 +224,30 @@ class SQLBuilder(logicalPlan: LogicalPlan, sqlContext:

[GitHub] spark pull request: [SPARK-12719][SQL] SQL generation support for ...

2016-03-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11696#discussion_r56120577 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala --- @@ -274,17 +293,25 @@ class SQLBuilder(logicalPlan: LogicalPlan, sqlContext:

[GitHub] spark pull request: [SPARK-12719][SQL] SQL generation support for ...

2016-03-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11696#discussion_r56120392 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala --- @@ -316,31 +345,73 @@ class SQLBuilder(logicalPlan: LogicalPlan, sqlContext:

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10428#issuecomment-196683541 **[Test build #53169 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53169/consoleFull)** for PR 10428 at commit

[GitHub] spark pull request: [SPARK-13660][SQL][Tests] ContinuousQuerySuite...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11703#issuecomment-196683532 **[Test build #53168 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53168/consoleFull)** for PR 11703 at commit

[GitHub] spark pull request: [SPARK-12719][SQL] SQL generation support for ...

2016-03-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11696#discussion_r56120228 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala --- @@ -354,59 +425,54 @@ class SQLBuilder(logicalPlan: LogicalPlan, sqlContext:

[GitHub] spark pull request: [SPARK-13660][SQL][Tests] ContinuousQuerySuite...

2016-03-15 Thread keypointt
Github user keypointt commented on a diff in the pull request: https://github.com/apache/spark/pull/11703#discussion_r5612 --- Diff: project/MimaExcludes.scala --- @@ -319,6 +319,68 @@ object MimaExcludes {

[GitHub] spark pull request: [SPARK-13892][SQL] remove useless lateral view...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11715#issuecomment-196682803 **[Test build #53167 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53167/consoleFull)** for PR 11715 at commit

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11714#discussion_r56119880 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala --- @@ -98,7 +107,8 @@ abstract class RuleExecutor[TreeType <:

[GitHub] spark pull request: [SPARK-13892][SQL] remove useless lateral view...

2016-03-15 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/11715 [SPARK-13892][SQL] remove useless lateral view handling ## What changes were proposed in this pull request? `LATERAL VIEW` is part of the relation, and we already handled it when

[GitHub] spark pull request: [SPARK-13892][SQL] remove useless lateral view...

2016-03-15 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11715#issuecomment-196682504 cc @hvanhovell @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/11714#discussion_r56119782 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala --- @@ -98,7 +107,8 @@ abstract class RuleExecutor[TreeType

[GitHub] spark pull request: [SPARK-13870][SQL] Add scalastyle escaping cor...

2016-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11700 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/11714#discussion_r56119755 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala --- @@ -98,7 +107,8 @@ abstract class RuleExecutor[TreeType

[GitHub] spark pull request: [SPARK-13660][SQL][Tests] ContinuousQuerySuite...

2016-03-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11703#discussion_r56119753 --- Diff: project/MimaExcludes.scala --- @@ -319,6 +319,68 @@ object MimaExcludes {

[GitHub] spark pull request: [SPARK-13888][DOC]Remove Akka Receiver doc and...

2016-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11711 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13870][SQL] Add scalastyle escaping cor...

2016-03-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11700#issuecomment-196681933 Merging in master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13118][SQL] Regression test for package...

2016-03-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11708#issuecomment-196681717 cc @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13888][DOC]Remove Akka Receiver doc and...

2016-03-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11711#issuecomment-196681596 Merging in master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11714#discussion_r56119467 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala --- @@ -98,7 +107,8 @@ abstract class RuleExecutor[TreeType <:

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11714#discussion_r56119479 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala --- @@ -29,6 +29,7 @@ import

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11714#discussion_r56119436 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala --- @@ -46,15 +47,23 @@ abstract class RuleExecutor[TreeType <:

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11714#discussion_r56119362 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala --- @@ -98,7 +107,8 @@ abstract class RuleExecutor[TreeType <:

[GitHub] spark pull request: [SPARK-13890][SQL] Remove some internal classe...

2016-03-15 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11712#issuecomment-196681094 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13884][SQL] Remove DescribeCommand's de...

2016-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11710 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13884][SQL] Remove DescribeCommand's de...

2016-03-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11710#issuecomment-196679919 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-196678560 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-196678561 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-13034] PySpark ml.classification suppor...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11707#issuecomment-196678381 **[Test build #53164 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53164/consoleFull)** for PR 11707 at commit

[GitHub] spark pull request: [SPARK-13884][SQL] Remove DescribeCommand's de...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11710#issuecomment-196677823 **[Test build #2641 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2641/consoleFull)** for PR 11710 at commit

<    4   5   6   7   8   9