[GitHub] spark pull request: SPARK-14091 [core] Consider improving performa...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11911#issuecomment-201393204 **[Test build #54195 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54195/consoleFull)** for PR 11911 at commit [`f59c85f`](https://gi

[GitHub] spark pull request: [SPARK-14109][SQL] Fix HDFSMetadataLog to fall...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11925#issuecomment-201393248 **[Test build #54194 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54194/consoleFull)** for PR 11925 at commit [`5eb63b6`](https://gi

[GitHub] spark pull request: [SPARK-14102][CORE] Block `reset` command in S...

2016-03-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11920#issuecomment-201392194 Thank you for the positive feedback. Indeed, it was just one-line change to block `reset`. All the others changes in that file is just about ScalaStyle correct

[GitHub] spark pull request: [SPARK-14131][SQL]Add a workaround for HADOOP-...

2016-03-25 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11940#discussion_r57471001 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -101,6 +102,65 @@ class StreamExecution( priv

[GitHub] spark pull request: [SPARK-13891] [SQL] [TEST] Issue Exceptions wh...

2016-03-25 Thread gatorsmile
Github user gatorsmile closed the pull request at: https://github.com/apache/spark/pull/11714 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-14091 [core] Consider improving performa...

2016-03-25 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11911#issuecomment-201389883 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14131][SQL]Add a workaround for HADOOP-...

2016-03-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/11940#discussion_r57470403 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -101,6 +102,65 @@ class StreamExecution( priva

[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...

2016-03-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11829#discussion_r57470219 --- Diff: bin/pyspark --- @@ -49,7 +49,10 @@ if [[ -n "$IPYTHON_OPTS" || "$IPYTHON" == "1" ]]; then # If IPython options are specified, assume user want

[GitHub] spark pull request: [SPARK-14089][CORE][MLLIB] Remove methods that...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11910#issuecomment-201385697 **[Test build #54193 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54193/consoleFull)** for PR 11910 at commit [`631c44c`](https://gi

[GitHub] spark pull request: [SPARK-14102][CORE] Block `reset` command in S...

2016-03-25 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11920#issuecomment-201385003 OK. If it's pretty simple and there is no good reason to call reset (since it kills the `SparkContext`) maybe it is worth blocking after all. --- If your project is set

[GitHub] spark pull request: [SPARK-14089][CORE][MLLIB] Remove methods that...

2016-03-25 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11910#issuecomment-201383708 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12555][SQL] Result should not be corrup...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11623#issuecomment-201383515 **[Test build #54192 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54192/consoleFull)** for PR 11623 at commit [`c0e73cd`](https://gi

[GitHub] spark pull request: [SPARK-14137][SPARK-14150][SQL] Infer IsNotNul...

2016-03-25 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11953#issuecomment-201383385 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark pull request: [SPARK-12555][SQL] Result should not be corrup...

2016-03-25 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/11623#issuecomment-201383428 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: [SPARK-14137][SPARK-14150][SQL] Infer IsNotNul...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11953#issuecomment-201382523 **[Test build #54191 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54191/consoleFull)** for PR 11953 at commit [`2f43d41`](https://gi

[GitHub] spark pull request: [SPARK-14137][SPARK-14150][SQL] Infer IsNotNul...

2016-03-25 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/11953#issuecomment-201382352 thanks, done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57468288 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -291,10 +308,10 @@ private[orc] case class OrcTableScan( val

[GitHub] spark pull request: [SPARK-14144][SQL] Explicitly identify/catch U...

2016-03-25 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/11950#issuecomment-201381524 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark pull request: [SPARK-13579][build][wip] Stop building the ma...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11796#issuecomment-201381299 **[Test build #54190 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54190/consoleFull)** for PR 11796 at commit [`01d9f0d`](https://gi

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57467951 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -117,6 +123,66 @@ private[sql] class DefaultSource extends FileFormat

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57467872 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -117,6 +123,66 @@ private[sql] class DefaultSource extends FileFormat

[GitHub] spark pull request: [SPARK-14071][PySpark][ML]Change MLWritable.wr...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11945#issuecomment-201379414 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14071][PySpark][ML]Change MLWritable.wr...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11945#issuecomment-201379419 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14071][PySpark][ML]Change MLWritable.wr...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11945#issuecomment-201378991 **[Test build #54187 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54187/consoleFull)** for PR 11945 at commit [`d8f5d6e`](https://g

[GitHub] spark pull request: [SPARK-12555][SQL] Result should not be corrup...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11623#issuecomment-201378536 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12555][SQL] Result should not be corrup...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11623#issuecomment-201378532 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14089][CORE][MLLIB] Remove methods that...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11910#issuecomment-201376467 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14114][SQL] implement buildReader for t...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11934#issuecomment-201376305 **[Test build #54188 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54188/consoleFull)** for PR 11934 at commit [`947fc70`](https://gi

[GitHub] spark pull request: [SPARK-14089][CORE][MLLIB] Remove methods that...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11910#issuecomment-201376459 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14089][CORE][MLLIB] Remove methods that...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11910#issuecomment-201376311 **[Test build #54175 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54175/consoleFull)** for PR 11910 at commit [`631c44c`](https://g

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11961#issuecomment-201376017 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11961#issuecomment-201376022 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11961#issuecomment-201375885 **[Test build #54186 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54186/consoleFull)** for PR 11961 at commit [`080a506`](https://g

[GitHub] spark pull request: [SPARK-14071][PySpark][ML]Change MLWritable.wr...

2016-03-25 Thread wangmiao1981
Github user wangmiao1981 commented on the pull request: https://github.com/apache/spark/pull/11945#issuecomment-201375961 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14158][SQL] implement buildReader for j...

2016-03-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11960#discussion_r57465871 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileLinesReader.scala --- @@ -0,0 +1,50 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14071][PySpark][ML]Change MLWritable.wr...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11945#issuecomment-201374973 **[Test build #54187 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54187/consoleFull)** for PR 11945 at commit [`d8f5d6e`](https://gi

[GitHub] spark pull request: [SPARK-14114][SQL] implement buildReader for t...

2016-03-25 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11934#issuecomment-201374918 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [MINOR] Typo fixes

2016-03-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11802#discussion_r57465383 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala --- @@ -246,9 +246,7 @@ class StreamingContext private[streaming] (

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201373865 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201373903 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14158][SQL] implement buildReader for j...

2016-03-25 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11960#issuecomment-201373343 Overall looks good. Let's fix the serialization issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-14158][SQL] implement buildReader for j...

2016-03-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11960#discussion_r57465176 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -58,7 +58,8 @@ private[sql] object FileSourceStra

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201373230 **[Test build #54183 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54183/consoleFull)** for PR 11936 at commit [`a26973e`](https://g

[GitHub] spark pull request: [SPARK-14158][SQL] implement buildReader for j...

2016-03-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11960#discussion_r57465015 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileLinesReader.scala --- @@ -0,0 +1,50 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14134] [core] [test-maven] Change the p...

2016-03-25 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11941#issuecomment-201370479 Cool, guess I'll wait for those, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...

2016-03-25 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201370396 Let me submit a PR for parsing `TOK_DESCDATABASE` and `TOK_DROPDATABASE`. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark pull request: [SPARK-14134] [core] [test-maven] Change the p...

2016-03-25 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11941#issuecomment-201369432 However, #11895 is blocked by #11940. It can not pass tests :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14134] [core] [test-maven] Change the p...

2016-03-25 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11941#issuecomment-201368662 @vanzio I fixed it in #11895 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-14158][SQL] implement buildReader for j...

2016-03-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11960#discussion_r57464019 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -58,7 +58,8 @@ private[sql] object FileSourceStra

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-25 Thread sethah
Github user sethah commented on the pull request: https://github.com/apache/spark/pull/11961#issuecomment-201361949 cc @jkbradley whenever you get a chance, could you take a look? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] spark pull request: [SPARK-14158][SQL] implement buildReader for j...

2016-03-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11960#discussion_r57462957 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JSONRelation.scala --- @@ -120,6 +122,39 @@ class DefaultSource extends File

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-25 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11961#discussion_r57462916 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala --- @@ -119,6 +119,31 @@ class GBTClassifierSuite extends SparkFun

[GitHub] spark pull request: [SPARK-14061][SQL] implement CreateMap

2016-03-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11879 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-25 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11961#discussion_r57462635 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala --- @@ -222,16 +222,10 @@ final class RandomForestClassificati

[GitHub] spark pull request: [SPARK-14134] [core] [test-maven] Change the p...

2016-03-25 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11941#issuecomment-201359154 this is the same flaky test that's failing in other places with maven... let me see if it's easy to fix. --- If your project is set up for it, you can reply to this ema

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11961#issuecomment-201358136 **[Test build #54186 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54186/consoleFull)** for PR 11961 at commit [`080a506`](https://gi

[GitHub] spark pull request: [SPARK-13742][Core] Add non-iterator interface...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11578#issuecomment-201357380 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13742][Core] Add non-iterator interface...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11578#issuecomment-201357385 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-25 Thread sethah
GitHub user sethah opened a pull request: https://github.com/apache/spark/pull/11961 [SPARK-11730][ML] Add feature importances for GBTs. ## What changes were proposed in this pull request? Now that GBTs have been moved to ML, they can use the implementation of feature impor

[GitHub] spark pull request: [SPARK-13742][Core] Add non-iterator interface...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11578#issuecomment-201357116 **[Test build #54179 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54179/consoleFull)** for PR 11578 at commit [`5319ced`](https://g

[GitHub] spark pull request: [SPARK-13579][build][wip] Stop building the ma...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11796#issuecomment-201356605 **[Test build #54185 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54185/consoleFull)** for PR 11796 at commit [`976ce2c`](https://gi

[GitHub] spark pull request: [SPARK-13579][build][wip] Stop building the ma...

2016-03-25 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11796#issuecomment-201355617 once more with sbt... retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14050][ML] Add multiple languages suppo...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11871#issuecomment-201353993 **[Test build #54184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54184/consoleFull)** for PR 11871 at commit [`789342f`](https://gi

[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...

2016-03-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11959#discussion_r57459785 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -53,12 +54,19 @@ case class CreateDatabase( extends NativeDDLC

[GitHub] spark pull request: [SPARK-13343] [CORE] speculative tasks that di...

2016-03-25 Thread devaraj-kavali
Github user devaraj-kavali commented on a diff in the pull request: https://github.com/apache/spark/pull/11916#discussion_r57459040 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -620,6 +620,14 @@ private[spark] class TaskSetManager( /

[GitHub] spark pull request: [SPARK-14105][STREAMING] Deep copy each kafka ...

2016-03-25 Thread liyintang
Github user liyintang closed the pull request at: https://github.com/apache/spark/pull/11921 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14105][STREAMING] Deep copy each kafka ...

2016-03-25 Thread liyintang
Github user liyintang commented on the pull request: https://github.com/apache/spark/pull/11921#issuecomment-201347094 Thanks @koeninger for the review and insightful comments ! It has been great start experience to contribute to the community. For this PR, I think it makes se

[GitHub] spark pull request: [SPARK-12504][SQL] [Backport-1.6] Masking cred...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10669#issuecomment-201347045 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-12737]Decrease the redundant activeIds ...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10676#issuecomment-201347040 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201346907 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201346909 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201346656 **[Test build #54177 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54177/consoleFull)** for PR 11959 at commit [`f0c43b9`](https://g

[GitHub] spark pull request: [SPARK-13919] [SQL] fix column pruning through...

2016-03-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11828 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13919] [SQL] [WIP] Resolving the Confli...

2016-03-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11745 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14158][SQL] implement buildReader for j...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11960#issuecomment-201345705 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14137][SPARK-14150][SQL] Infer IsNotNul...

2016-03-25 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11953#issuecomment-201345745 #11828 Has been merged, could you enable `union20` here ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-14158][SQL] implement buildReader for j...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11960#issuecomment-201345704 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13919] [SQL] fix column pruning through...

2016-03-25 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11828#issuecomment-201345415 Merging into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-14158][SQL] implement buildReader for j...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11960#issuecomment-20134 **[Test build #54180 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54180/consoleFull)** for PR 11960 at commit [`3efd4a1`](https://g

[GitHub] spark pull request: [SPARK-14102][CORE] Block `reset` command in S...

2016-03-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11920#issuecomment-201341699 Hi, @srowen . Recently Jenkins was a little bit flakey. How do you think about this PR now? The code is the same. It is just rebased to pass the test.

[GitHub] spark pull request: [SPARK-14014][SQL] Integrate session catalog (...

2016-03-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11938#discussion_r57456787 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -31,17 +32,34 @@ import org.apache.spark.sql.cat

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57456602 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -117,6 +123,66 @@ private[sql] class DefaultSource extends FileFor

[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-201339819 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-201339820 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-201339654 **[Test build #54176 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54176/consoleFull)** for PR 11829 at commit [`e1a0c40`](https://g

[GitHub] spark pull request: [MINOR] Typo fixes

2016-03-25 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/11802#discussion_r57455819 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala --- @@ -246,9 +246,7 @@ class StreamingContext private[streaming]

[GitHub] spark pull request: [SPARK-14071][PySpark][ML]Change MLWritable.wr...

2016-03-25 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/11945#issuecomment-201336839 LGTM except the minor issue. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14071][PySpark][ML]Change MLWritable.wr...

2016-03-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/11945#discussion_r57455505 --- Diff: python/pyspark/ml/util.py --- @@ -149,6 +151,8 @@ class JavaMLWritable(MLWritable): (Private) Mixin for ML instances that provide :py:cl

[GitHub] spark pull request: [SPARK-14071][PySpark][ML]Change MLWritable.wr...

2016-03-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/11945#discussion_r57455467 --- Diff: python/pyspark/ml/util.py --- @@ -134,13 +134,15 @@ class MLWritable(object): .. versionadded:: 2.0.0 """ +@prope

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57455299 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -117,6 +123,66 @@ private[sql] class DefaultSource extends FileFor

[GitHub] spark pull request: [SPARK-14071][PySpark][ML]Change MLWritable.wr...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11945#issuecomment-201332626 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13664][SQL] Add a strategy for planning...

2016-03-25 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/11646#discussion_r57454374 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -0,0 +1,202 @@ +/* + * Licensed to th

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201332833 **[Test build #54183 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54183/consoleFull)** for PR 11936 at commit [`a26973e`](https://gi

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201332718 Just realized the problem while washing dishes... The above comment is a false alarm. The real problem is that I ignored start position and length of the `Par

[GitHub] spark pull request: [SPARK-14071][PySpark][ML]Change MLWritable.wr...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11945#issuecomment-201332624 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14071][PySpark][ML]Change MLWritable.wr...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11945#issuecomment-201332513 **[Test build #54181 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54181/consoleFull)** for PR 11945 at commit [`cf02cf8`](https://g

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201332139 **[Test build #54182 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54182/consoleFull)** for PR 11936 at commit [`2cbb56d`](https://g

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201332145 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201332143 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201331875 **[Test build #54182 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54182/consoleFull)** for PR 11936 at commit [`2cbb56d`](https://gi

<    1   2   3   4   5   6   7   >