[GitHub] spark pull request: [SPARK-14372] [SQL] : Dataset.randomSplit() ne...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12184#issuecomment-206007445 **[Test build #55029 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55029/consoleFull)** for PR 12184 at commit

[GitHub] spark pull request: [SPARK-14372] [SQL] : Dataset.randomSplit() ne...

2016-04-05 Thread rekhajoshm
GitHub user rekhajoshm opened a pull request: https://github.com/apache/spark/pull/12184 [SPARK-14372] [SQL] : Dataset.randomSplit() needs a Java version ## What changes were proposed in this pull request? 1.Added method randomSplitAsList() in Dataset for java ##

[GitHub] spark pull request: [SPARK-14296][SQL] whole stage codegen support...

2016-04-05 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12087#discussion_r58622864 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala --- @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12121#discussion_r58622715 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -292,11 +357,53 @@ case class AlterTableSetFileFormat(

[GitHub] spark pull request: [SPARK-13048][ML][MLLIB] keepLastCheckpoint op...

2016-04-05 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12166#issuecomment-206006902 This change looks good to me pending tests/MiMa & possibly user verification - we should also either add a follow up JIRA for the Python API or add it in this PR.

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-206005487 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14411][SQL]Add a note to warn that onQu...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12180#issuecomment-206005690 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-206005390 **[Test build #55002 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55002/consoleFull)** for PR 12171 at commit

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-206005481 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14411][SQL]Add a note to warn that onQu...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12180#issuecomment-206005685 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14411][SQL]Add a note to warn that onQu...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12180#issuecomment-206005141 **[Test build #55018 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55018/consoleFull)** for PR 12180 at commit

[GitHub] spark pull request: [SPARK-14410] [SQL] : SessionCatalog needs to ...

2016-04-05 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12183#issuecomment-206004627 @rekhajoshm Thank you for working on this! I think there are other methods in SessionCatalog that handle an existing table/db/function that do not check the existence of

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-206004514 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-206004520 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-206004093 **[Test build #55015 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55015/consoleFull)** for PR 12156 at commit

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13929] Use Scala reflection for UDTs

2016-04-05 Thread joan38
Github user joan38 commented on a diff in the pull request: https://github.com/apache/spark/pull/12149#discussion_r58621915 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala --- @@ -81,9 +81,43 @@ case class MultipleConstructorsData(a:

[GitHub] spark pull request: [SPARK-10387][ML] Add code gen for gbt

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9524#issuecomment-206002113 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10387][ML] Add code gen for gbt

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9524#issuecomment-206002116 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10387][ML] Add code gen for gbt

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9524#issuecomment-206001889 **[Test build #55016 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55016/consoleFull)** for PR 9524 at commit

[GitHub] spark pull request: [SPARK-13430][PySpark][ML] Python API for trai...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11621#issuecomment-206001580 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13430][PySpark][ML] Python API for trai...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11621#issuecomment-206001577 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206001541 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206001545 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14410] [SQL] : SessionCatalog needs to ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12183#issuecomment-205999728 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205999807 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14410] [SQL] : SessionCatalog needs to ...

2016-04-05 Thread rekhajoshm
GitHub user rekhajoshm opened a pull request: https://github.com/apache/spark/pull/12183 [SPARK-14410] [SQL] : SessionCatalog needs to check database/table/function existence ## What changes were proposed in this pull request? 1.Check for existence of Function in catalog,

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12121#issuecomment-205997358 Seems "Checking for ability to automatically merge…" is taking a long time. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12121#issuecomment-205996108 LGTM. Just have one comment for altering the location of a partition. But, we can address that in a follow-up PR. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [WIP][SPARK-14394][SQL] Generate AggregateHash...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-205995990 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [WIP][SPARK-14394][SQL] Generate AggregateHash...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-205995991 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14320][SQL] Make ColumnarBatch.Row muta...

2016-04-05 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/12103#discussion_r58618637 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java --- @@ -232,6 +234,96 @@ public MapData getMap(int

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12121#discussion_r58618530 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -292,11 +357,53 @@ case class AlterTableSetFileFormat(

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12121#discussion_r58618579 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -292,11 +357,53 @@ case class AlterTableSetFileFormat(

[GitHub] spark pull request: [SPARK-12785][SQL] Add ColumnarBatch, an in me...

2016-04-05 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/10628#issuecomment-205993243 I don't think it should be needed for OnHeap (it uses Platform.getInt which I think should work for both). For offheap, as far as I know, only a few of the puts that

[GitHub] spark pull request: [SPARK-13112]CoarsedExecutorBackend register t...

2016-04-05 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/12078#discussion_r58617810 --- Diff: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala --- @@ -41,7 +41,8 @@ private[spark] class

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12121#issuecomment-205991505 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12121#issuecomment-205991503 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14320][SQL] Make ColumnarBatch.Row muta...

2016-04-05 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/12103#issuecomment-205991469 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-14320][SQL] Make ColumnarBatch.Row muta...

2016-04-05 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/12103#discussion_r58617460 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java --- @@ -232,6 +234,96 @@ public MapData getMap(int ordinal) {

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12121#issuecomment-205991229 **[Test build #55011 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55011/consoleFull)** for PR 12121 at commit

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12169#discussion_r58616584 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -553,9 +553,13 @@ class SparkSqlAstBuilder extends

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-205988320 Please do not delete JavaDeveloperApiExample.java AFAIK, this is the only code example we have for Java developers who want to build custom ML pipelines. --- If

[GitHub] spark pull request: [SPARK-13211] [STREAMING] StreamingContext thr...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12174#issuecomment-205988357 **[Test build #55023 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55023/consoleFull)** for PR 12174 at commit

[GitHub] spark pull request: [SPARK-13211] [STREAMING] StreamingContext thr...

2016-04-05 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/12174#issuecomment-205987308 LGTM pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13211] [STREAMING] StreamingContext thr...

2016-04-05 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/12174#issuecomment-205987295 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14359] Unit tests for java 8 lambda syn...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12181#issuecomment-205987176 **[Test build #55022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55022/consoleFull)** for PR 12181 at commit

[GitHub] spark pull request: [SPARK-14359] Unit tests for java 8 lambda syn...

2016-04-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12181#issuecomment-205986809 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6717][ML] Clear shuffle files after che...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11919#issuecomment-205986042 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-6717][ML] Clear shuffle files after che...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11919#issuecomment-205986044 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14359] Unit tests for java 8 lambda syn...

2016-04-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12181#issuecomment-205985264 ``` [warn] Java 8 tests will not run because JDK version is < 1.8. ``` I think that the default PR builder might still be running Java 7 because my

[GitHub] spark pull request: [SPARK-14234] [CORE] Executor crashes for Task...

2016-04-05 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/12031#discussion_r58614159 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -315,14 +326,23 @@ private[spark] class Executor( } catch {

[GitHub] spark pull request: [SPARK-14234] [CORE] Executor crashes for Task...

2016-04-05 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/12031#discussion_r58613975 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -191,10 +194,18 @@ private[spark] class Executor( logInfo(s"Executor

[GitHub] spark pull request: [SPARK-14369][SQL][test-hadoop2.2] Locality su...

2016-04-05 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12153#discussion_r58613973 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -205,4 +210,20 @@ private[sql] object

[GitHub] spark pull request: [SPARK-14234] [CORE] Executor crashes for Task...

2016-04-05 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/12031#discussion_r58613857 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -178,6 +178,9 @@ private[spark] class Executor( /** Whether this task

[GitHub] spark pull request: [SPARK-14369][SQL][test-hadoop2.2] Locality su...

2016-04-05 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12153#discussion_r58613895 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -137,10 +140,12 @@ private[sql] object

[GitHub] spark pull request: use https while downloading binaries

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12182#issuecomment-205983611 **[Test build #55020 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55020/consoleFull)** for PR 12182 at commit

[GitHub] spark pull request: use https while downloading binaries

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12182#issuecomment-205982806 **[Test build #55019 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55019/consoleFull)** for PR 12182 at commit

[GitHub] spark pull request: use https while downloading binaries

2016-04-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12182#issuecomment-205982721 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: use https while downloading binaries

2016-04-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12182#issuecomment-205982625 The change itself LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14407][SQL] Hides HadoopFsRelation rela...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12178#issuecomment-205982437 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14407][SQL] Hides HadoopFsRelation rela...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12178#issuecomment-205982422 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: use https while downloading binaries

2016-04-05 Thread infynyxx
Github user infynyxx commented on the pull request: https://github.com/apache/spark/pull/12182#issuecomment-205982310 @hvanhovell I didn't create JIRA ticket because as per [Contributing Guide](https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark) creating JIRA

[GitHub] spark pull request: [SPARK-14407][SQL] Hides HadoopFsRelation rela...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12178#issuecomment-205982150 **[Test build #55004 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55004/consoleFull)** for PR 12178 at commit

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/12020#issuecomment-205981531 Thanks @holdenk and @jkbradley, I'll fix them soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-14369][SQL][test-hadoop2.2] Locality su...

2016-04-05 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12153#discussion_r58612163 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala --- @@ -86,4 +87,8 @@ class FileScanRDD( }

[GitHub] spark pull request: [SPARK-14369][SQL][test-hadoop2.2] Locality su...

2016-04-05 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12153#discussion_r58611815 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -620,17 +621,28 @@ class HDFSFileCatalog( if (paths.length >=

[GitHub] spark pull request: [SPARK-14352][SQL] approxQuantile should suppo...

2016-04-05 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12135#issuecomment-205980533 So if we are going to add this - it might make sense to also add the Python API at the same time (or at least create a JIRA to track adding this to the Python API so

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: use https while downloading binaries

2016-04-05 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/12182#issuecomment-205979054 @infynyxx could you add a JIRA ticket and create a ticket like `[SPARK-][BUILD] use https while downloading binaries` (see the titles of other PRs). --- If

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-05 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-205978731 Awesome :) A few minor things found while reviewing: One thing I noticed while looking at the differences between the code we are deleting and the code we are

[GitHub] spark pull request: use https while downloading binaries

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12182#issuecomment-205978561 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14411][SQL]Add a note to warn that onQu...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12180#issuecomment-205978659 **[Test build #55018 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55018/consoleFull)** for PR 12180 at commit

[GitHub] spark pull request: [SPARK-14402][SQL] initcap UDF doesn't match H...

2016-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12175 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Tr...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9207#issuecomment-205978313 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13048][ML][MLLIB] keepLastCheckpoint op...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12166#issuecomment-205978307 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Tr...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9207#issuecomment-205978292 **[Test build #55017 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55017/consoleFull)** for PR 9207 at commit

[GitHub] spark pull request: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Tr...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9207#issuecomment-205978315 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13048][ML][MLLIB] keepLastCheckpoint op...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12166#issuecomment-205978310 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/12171#discussion_r58610193 --- Diff: pom.xml --- @@ -840,14 +827,13 @@ org.apache.avro avro-mapred ${avro.version} +

[GitHub] spark pull request: [SPARK-13048][ML][MLLIB] keepLastCheckpoint op...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12166#issuecomment-205978280 **[Test build #55013 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55013/consoleFull)** for PR 12166 at commit

[GitHub] spark pull request: [SPARK-14402][SQL] initcap UDF doesn't match H...

2016-04-05 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/12175#issuecomment-205978170 Thanks, merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14411][SQL]Add a note to warn that onQu...

2016-04-05 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/12180#issuecomment-205978037 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14402][SQL] initcap UDF doesn't match H...

2016-04-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12175#issuecomment-205977980 Finally, I passed the Jenkins with the updated code. Please let me know if there is something I missed. Thank you, @marmbrus and @srowen . --- If your

[GitHub] spark pull request: use https while downloading binaries

2016-04-05 Thread infynyxx
GitHub user infynyxx opened a pull request: https://github.com/apache/spark/pull/12182 use https while downloading binaries ## What changes were proposed in this pull request? `./build/mvn` file was downloading binaries in non HTTPS mode. This PR tends to fix it.

[GitHub] spark pull request: [SPARK-529] [sql] Modify SQLConf to use new co...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11570#issuecomment-205977677 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-529] [sql] Modify SQLConf to use new co...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11570#issuecomment-205977671 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-529] [sql] Modify SQLConf to use new co...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11570#issuecomment-205977250 **[Test build #55003 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55003/consoleFull)** for PR 11570 at commit

[GitHub] spark pull request: [SPARK-14411][SQL]Add a note to warn that onQu...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12180#issuecomment-205976944 **[Test build #55012 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55012/consoleFull)** for PR 12180 at commit

[GitHub] spark pull request: [SPARK-14411][SQL]Add a note to warn that onQu...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12180#issuecomment-205976976 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14411][SQL]Add a note to warn that onQu...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12180#issuecomment-205976978 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [MINOR][MLLIB] Public visibility for eval metr...

2016-04-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11219#issuecomment-205975994 I don't think this should be public. If this is needed for the DataFrame-based API, then we should discuss providing the evaluation metric classes within the

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-205975799 **[Test build #55015 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55015/consoleFull)** for PR 12156 at commit

[GitHub] spark pull request: [SPARK-10387][ML] Add code gen for gbt

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9524#issuecomment-205975829 **[Test build #55016 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55016/consoleFull)** for PR 9524 at commit

[GitHub] spark pull request: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Tr...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9207#issuecomment-205975808 **[Test build #55017 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55017/consoleFull)** for PR 9207 at commit

[GitHub] spark pull request: [SPARK-14359] Unit tests for java 8 lambda syn...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12181#issuecomment-205975784 **[Test build #55014 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55014/consoleFull)** for PR 12181 at commit

[GitHub] spark pull request: [SPARK-14411][SQL]Add a note to warn that onQu...

2016-04-05 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/12180#issuecomment-205975113 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-14359] Unit tests for java 8 lambda syn...

2016-04-05 Thread ericl
GitHub user ericl opened a pull request: https://github.com/apache/spark/pull/12181 [SPARK-14359] Unit tests for java 8 lambda syntax with typed aggregates ## What changes were proposed in this pull request? Adds unit tests for java 8 lambda syntax with typed aggregates as

[GitHub] spark pull request: [SPARK-14359] Unit tests for java 8 lambda syn...

2016-04-05 Thread ericl
Github user ericl commented on the pull request: https://github.com/apache/spark/pull/12181#issuecomment-205974560 @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205974356 LGTM, merging this into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

<    1   2   3   4   5   6   7   8   9   10   >