[GitHub] spark pull request: [SPARK-15205][SQL] Codegen can compile the sam...

2016-05-17 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-219932274 @sarutak It's expected to compile twice on two different queries, it does not worth to optimize this corner case (ideally it should generate different source code even

[GitHub] spark pull request: [SPARK-15165][SQL] Codegen can break because t...

2016-05-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12939#issuecomment-219931861 We can just expand the whitelist and add * + and such into that can't we? My main worry is that security is very difficult to get right, and having a whitelist

[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...

2016-05-17 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-219931535 cc @andrewor14 @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-219931477 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15165][SQL] Codegen can break because t...

2016-05-17 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/12939#issuecomment-219931480 Lots of punctuation characters like `*`, `+` can be used as an operator in expressions so I'm afraid comments in generated code will be difficult to read if characters

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-219931474 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-219931325 **[Test build #58740 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58740/consoleFull)** for PR 13156 at commit

[GitHub] spark pull request: [SPARK-15205][SQL][WIP] Codegen can compile th...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-219930465 **[Test build #58746 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58746/consoleFull)** for PR 12979 at commit

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-17 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13156#discussion_r63647706 --- Diff: sql/hivecontext-compatibility/src/test/scala/org/apache/spark/sql/hive/HiveContextCompatibilitySuite.scala --- @@ -99,4 +105,41 @@ class

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-219929255 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-219929253 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-219929172 **[Test build #58741 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58741/consoleFull)** for PR 13008 at commit

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13129#issuecomment-219928497 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13129#issuecomment-219928428 **[Test build #58744 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58744/consoleFull)** for PR 13129 at commit

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13129#issuecomment-219928499 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13156#discussion_r63646713 --- Diff: sql/hivecontext-compatibility/src/test/scala/org/apache/spark/sql/hive/HiveContextCompatibilitySuite.scala --- @@ -99,4 +105,41 @@ class

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219927964 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219927902 **[Test build #58743 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58743/consoleFull)** for PR 13148 at commit

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219927963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15075] [SQL] Cleanup dependencies betwe...

2016-05-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13102#issuecomment-219927672 Sorry this is not what I meant in the JIRA ticket. What I meant was that we should just save SparkSessions, and then SQLContext calls into that. I didn't mean to

[GitHub] spark pull request: [SPARK-15075] [SQL] Cleanup dependencies betwe...

2016-05-17 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/13102#issuecomment-219927191 cc @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13135#issuecomment-219926751 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13135#issuecomment-219926703 **[Test build #58745 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58745/consoleFull)** for PR 13135 at commit

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13135#issuecomment-219926748 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13129#issuecomment-219926099 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13129#issuecomment-219926097 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13129#issuecomment-219926031 **[Test build #58742 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58742/consoleFull)** for PR 13129 at commit

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13135#issuecomment-219925856 **[Test build #58745 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58745/consoleFull)** for PR 13135 at commit

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13135#discussion_r63644923 --- Diff: examples/src/main/python/ml/simple_params_example.py --- @@ -36,18 +35,20 @@ if len(sys.argv) > 1: --- End diff -- Thank

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-17 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/12836#issuecomment-219925061 I mean is it too simple to allow grouping by columns only - what if after grouped by columns the dataset is too large to fit in memory? What if we are to

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13129#issuecomment-219924209 **[Test build #58744 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58744/consoleFull)** for PR 13129 at commit

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219923723 **[Test build #58743 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58743/consoleFull)** for PR 13148 at commit

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-17 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13156#discussion_r63644169 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala --- @@ -622,7 +622,7 @@ class MetastoreDataSourcesSuite

[GitHub] spark pull request: [SPARK-15375][SQL][Streaming] Add ConsoleSink ...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13162#issuecomment-219922682 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15375][SQL][Streaming] Add ConsoleSink ...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13162#issuecomment-219922683 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15375][SQL][Streaming] Add ConsoleSink ...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13162#issuecomment-219922548 **[Test build #58738 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58738/consoleFull)** for PR 13162 at commit

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219922327 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/13135#discussion_r63643565 --- Diff: examples/src/main/python/ml/simple_params_example.py --- @@ -36,18 +35,20 @@ if len(sys.argv) > 1: --- End diff -- We're

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219922326 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-21990 **[Test build #58736 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58736/consoleFull)** for PR 13161 at commit

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13129#issuecomment-219922177 **[Test build #58742 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58742/consoleFull)** for PR 13129 at commit

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/13135#issuecomment-219922114 @HyukjinKwon ah right, of course. I forgot the params get set during `fit` in Python. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-17 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13156#discussion_r63643173 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala --- @@ -622,7 +622,7 @@ class MetastoreDataSourcesSuite extends

[GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs and c...

2016-05-17 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13129#discussion_r63643069 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -252,7 +250,7 @@ class LinearRegression @Since("1.3.0")

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219921050 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219921049 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219920955 **[Test build #58735 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58735/consoleFull)** for PR 13161 at commit

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-219920209 **[Test build #58741 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58741/consoleFull)** for PR 13008 at commit

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-219918792 **[Test build #58740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58740/consoleFull)** for PR 13156 at commit

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13127#issuecomment-219918387 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13127#issuecomment-219918389 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13127#issuecomment-219918386 **[Test build #58739 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58739/consoleFull)** for PR 13127 at commit

[GitHub] spark pull request: [SPARK-15334][SQL] HiveClient facade not compa...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13127#issuecomment-219918225 **[Test build #58739 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58739/consoleFull)** for PR 13127 at commit

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13135#discussion_r63640828 --- Diff: examples/src/main/python/ml/simple_params_example.py --- @@ -36,18 +35,20 @@ if len(sys.argv) > 1: --- End diff --

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13135#discussion_r63640687 --- Diff: examples/src/main/python/ml/simple_params_example.py --- @@ -36,18 +35,20 @@ if len(sys.argv) > 1: --- End diff -- I

[GitHub] spark pull request: [SPARK-15296][MLlib] Refactor All Java Tests t...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13101#issuecomment-219915352 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15296][MLlib] Refactor All Java Tests t...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13101#issuecomment-219915350 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15296][MLlib] Refactor All Java Tests t...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13101#issuecomment-219915297 **[Test build #58737 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58737/consoleFull)** for PR 13101 at commit

[GitHub] spark pull request: [SPARK-13081][PYSPARK][SPARK_SUBMIT]. Allow se...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13146#issuecomment-219914887 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13081][PYSPARK][SPARK_SUBMIT]. Allow se...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13146#issuecomment-219914888 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13081][PYSPARK][SPARK_SUBMIT]. Allow se...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13146#issuecomment-219914744 **[Test build #58732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58732/consoleFull)** for PR 13146 at commit

[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...

2016-05-17 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/13134#issuecomment-219914749 cc @davies Please take a look, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15375][SQL][Streaming] Add ConsoleSink ...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13162#issuecomment-219914340 **[Test build #58738 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58738/consoleFull)** for PR 13162 at commit

[GitHub] spark pull request: [SPARK-15375][SQL][Streaming] Add ConsoleSink ...

2016-05-17 Thread jerryshao
GitHub user jerryshao opened a pull request: https://github.com/apache/spark/pull/13162 [SPARK-15375][SQL][Streaming] Add ConsoleSink to structure streaming ## What changes were proposed in this pull request? Add ConsoleSink to structure streaming, user could use it to

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/13135#discussion_r63638842 --- Diff: examples/src/main/python/ml/simple_params_example.py --- @@ -36,18 +35,20 @@ if len(sys.argv) > 1: --- End diff -- This

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13135#discussion_r63638465 --- Diff: examples/src/main/python/ml/simple_params_example.py --- @@ -36,18 +35,20 @@ if len(sys.argv) > 1: --- End diff -- Hm..

[GitHub] spark pull request: [SPARK-8603] [sparkR] In windows, Incorrect fi...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/7025#discussion_r63638336 --- Diff: R/pkg/R/client.R --- @@ -42,6 +42,19 @@ determineSparkSubmitBin <- function() { } sparkSubmitBinName } +# R supports both

[GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...

2016-05-17 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/13135#discussion_r63638222 --- Diff: examples/src/main/python/ml/simple_params_example.py --- @@ -36,18 +35,20 @@ if len(sys.argv) > 1: --- End diff -- It

[GitHub] spark pull request: [SPARK-15345][SQL][PYSPARK]. SparkSession's co...

2016-05-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13160#issuecomment-219911211 logging a warning seems like a good idea! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15345][SQL][PYSPARK]. SparkSession's co...

2016-05-17 Thread zjffdu
Github user zjffdu commented on the pull request: https://github.com/apache/spark/pull/13160#issuecomment-219910757 Changing sql conf setting seems a better approach. Besides that some other setting in SparkSession#Build also won't take effect if there's already an existing

[GitHub] spark pull request: [SPARK-15296][MLlib] Refactor All Java Tests t...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13101#issuecomment-219910742 **[Test build #58737 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58737/consoleFull)** for PR 13101 at commit

[GitHub] spark pull request: [SPARK-14851] Support radix sort with nullable...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219910107 **[Test build #58736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58736/consoleFull)** for PR 13161 at commit

[GitHub] spark pull request: [SPARK-14851] Support radix sort with nullable...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219910188 (@ericl I see you set a component in JIRA. It would be nicer if the component is specified in the PR title as described in

[GitHub] spark pull request: [SPARK-14851] Support radix sort with nullable...

2016-05-17 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/13161#discussion_r63637597 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala --- @@ -64,49 +64,57 @@ case class SortOrder(child:

[GitHub] spark pull request: [SPARK-15345][SQL][PYSPARK]. SparkSession's co...

2016-05-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13160#issuecomment-219909680 hm I don't think it is safe to create two contexts and stop the existing one. Maybe we can go ahead and change the sql conf setting, but not the spark context setting?

[GitHub] spark pull request: [DOC][MINOR] ml.feature Scala and Python API s...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13159#discussion_r63637481 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/VectorIndexer.scala --- @@ -240,7 +240,8 @@ object VectorIndexer extends

[GitHub] spark pull request: [DOC][MINOR] ml.feature Scala and Python API s...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13159#discussion_r63637490 --- Diff: python/pyspark/ml/feature.py --- @@ -2401,7 +2413,7 @@ class PCAModel(JavaModel, JavaMLReadable, JavaMLWritable): """ ..

[GitHub] spark pull request: [DOC][MINOR] ml.feature Scala and Python API s...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13159#discussion_r63637479 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/PCA.scala --- @@ -106,7 +107,7 @@ object PCA extends DefaultParamsReadable[PCA] {

[GitHub] spark pull request: [SPARK-15345][SQL][PYSPARK]. SparkSession's co...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13160#issuecomment-219909346 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15171][SQL] Remove the references to de...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13098#issuecomment-219909361 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15345][SQL][PYSPARK]. SparkSession's co...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13160#issuecomment-219909350 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15171][SQL] Remove the references to de...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13098#issuecomment-219909359 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15345][SQL][PYSPARK]. SparkSession's co...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13160#issuecomment-219909325 **[Test build #58734 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58734/consoleFull)** for PR 13160 at commit

[GitHub] spark pull request: [SPARK-15171][SQL] Remove the references to de...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13098#issuecomment-219909236 **[Test build #58731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58731/consoleFull)** for PR 13098 at commit

[GitHub] spark pull request: [SPARK-14851] Support radix sort with nullable...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13161#discussion_r63637193 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala --- @@ -64,49 +64,57 @@ case class SortOrder(child:

[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-219909074 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-219909077 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15165][SQL] Codegen can break because t...

2016-05-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12939#issuecomment-219908934 Just remove the character. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-219908945 **[Test build #58729 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58729/consoleFull)** for PR 13158 at commit

[GitHub] spark pull request: [SPARK-14851] Support radix sort with nullable...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219908862 **[Test build #58735 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58735/consoleFull)** for PR 13161 at commit

[GitHub] spark pull request: [SPARK-15353] [CORE] Making peer selection for...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13152#discussion_r63636922 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1079,109 +1103,97 @@ private[spark] class BlockManager( }

[GitHub] spark pull request: [SPARK-14851] Support radix sort with nullable...

2016-05-17 Thread ericl
GitHub user ericl opened a pull request: https://github.com/apache/spark/pull/13161 [SPARK-14851] Support radix sort with nullable longs ## What changes were proposed in this pull request? This adds support for radix sort of nullable long fields. When a sort field is null

[GitHub] spark pull request: [SPARK-15345][SQL][PYSPARK]. SparkSession's co...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13160#issuecomment-219908222 **[Test build #58734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58734/consoleFull)** for PR 13160 at commit

[GitHub] spark pull request: [SPARK-15353] [CORE] Making peer selection for...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13152#discussion_r63636534 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1079,109 +1103,97 @@ private[spark] class BlockManager( }

[GitHub] spark pull request: [SPARK-15345][SQL][PYSPARK]. SparkSession's co...

2016-05-17 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/spark/pull/13160 [SPARK-15345][SQL][PYSPARK]. SparkSession's conf doesn't take effect when this already an existing SparkContext ## What changes were proposed in this pull request? Override the existing

[GitHub] spark pull request: [SPARK-15171][SQL] Remove the references to de...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13098#issuecomment-219907870 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15171][SQL] Remove the references to de...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13098#issuecomment-219907867 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15353] [CORE] Making peer selection for...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13152#discussion_r63636491 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1079,109 +1103,97 @@ private[spark] class BlockManager( }

[GitHub] spark pull request: [SPARK-15353] [CORE] Making peer selection for...

2016-05-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13152#discussion_r63636461 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1079,109 +1103,97 @@ private[spark] class BlockManager( }

[GitHub] spark pull request: [SPARK-15171][SQL] Remove the references to de...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13098#issuecomment-219907748 **[Test build #58730 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58730/consoleFull)** for PR 13098 at commit

  1   2   3   4   5   6   >