[GitHub] spark pull request: [SPARK-15646] [SQL] When spark.sql.hive.convertCTAS is t...

2016-05-31 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13386 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [SPARK-15663] SparkSession.catalog.listFunctions shouldn...

2016-05-31 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/13413 @rxin Sure, will keep in mind next time. Will filtering out non temp functions work in this case ? ```scala val loadedFunctions = StringUtils.filterPattern(functionRegistry.listFun

[GitHub] spark pull request: [SPARK-14507] [SQL] EXTERNAL keyword in a CTAS statement...

2016-05-31 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13395 uh, I see. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] spark pull request: [SPARK-14507] [SQL] EXTERNAL keyword in a CTAS statement...

2016-05-31 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13395 @gatorsmile Thanks. For partitioned by, it is in https://github.com/apache/spark/pull/13386. For clustered by, seems we do have test case in HiveDDLCommandSuite. --- If your project is set up

[GitHub] spark pull request: [SPARK-15667][SQL]Throw exception if columns number of o...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13409 **[Test build #59659 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59659/consoleFull)** for PR 13409 at commit [`c46e5d0`](https://github.com/apache/spark/c

[GitHub] spark pull request: [SPARK-14507] [SQL] EXTERNAL keyword in a CTAS statement...

2016-05-31 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13395 Just realized you are working on all the restrictions of CTAS. Based on the [official document of Hive](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDD

[GitHub] spark pull request: [SPARK-15663] SparkSession.catalog.listFunctions shouldn...

2016-05-31 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13413 @techaddict in the future can you please think hard and think it through before you submit pull requests? If you have questions, feel free to leave them on the jira ticket. --- If your projec

[GitHub] spark pull request: [SPARK-15649] [SQL] Avoid to serialize MetastoreRelation...

2016-05-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13397 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

2016-05-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13406#discussion_r65215816 --- Diff: core/src/main/java/org/apache/spark/api/java/function/package.scala --- @@ -22,4 +22,4 @@ package org.apache.spark.api.java * these interfaces t

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

2016-05-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13406#discussion_r65215714 --- Diff: core/src/main/java/org/apache/spark/api/java/function/package.scala --- @@ -22,4 +22,4 @@ package org.apache.spark.api.java * these interfaces t

[GitHub] spark pull request: [SPARK-15663] SparkSession.catalog.listFunctions shouldn...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13413 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-15663] SparkSession.catalog.listFunctions shouldn...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13413 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59656/ Test FAILed.

[GitHub] spark pull request: [SPARK-15663] SparkSession.catalog.listFunctions shouldn...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13413 **[Test build #59656 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59656/consoleFull)** for PR 13413 at commit [`16f57eb`](https://github.com/apache/spark/

[GitHub] spark pull request: [SPARK-15649] [SQL] Avoid to serialize MetastoreRelation...

2016-05-31 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13397 Merging in master/2.0. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

2016-05-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13406#discussion_r65214361 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/catalog/interface.scala --- @@ -25,6 +25,14 @@ import org.apache.spark.sql.catalyst.DefinedByConstructor

[GitHub] spark pull request: [SPARK-15663] SparkSession.catalog.listFunctions shouldn...

2016-05-31 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13413 Yea this won't work unfortunately. On Tuesday, May 31, 2016, Takeshi Yamamuro wrote: > I'm afraid this fix couldn't satisfies @rxin > intention; it

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() on DataFra...

2016-05-31 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/12836 @NarineK, thanks. I will take a final round of look soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs and API ...

2016-05-31 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/13394 Thanks @vectorijk - I created https://issues.apache.org/jira/browse/SPARK-15672 for that --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in OptimizeCodege...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13392 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59654/ Test PASSed.

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in OptimizeCodege...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13392 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in OptimizeCodege...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13392 **[Test build #59654 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59654/consoleFull)** for PR 13392 at commit [`9830e31`](https://github.com/apache/spark/

[GitHub] spark pull request: [SPARK-13590] [ML] [Doc] Document spark.ml LiR, LoR and ...

2016-05-31 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/12731 ping @mengxr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request: [SPARK-15605] [ML] [Examples] Remove JavaDeveloperApiExa...

2016-05-31 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/13353 cc @mengxr @jkbradley --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request: [SPARK-15608][ml][doc] add_isotonic_regression_doc

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13381#discussion_r65207877 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaIsotonicRegressionExample.java --- @@ -0,0 +1,77 @@ +/* + * Licensed to the Apa

[GitHub] spark pull request: [SPARK-15608][ml][doc] add_isotonic_regression_doc

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13381#discussion_r65207910 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaIsotonicRegressionExample.java --- @@ -0,0 +1,77 @@ +/* + * Licensed to the Apa

[GitHub] spark pull request: [SPARK-15608][ml][doc] add_isotonic_regression_doc

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13381#discussion_r65207750 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaIsotonicRegressionExample.java --- @@ -0,0 +1,77 @@ +/* + * Licensed to the Apa

[GitHub] spark pull request: [SPARK-15608][ml][doc] add_isotonic_regression_doc

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13381#discussion_r65207828 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaIsotonicRegressionExample.java --- @@ -0,0 +1,77 @@ +/* + * Licensed to the Apa

[GitHub] spark pull request: [SPARK-15608][ml][doc] add_isotonic_regression_doc

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13381#discussion_r65207453 --- Diff: docs/ml-classification-regression.md --- @@ -685,6 +685,88 @@ The implementation matches the result from R's survival function

[GitHub] spark pull request: [SPARK-15608][ml][doc] add_isotonic_regression_doc

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13381#discussion_r65206624 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaIsotonicRegressionExample.java --- @@ -0,0 +1,77 @@ +/* + * Licensed to the Apa

[GitHub] spark pull request: [SPARK-15663] SparkSession.catalog.listFunctions shouldn...

2016-05-31 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/13413 I'm afraid this fix couldn't satisfies @rxin intention; it filters out not only built-in, but also user-defined temp funcs? --- If your project is set up for it, you can reply to this email a

[GitHub] spark pull request: [SPARK-15608][ml][doc] add_isotonic_regression_doc

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13381#discussion_r65206320 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/IsotonicRegressionExample.scala --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apach

[GitHub] spark pull request: [SPARK-15622] [SQL] Wrap the parent classloader of Janin...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13366 **[Test build #59657 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59657/consoleFull)** for PR 13366 at commit [`a539fae`](https://github.com/apache/spark/c

[GitHub] spark pull request: [SPARK-15663] SparkSession.catalog.listFunctions shouldn...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13413 **[Test build #59656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59656/consoleFull)** for PR 13413 at commit [`16f57eb`](https://github.com/apache/spark/c

[GitHub] spark pull request: [SPARK-15608][ml][doc] add_isotonic_regression_doc

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13381#discussion_r65206116 --- Diff: examples/src/main/python/ml/isotonic_regression_example.py --- @@ -0,0 +1,51 @@ +# +# Licensed to the Apache Software Foundation (ASF) un

[GitHub] spark pull request: [SQL] Prevent illegal NULL propagation when filtering ou...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13290 **[Test build #59658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59658/consoleFull)** for PR 13290 at commit [`127024d`](https://github.com/apache/spark/c

[GitHub] spark pull request: [SPARK-15608][ml][doc] add_isotonic_regression_doc

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13381#discussion_r65204603 --- Diff: examples/src/main/python/ml/isotonic_regression_example.py --- @@ -0,0 +1,51 @@ +# +# Licensed to the Apache Software Foundation (ASF) un

[GitHub] spark pull request: [SPARK-15608][ml][doc] add_isotonic_regression_doc

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13381#discussion_r65203447 --- Diff: examples/src/main/python/ml/isotonic_regression_example.py --- @@ -0,0 +1,51 @@ +# +# Licensed to the Apache Software Foundation (ASF) un

[GitHub] spark pull request: [SPARK-15663] SparkSession.catalog.listFunctions shouldn...

2016-05-31 Thread techaddict
GitHub user techaddict opened a pull request: https://github.com/apache/spark/pull/13413 [SPARK-15663] SparkSession.catalog.listFunctions shouldn't include the list of built-in functions ## What changes were proposed in this pull request? SparkSession.catalog.listFunctions curre

[GitHub] spark pull request: [SPARK-15608][ml][doc] add_isotonic_regression_doc

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13381#discussion_r65204158 --- Diff: examples/src/main/python/ml/isotonic_regression_example.py --- @@ -0,0 +1,51 @@ +# +# Licensed to the Apache Software Foundation (ASF) un

[GitHub] spark pull request: [SPARK-15622] [SQL] Wrap the parent classloader of Janin...

2016-05-31 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13366 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [SQL] Prevent illegal NULL propagation when filtering ou...

2016-05-31 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13290 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: [Spark-15129][R][DOC]R API changes in ML

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13285#discussion_r65202390 --- Diff: docs/sparkr.md --- @@ -285,71 +285,57 @@ head(teenagers) # Machine Learning -SparkR allows the fitting of generalized linear

[GitHub] spark pull request: [Spark-15129][R][DOC]R API changes in ML

2016-05-31 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/13285 @GayathriMurali 1, Please clear the change for ml-features.md which is irrelevant to this issue. 2, Please also include examples of other machine learning algorithms (spark.survre

[GitHub] spark pull request: [Spark-15129][R][DOC]R API changes in ML

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13285#discussion_r65201258 --- Diff: docs/sparkr.md --- @@ -285,71 +285,57 @@ head(teenagers) # Machine Learning -SparkR allows the fitting of generalized linear

[GitHub] spark pull request: [Spark-15129][R][DOC]R API changes in ML

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13285#discussion_r65200612 --- Diff: docs/sparkr.md --- @@ -285,71 +285,57 @@ head(teenagers) # Machine Learning -SparkR allows the fitting of generalized linear

[GitHub] spark pull request: [Spark-15129][R][DOC]R API changes in ML

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13285#discussion_r65199761 --- Diff: docs/sparkr.md --- @@ -285,71 +285,57 @@ head(teenagers) # Machine Learning -SparkR allows the fitting of generalized linear

[GitHub] spark pull request: [SPARK-15670][Java API][Spark Core]label_accumulator_dep...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13412 **[Test build #59655 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59655/consoleFull)** for PR 13412 at commit [`8761c52`](https://github.com/apache/spark/c

[GitHub] spark pull request: [SPARK-15670][Java API][Spark Core]label_accumulator_dep...

2016-05-31 Thread WeichenXu123
GitHub user WeichenXu123 opened a pull request: https://github.com/apache/spark/pull/13412 [SPARK-15670][Java API][Spark Core]label_accumulator_deprecate_in_java_spark_context ## What changes were proposed in this pull request? Add deprecate annotation for acumulator V1 int

[GitHub] spark pull request: [SPARK-15177] [SparkR] [ML] SparkR 2.0 QA: New R APIs an...

2016-05-31 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/13023 @vectorijk There is a separate PR focus on updating machine learning section of SparkR users guide. FYI #13285. Thanks. --- If your project is set up for it, you can reply to this email a

[GitHub] spark pull request: [SPARK-15667][SQL]Throw exception if columns number of o...

2016-05-31 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/13409#discussion_r65193655 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala --- @@ -1057,7 +1057,7 @@ class HiveQuerySuite extends HiveCo

[GitHub] spark pull request: [SPARK-15667][SQL]Throw exception if columns number of o...

2016-05-31 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/13409#discussion_r65193366 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala --- @@ -170,6 +170,13 @@ case class InsertIntoHiveTable(

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in OptimizeCodege...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13392 **[Test build #59654 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59654/consoleFull)** for PR 13392 at commit [`9830e31`](https://github.com/apache/spark/c

[GitHub] spark pull request: [SPARK-15587] [ML] ML 2.0 QA: Scala APIs audit for ml.fe...

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13410#discussion_r65192762 --- Diff: python/pyspark/ml/feature.py --- @@ -1481,6 +1474,10 @@ class StandardScaler(JavaEstimator, HasInputCol, HasOutputCol, JavaMLReadable, J

[GitHub] spark pull request: [SPARK-15587] [ML] ML 2.0 QA: Scala APIs audit for ml.fe...

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13410#discussion_r65192185 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala --- @@ -91,9 +91,6 @@ final class QuantileDiscretizer(override val ui

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in OptimizeCodege...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13392 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in OptimizeCodege...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13392 **[Test build #59653 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59653/consoleFull)** for PR 13392 at commit [`9830e31`](https://github.com/apache/spark/

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in OptimizeCodege...

2016-05-31 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13392 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] spark pull request: [SPARK-15587] [ML] ML 2.0 QA: Scala APIs audit for ml.fe...

2016-05-31 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13410#discussion_r65190848 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala --- @@ -114,7 +112,7 @@ private[feature] trait CountVectorizerParams exte

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in OptimizeCodege...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13392 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59653/ Test FAILed.

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in OptimizeCodege...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13392 **[Test build #59653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59653/consoleFull)** for PR 13392 at commit [`9830e31`](https://github.com/apache/spark/c

[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in OptimizeCodege...

2016-05-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13392#discussion_r65184085 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -937,8 +937,12 @@ object SimplifyConditionals extend

[GitHub] spark pull request: [SPARK-15668] [ML] ml.feature: update check schema to av...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13411 **[Test build #59652 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59652/consoleFull)** for PR 13411 at commit [`ee33d2e`](https://github.com/apache/spark/

[GitHub] spark pull request: [SPARK-15668] [ML] ml.feature: update check schema to av...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13411 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-15668] [ML] ml.feature: update check schema to av...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13411 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59652/ Test PASSed.

[GitHub] spark pull request: [SPARK-15665] [CORE] spark-submit --kill and --status ar...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13407 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59647/ Test PASSed.

[GitHub] spark pull request: [SPARK-15665] [CORE] spark-submit --kill and --status ar...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13407 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-15665] [CORE] spark-submit --kill and --status ar...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13407 **[Test build #59647 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59647/consoleFull)** for PR 13407 at commit [`62ebc7a`](https://github.com/apache/spark/

[GitHub] spark pull request: [SPARK-15587] [ML] ML 2.0 QA: Scala APIs audit for ml.fe...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13410 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59651/ Test PASSed.

[GitHub] spark pull request: [SPARK-15587] [ML] ML 2.0 QA: Scala APIs audit for ml.fe...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13410 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-15587] [ML] ML 2.0 QA: Scala APIs audit for ml.fe...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13410 **[Test build #59651 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59651/consoleFull)** for PR 13410 at commit [`570c333`](https://github.com/apache/spark/

[GitHub] spark pull request: [SPARK-15667][SQL]Throw exception if columns number of o...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13409 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-15667][SQL]Throw exception if columns number of o...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13409 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59650/ Test PASSed.

[GitHub] spark pull request: [SPARK-15667][SQL]Throw exception if columns number of o...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13409 **[Test build #59650 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59650/consoleFull)** for PR 13409 at commit [`ca269a4`](https://github.com/apache/spark/

[GitHub] spark pull request: [SPARK-15668] [ML] ml.feature: update check schema to av...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13411 **[Test build #59652 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59652/consoleFull)** for PR 13411 at commit [`ee33d2e`](https://github.com/apache/spark/c

[GitHub] spark pull request: [SPARK-15668] [ML] ml.feature: update check schema to av...

2016-05-31 Thread hhbyyh
GitHub user hhbyyh opened a pull request: https://github.com/apache/spark/pull/13411 [SPARK-15668] [ML] ml.feature: update check schema to avoid confusion when user use MLlib.vector as input type ## What changes were proposed in this pull request? ml.feature: update check s

[GitHub] spark pull request: [SPARK-15100][DOC] Modified user guide and examples for ...

2016-05-31 Thread oliverpierson
Github user oliverpierson commented on a diff in the pull request: https://github.com/apache/spark/pull/13176#discussion_r65173690 --- Diff: docs/ml-features.md --- @@ -145,9 +148,11 @@ for more details on the API. passed to other algorithms like LDA. During the fi

[GitHub] spark pull request: [SPARK-12978][SQL] Skip unnecessary final group-by when ...

2016-05-31 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/10896 Thank for you comments! I'll check them in a few days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15606][core] Use a minimum of 3 dispatcher thread...

2016-05-31 Thread robbinspg
Github user robbinspg commented on the pull request: https://github.com/apache/spark/pull/13355 @zsxwing Do you mean change BlockManagerMaster.removeExecutor to send the message using send (fire and forget) rather than askWithRetry? --- If your project is set up for it, you can rep

[GitHub] spark pull request: [SPARK-15528][SQL] Fix race condition in NumberConverter

2016-05-31 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13391 Merged to master/2.0/1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [SPARK-15528][SQL] Fix race condition in NumberConverter

2016-05-31 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/13391 thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request: [SPARK-15528][SQL] Fix race condition in NumberConverter

2016-05-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13391 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15660][CORE] RDD and Dataset should show the cons...

2016-05-31 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13403 Thank you for review, @srowen . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-15587] [ML] ML 2.0 QA: Scala APIs audit for ml.fe...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13410 **[Test build #59651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59651/consoleFull)** for PR 13410 at commit [`570c333`](https://github.com/apache/spark/c

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs and API ...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13394 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59648/ Test PASSed.

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs and API ...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13394 **[Test build #59648 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59648/consoleFull)** for PR 13394 at commit [`294cadd`](https://github.com/apache/spark/

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs and API ...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13394 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-15294][SPARKR][MINOR] Add pivot functionality to ...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13295 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-15294][SPARKR][MINOR] Add pivot functionality to ...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13295 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59649/ Test FAILed.

[GitHub] spark pull request: [SPARK-15294][SPARKR][MINOR] Add pivot functionality to ...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13295 **[Test build #59649 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59649/consoleFull)** for PR 13295 at commit [`f2b8d97`](https://github.com/apache/spark/

[GitHub] spark pull request: [SPARK-15587] [ML] ML 2.0 QA: Scala APIs audit for ml.fe...

2016-05-31 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/13410 [SPARK-15587] [ML] ML 2.0 QA: Scala APIs audit for ml.feature ## What changes were proposed in this pull request? ML 2.0 QA: Scala APIs audit for ml.feature. ## How was this patch te

[GitHub] spark pull request: [SPARK-15667][SQL]Throw exception if columns number of o...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13409 **[Test build #59650 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59650/consoleFull)** for PR 13409 at commit [`ca269a4`](https://github.com/apache/spark/c

[GitHub] spark pull request: [SPARK-15667][SQL]Throw exception if columns number of o...

2016-05-31 Thread WangTaoTheTonic
GitHub user WangTaoTheTonic opened a pull request: https://github.com/apache/spark/pull/13409 [SPARK-15667][SQL]Throw exception if columns number of outputs mismatch the inputs ## What changes were proposed in this pull request? We will throw exception if the columns number

[GitHub] spark pull request: [SPARK-15294][SPARKR][MINOR] Add pivot functionality to ...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13295 **[Test build #59649 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59649/consoleFull)** for PR 13295 at commit [`f2b8d97`](https://github.com/apache/spark/c

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs and API ...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13394 **[Test build #59648 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59648/consoleFull)** for PR 13394 at commit [`294cadd`](https://github.com/apache/spark/c

[GitHub] spark pull request: [Spark-14230][STREAMING] Config the start time (jitter) ...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12026 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: SPARK-15641 HistoryServer to not show invalid date for i...

2016-05-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13396 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: SPARK-15641 HistoryServer to not show invalid date for i...

2016-05-31 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13396 Merged to master/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] spark pull request: [SPARK-15660][CORE] RDD and Dataset should show the cons...

2016-05-31 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13403 Yeah I find this surprising too. As far as I know, databases tend to treat stddev as the sample stddev -- except Hive for some reason, AFAIK. I've never quite understood the theoretical motiva

[GitHub] spark pull request: [SPARK-15665] [CORE] spark-submit --kill and --status ar...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13407 **[Test build #59647 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59647/consoleFull)** for PR 13407 at commit [`62ebc7a`](https://github.com/apache/spark/c

[GitHub] spark pull request: [SPARK-15665] [CORE] spark-submit --kill and --status ar...

2016-05-31 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13407 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

<    2   3   4   5   6   7   8   >