Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13415#discussion_r65617809
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -880,6 +880,23 @@ class SparkSqlAstBuilder(conf: SQLConf) ext
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13447
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13447
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59865/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13447
**[Test build #59865 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59865/consoleFull)**
for PR 13447 at commit
[`be187d8`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13471
**[Test build #59874 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59874/consoleFull)**
for PR 13471 at commit
[`f94b909`](https://github.com/apache/spark/commit/f
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13453
LGTM, pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13451
@andrewor14 Could you please help sign off this one? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13456
**[Test build #59872 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59872/consoleFull)**
for PR 13456 at commit
[`b9d5f04`](https://github.com/apache/spark/commit/b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13447
**[Test build #59873 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59873/consoleFull)**
for PR 13447 at commit
[`bbaad66`](https://github.com/apache/spark/commit/b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13415
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59866/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13415
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user ericl commented on the issue:
https://github.com/apache/spark/pull/13456
@rxin updated with parquet variations
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13471#discussion_r65613435
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala
---
@@ -57,7 +57,13 @@ case class LocalRelation(outp
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13415
**[Test build #59866 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59866/consoleFull)**
for PR 13415 at commit
[`942366f`](https://github.com/apache/spark/commit/
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/13456#discussion_r65613378
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/WideSchemaBenchmark.scala
---
@@ -0,0 +1,285 @@
+/*
+ * Licensed to the Apa
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13453
**[Test build #59871 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59871/consoleFull)**
for PR 13453 at commit
[`6f69899`](https://github.com/apache/spark/commit/6
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13453#discussion_r65612716
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -779,18 +780,29 @@ private[hive] class HiveClientImpl(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13463#discussion_r65612485
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala
---
@@ -84,39 +84,12 @@ class ListingFileCatalog(
Github user GayathriMurali commented on the issue:
https://github.com/apache/spark/pull/13176
@MLnick Please let me know if there is anything else that I can help with
this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65612428
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <:
Tr
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13463#discussion_r65612284
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala
---
@@ -84,39 +84,12 @@ class ListingFileCatalog(
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/13471#discussion_r65612208
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/LocalTableScanExec.scala
---
@@ -48,6 +48,14 @@ private[sql] case class LocalTableScanExec
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13283
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65612128
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <:
Tr
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/13471#discussion_r65612007
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala
---
@@ -57,7 +57,13 @@ case class LocalRelation(outpu
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/13258
@lw-lin could you update this PR soon? Otherwise, we may not be able to
merge into 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13463#discussion_r65611847
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala
---
@@ -84,39 +84,12 @@ class ListingFileCatalog(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13070#discussion_r65611801
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -140,6 +170,32 @@ case class CatalogTable(
l
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13070#discussion_r65611638
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -65,8 +85,18 @@ case class CatalogColumn(
// a
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65611639
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <:
Tre
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13470
**[Test build #59870 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59870/consoleFull)**
for PR 13470 at commit
[`1466eb5`](https://github.com/apache/spark/commit/1
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65611456
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <:
Tre
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/13283
LGTM. Merging to master and 2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/13447
I think your concern is valid. Will add an `assert` in `InsertIntoTable`.
So far, dynamic partitioning is used by the `insertInto` API. However,
there is no way to specify `IF NOT EXISTS`
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13070#discussion_r65610890
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -48,7 +49,26 @@ case class CatalogStorageFormat(
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65610587
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <:
Tre
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65610289
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <:
Tr
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13051
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13051
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59864/
Test PASSed.
---
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13471
LGTM except for minor naming issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13471#discussion_r65609750
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/LocalTableScanExec.scala
---
@@ -48,6 +48,14 @@ private[sql] case class LocalTableScanExe
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13051
**[Test build #59864 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59864/consoleFull)**
for PR 13051 at commit
[`80d1e3e`](https://github.com/apache/spark/commit/
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13471#discussion_r65609589
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala
---
@@ -57,7 +57,13 @@ case class LocalRelation(outp
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13418#discussion_r65609442
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
---
@@ -123,6 +123,31 @@ class SubquerySuite extends QueryTest with
SharedSQLCo
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65609097
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <:
Tre
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13418#discussion_r65609083
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
---
@@ -123,6 +123,31 @@ class SubquerySuite extends QueryTest with
SharedSQLCo
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/13463
@cloud-fan Thanks! let me try that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13470
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65608809
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <:
Tr
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13470
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59861/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13470
**[Test build #59861 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59861/consoleFull)**
for PR 13470 at commit
[`47ea0eb`](https://github.com/apache/spark/commit/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65608399
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <:
Tr
Github user NarineK commented on the issue:
https://github.com/apache/spark/pull/12836
Thanks, sun-rui. Will look at it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13269
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13269
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59863/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13269
**[Test build #59863 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59863/consoleFull)**
for PR 13269 at commit
[`efa9616`](https://github.com/apache/spark/commit/
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13446
it will be great if we can come up with a test for it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65607416
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <:
Tre
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13446#discussion_r65607282
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TypedAggregateExpression.scala
---
@@ -34,6 +34,11 @@ object TypedAggregateExpr
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13407
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59862/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13407
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13407
**[Test build #59862 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59862/consoleFull)**
for PR 13407 at commit
[`30dfb0f`](https://github.com/apache/spark/commit/
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65606416
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <:
Tre
Github user ioana-delaney commented on the issue:
https://github.com/apache/spark/pull/13418
@cloud-fan I moved the unit tests to a new test case. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/13447
@gatorsmile the overall approach seems good to me. We are currently fixing
this for the SQL codepath. I was wondering if are other codepaths that can
cause this unwanted behavior? If there are th
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59860/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13469
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13469
**[Test build #59860 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59860/consoleFull)**
for PR 13469 at commit
[`de1eff6`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13077
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59857/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13077
**[Test build #59857 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59857/consoleFull)**
for PR 13077 at commit
[`ae85f81`](https://github.com/apache/spark/commit/
Github user inouehrs commented on the issue:
https://github.com/apache/spark/pull/13446
I fixed my typos.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user inouehrs commented on a diff in the pull request:
https://github.com/apache/spark/pull/13446#discussion_r65604802
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TypedAggregateExpression.scala
---
@@ -34,6 +34,11 @@ object TypedAggregateExpre
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65604769
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <:
Tr
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65604658
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <:
Tr
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13143
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13143
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59856/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13143
**[Test build #59856 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59856/consoleFull)**
for PR 13143 at commit
[`c16fb5f`](https://github.com/apache/spark/commit/
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13465
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/13446
Thanks - can you also update the title? TangstenAggregate ->
TungstenAggregate
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/13465
Merging in master/2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13470
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13470
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59859/
Test PASSed.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/13070
CC @clockfly @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13470
**[Test build #59859 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59859/consoleFull)**
for PR 13470 at commit
[`ec97fde`](https://github.com/apache/spark/commit/
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/13415
@cloud-fan Yeah. Agree. I knew you will say that. : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13472
**[Test build #59869 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59869/consoleFull)**
for PR 13472 at commit
[`27d1c28`](https://github.com/apache/spark/commit/2
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13471
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/13456#discussion_r65602557
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/WideSchemaBenchmark.scala
---
@@ -0,0 +1,285 @@
+/*
+ * Licensed to the Apa
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65602440
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <:
Tr
GitHub user ericl opened a pull request:
https://github.com/apache/spark/pull/13472
[SPARK-15735] Allow specifying min time to run in microbenchmarks
## What changes were proposed in this pull request?
This makes microbenchmarks run for at least 2 seconds by default, to allo
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65602110
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <:
Tr
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13470
**[Test build #59868 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59868/consoleFull)**
for PR 13470 at commit
[`17eef0f`](https://github.com/apache/spark/commit/1
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/13471
cc @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/13471
This depends on PR https://github.com/apache/spark/pull/13470
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13415#discussion_r65599775
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -880,6 +880,23 @@ class SparkSqlAstBuilder(conf: SQLConf) exte
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13471
**[Test build #59867 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59867/consoleFull)**
for PR 13471 at commit
[`2e679f7`](https://github.com/apache/spark/commit/2
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65600672
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <:
Tre
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13415
I'm thinking about case sensitivity, maybe we should put this check in
analyzer instead of parser?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13415#discussion_r65600341
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -880,6 +880,23 @@ class SparkSqlAstBuilder(conf: SQLConf) exte
401 - 500 of 770 matches
Mail list logo
