[GitHub] spark issue #13881: [SPARK-3723] [MLlib] Adding instrumentation to random fo...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13881 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61151/ Test PASSed. ---

[GitHub] spark issue #13881: [SPARK-3723] [MLlib] Adding instrumentation to random fo...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13881 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13881: [SPARK-3723] [MLlib] Adding instrumentation to random fo...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13881 **[Test build #61151 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61151/consoleFull)** for PR 13881 at commit

[GitHub] spark issue #13883: [SPARK-16179] [PYSPARK] fix bugs for Python udf in gener...

2016-06-23 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13883 Thanks - can you describe the bug in the pr description? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #13883: [SPARK-16179] [PYSPARK] fix bugs for Python udf in gener...

2016-06-23 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/13883 https://gist.github.com/vlad17/964c0a93510d79cb130c33700f6139b7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #13884: [SPARK-16181][SQL: outer join with isNull filter ...

2016-06-23 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13884#discussion_r68355286 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -688,6 +688,14 @@ object FoldablePropagation extends

[GitHub] spark pull request #13884: [SPARK-16181][SQL: outer join with isNull filter ...

2016-06-23 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13884#discussion_r68355194 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1541,4 +1541,13 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark issue #13883: [SPARK-16179] [PYSPARK] fix bugs for Python udf in gener...

2016-06-23 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13883 What is the bug? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #13881: [SPARK-3723] [MLlib] Adding instrumentation to random fo...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13881 **[Test build #61151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61151/consoleFull)** for PR 13881 at commit

[GitHub] spark issue #13881: [SPARK-3723] [MLlib] Adding instrumentation to random fo...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13881 **[Test build #61150 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61150/consoleFull)** for PR 13881 at commit

[GitHub] spark issue #13881: [SPARK-3723] [MLlib] Adding instrumentation to random fo...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13881 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61150/ Test FAILed. ---

[GitHub] spark issue #13881: [SPARK-3723] [MLlib] Adding instrumentation to random fo...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13881 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13881: [SPARK-3723] [MLlib] Adding instrumentation to random fo...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13881 **[Test build #61150 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61150/consoleFull)** for PR 13881 at commit

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce additonal implementation wi...

2016-06-23 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13680 having 2 implementations is also kind of a branch: the virtual function call need to be dispatched between these 2 implementations, while the only one implementation can be marked as final and

[GitHub] spark pull request #13701: [SPARK-15639][SQL] Try to push down filter at Row...

2016-06-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13701#discussion_r68353312 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -85,8 +85,15 @@ private[sql] object

[GitHub] spark issue #13844: [SPARK-16133][ML] model loading backward compatibility f...

2016-06-23 Thread mengxr
Github user mengxr commented on the issue: https://github.com/apache/spark/pull/13844 LGTM. Merged into master and branch-2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #13884: [SPARK-16181][SQL: outer join with isNull filter may ret...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13884 **[Test build #61149 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61149/consoleFull)** for PR 13884 at commit

[GitHub] spark pull request #13883: [SPARK-16179] [PYSPARK] fix bugs for Python udf i...

2016-06-23 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/13883 [SPARK-16179] [PYSPARK] fix bugs for Python udf in generate ## What changes were proposed in this pull request? This PR fix the bug when Python UDF is used in explode (generator),

[GitHub] spark issue #13844: [SPARK-16133][ML] model loading backward compatibility f...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13844 **[Test build #61145 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61145/consoleFull)** for PR 13844 at commit

[GitHub] spark pull request #13884: [SPARK-16181][SQL: outer join with isNull filter ...

2016-06-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13884#discussion_r68353553 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -688,6 +688,14 @@ object FoldablePropagation extends

[GitHub] spark pull request #13884: [SPARK-16181][SQL: outer join with isNull filter ...

2016-06-23 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/13884 [SPARK-16181][SQL: outer join with isNull filter may return wrong result ## What changes were proposed in this pull request? The root cause is: the output attributes of outer join are

[GitHub] spark issue #13701: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-06-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/13701 @yhuai As I mentioned in the description, I am not sure if we can manipulate row groups as we want, but I have manually tested it to show the actually scanned row numbers. --- If your project is

[GitHub] spark pull request #13844: [SPARK-16133][ML] model loading backward compatib...

2016-06-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13844 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13883: [SPARK-16179] [PYSPARK] fix bugs for Python udf in gener...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13883 **[Test build #61148 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61148/consoleFull)** for PR 13883 at commit

[GitHub] spark issue #13844: [SPARK-16133][ML] model loading backward compatibility f...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13844 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13844: [SPARK-16133][ML] model loading backward compatibility f...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13844 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61145/ Test PASSed. ---

[GitHub] spark issue #13701: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-06-23 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/13701 Thank you for the testing. Can you also test the case that a file contains multiple row groups and we can avoid of scanning unneeded ones? Also since it is not fixing a critical bug, let's

[GitHub] spark pull request #13877: [SPARK-16142] [R] group naiveBayes method docs in...

2016-06-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13877 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13877: [SPARK-16142] [R] group naiveBayes method docs in a sing...

2016-06-23 Thread mengxr
Github user mengxr commented on the issue: https://github.com/apache/spark/pull/13877 Merged into master and branch-2.0. Thanks for reviewing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #13881: [SPARK-3723] [MLlib] Adding instrumentation to random fo...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13881 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61144/ Test PASSed. ---

[GitHub] spark issue #13881: [SPARK-3723] [MLlib] Adding instrumentation to random fo...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13881 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13881: [SPARK-3723] [MLlib] Adding instrumentation to random fo...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13881 **[Test build #61144 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61144/consoleFull)** for PR 13881 at commit

[GitHub] spark pull request #13701: [SPARK-15639][SQL] Try to push down filter at Row...

2016-06-23 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13701#discussion_r68352913 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -85,8 +85,15 @@ private[sql] object

[GitHub] spark pull request #13701: [SPARK-15639][SQL] Try to push down filter at Row...

2016-06-23 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13701#discussion_r68352884 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -85,8 +85,15 @@ private[sql] object

[GitHub] spark issue #13865: [SPARK-13709][SQL] Initialize deserializer with both tab...

2016-06-23 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/13865 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #13701: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13701 **[Test build #61147 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61147/consoleFull)** for PR 13701 at commit

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce additonal implementation wi...

2016-06-23 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/13680 @cloud-fan , for the first issue, we are on the same page. Your proposal is what I am thinking about as possible solutions. I will do that. For the second issue, it seems to be design choice

[GitHub] spark issue #13865: [SPARK-13709][SQL] Initialize deserializer with both tab...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13865 **[Test build #61146 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61146/consoleFull)** for PR 13865 at commit

[GitHub] spark issue #13865: [SPARK-13709][SQL] Initialize deserializer with both tab...

2016-06-23 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13865 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #13701: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-06-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/13701 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #13877: [SPARK-16142] [R] group naiveBayes method docs in a sing...

2016-06-23 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/13877 The new document in the screenshot looks pretty good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #13865: [SPARK-13709][SQL] Initialize deserializer with b...

2016-06-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13865#discussion_r68352383 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/QueryPartitionSuite.scala --- @@ -65,4 +68,77 @@ class QueryPartitionSuite extends QueryTest

[GitHub] spark pull request #13865: [SPARK-13709][SQL] Initialize deserializer with b...

2016-06-23 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13865#discussion_r68352349 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/QueryPartitionSuite.scala --- @@ -65,4 +68,77 @@ class QueryPartitionSuite extends QueryTest

[GitHub] spark pull request #13865: [SPARK-13709][SQL] Initialize deserializer with b...

2016-06-23 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13865#discussion_r68352336 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/QueryPartitionSuite.scala --- @@ -65,4 +68,77 @@ class QueryPartitionSuite extends QueryTest with

[GitHub] spark pull request #13865: [SPARK-13709][SQL] Initialize deserializer with b...

2016-06-23 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13865#discussion_r68352322 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/QueryPartitionSuite.scala --- @@ -65,4 +68,77 @@ class QueryPartitionSuite extends QueryTest with

[GitHub] spark pull request #13865: [SPARK-13709][SQL] Initialize deserializer with b...

2016-06-23 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13865#discussion_r68352282 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/QueryPartitionSuite.scala --- @@ -65,4 +68,77 @@ class QueryPartitionSuite extends QueryTest with

[GitHub] spark pull request #13865: [SPARK-13709][SQL] Initialize deserializer with b...

2016-06-23 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13865#discussion_r68352258 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/QueryPartitionSuite.scala --- @@ -65,4 +68,77 @@ class QueryPartitionSuite extends QueryTest

[GitHub] spark issue #13701: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13701 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13701: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13701 **[Test build #61143 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61143/consoleFull)** for PR 13701 at commit

[GitHub] spark issue #13701: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13701 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61143/ Test FAILed. ---

[GitHub] spark pull request #13877: [SPARK-16142] [R] group naiveBayes method docs in...

2016-06-23 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/13877#discussion_r68352034 --- Diff: R/pkg/R/mllib.R --- @@ -390,23 +376,41 @@ setMethod("predict", signature(object = "KMeansModel"),

[GitHub] spark issue #13844: [SPARK-16133][ML] model loading backward compatibility f...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13844 **[Test build #61145 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61145/consoleFull)** for PR 13844 at commit

[GitHub] spark issue #13844: [SPARK-16133][ML] model loading backward compatibility f...

2016-06-23 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/13844 @mengxr Thanks for your review. Sent update for the style issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #13881: [SPARK-3723] [MLlib] Adding instrumentation to random fo...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13881 **[Test build #61144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61144/consoleFull)** for PR 13881 at commit

[GitHub] spark pull request #13844: [SPARK-16133][ML] model loading backward compatib...

2016-06-23 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/13844#discussion_r68350637 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinMaxScaler.scala --- @@ -232,7 +233,9 @@ object MinMaxScalerModel extends

[GitHub] spark issue #13881: [SPARK-3723] [MLlib] Adding instrumentation to random fo...

2016-06-23 Thread mengxr
Github user mengxr commented on the issue: https://github.com/apache/spark/pull/13881 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #13720: [SPARK-16004] [SQL] improve the display of CatalogTable ...

2016-06-23 Thread bomeng
Github user bomeng commented on the issue: https://github.com/apache/spark/pull/13720 ok, i will work on it based on comments. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #13879: [SPARK-16177] [ML] model loading backward compati...

2016-06-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13879 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #13844: [SPARK-16133][ML] model loading backward compatib...

2016-06-23 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/13844#discussion_r68350339 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinMaxScaler.scala --- @@ -232,7 +233,9 @@ object MinMaxScalerModel extends

[GitHub] spark issue #13879: [SPARK-16177] [ML] model loading backward compatibility ...

2016-06-23 Thread mengxr
Github user mengxr commented on the issue: https://github.com/apache/spark/pull/13879 LGTM. Merged into master and branch-2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #13701: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13701 **[Test build #61143 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61143/consoleFull)** for PR 13701 at commit

[GitHub] spark pull request #13874: [SQL][minor] ParserUtils.operationNotAllowed shou...

2016-06-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13874 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13874: [SQL][minor] ParserUtils.operationNotAllowed should thro...

2016-06-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/13874 LGTM - thanks! Merging to master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13701: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-06-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/13701 ping @liancheng @yhuai again... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #13874: [SQL][minor] ParserUtils.operationNotAllowed should thro...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13874 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61141/ Test PASSed. ---

[GitHub] spark issue #13874: [SQL][minor] ParserUtils.operationNotAllowed should thro...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13874 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13874: [SQL][minor] ParserUtils.operationNotAllowed should thro...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13874 **[Test build #61141 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61141/consoleFull)** for PR 13874 at commit

[GitHub] spark issue #13699: [SPARK-15958] Make initial buffer size for the Sorter co...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13699 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13699: [SPARK-15958] Make initial buffer size for the Sorter co...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13699 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61140/ Test PASSed. ---

[GitHub] spark issue #13699: [SPARK-15958] Make initial buffer size for the Sorter co...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13699 **[Test build #61140 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61140/consoleFull)** for PR 13699 at commit

[GitHub] spark issue #13130: [SPARK-15340][SQL]Limit the size of the map used to cach...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13130 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13130: [SPARK-15340][SQL]Limit the size of the map used to cach...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13130 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61142/ Test FAILed. ---

[GitHub] spark issue #13130: [SPARK-15340][SQL]Limit the size of the map used to cach...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13130 **[Test build #61142 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61142/consoleFull)** for PR 13130 at commit

[GitHub] spark issue #13778: [SPARK-16062][SPARK-15989][SQL] Fix two bugs of Python-o...

2016-06-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/13778 ping @vlad17 @davies @liancheng Any thing else? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #13130: [SPARK-15340][SQL]Limit the size of the map used to cach...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13130 **[Test build #61142 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61142/consoleFull)** for PR 13130 at commit

[GitHub] spark issue #13130: [SPARK-15340][SQL]Limit the size of the map used to cach...

2016-06-23 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13130 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #13786: [SPARK-15294][R] Add `pivot` to SparkR

2016-06-23 Thread Div333
Github user Div333 commented on the issue: https://github.com/apache/spark/pull/13786 Hello everyone, Thanks a lot for implementing the pivot functionality. I have started using SparkR recently and would like to know if the pivot method is included in the library as I don't find it

[GitHub] spark issue #12601: [SPARK-14525][SQL] Make DataFrameWrite.save work for jdb...

2016-06-23 Thread JustinPihony
Github user JustinPihony commented on the issue: https://github.com/apache/spark/pull/12601 Bump @HyukjinKwon I have some comments to your comments. Could you please review them and I can push my changes. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #13882: Branch 1.6

2016-06-23 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/13882 Please close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #13720: [SPARK-16004] [SQL] improve the display of Catalo...

2016-06-23 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13720#discussion_r68343766 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -522,7 +523,7 @@ case class DescribeTableCommand(table:

[GitHub] spark issue #13882: Branch 1.6

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13882 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #13865: [SPARK-13709][SQL] Initialize deserializer with b...

2016-06-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13865#discussion_r68343609 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/QueryPartitionSuite.scala --- @@ -65,4 +68,77 @@ class QueryPartitionSuite extends QueryTest

[GitHub] spark pull request #13882: Branch 1.6

2016-06-23 Thread liu549676915
GitHub user liu549676915 opened a pull request: https://github.com/apache/spark/pull/13882 Branch 1.6 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please explain how

[GitHub] spark issue #13720: [SPARK-16004] [SQL] improve the display of CatalogTable ...

2016-06-23 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13720 For the test, currently we only have one `desc table` test in `HiveDDLSuite`, It will be good if we can have an individual test suite for it. --- If your project is set up for it, you can reply

[GitHub] spark pull request #13720: [SPARK-16004] [SQL] improve the display of Catalo...

2016-06-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13720#discussion_r68342801 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -522,7 +523,7 @@ case class DescribeTableCommand(table:

[GitHub] spark issue #13874: [SQL][minor] ParserUtils.operationNotAllowed should thro...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13874 **[Test build #61141 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61141/consoleFull)** for PR 13874 at commit

[GitHub] spark issue #13880: SPARK-16178: Remove unnecessary Hive partition check.

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13880 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61139/ Test PASSed. ---

[GitHub] spark issue #13880: SPARK-16178: Remove unnecessary Hive partition check.

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13880 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13880: SPARK-16178: Remove unnecessary Hive partition check.

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13880 **[Test build #61139 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61139/consoleFull)** for PR 13880 at commit

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce additonal implementation wi...

2016-06-23 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13680 @kiszk we should definitely put zero into the corresponding field when set null. It will be a little harder than `UnsafeRow`, as we need `setNullBoolean`, `setNullInt`, etc. but it's still

[GitHub] spark pull request #13832: [SPARK-16123] Avoid NegativeArraySizeException wh...

2016-06-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13832 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13832: [SPARK-16123] Avoid NegativeArraySizeException while res...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13832 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61138/ Test PASSed. ---

[GitHub] spark issue #13832: [SPARK-16123] Avoid NegativeArraySizeException while res...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13832 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13832: [SPARK-16123] Avoid NegativeArraySizeException while res...

2016-06-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/13832 Merging to master/2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #13832: [SPARK-16123] Avoid NegativeArraySizeException while res...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13832 **[Test build #61138 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61138/consoleFull)** for PR 13832 at commit

[GitHub] spark issue #13876: [SPARK-16174][SQL] Improve OptimizeIn optimizer to remov...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13876 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61137/ Test PASSed. ---

[GitHub] spark issue #13860: [SPARK-16157] [SQL] Add New Methods for comments in Stru...

2016-06-23 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13860 @hvanhovell Sure, will do it! It sounds like you also like the suggestion by @cloud-fan . Let me do it too. Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #13876: [SPARK-16174][SQL] Improve OptimizeIn optimizer to remov...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13876 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13876: [SPARK-16174][SQL] Improve OptimizeIn optimizer to remov...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13876 **[Test build #61137 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61137/consoleFull)** for PR 13876 at commit

[GitHub] spark pull request #13837: [SPARK-16126] [SQL] Better Error Message When usi...

2016-06-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13837#discussion_r68341391 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetOptions.scala --- @@ -40,7 +40,7 @@ private[sql] class

  1   2   3   4   5   >