[GitHub] spark issue #14663: [SPARK-17001] [ML] Enable standardScaler to standardize ...

2016-08-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14663 If I understood you correctly @MLnick you favored just adding warnings in the doc? I added to three more places that needed it. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request #14747: [SPARK-17086][ML] Fix InvalidArgumentException is...

2016-08-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14747#discussion_r75846911 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala --- @@ -114,7 +114,12 @@ final class QuantileDiscretizer @Since("1.6.0")

[GitHub] spark pull request #14688: [SPARK-17095] [Documentation] [Latex and Scala do...

2016-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14688 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14688: [SPARK-17095] [Documentation] [Latex and Scala doc do no...

2016-08-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14688 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14772: [Trivial] Typo Fix

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14772 **[Test build #64287 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64287/consoleFull)** for PR 14772 at commit

[GitHub] spark pull request #14771: [SPARK-17199] Use CatalystConf.resolver for case-...

2016-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14771 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14772: [Trivial] Typo Fix

2016-08-23 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/14772 @srowen Agreed. I will update it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14771: [SPARK-17199] Use CatalystConf.resolver for case-sensiti...

2016-08-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14771 LGTM - merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14772: [Trivial] Typo Fix

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14772 **[Test build #64286 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64286/consoleFull)** for PR 14772 at commit

[GitHub] spark issue #14772: [Trivial] Typo Fix

2016-08-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14772 The end is just redundant. I'd end with ` ... [0,$numClasses)` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #14772: [Trivial] Typo Fix

2016-08-23 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/14772 [Trivial] Typo Fix ## What changes were proposed in this pull request? Fix a typo ## How was this patch tested? no tests You can merge this pull request into

[GitHub] spark pull request #14180: [SPARK-16367][PYSPARK] Wheelhouse and VirtualEnv ...

2016-08-23 Thread Stibbons
Github user Stibbons commented on a diff in the pull request: https://github.com/apache/spark/pull/14180#discussion_r75841339 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala --- @@ -68,6 +100,135 @@ private[spark] class

[GitHub] spark pull request #14180: [SPARK-16367][PYSPARK] Wheelhouse and VirtualEnv ...

2016-08-23 Thread Stibbons
Github user Stibbons commented on a diff in the pull request: https://github.com/apache/spark/pull/14180#discussion_r75841147 --- Diff: python/pyspark/context.py --- @@ -797,21 +824,65 @@ def clearFiles(self): def addPyFile(self, path): """ -

[GitHub] spark issue #14537: [SPARK-16948][SQL] Querying empty partitioned orc tables...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14537 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14537: [SPARK-16948][SQL] Querying empty partitioned orc tables...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14537 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64285/ Test PASSed. ---

[GitHub] spark issue #14537: [SPARK-16948][SQL] Querying empty partitioned orc tables...

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14537 **[Test build #64285 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64285/consoleFull)** for PR 14537 at commit

[GitHub] spark issue #14771: [SPARK-17199] Use CatalystConf.resolver for case-sensiti...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14771 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14771: [SPARK-17199] Use CatalystConf.resolver for case-sensiti...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14771 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64284/ Test PASSed. ---

[GitHub] spark issue #14771: [SPARK-17199] Use CatalystConf.resolver for case-sensiti...

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14771 **[Test build #64284 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64284/consoleFull)** for PR 14771 at commit

[GitHub] spark issue #10896: [SPARK-12978][SQL] Skip unnecessary final group-by when ...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/10896 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64283/ Test PASSed. ---

[GitHub] spark issue #10896: [SPARK-12978][SQL] Skip unnecessary final group-by when ...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/10896 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #10896: [SPARK-12978][SQL] Skip unnecessary final group-by when ...

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/10896 **[Test build #64283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64283/consoleFull)** for PR 10896 at commit

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14531 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64282/ Test PASSed. ---

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14531 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14531 **[Test build #64282 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64282/consoleFull)** for PR 14531 at commit

[GitHub] spark issue #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14757 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64281/ Test PASSed. ---

[GitHub] spark issue #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14757 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14757 **[Test build #64281 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64281/consoleFull)** for PR 14757 at commit

[GitHub] spark pull request #14298: [SPARK-16283][SQL] Implement `percentile_approx` ...

2016-08-23 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/14298#discussion_r75830247 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/PercentileApprox.scala --- @@ -0,0 +1,462 @@ +/* + *

[GitHub] spark issue #14180: [SPARK-16367][PYSPARK] Wheelhouse and VirtualEnv support

2016-08-23 Thread Stibbons
Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14180 It makes sense. If you manage to get this merged I can rebase with only my diff. Too bad we cannot stack pull requests on github :( --- If your project is set up for it, you can reply to

[GitHub] spark issue #14537: [SPARK-16948][SQL] Querying empty partitioned orc tables...

2016-08-23 Thread rajeshbalamohan
Github user rajeshbalamohan commented on the issue: https://github.com/apache/spark/pull/14537 Thanks @gatorsmile. Addressed review comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #14537: [SPARK-16948][SQL] Querying empty partitioned orc tables...

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14537 **[Test build #64285 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64285/consoleFull)** for PR 14537 at commit

[GitHub] spark issue #14640: [SPARK-17055] [MLLIB] add labelKFold to CrossValidator

2016-08-23 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14640 @VinceShieh there are kfold exists in Spark ML as well, and this PR could maybe go instead of trying to add it on to mllib (for which we don't plan to add new features anymore rather bug fixes

[GitHub] spark issue #14452: [SPARK-16849][SQL] Improve subquery execution by dedupli...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14452 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14452: [SPARK-16849][SQL] Improve subquery execution by dedupli...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14452 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64278/ Test PASSed. ---

[GitHub] spark issue #14452: [SPARK-16849][SQL] Improve subquery execution by dedupli...

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14452 **[Test build #64278 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64278/consoleFull)** for PR 14452 at commit

[GitHub] spark issue #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptron Class...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14447 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64279/ Test FAILed. ---

[GitHub] spark issue #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptron Class...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14447 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptron Class...

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14447 **[Test build #64279 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64279/consoleFull)** for PR 14447 at commit

[GitHub] spark pull request #14640: [SPARK-17055] [MLLIB] add labelKFold to CrossVali...

2016-08-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14640#discussion_r75826211 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala --- @@ -228,6 +229,30 @@ object MLUtils extends Logging { } /**

[GitHub] spark issue #14524: [SPARK-16832] [ML] [WIP] CrossValidator and TrainValidat...

2016-08-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14524 Yes, isn't that why it's possible to fix a seed? I can understand an argument that the default should be not-random, but, every API I've ever seen (including Spark's) defaults to a random seed.

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2016-08-23 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/spark/pull/13599 @davies @JoshRosen Do you have time to review it ? @Stibbons has another PR #14180 based on this to support wheelhouse, but I just afraid putting these together would be too big to review. So it

[GitHub] spark issue #14038: [SPARK-16317][SQL] Add a new interface to filter files i...

2016-08-23 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/14038 Understood though, it seems this is a difficult issue because I'm not 100% sure how rich we should need for the filter interface (at least `timestamp` and `file type` is not used for now when

[GitHub] spark issue #14180: [SPARK-16367][PYSPARK] Wheelhouse and VirtualEnv support

2016-08-23 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/spark/pull/14180 @Stibbons After second review your PR, I have one concern that may be support wheelhouse and virtualenv in one PR is too big to review, it might be better to do it in 2 PRs. I will try to get some

[GitHub] spark pull request #14180: [SPARK-16367][PYSPARK] Wheelhouse and VirtualEnv ...

2016-08-23 Thread zjffdu
Github user zjffdu commented on a diff in the pull request: https://github.com/apache/spark/pull/14180#discussion_r75823127 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala --- @@ -68,6 +100,135 @@ private[spark] class

[GitHub] spark pull request #14768: [MINOR][BUILD] Fix Java CheckStyle Error

2016-08-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14768#discussion_r75822964 --- Diff: examples/src/main/java/org/apache/spark/examples/sql/streaming/JavaStructuredNetworkWordCount.java --- @@ -61,7 +61,8 @@ public static void

[GitHub] spark pull request #14768: [MINOR][BUILD] Fix Java CheckStyle Error

2016-08-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14768#discussion_r75822770 --- Diff: examples/src/main/java/org/apache/spark/examples/sql/streaming/JavaStructuredNetworkWordCount.java --- @@ -61,7 +61,8 @@ public static void

[GitHub] spark pull request #14180: [SPARK-16367][PYSPARK] Wheelhouse and VirtualEnv ...

2016-08-23 Thread zjffdu
Github user zjffdu commented on a diff in the pull request: https://github.com/apache/spark/pull/14180#discussion_r75821756 --- Diff: python/pyspark/context.py --- @@ -797,21 +824,65 @@ def clearFiles(self): def addPyFile(self, path): """ -

[GitHub] spark issue #14771: [SPARK-17199] Use CatalystConf.resolver for case-sensiti...

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14771 **[Test build #64284 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64284/consoleFull)** for PR 14771 at commit

[GitHub] spark pull request #14771: [SPARK-17199] Use CatalystConf.resolver for case-...

2016-08-23 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/14771 [SPARK-17199] Use CatalystConf.resolver for case-sensitivity comparison ## What changes were proposed in this pull request? Use `CatalystConf.resolver` consistently for

[GitHub] spark issue #10896: [SPARK-12978][SQL] Skip unnecessary final group-by when ...

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/10896 **[Test build #64283 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64283/consoleFull)** for PR 10896 at commit

[GitHub] spark issue #10896: [SPARK-12978][SQL] Skip unnecessary final group-by when ...

2016-08-23 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/10896 @hvanhovell okay, fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14531 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #10896: [SPARK-12978][SQL] Skip unnecessary final group-b...

2016-08-23 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/10896#discussion_r75819461 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala --- @@ -27,26 +27,87 @@ import

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14531 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64276/ Test PASSed. ---

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14531 **[Test build #64276 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64276/consoleFull)** for PR 14531 at commit

[GitHub] spark issue #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14757 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64273/ Test PASSed. ---

[GitHub] spark issue #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14757 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14757 **[Test build #64273 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64273/consoleFull)** for PR 14757 at commit

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14531 **[Test build #64282 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64282/consoleFull)** for PR 14531 at commit

[GitHub] spark issue #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14757 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64272/ Test PASSed. ---

[GitHub] spark issue #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14757 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14757 **[Test build #64272 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64272/consoleFull)** for PR 14757 at commit

[GitHub] spark issue #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14757 **[Test build #64281 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64281/consoleFull)** for PR 14757 at commit

[GitHub] spark pull request #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bu...

2016-08-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14531#discussion_r75814610 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -56,7 +56,13 @@ case class

[GitHub] spark pull request #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bu...

2016-08-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14531#discussion_r75814564 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -75,18 +81,46 @@ case class CreateTableLikeCommand(

[GitHub] spark issue #14770: [MINOR][DOC] Use standard quotes instead of "curly quote...

2016-08-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14770 Thank you fore reviewing this. (BTW, (as you might already know) https://github.com/apache/spark/blob/master/scalastyle-config.xml#L119 will prevent this case in codes (haven't tested it but it

[GitHub] spark pull request #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14757#discussion_r75813864 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala --- @@ -51,7 +51,8 @@ class MetastoreDataSourcesSuite

[GitHub] spark pull request #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14757#discussion_r75813871 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/ShowCreateTableSuite.scala --- @@ -266,7 +266,7 @@ class ShowCreateTableSuite extends

[GitHub] spark pull request #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14757#discussion_r75813839 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala --- @@ -378,10 +378,9 @@ object SetMetastoreURLTest extends

[GitHub] spark pull request #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14757#discussion_r75813787 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameSuite.scala --- @@ -31,7 +31,7 @@ class HiveDataFrameSuite extends QueryTest

[GitHub] spark issue #14770: [MINOR][DOC] Use standard quotes instead of "curly quote...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14770 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64280/ Test PASSed. ---

[GitHub] spark pull request #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14757#discussion_r75813591 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala --- @@ -40,6 +40,15 @@ abstract class

[GitHub] spark issue #14770: [MINOR][DOC] Use standard quotes instead of "curly quote...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14770 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14770: [MINOR][DOC] Use standard quotes instead of "curly quote...

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14770 **[Test build #64280 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64280/consoleFull)** for PR 14770 at commit

[GitHub] spark pull request #14658: [WIP][SPARK-5928][SPARK-6238] Remote Shuffle Bloc...

2016-08-23 Thread witgo
Github user witgo closed the pull request at: https://github.com/apache/spark/pull/14658 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14647: [WIP][Test only][DEMO][SPARK-6235]Address various...

2016-08-23 Thread witgo
Github user witgo closed the pull request at: https://github.com/apache/spark/pull/14647 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14751: [WIP][SPARK-17184][[CORE]]Replace ByteBuf with In...

2016-08-23 Thread witgo
Github user witgo closed the pull request at: https://github.com/apache/spark/pull/14751 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14664: [WIP][SPARK-6236][SPARK-6237][CORE]Support cachin...

2016-08-23 Thread witgo
Github user witgo closed the pull request at: https://github.com/apache/spark/pull/14664 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14662: [WIP][SPARK-17082][CORE]Replace ByteBuffer with C...

2016-08-23 Thread witgo
Github user witgo closed the pull request at: https://github.com/apache/spark/pull/14662 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bu...

2016-08-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14531#discussion_r75813062 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -56,7 +56,13 @@ case class

[GitHub] spark pull request #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bu...

2016-08-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14531#discussion_r75813056 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -75,18 +81,46 @@ case class CreateTableLikeCommand(

[GitHub] spark pull request #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bu...

2016-08-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14531#discussion_r75812861 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -56,7 +56,13 @@ case class

[GitHub] spark pull request #14537: [SPARK-16948][SQL] Querying empty partitioned orc...

2016-08-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14537#discussion_r75812657 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -237,21 +237,24 @@ private[hive] class

[GitHub] spark pull request #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14757#discussion_r75812578 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala --- @@ -51,7 +51,8 @@ class MetastoreDataSourcesSuite extends

[GitHub] spark pull request #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14757#discussion_r75812586 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/ShowCreateTableSuite.scala --- @@ -266,7 +266,7 @@ class ShowCreateTableSuite extends

[GitHub] spark pull request #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14757#discussion_r75812566 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala --- @@ -378,10 +378,9 @@ object SetMetastoreURLTest extends Logging

[GitHub] spark pull request #14537: [SPARK-16948][SQL] Querying empty partitioned orc...

2016-08-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14537#discussion_r75812470 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala --- @@ -372,6 +372,48 @@ class OrcQuerySuite extends QueryTest with

[GitHub] spark pull request #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14757#discussion_r75812417 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameSuite.scala --- @@ -31,7 +31,7 @@ class HiveDataFrameSuite extends QueryTest with

[GitHub] spark pull request #14757: [SPARK-17190] [SQL] Removal of HiveSharedState

2016-08-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14757#discussion_r75812142 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala --- @@ -40,6 +40,15 @@ abstract class

[GitHub] spark issue #14770: [MINOR][DOC] Use standard quotes instead of "curly quote...

2016-08-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14770 Agree with this. I'd say add a style rule for it but it wouldn't catch the docs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #14762: [SPARK-16962][CORE][SQL] Fix misaligned record ac...

2016-08-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14762#discussion_r75811895 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/CompressibleColumnBuilder.scala --- @@ -61,8 +63,16 @@

[GitHub] spark pull request #14762: [SPARK-16962][CORE][SQL] Fix misaligned record ac...

2016-08-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14762#discussion_r75811832 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java --- @@ -0,0 +1,50 @@ +/* + * Class to make changes to record

[GitHub] spark pull request #14762: [SPARK-16962][CORE][SQL] Fix misaligned record ac...

2016-08-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14762#discussion_r75811782 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java --- @@ -47,13 +47,19 @@ public static int

[GitHub] spark pull request #14762: [SPARK-16962][CORE][SQL] Fix misaligned record ac...

2016-08-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14762#discussion_r75811759 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java --- @@ -0,0 +1,50 @@ +/* + * Class to make changes to record

[GitHub] spark issue #14770: [MINOR][DOC] Use standard quotes instead of "curly quote...

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14770 **[Test build #64280 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64280/consoleFull)** for PR 14770 at commit

[GitHub] spark pull request #14762: [SPARK-16962][CORE][SQL] Fix misaligned record ac...

2016-08-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14762#discussion_r75811674 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java --- @@ -0,0 +1,50 @@ +/* + * Class to make changes to record

[GitHub] spark pull request #14762: [SPARK-16962][CORE][SQL] Fix misaligned record ac...

2016-08-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14762#discussion_r75811646 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java --- @@ -0,0 +1,50 @@ +/* + * Class to make changes to record

[GitHub] spark pull request #14762: [SPARK-16962][CORE][SQL] Fix misaligned record ac...

2016-08-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14762#discussion_r75811715 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java --- @@ -0,0 +1,50 @@ +/* + * Class to make changes to record

[GitHub] spark pull request #14762: [SPARK-16962][CORE][SQL] Fix misaligned record ac...

2016-08-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14762#discussion_r75811636 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java --- @@ -0,0 +1,50 @@ +/* --- End diff -- There are a

<    1   2   3   4   5   6   >