[GitHub] spark issue #14788: [SPARK-17174][SQL] Add the support for TimestampType for...

2016-09-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14788 **[Test build #65092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65092/consoleFull)** for PR 14788 at commit [`8c50b2c`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #14995: [Test Only][not ready for review][SPARK-6235][CORE]Addre...

2016-09-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14995 **[Test build #65090 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65090/consoleFull)** for PR 14995 at commit [`2b9c946`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #14980: [SPARK-17317][SparkR] Add SparkR vignette

2016-09-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14980 **[Test build #65086 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65086/consoleFull)** for PR 14980 at commit [`82b6167`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14980: [SPARK-17317][SparkR] Add SparkR vignette

2016-09-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14980 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65086/ Test FAILed. ---

[GitHub] spark issue #14980: [SPARK-17317][SparkR] Add SparkR vignette

2016-09-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14980 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15012: [SPARK-17446] [SQL] No total size for data source tables...

2016-09-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15012 **[Test build #65089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65089/consoleFull)** for PR 15012 at commit [`8276ab0`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #15011: [SPARK-17122][SQL]support drop current database

2016-09-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15011 **[Test build #65088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65088/consoleFull)** for PR 15011 at commit [`467f8d7`](https://github.com/apache/spark/commit/4

[GitHub] spark pull request #14990: [SPARK-17426][SQL] Refactor `TreeNode.toJSON` to ...

2016-09-08 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14990#discussion_r77958425 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala --- @@ -626,189 +626,25 @@ abstract class TreeNode[BaseType <: Tr

[GitHub] spark issue #15012: No total size for data source tables in InMemoryCatalog

2016-09-08 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/15012 @cloud-fan @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #15012: No total size for data source tables in InMemoryC...

2016-09-08 Thread wzhfy
GitHub user wzhfy opened a pull request: https://github.com/apache/spark/pull/15012 No total size for data source tables in InMemoryCatalog ## What changes were proposed in this pull request? For data source table in InMemoryCatalog, it's `catalogTable.storage.locationUri` is No

[GitHub] spark issue #15006: [SPARK-17364][SQL] Antlr lexer wrongly treats full quali...

2016-09-08 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/15006 @clockfly I also spent some time looking into this :-) I initially tried to handle this at lexer level and found it difficult distinguish between the number literals and table names. In particu

[GitHub] spark issue #15006: [SPARK-17364][SQL] Antlr lexer wrongly treats full quali...

2016-09-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15006 This is a design decision. Either is fine to me. : ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #12601: [SPARK-14525][SQL] Make DataFrameWrite.save work for jdb...

2016-09-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12601 **[Test build #65087 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65087/consoleFull)** for PR 12601 at commit [`c686b0e`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #15006: [SPARK-17364][SQL] Antlr lexer wrongly treats full quali...

2016-09-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15006 uh... We use the Hive APIs. Basically, what we did is like passing a quoted identifier to Hive. Thus, it is OK to be more flexible. You are also right. I did not run Spark SQL after your

[GitHub] spark issue #12601: [SPARK-14525][SQL] Make DataFrameWrite.save work for jdb...

2016-09-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/12601 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] spark pull request #15004: [SPARK-17440] [SPARK-17441] Fixed Multiple Bugs i...

2016-09-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15004#discussion_r77956925 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -305,6 +305,19 @@ class HiveDDLSuite } }

[GitHub] spark issue #15006: [SPARK-17364][SQL] Antlr lexer wrongly treats full quali...

2016-09-08 Thread clockfly
Github user clockfly commented on the issue: https://github.com/apache/spark/pull/15006 Besides, Spark 1.6, Spark 2.0, supports syntax like `select * from 123_LIST`, so maybe we should keep it compatible so that we can also support syntax like `select * from default.123_LIST` --- I

[GitHub] spark issue #15006: [SPARK-17364][SQL] Antlr lexer wrongly treats full quali...

2016-09-08 Thread clockfly
Github user clockfly commented on the issue: https://github.com/apache/spark/pull/15006 @gatorsmile We are not "more flexible than Hive". We are as flexible as Hive. With this PR, we only treats a string as an IDENTIFIER if there is no ambiguity that it can not be interpreted

[GitHub] spark issue #14980: [SPARK-17317][SparkR] Add SparkR vignette

2016-09-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14980 **[Test build #65086 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65086/consoleFull)** for PR 14980 at commit [`82b6167`](https://github.com/apache/spark/commit/8

[GitHub] spark pull request #15004: [SPARK-17440] [SPARK-17441] Fixed Multiple Bugs i...

2016-09-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15004#discussion_r77956433 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -869,6 +869,14 @@ class DDLSuite extends QueryTest with Sha

[GitHub] spark pull request #15004: [SPARK-17440] [SPARK-17441] Fixed Multiple Bugs i...

2016-09-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15004#discussion_r77956260 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -881,23 +889,30 @@ class DDLSuite extends QueryTest with S

[GitHub] spark issue #15011: [SPARK-17122][SQL]support drop current database

2016-09-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15011 I checked how Hive works. ``` hive (db2)> use default; OK Time taken: 0.024 seconds hive (default)> create database db2; OK Time taken: 0.02 seconds hive (default)>

[GitHub] spark pull request #15004: [SPARK-17440] [SPARK-17441] Fixed Multiple Bugs i...

2016-09-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15004#discussion_r77956188 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -881,23 +889,30 @@ class DDLSuite extends QueryTest with S

[GitHub] spark pull request #15004: [SPARK-17440] [SPARK-17441] Fixed Multiple Bugs i...

2016-09-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15004#discussion_r77955991 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -693,14 +705,22 @@ object DDLUtils { catalog: SessionC

[GitHub] spark pull request #15004: [SPARK-17440] [SPARK-17441] Fixed Multiple Bugs i...

2016-09-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15004#discussion_r77956043 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -383,7 +385,14 @@ case class AlterTableRenamePartitionCommand(

[GitHub] spark pull request #15004: [SPARK-17440] [SPARK-17441] Fixed Multiple Bugs i...

2016-09-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15004#discussion_r77955887 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -693,14 +705,22 @@ object DDLUtils { catalog: SessionC

[GitHub] spark pull request #13334: [SPARK-15576] Add back hive tests blacklisted by ...

2016-09-08 Thread techaddict
Github user techaddict closed the pull request at: https://github.com/apache/spark/pull/13334 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14990: [SPARK-17426][SQL] Refactor `TreeNode.toJSON` to ...

2016-09-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14990#discussion_r77955319 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/trees/TreeNodeSuite.scala --- @@ -261,4 +283,146 @@ class TreeNodeSuite extends SparkF

[GitHub] spark issue #15011: [SPARK-17122][SQL]support drop current database

2016-09-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15011 **[Test build #65085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65085/consoleFull)** for PR 15011 at commit [`551b272`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #15011: [SPARK-17122][SQL]support drop current database

2016-09-08 Thread adrian-wang
Github user adrian-wang commented on the issue: https://github.com/apache/spark/pull/15011 @jameszhouyi @chenghao-intel --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark pull request #15011: [SPARK-17122][SQL]support drop current database

2016-09-08 Thread adrian-wang
GitHub user adrian-wang opened a pull request: https://github.com/apache/spark/pull/15011 [SPARK-17122][SQL]support drop current database ## What changes were proposed in this pull request? In Spark 1.6 and earlier, we can drop the database we are using. In Spark 2.0, nativ

[GitHub] spark issue #15006: [SPARK-17364][SQL] Antlr lexer wrongly treats full quali...

2016-09-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15006 If users really need to use the names starting with numeric, could they use quoted identifiers? --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] spark pull request #14990: [SPARK-17426][SQL] Refactor `TreeNode.toJSON` to ...

2016-09-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14990#discussion_r77954704 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala --- @@ -626,189 +626,25 @@ abstract class TreeNode[BaseType <: T

[GitHub] spark issue #15006: [SPARK-17364][SQL] Antlr lexer wrongly treats full quali...

2016-09-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15006 More tries in Hive ``` hive> create table `3M` (col3 int); OK Time taken: 0.06 seconds hive> create table `3L` (col3 int); OK Time taken: 0.062 seconds hive> create

[GitHub] spark issue #14859: [SPARK-17200][PROJECT INFRA][BUILD][SPARKR] Automate bui...

2016-09-08 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14859 BTW, I already cc the author of winutils in https://github.com/apache/spark/pull/14859#issuecomment-243073024 :). --- If your project is set up for it, you can reply to this email and have your

<    1   2   3   4   5