Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100648519
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -0,0 +1,213 @@
+/*
+ * Licensed to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100648210
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -394,36 +447,32 @@ class JacksonParser(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100648139
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,102 @@ class JacksonParser(
/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100647494
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,110 @@ class JacksonParser(
/
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100647313
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf) extend
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16826
**[Test build #72727 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72727/testReport)**
for PR 16826 at commit
[`6da6bda`](https://github.com/apache/spark/commit/6d
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100647047
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -31,10 +31,17 @@ import
org.apache.spark.sql.catalyst.
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100646859
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf) extend
Github user erenavsarogullari commented on the issue:
https://github.com/apache/spark/pull/15604
Hi @kayousterhout and @squito,
Firstly, many thanks for the review. All comments are addressed. This is
ready to re-review ;)
---
If your project is set up for it, you can reply to th
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16386
**[Test build #72726 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72726/testReport)**
for PR 16386 at commit
[`0f4686d`](https://github.com/apache/spark/commit/0f
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100646662
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf) exte
Github user erenavsarogullari commented on a diff in the pull request:
https://github.com/apache/spark/pull/15604#discussion_r100646612
--- Diff: core/src/test/scala/org/apache/spark/scheduler/PoolSuite.scala ---
@@ -178,4 +180,97 @@ class PoolSuite extends SparkFunSuite with
Local
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100646497
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,98 @@ class JacksonParser(
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100646267
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf) extend
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16871#discussion_r100646239
--- Diff: project/SparkBuild.scala ---
@@ -765,16 +750,6 @@ object CopyDependencies {
}
-object Java8TestSettings {
- import BuildCo
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15604
**[Test build #72725 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72725/testReport)**
for PR 15604 at commit
[`f84abe7`](https://github.com/apache/spark/commit/f8
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16871#discussion_r100645947
--- Diff: project/SparkBuild.scala ---
@@ -765,16 +750,6 @@ object CopyDependencies {
}
-object Java8TestSettings {
- import BuildCo
Github user erenavsarogullari commented on the issue:
https://github.com/apache/spark/pull/15604
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16871
**[Test build #72724 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72724/testReport)**
for PR 16871 at commit
[`7f8a2cb`](https://github.com/apache/spark/commit/7f
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16871#discussion_r100645304
--- Diff: project/SparkBuild.scala ---
@@ -765,16 +750,6 @@ object CopyDependencies {
}
-object Java8TestSettings {
- import BuildCo
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16871#discussion_r100644859
--- Diff: project/SparkBuild.scala ---
@@ -765,16 +750,6 @@ object CopyDependencies {
}
-object Java8TestSettings {
- import BuildCo
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100644845
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf) exte
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15604
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15604
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72722/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15604
**[Test build #72722 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72722/testReport)**
for PR 15604 at commit
[`84513b1`](https://github.com/apache/spark/commit/8
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15009
**[Test build #72723 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72723/testReport)**
for PR 15009 at commit
[`cc2c0be`](https://github.com/apache/spark/commit/cc
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15604
**[Test build #72722 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72722/testReport)**
for PR 15604 at commit
[`84513b1`](https://github.com/apache/spark/commit/84
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16871#discussion_r100644266
--- Diff: project/SparkBuild.scala ---
@@ -765,16 +750,6 @@ object CopyDependencies {
}
-object Java8TestSettings {
- import BuildCo
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100644275
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,98 @@ class JacksonParser(
//
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14864
This is an optimization and we usually don't backport optimizations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16871#discussion_r100643906
--- Diff:
streaming/src/test/java/org/apache/spark/streaming/Java8APISuite.java ---
@@ -15,7 +15,7 @@
* limitations under the License.
*/
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/16067
@gatorsmile can we also add it in branch-2.0? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16871#discussion_r100643005
--- Diff: project/SparkBuild.scala ---
@@ -765,16 +750,6 @@ object CopyDependencies {
}
-object Java8TestSettings {
- import BuildCo
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16871#discussion_r100643153
--- Diff:
streaming/src/test/java/org/apache/spark/streaming/Java8APISuite.java ---
@@ -15,7 +15,7 @@
* limitations under the License.
*/
Github user ankravch commented on the issue:
https://github.com/apache/spark/pull/14864
Was this patch merged in spark2.0.1 release? If so, how can it be
enforced/turned on?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100642343
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf) extend
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15125
@viirya @dding3 I'm going to rerun our big connected components computation
with the changes I've suggested to validate that it still performs and
completes as expected. Given the time required to c
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100641170
--- Diff:
graphx/src/main/scala/org/apache/spark/graphx/util/PeriodicGraphCheckpointer.scala
---
@@ -87,10 +88,7 @@ private[mllib] class PeriodicGraphCheck
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100640620
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,98 @@ class JacksonParser(
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16886
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16886
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100640256
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -123,16 +127,25 @@ object Pregel extends Logging {
s" but got ${maxIte
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16886
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16886
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72719/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16886
**[Test build #72719 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72719/testReport)**
for PR 16886 at commit
[`8cf25b9`](https://github.com/apache/spark/commit/8
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100638292
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -123,16 +127,25 @@ object Pregel extends Logging {
s" but got ${maxIte
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100638130
--- Diff:
graphx/src/main/scala/org/apache/spark/graphx/util/PeriodicGraphCheckpointer.scala
---
@@ -76,7 +77,7 @@ import org.apache.spark.storage.StorageL
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16889
**[Test build #72720 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72720/testReport)**
for PR 16889 at commit
[`ac09ad5`](https://github.com/apache/spark/commit/ac
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16880
**[Test build #72721 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72721/testReport)**
for PR 16880 at commit
[`cae981f`](https://github.com/apache/spark/commit/ca
GitHub user koertkuipers opened a pull request:
https://github.com/apache/spark/pull/16889
[SPARK-17668][SQL] Use Expressions for conversions to/from user types in
UDFs
## What changes were proposed in this pull request?
do not merge
this is a first attempt at trying to
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16880#discussion_r100636660
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -323,6 +329,20 @@ class StreamExecution(
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16161
I'm fine to backport this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15945#discussion_r100633797
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/MergePartialAggregate.scala
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to t
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16699
@sethah Thanks much for your review.
Regarding prediction, both R and my implementation here allow prediction
with offsets. If the users want to get the predicted rates (instead of cou
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15945#discussion_r100632491
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregateExec.scala
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apach
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15945#discussion_r100632348
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -82,32 +81,14 @@ class QueryExecution(val sparkSession: Spark
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100632148
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/impl/PeriodicRDDCheckpointerSuite.scala
---
@@ -23,7 +23,7 @@ import org.apache.spark.{SparkContext,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16395
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72718/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16395
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16395
**[Test build #72718 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72718/testReport)**
for PR 16395 at commit
[`96b14de`](https://github.com/apache/spark/commit/9
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100631975
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/impl/PeriodicGraphCheckpointerSuite.scala
---
@@ -21,6 +21,7 @@ import org.apache.hadoop.fs.Path
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/16161
Shall we backport this to branch-2.1? I'd consider this as a bug because of
the following snippet fail in Spark 2.1:
```scala
case class Wrapper1(value: Option[Map[String, String]])
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15945#discussion_r100629464
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/PhysicalOptimizer.scala
---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Soft
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16664
@salilsurendran yes, and we can send another PR to fix the InsertXXX
command problem
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user salilsurendran commented on the issue:
https://github.com/apache/spark/pull/16664
@cloud-fan From what I understand we need to modify InsertXXX command to
carry all the write options instead of the change suggested in this PR. Right
now the QueryExecution object doesn't ca
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16664
@vanzin yes, InsertXXX command will carry all the write options.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16664
Does that mean the information would show up in the plan? That would be
great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Bcpoole commented on a diff in the pull request:
https://github.com/apache/spark/pull/16864#discussion_r100624882
--- Diff:
common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilterImpl.java
---
@@ -221,6 +221,49 @@ public BloomFilter mergeInPlace(BloomFilte
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r100624733
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -859,6 +859,48 @@ class CSVSuite extends QueryTest
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r100623330
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -58,13 +59,15 @@ private[sql] class JSONOptions(
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/16699
@actuaryzhang This is looking pretty good overall. Regarding the prediction
logic, R glm does not allow you to predict with offsets, correct? I notice that
statsmodels in Python _does_ allow it. For,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16886
**[Test build #72719 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72719/testReport)**
for PR 16886 at commit
[`8cf25b9`](https://github.com/apache/spark/commit/8c
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16887
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16887
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16887
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72713/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16887
**[Test build #72713 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72713/testReport)**
for PR 16887 at commit
[`81b4243`](https://github.com/apache/spark/commit/8
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16887
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16887
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72717/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16887
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16887
Merging in master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16888
BTW for Netty we shouldn't just bump to the highest version. We should use
the maintenance branches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16888
Shouldn't we use netty-4.0.44.Final rather than 4.1.x?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16887
**[Test build #72717 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72717/testReport)**
for PR 16887 at commit
[`50c54b1`](https://github.com/apache/spark/commit/5
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16854#discussion_r100613684
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -361,6 +362,41 @@ class DataFrameReader private[sql](sparkSession:
Sp
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100612936
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,98 @@ class JacksonParser(
//
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100612840
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -123,16 +127,25 @@ object Pregel extends Logging {
s" but got ${maxIte
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16395#discussion_r100611930
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
---
@@ -0,0 +1,623 @@
+/*
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16395#discussion_r100611664
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
---
@@ -0,0 +1,623 @@
+/*
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16860
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16395#discussion_r100611368
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
---
@@ -0,0 +1,623 @@
+/*
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16395#discussion_r100611222
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
---
@@ -0,0 +1,623 @@
+/*
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16860
LGTM
Merging with master
Thanks @sueann !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100610662
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -48,69 +47,98 @@ class JacksonParser(
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100609529
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -123,16 +127,25 @@ object Pregel extends Logging {
s" but got ${maxIte
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16395#discussion_r100608877
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
---
@@ -0,0 +1,623 @@
+/*
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100608839
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala ---
@@ -123,16 +127,25 @@ object Pregel extends Logging {
s" but got ${maxIte
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16887
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72716/
Test PASSed.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16395#discussion_r100608545
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
---
@@ -0,0 +1,623 @@
+/*
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16887
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16887
**[Test build #72716 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72716/testReport)**
for PR 16887 at commit
[`a5f4946`](https://github.com/apache/spark/commit/a
101 - 200 of 435 matches
Mail list logo
