[GitHub] spark issue #17144: [SPARK-19803][TEST] flaky BlockManagerReplicationSuite t...

2017-03-02 Thread uncleGen
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/17144 one more flaky test? `org.apache.spark.streaming.CheckpointSuite.recovery with map and reduceByKey operations` I will check it later. retest this please. --- If your project is set up for it, you

[GitHub] spark issue #17146: [SPARK-19806][ML][PySpark] PySpark GeneralizedLinearRegr...

2017-03-02 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/17146 cc @jkbradley @actuaryzhang @MLnick @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add to_json in FunctionRegistr...

2017-03-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r104090922 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3007,7 +3008,7 @@ object functions { * @since 2.1.0 */

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add to_json in FunctionRegistr...

2017-03-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r104090870 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonUtils.scala --- @@ -55,4 +60,22 @@ object JacksonUtils {

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add to_json in FunctionRegistr...

2017-03-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r104090791 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonUtils.scala --- @@ -55,4 +60,22 @@ object JacksonUtils {

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add to_json in FunctionRegistr...

2017-03-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r104090730 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonUtils.scala --- @@ -55,4 +60,22 @@ object JacksonUtils {

[GitHub] spark issue #17145: [SPARK-19805][TEST] Log the row type when query type dos...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17145 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17145: [SPARK-19805][TEST] Log the row type when query type dos...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17145 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73806/ Test FAILed. ---

[GitHub] spark issue #17145: [SPARK-19805][TEST] Log the row type when query type dos...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17145 **[Test build #73806 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73806/testReport)** for PR 17145 at commit

[GitHub] spark issue #17122: [SPARK-19786][SQL] Facilitate loop optimizations in a JI...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17122 **[Test build #73813 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73813/testReport)** for PR 17122 at commit

[GitHub] spark pull request #17067: [SPARK-19602][SQL][TESTS] Add tests for qualified...

2017-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17067 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17124: [SPARK-19779][SS]Delete needless tmp file after r...

2017-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

2017-03-02 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r104090569 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -206,6 +206,18 @@ trait CodegenSupport extends SparkPlan

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

2017-03-02 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r104090563 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -206,6 +206,18 @@ trait CodegenSupport extends SparkPlan

[GitHub] spark issue #17067: [SPARK-19602][SQL][TESTS] Add tests for qualified column...

2017-03-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17067 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

2017-03-02 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/17124 LGTM. Merging to master, 2.1 and 2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17096: [SPARK-15243][ML][SQL][PYTHON] Add missing support for u...

2017-03-02 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17096 In `StructType.add`, if the given field name is a `basestring`, we will directly use it as key in `names` property. If we pass in a `StructField`, we take `StructField.name` as key in

[GitHub] spark issue #17067: [SPARK-19602][SQL][TESTS] Add tests for qualified column...

2017-03-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17067 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #17146: [SPARK-19806][ML][PySpark] PySpark GeneralizedLinearRegr...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17146 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73812/ Test PASSed. ---

[GitHub] spark issue #17146: [SPARK-19806][ML][PySpark] PySpark GeneralizedLinearRegr...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17146 **[Test build #73812 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73812/testReport)** for PR 17146 at commit

[GitHub] spark issue #17146: [SPARK-19806][ML][PySpark] PySpark GeneralizedLinearRegr...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17146 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17124 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17124 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73803/ Test PASSed. ---

[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17124 **[Test build #73803 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73803/testReport)** for PR 17124 at commit

[GitHub] spark issue #17144: [SPARK-19803][TEST] flaky BlockManagerReplicationSuite t...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17144 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73800/ Test FAILed. ---

[GitHub] spark issue #17144: [SPARK-19803][TEST] flaky BlockManagerReplicationSuite t...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17144 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17081: [SPARK-18726][SQL]resolveRelation for FileFormat DataSou...

2017-03-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17081 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #17144: [SPARK-19803][TEST] flaky BlockManagerReplicationSuite t...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17144 **[Test build #73800 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73800/testReport)** for PR 17144 at commit

[GitHub] spark issue #17146: [SPARK-19806][ML][PySpark] PySpark GeneralizedLinearRegr...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17146 **[Test build #73812 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73812/testReport)** for PR 17146 at commit

[GitHub] spark issue #17146: [SPARK-19806][ML][PySpark] PySpark GeneralizedLinearRegr...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17146 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17146: [SPARK-19806][ML][PySpark] PySpark GeneralizedLinearRegr...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17146 **[Test build #73811 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73811/testReport)** for PR 17146 at commit

[GitHub] spark issue #17146: [SPARK-19806][ML][PySpark] PySpark GeneralizedLinearRegr...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17146 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73811/ Test FAILed. ---

[GitHub] spark issue #17146: [SPARK-19806][ML][PySpark] PySpark GeneralizedLinearRegr...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17146 **[Test build #73811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73811/testReport)** for PR 17146 at commit

[GitHub] spark issue #17146: [SPARK-19806][ML][PySpark] PySpark GeneralizedLinearRegr...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17146 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17146: [SPARK-19806][ML][PySpark] PySpark GeneralizedLinearRegr...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17146 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73810/ Test FAILed. ---

[GitHub] spark issue #17146: [SPARK-19806][ML][PySpark] PySpark GeneralizedLinearRegr...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17146 **[Test build #73810 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73810/testReport)** for PR 17146 at commit

[GitHub] spark issue #17146: [SPARK-19806][ML][PySpark] PySpark GeneralizedLinearRegr...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17146 **[Test build #73810 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73810/testReport)** for PR 17146 at commit

[GitHub] spark issue #16981: [SPARK-19637][SQL] Add from_json/to_json in FunctionRegi...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16981 **[Test build #73809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73809/testReport)** for PR 16981 at commit

[GitHub] spark pull request #17146: [SPARK-19806][ML][PySpark] PySpark GeneralizedLin...

2017-03-02 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/17146 [SPARK-19806][ML][PySpark] PySpark GeneralizedLinearRegression supports tweedie distribution. ## What changes were proposed in this pull request? PySpark ```GeneralizedLinearRegression```

[GitHub] spark issue #17080: [SPARK-19739][CORE] propagate S3 session token to cluser

2017-03-02 Thread uncleGen
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/17080 cc @vanzin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-03-02 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/15435 @sethah OK no problem! I can move the method implementations into trait. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16944: [SPARK-19611][SQL] Introduce configurable table schema i...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16944 **[Test build #73808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73808/testReport)** for PR 16944 at commit

[GitHub] spark issue #17133: [SPARK-19793] Use clock.getTimeMillis when mark task as ...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17133 **[Test build #73807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73807/testReport)** for PR 17133 at commit

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-03-02 Thread budde
Github user budde commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r104086046 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -597,6 +597,16 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark issue #12461: [SPARK-14409][ML] Adding a RankingEvaluator to ML

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12461 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-03-02 Thread budde
Github user budde commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r104085922 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -195,17 +207,20 @@ private[hive] class

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-03-02 Thread budde
Github user budde commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r104085920 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -195,17 +207,20 @@ private[hive] class

[GitHub] spark issue #12461: [SPARK-14409][ML] Adding a RankingEvaluator to ML

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12461 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73804/ Test PASSed. ---

[GitHub] spark issue #12461: [SPARK-14409][ML] Adding a RankingEvaluator to ML

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12461 **[Test build #73804 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73804/testReport)** for PR 12461 at commit

[GitHub] spark issue #17080: [SPARK-19739][CORE] propagate S3 session token to cluser

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17080 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17080: [SPARK-19739][CORE] propagate S3 session token to cluser

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17080 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73797/ Test PASSed. ---

[GitHub] spark issue #17080: [SPARK-19739][CORE] propagate S3 session token to cluser

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17080 **[Test build #73797 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73797/testReport)** for PR 17080 at commit

[GitHub] spark issue #17081: [SPARK-18726][SQL]resolveRelation for FileFormat DataSou...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17081 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73798/ Test PASSed. ---

[GitHub] spark issue #17081: [SPARK-18726][SQL]resolveRelation for FileFormat DataSou...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17081 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17145: [SPARK-19805][TEST] Log the row type when query type dos...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17145 **[Test build #73806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73806/testReport)** for PR 17145 at commit

[GitHub] spark issue #17081: [SPARK-18726][SQL]resolveRelation for FileFormat DataSou...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17081 **[Test build #73798 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73798/testReport)** for PR 17081 at commit

[GitHub] spark pull request #17145: [SPARK-19805][TEST] Log the row type when query t...

2017-03-02 Thread uncleGen
GitHub user uncleGen opened a pull request: https://github.com/apache/spark/pull/17145 [SPARK-19805][TEST] Log the row type when query type dose not match ## What changes were proposed in this pull request? before pr: ``` == Results == !== Correct Answer -

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-03-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r104084674 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -195,17 +207,20 @@ private[hive] class

[GitHub] spark issue #17074: [SPARK-18646][REPL] Set parent classloader as null for E...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17074 **[Test build #73805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73805/testReport)** for PR 17074 at commit

[GitHub] spark pull request #17076: [SPARK-19745][ML] SVCAggregator captures coeffici...

2017-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17076 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17076: [SPARK-19745][ML] SVCAggregator captures coefficients in...

2017-03-02 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/17076 The failure is irrelevant, I'll merge this into master, thanks for all. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-03-02 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/15435 I mean that I thought we would put all the method implementations in the traits, so that the `Impl` classes only have to extend them and not implement anything themselves. So, the impl class would

[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17124 **[Test build #73803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73803/testReport)** for PR 17124 at commit

[GitHub] spark issue #12461: [SPARK-14409][ML] Adding a RankingEvaluator to ML

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12461 **[Test build #73804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73804/testReport)** for PR 12461 at commit

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-03-02 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/15435 @sethah I think `truePositiveRate` is equivalent to `recall` so I directly implement another one in the trait, but if you don't like this way I can modify it. Is there anything else need

[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

2017-03-02 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/17124 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-03-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r104081966 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -195,17 +207,20 @@ private[hive] class

[GitHub] spark issue #17113: [SPARK-13669][Core] Improve the blacklist mechanism to h...

2017-03-02 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17113 @tgravescs , thanks a lot for your comments. Actually the issue here is a simulated one from my test cluster, I didn't get an issue report from real customers. Yes, in most of

[GitHub] spark issue #17140: [SPARK-19796][CORE] Fix serialization of long property v...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17140 **[Test build #73802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73802/testReport)** for PR 17140 at commit

[GitHub] spark issue #17074: [SPARK-18646][REPL] Set parent classloader as null for E...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17074 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73801/ Test FAILed. ---

[GitHub] spark issue #17074: [SPARK-18646][REPL] Set parent classloader as null for E...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17074 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17074: [SPARK-18646][REPL] Set parent classloader as null for E...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17074 **[Test build #73801 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73801/testReport)** for PR 17074 at commit

[GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...

2017-03-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16944#discussion_r104081425 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -597,6 +597,16 @@ private[spark] class

[GitHub] spark issue #17074: [SPARK-18646][REPL] Set parent classloader as null for E...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17074 **[Test build #73801 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73801/testReport)** for PR 17074 at commit

[GitHub] spark issue #17144: [SPARK-19803][TEST] flaky BlockManagerReplicationSuite t...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17144 **[Test build #73800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73800/testReport)** for PR 17144 at commit

[GitHub] spark pull request #17144: [SPARK-19803][TEST] flaky BlockManagerReplication...

2017-03-02 Thread uncleGen
GitHub user uncleGen opened a pull request: https://github.com/apache/spark/pull/17144 [SPARK-19803][TEST] flaky BlockManagerReplicationSuite test failure ## What changes were proposed in this pull request? give more time for replication to happen and new block be reported

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-03-02 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/15435 @WeichenXu123 Thanks for the updates. I'm wondering why the `Impl` classes have the method implementations? I thought we should just put the implementations (e.g. `falsePositiveRateByLabel`, etc...)

[GitHub] spark issue #17074: [SPARK-18646][REPL] Set parent classloader as null for E...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17074 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17074: [SPARK-18646][REPL] Set parent classloader as null for E...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17074 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73799/ Test FAILed. ---

[GitHub] spark issue #17074: [SPARK-18646][REPL] Set parent classloader as null for E...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17074 **[Test build #73799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73799/testReport)** for PR 17074 at commit

[GitHub] spark issue #17074: [SPARK-18646][REPL] Set parent classloader as null for E...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17074 **[Test build #73799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73799/testReport)** for PR 17074 at commit

[GitHub] spark issue #17081: [SPARK-18726][SQL]resolveRelation for FileFormat DataSou...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17081 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17081: [SPARK-18726][SQL]resolveRelation for FileFormat DataSou...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17081 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73793/ Test PASSed. ---

[GitHub] spark issue #17081: [SPARK-18726][SQL]resolveRelation for FileFormat DataSou...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17081 **[Test build #73793 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73793/testReport)** for PR 17081 at commit

[GitHub] spark issue #17133: [SPARK-19793] Use clock.getTimeMillis when mark task as ...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17133 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73795/ Test FAILed. ---

[GitHub] spark issue #17133: [SPARK-19793] Use clock.getTimeMillis when mark task as ...

2017-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17133 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17133: [SPARK-19793] Use clock.getTimeMillis when mark task as ...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17133 **[Test build #73795 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73795/testReport)** for PR 17133 at commit

[GitHub] spark issue #17122: [SPARK-19786][SQL] Facilitate loop optimizations in a JI...

2017-03-02 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17122 Have few suggestions about the code comments. Otherwise LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

2017-03-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r104078113 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -206,6 +206,18 @@ trait CodegenSupport extends

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

2017-03-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r104077831 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -206,6 +206,18 @@ trait CodegenSupport extends

[GitHub] spark pull request #17135: SPARK-19794 Release HDFS Client after read/write ...

2017-03-02 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/17135#discussion_r104077712 --- Diff: core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala --- @@ -279,8 +287,13 @@ private[spark] object ReliableCheckpointRDD

[GitHub] spark issue #17052: [SPARK-19690][SS] Join a streaming DataFrame with a batc...

2017-03-02 Thread uncleGen
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/17052 ping @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #17135: SPARK-19794 Release HDFS Client after read/write ...

2017-03-02 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/17135#discussion_r104077402 --- Diff: core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala --- @@ -181,21 +181,26 @@ private[spark] object ReliableCheckpointRDD

[GitHub] spark issue #17143: [SPARK-19801][BUILD] Remove JDK7 from Travis CI

2017-03-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17143 Thank you, @felixcheung . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #15505: [SPARK-18890][CORE] Move task serialization from the Tas...

2017-03-02 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/15505 @kayousterhout I am surprised it is not more, but I agree that the added complexity for such low returns is not worth it. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

2017-03-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r104076198 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -206,6 +206,18 @@ trait CodegenSupport extends

[GitHub] spark issue #17081: [SPARK-18726][SQL]resolveRelation for FileFormat DataSou...

2017-03-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17081 **[Test build #73798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73798/testReport)** for PR 17081 at commit

[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

2017-03-02 Thread gf53520
Github user gf53520 commented on the issue: https://github.com/apache/spark/pull/17124 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16981: [SPARK-19637][SQL] Add from_json/to_json in FunctionRegi...

2017-03-02 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/16981 So, this pr re-used `DataType.fromJson` here: https://github.com/apache/spark/pull/16981/files#diff-113a2b8242f0ee6ec3914f539f119619R65. But, I know this is some arguable. I also think it'd be

[GitHub] spark issue #17140: [SPARK-19796][CORE] Fix serialization of long property v...

2017-03-02 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/17140 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

<    1   2   3   4   5   6   7   >