[GitHub] spark pull request #16811: [SPARK-17629][ML] methods to return synonyms dire...

2017-03-07 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/16811#discussion_r104861465 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala --- @@ -134,13 +134,20 @@ class Word2VecSuite extends SparkFunSuite with

[GitHub] spark pull request #17204: [SPARK-19864][SQL]provide a makeQualifiedPath fun...

2017-03-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17204#discussion_r104861159 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala --- @@ -337,4 +339,15 @@ private[sql] object SQLTestUtils {

[GitHub] spark pull request #17200: [SPARK-19561][Python] cast TimestampType.toIntern...

2017-03-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17200#discussion_r104861095 --- Diff: python/pyspark/sql/types.py --- @@ -189,7 +189,7 @@ def toInternal(self, dt): if dt is not None: seconds =

[GitHub] spark issue #17204: [SPARK-19864][SQL]provide a makeQualifiedPath functions ...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17204 **[Test build #74189 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74189/testReport)** for PR 17204 at commit

[GitHub] spark issue #17139: [SPARK-18890][CORE](try 3) Move task serialization from ...

2017-03-07 Thread witgo
Github user witgo commented on the issue: https://github.com/apache/spark/pull/17139 Added the multi-threaded code for serialization `TaskDescription` . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17204: [SPARK-19864][SQL]provide a makeQualifiedPath functions ...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17204 **[Test build #74188 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74188/testReport)** for PR 17204 at commit

[GitHub] spark issue #17201: [SPARK-18055][SQL] Use correct mirror in ExpresionEncode...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17201 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74177/ Test PASSed. ---

[GitHub] spark issue #17201: [SPARK-18055][SQL] Use correct mirror in ExpresionEncode...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17201 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17146: [SPARK-19806][ML][PySpark] PySpark GeneralizedLinearRegr...

2017-03-07 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17146 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #17200: [SPARK-19561][Python] cast TimestampType.toIntern...

2017-03-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17200#discussion_r104858211 --- Diff: python/pyspark/sql/types.py --- @@ -189,7 +189,7 @@ def toInternal(self, dt): if dt is not None: seconds =

[GitHub] spark issue #17201: [SPARK-18055][SQL] Use correct mirror in ExpresionEncode...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17201 **[Test build #74177 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74177/testReport)** for PR 17201 at commit

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

2017-03-07 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16729 yea - I'm sorry if it was confusing - I was referring to `SparkR::tweedie` (2 `:`), and not `SparkR:::tweedie` (3 `:`), which was why I wasn't sure that could be done. In the past

[GitHub] spark pull request #17200: [SPARK-19561][Python] cast TimestampType.toIntern...

2017-03-07 Thread JasonMWhite
Github user JasonMWhite commented on a diff in the pull request: https://github.com/apache/spark/pull/17200#discussion_r104856801 --- Diff: python/pyspark/sql/types.py --- @@ -189,7 +189,7 @@ def toInternal(self, dt): if dt is not None: seconds =

[GitHub] spark issue #16933: [SPARK-19601] [SQL] Fix CollapseRepartition rule to pres...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16933 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74179/ Test PASSed. ---

[GitHub] spark pull request #17096: [SPARK-15243][ML][SQL][PYTHON] Add missing suppor...

2017-03-07 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17096#discussion_r104856634 --- Diff: python/pyspark/ml/tests.py --- @@ -320,6 +320,13 @@ def test_hasparam(self): testParams = TestParams()

[GitHub] spark issue #16933: [SPARK-19601] [SQL] Fix CollapseRepartition rule to pres...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16933 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16933: [SPARK-19601] [SQL] Fix CollapseRepartition rule to pres...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16933 **[Test build #74179 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74179/testReport)** for PR 16933 at commit

[GitHub] spark issue #17205: [SPARK-19843] [SQL] [Followup] Classdoc for `IntWrapper`...

2017-03-07 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/17205 LGTM too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #17200: [SPARK-19561][Python] cast TimestampType.toIntern...

2017-03-07 Thread JasonMWhite
Github user JasonMWhite commented on a diff in the pull request: https://github.com/apache/spark/pull/17200#discussion_r104856310 --- Diff: python/pyspark/sql/types.py --- @@ -189,7 +189,7 @@ def toInternal(self, dt): if dt is not None: seconds =

[GitHub] spark issue #17204: [SPARK-19864][SQL]provide a makeQualifiedPath functions ...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17204 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74176/ Test PASSed. ---

[GitHub] spark issue #17204: [SPARK-19864][SQL]provide a makeQualifiedPath functions ...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17204 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17197: [SPARK-19858][SS]Add output mode to flatMapGroupsWithSta...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17197 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74180/ Test PASSed. ---

[GitHub] spark issue #17204: [SPARK-19864][SQL]provide a makeQualifiedPath functions ...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17204 **[Test build #74176 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74176/testReport)** for PR 17204 at commit

[GitHub] spark issue #17197: [SPARK-19858][SS]Add output mode to flatMapGroupsWithSta...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17197 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17197: [SPARK-19858][SS]Add output mode to flatMapGroupsWithSta...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17197 **[Test build #74180 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74180/testReport)** for PR 17197 at commit

[GitHub] spark issue #16944: [SPARK-19611][SQL] Introduce configurable table schema i...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16944 **[Test build #74187 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74187/testReport)** for PR 16944 at commit

[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17075 **[Test build #74186 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74186/testReport)** for PR 17075 at commit

[GitHub] spark pull request #17200: [SPARK-19561][Python] cast TimestampType.toIntern...

2017-03-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17200#discussion_r104855668 --- Diff: python/pyspark/sql/types.py --- @@ -189,7 +189,7 @@ def toInternal(self, dt): if dt is not None: seconds =

[GitHub] spark issue #16944: [SPARK-19611][SQL] Introduce configurable table schema i...

2017-03-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16944 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...

2017-03-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17075 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

2017-03-07 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16729 @felixcheung Could you take a look at this new fix when you get a chance? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15009 **[Test build #74185 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74185/testReport)** for PR 15009 at commit

[GitHub] spark pull request #17146: [SPARK-19806][ML][PySpark] PySpark GeneralizedLin...

2017-03-07 Thread actuaryzhang
Github user actuaryzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/17146#discussion_r104853968 --- Diff: python/pyspark/ml/tests.py --- @@ -1223,6 +1223,26 @@ def test_apply_binary_term_freqs(self): ":

[GitHub] spark issue #17146: [SPARK-19806][ML][PySpark] PySpark GeneralizedLinearRegr...

2017-03-07 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/17146 This looks good to me. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #15363: [SPARK-17791][SQL] Join reordering using star schema det...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15363 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74175/ Test PASSed. ---

[GitHub] spark issue #15363: [SPARK-17791][SQL] Join reordering using star schema det...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15363 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15363: [SPARK-17791][SQL] Join reordering using star schema det...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15363 **[Test build #74175 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74175/testReport)** for PR 15363 at commit

[GitHub] spark issue #17186: [SPARK-19846][SQL] Add a flag to disable constraint prop...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17186 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17186: [SPARK-19846][SQL] Add a flag to disable constraint prop...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17186 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74174/ Test PASSed. ---

[GitHub] spark pull request #17202: [SPARK-19861][SS] watermark should not be a negat...

2017-03-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17202#discussion_r104853064 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -576,6 +576,8 @@ class Dataset[T] private[sql]( val parsedDelay =

[GitHub] spark issue #17186: [SPARK-19846][SQL] Add a flag to disable constraint prop...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17186 **[Test build #74174 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74174/testReport)** for PR 17186 at commit

[GitHub] spark issue #15009: [SPARK-17443][SPARK-11035] Stop Spark Application if lau...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15009 **[Test build #74184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74184/testReport)** for PR 15009 at commit

[GitHub] spark issue #17205: [SPARK-19843] [SQL] [Followup] Classdoc for `IntWrapper`...

2017-03-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17205 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17075 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74181/ Test FAILed. ---

[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17075 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17075 **[Test build #74181 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74181/testReport)** for PR 17075 at commit

[GitHub] spark issue #17205: [SPARK-19843] [SQL] [Followup] Classdoc for `IntWrapper`...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17205 **[Test build #74183 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74183/testReport)** for PR 17205 at commit

[GitHub] spark pull request #17184: [SPARK-19843] [SQL] UTF8String => (int / long) co...

2017-03-07 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/17184#discussion_r104851283 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -850,26 +850,27 @@ public UTF8String

[GitHub] spark pull request #17205: [SPARK-19843] [SQL] [Followup] Classdoc for `IntW...

2017-03-07 Thread tejasapatil
GitHub user tejasapatil opened a pull request: https://github.com/apache/spark/pull/17205 [SPARK-19843] [SQL] [Followup] Classdoc for `IntWrapper` and `LongWrapper` ## What changes were proposed in this pull request? This is as per suggestion by @rxin at :

[GitHub] spark issue #17186: [SPARK-19846][SQL] Add a flag to disable constraint prop...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17186 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17186: [SPARK-19846][SQL] Add a flag to disable constraint prop...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17186 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74173/ Test PASSed. ---

[GitHub] spark issue #17186: [SPARK-19846][SQL] Add a flag to disable constraint prop...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17186 **[Test build #74173 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74173/testReport)** for PR 17186 at commit

[GitHub] spark issue #17202: [SPARK-19861][SS] watermark should not be a negative tim...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17202 **[Test build #74182 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74182/testReport)** for PR 17202 at commit

[GitHub] spark issue #17202: [SPARK-19861][SS] watermark should not be a negative tim...

2017-03-07 Thread uncleGen
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/17202 cc @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #16896: [SPARK-19561][Python] cast TimestampType.toInternal outp...

2017-03-07 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/16896 My bad, did not realized that, sorry. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17200: [SPARK-19561][Python] cast TimestampType.toInternal outp...

2017-03-07 Thread JasonMWhite
Github user JasonMWhite commented on the issue: https://github.com/apache/spark/pull/17200 Ah, test failed on Python 3.4 only. That makes some sense, I only tested locally on 2.6, and there are changes with how Python 3 handles ints vs longs. I'll dig in with Python 3.4 and see if I

[GitHub] spark issue #17202: [SPARK-19861][SS] watermark should not be a negative tim...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17202 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17202: [SPARK-19861][SS] watermark should not be a negative tim...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17202 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74172/ Test PASSed. ---

[GitHub] spark issue #17202: [SPARK-19861][SS] watermark should not be a negative tim...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17202 **[Test build #74172 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74172/testReport)** for PR 17202 at commit

[GitHub] spark pull request #17200: [SPARK-19561][Python] cast TimestampType.toIntern...

2017-03-07 Thread JasonMWhite
Github user JasonMWhite commented on a diff in the pull request: https://github.com/apache/spark/pull/17200#discussion_r104847039 --- Diff: python/pyspark/sql/tests.py --- @@ -1435,6 +1435,12 @@ def test_time_with_timezone(self): self.assertEqual(now, now1)

[GitHub] spark issue #17001: [SPARK-19667][SQL]create table with hiveenabled in defau...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17001 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17001: [SPARK-19667][SQL]create table with hiveenabled in defau...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17001 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74170/ Test PASSed. ---

[GitHub] spark issue #17001: [SPARK-19667][SQL]create table with hiveenabled in defau...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17001 **[Test build #74170 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74170/testReport)** for PR 17001 at commit

[GitHub] spark pull request #17200: [SPARK-19561][Python] cast TimestampType.toIntern...

2017-03-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17200#discussion_r104845981 --- Diff: python/pyspark/sql/tests.py --- @@ -1435,6 +1435,12 @@ def test_time_with_timezone(self): self.assertEqual(now, now1)

[GitHub] spark issue #17186: [SPARK-19846][SQL] Add a flag to disable constraint prop...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17186 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17186: [SPARK-19846][SQL] Add a flag to disable constraint prop...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17186 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74171/ Test PASSed. ---

[GitHub] spark issue #17186: [SPARK-19846][SQL] Add a flag to disable constraint prop...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17186 **[Test build #74171 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74171/testReport)** for PR 17186 at commit

[GitHub] spark pull request #17184: [SPARK-19843] [SQL] UTF8String => (int / long) co...

2017-03-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/17184#discussion_r104845661 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -897,41 +898,52 @@ public long toLong() { break;

[GitHub] spark issue #15180: FIX: AggregatedDialect does not quote identifier correct...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15180 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17184: [SPARK-19843] [SQL] UTF8String => (int / long) co...

2017-03-07 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/17184#discussion_r104843817 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -897,41 +898,52 @@ public long toLong() {

[GitHub] spark issue #17200: [SPARK-19561][Python] cast TimestampType.toInternal outp...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17200 **[Test build #74178 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74178/testReport)** for PR 17200 at commit

[GitHub] spark issue #17200: [SPARK-19561][Python] cast TimestampType.toInternal outp...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17200 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74178/ Test FAILed. ---

[GitHub] spark issue #17200: [SPARK-19561][Python] cast TimestampType.toInternal outp...

2017-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17200 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17193: [SPARK-19348][PYTHON] PySpark keyword_only decora...

2017-03-07 Thread BryanCutler
Github user BryanCutler closed the pull request at: https://github.com/apache/spark/pull/17193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #17195: [SPARK-19348][PYTHON] PySpark keyword_only decora...

2017-03-07 Thread BryanCutler
Github user BryanCutler closed the pull request at: https://github.com/apache/spark/pull/17195 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #17195: [SPARK-19348][PYTHON] PySpark keyword_only decorator is ...

2017-03-07 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/17195 Sure, no problem! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17195: [SPARK-19348][PYTHON] PySpark keyword_only decorator is ...

2017-03-07 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17195 LGTM Merging with branch-2.0 Thank you again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #17193: [SPARK-19348][PYTHON] PySpark keyword_only decorator is ...

2017-03-07 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17193 LGTM Merging with branch-2.1 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17075 **[Test build #74181 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74181/testReport)** for PR 17075 at commit

[GitHub] spark issue #17197: [SPARK-19858][SS]Add output mode to flatMapGroupsWithSta...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17197 **[Test build #74180 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74180/testReport)** for PR 17197 at commit

[GitHub] spark issue #17197: [SPARK-19858][SS]Add output mode to flatMapGroupsWithSta...

2017-03-07 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/17197 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #16811: [SPARK-17629][ML] methods to return synonyms dire...

2017-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16811 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16811: [SPARK-17629][ML] methods to return synonyms directly

2017-03-07 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/16811 Thanks! I made a follow-up JIRA for updating the Python API: https://issues.apache.org/jira/browse/SPARK-19866 --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #17200: [SPARK-19561][Python] cast TimestampType.toInternal outp...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17200 **[Test build #74178 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74178/testReport)** for PR 17200 at commit

[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...

2017-03-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17075 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16933: [SPARK-19601] [SQL] Fix CollapseRepartition rule to pres...

2017-03-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16933 **[Test build #74179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74179/testReport)** for PR 16933 at commit

[GitHub] spark pull request #17199: [SPARK-19859][SS]The new watermark should overrid...

2017-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17199 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17200: [SPARK-19561][Python] cast TimestampType.toInternal outp...

2017-03-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17200 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #16933: [SPARK-19601] [SQL] Fix CollapseRepartition rule to pres...

2017-03-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16933 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16811: [SPARK-17629][ML] methods to return synonyms directly

2017-03-07 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/16811 LGTM Merging with master Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17183: [SPARK-19841][SS]watermarkPredicate should filter...

2017-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17183 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17184: [SPARK-19843] [SQL] UTF8String => (int / long) co...

2017-03-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17184#discussion_r104842090 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -897,41 +898,52 @@ public long toLong() { break;

[GitHub] spark issue #17199: [SPARK-19859][SS]The new watermark should override the o...

2017-03-07 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/17199 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17183: [SPARK-19841][SS]watermarkPredicate should filter based ...

2017-03-07 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/17183 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17184: [SPARK-19843] [SQL] UTF8String => (int / long) conversio...

2017-03-07 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/17184 I believe IBM J9 actually improved this specific case (their JIT handles tons of exceptions better). Oh well -- if only JIT is perfect. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #16883: [SPARK-17498][ML] StringIndexer enhancement for handling...

2017-03-07 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/16883 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #17184: [SPARK-19843] [SQL] UTF8String => (int / long) co...

2017-03-07 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/17184#discussion_r104841803 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -850,26 +850,27 @@ public UTF8String

[GitHub] spark pull request #17184: [SPARK-19843] [SQL] UTF8String => (int / long) co...

2017-03-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/17184#discussion_r104841789 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -897,41 +898,52 @@ public long toLong() { break;

[GitHub] spark pull request #17184: [SPARK-19843] [SQL] UTF8String => (int / long) co...

2017-03-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/17184#discussion_r104841761 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -897,41 +898,52 @@ public long toLong() { break;

[GitHub] spark pull request #17184: [SPARK-19843] [SQL] UTF8String => (int / long) co...

2017-03-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/17184#discussion_r104841735 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -850,26 +850,27 @@ public UTF8String translate(Map

  1   2   3   4   5   6   7   8   9   >