Github user dbolshak commented on the issue:
https://github.com/apache/spark/pull/17458
Corrected.
Please take a look.
There is only one change (in 2 places) related to calling toSeq which has
comment, but it's not clear can I leave my change or not.
---
If your project is
Github user dbolshak commented on a diff in the pull request:
https://github.com/apache/spark/pull/17458#discussion_r108890304
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllStagesPage.scala
---
@@ -34,9 +34,9 @@ private[ui] class AllStagesPage(parent: StagesTab)
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17430
**[Test build #75387 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75387/testReport)**
for PR 17430 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17477
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17477
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75381/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17477
**[Test build #75381 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75381/testReport)**
for PR 17477 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17443
@aseigneurin Please read http://spark.apache.org/contributing.html too. As
you might imagine "typos" isn't useful as a title. Write "[MINOR]" too
---
If your project is set up for it, you can reply
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17472
**[Test build #75386 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75386/testReport)**
for PR 17472 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17430
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17452#discussion_r108885749
--- Diff: dev/make-distribution.sh ---
@@ -217,43 +217,43 @@ fi
# Make R package - this is used for both CRAN release and packing R layout
into
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17417
Looks good, just needs a rebase now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user samelamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17472#discussion_r108884506
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -46,18 +46,22 @@
private static final boolean unaligned;
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17472#discussion_r108884076
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -46,18 +46,22 @@
private static final boolean unaligned;
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/17467
You're a gen @HyukjinKwon ð¯ . I will wait for Tathagata and Burak's
inputs then :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17442
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17477
**[Test build #75385 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75385/testReport)**
for PR 17477 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17477#discussion_r108882566
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -704,12 +704,12 @@ private[spark] object TaskSchedulerImpl {
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17442
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17251
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75384/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17251
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17251
**[Test build #75384 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75384/testReport)**
for PR 17251 at commit
Github user samelamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17472#discussion_r108881923
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -46,18 +46,22 @@
private static final boolean unaligned;
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17329#discussion_r108881597
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java
---
@@ -37,13 +37,24 @@
* A {@link
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17472#discussion_r108880865
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -46,18 +46,22 @@
private static final boolean unaligned;
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17458#discussion_r108880632
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -116,15 +116,15 @@ private[spark] abstract class WebUI(
* @param path Path in UI
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17479
I don't think this is worth changing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17324#discussion_r108880024
--- Diff: examples/src/main/python/ml/imputer_example.py ---
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17479#discussion_r108879364
--- Diff:
core/src/main/resources/org/apache/spark/ui/static/executorspage-template.html
---
@@ -24,7 +24,7 @@ Summary
RDD
Github user samelamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17472#discussion_r108879329
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -46,18 +46,22 @@
private static final boolean unaligned;
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17472#discussion_r108878462
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -46,18 +46,22 @@
private static final boolean unaligned;
Github user guoxiaolongzte commented on a diff in the pull request:
https://github.com/apache/spark/pull/17479#discussion_r108876916
--- Diff:
core/src/main/resources/org/apache/spark/ui/static/executorspage-template.html
---
@@ -24,7 +24,7 @@ Summary
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/17479#discussion_r108875608
--- Diff:
core/src/main/resources/org/apache/spark/ui/static/executorspage-template.html
---
@@ -24,7 +24,7 @@ Summary
RDD
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17458#discussion_r108874836
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala ---
@@ -42,7 +42,7 @@ private[ui] class RDDPage(parent: StorageTab) extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17458#discussion_r108874623
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/UIData.scala ---
@@ -180,8 +180,8 @@ private[spark] object UIData {
speculative =
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17458#discussion_r108874489
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagesTab.scala ---
@@ -35,7 +35,7 @@ private[ui] class StagesTab(parent: SparkUI) extends
Github user samelamin commented on the issue:
https://github.com/apache/spark/pull/17472
Can someone guide me why the tests failed? is it another flakey test or?
because the below message doesnt make sense to me :(
> Traceback (most recent call last):
> File
Github user samelamin commented on the issue:
https://github.com/apache/spark/pull/17472
jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dbolshak commented on the issue:
https://github.com/apache/spark/pull/17458
@srowen, @HyukjinKwon could you please merge the PR if it's ok of course?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user erenavsarogullari commented on the issue:
https://github.com/apache/spark/pull/15326
Hi @kayousterhout and @markhamstra,
- This PR is ready for review in the light of first-added-wins
(Schedulables: `Pool` / `TaskSetManager`) pattern. All feedback are welcome in
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17324
**[Test build #75383 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75383/testReport)**
for PR 17324 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17324
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75383/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17324
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17468
@gatorsmile, could you take a look please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17478
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17478
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75382/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17478
**[Test build #75382 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75382/testReport)**
for PR 17478 at commit
Github user guoxiaolongzte commented on a diff in the pull request:
https://github.com/apache/spark/pull/17479#discussion_r108863264
--- Diff:
core/src/main/resources/org/apache/spark/ui/static/executorspage-template.html
---
@@ -24,7 +24,7 @@ Summary
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/17479#discussion_r108862872
--- Diff:
core/src/main/resources/org/apache/spark/ui/static/executorspage-template.html
---
@@ -24,7 +24,7 @@ Summary
RDD
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17479
I think UI change requires a screenshot as written above. It seems trivial
though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17479
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user guoxiaolongzte opened a pull request:
https://github.com/apache/spark/pull/17479
[SPARK-20154][Web UI]In web ui,http://ip:4040/executors/,the title 'Storage
Memory' shouldâ¦
⦠modify 'Storage Memory used/total'
## What changes were proposed in this pull
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17419#discussion_r108858117
--- Diff: mllib/src/main/scala/org/apache/spark/ml/stat/Summarizer.scala ---
@@ -0,0 +1,746 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17477#discussion_r108857749
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -704,12 +704,12 @@ private[spark] object TaskSchedulerImpl {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17419#discussion_r108856798
--- Diff: mllib/src/main/scala/org/apache/spark/ml/stat/Summarizer.scala ---
@@ -0,0 +1,746 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17251
Thank you so much for review, @gatorsmile .
I updated the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17251
**[Test build #75384 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75384/testReport)**
for PR 17251 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17324
**[Test build #75383 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75383/testReport)**
for PR 17324 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/17251#discussion_r108855184
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -590,6 +591,21 @@ object TypeCoercion {
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/17324
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/17251#discussion_r108854836
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
---
@@ -707,6 +707,36 @@ class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/17251#discussion_r108854853
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala ---
@@ -39,9 +39,9 @@ class GeneratorFunctionSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/17251#discussion_r108854595
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -156,9 +157,21 @@ case class Stack(children:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17478
**[Test build #75382 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75382/testReport)**
for PR 17478 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17251
LGTM except a few comments
cc @cloud-fan for the final sign off
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/17375
@holdenk At least some users have more control over Python environment
than a whole cluster setup, and with Anaconda defaulting now to 3.6, it is an
annoyance. Assuming there will be 1.6.4, it
GitHub user wangmiao1981 opened a pull request:
https://github.com/apache/spark/pull/17478
[SPARK-18901][ML]:Require in LR LogisticAggregator is redundant
## What changes were proposed in this pull request?
In MultivariateOnlineSummarizer,
`add` and `merge` have
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17472
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17472
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75380/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17476
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17476
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75379/
Test PASSed.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17477
FYI, If I haven't missed something, all the cases are the instances with
the ones previously fixed. cc @joshrosen, @srowen and @jkbradley. Could you
take a look and see if it makes sense?
---
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17251#discussion_r108853416
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -590,6 +591,21 @@ object TypeCoercion {
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17476
**[Test build #75379 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75379/testReport)**
for PR 17476 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17477
**[Test build #75381 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75381/testReport)**
for PR 17477 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17477#discussion_r108853043
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -74,7 +74,7 @@ abstract class Classifier[
*
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17477#discussion_r108852891
--- Diff: mllib/src/test/scala/org/apache/spark/ml/PipelineSuite.scala ---
@@ -230,7 +230,9 @@ class PipelineSuite extends SparkFunSuite with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17251#discussion_r108852801
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala ---
@@ -39,9 +39,9 @@ class GeneratorFunctionSuite extends QueryTest
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/17477
[SPARK-18692][BUILD][DOCS] Test Java 8 unidoc build on Jenkins
## What changes were proposed in this pull request?
This PR proposes to run Spark unidoc to test Javadoc 8 build as
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17251#discussion_r108852699
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
---
@@ -707,6 +707,36 @@ class TypeCoercionSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17251#discussion_r108852596
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -156,9 +157,21 @@ case class Stack(children:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/17436
@sameeragarwal @cloud-fan could you review this except `SparkConf.scala`
while there are four failures. They are not regressions.
This is because `SparkConf.scala` is changed for tentatively
Github user ScrapCodes commented on the issue:
https://github.com/apache/spark/pull/17308
@tdas ping !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17472
**[Test build #75380 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75380/testReport)**
for PR 17472 at commit
Github user samelamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17472#discussion_r108849902
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -46,18 +46,22 @@
private static final boolean unaligned;
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17436
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17436
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75377/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17436
**[Test build #75377 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75377/testReport)**
for PR 17436 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17467
I am not used to Kinesis. I usually click blame button and check both the
recent code modifier and committer, e.g.,
301 - 388 of 388 matches
Mail list logo
