[GitHub] spark pull request #17630: [SPARK-20318][SQL] Use Catalyst type for min/max ...

2017-04-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17630 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17630: [SPARK-20318][SQL] Use Catalyst type for min/max in Colu...

2017-04-14 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17630 LGTM, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17596: [SPARK-12837][CORE] Do not send the accumulator name to ...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17596 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17596: [SPARK-12837][CORE] Do not send the accumulator name to ...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17596 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75803/ Test FAILed. ---

[GitHub] spark issue #17596: [SPARK-12837][CORE] Do not send the accumulator name to ...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17596 **[Test build #75803 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75803/testReport)** for PR 17596 at commit

[GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...

2017-04-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17568#discussion_r111561928 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetPrimitiveSuite.scala --- @@ -253,4 +256,27 @@ class DatasetPrimitiveSuite extends QueryTest

[GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...

2017-04-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17568#discussion_r111561852 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/objects.scala --- @@ -96,3 +99,32 @@ object CombineTypedFilters extends

[GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...

2017-04-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17568#discussion_r111561061 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -368,6 +369,8 @@ case class NullPropagation(conf:

[GitHub] spark issue #17533: [WIP][SPARK-20219] Schedule tasks based on size of input...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17533 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75802/ Test FAILed. ---

[GitHub] spark issue #17533: [WIP][SPARK-20219] Schedule tasks based on size of input...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17533 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17533: [WIP][SPARK-20219] Schedule tasks based on size of input...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17533 **[Test build #75802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75802/testReport)** for PR 17533 at commit

[GitHub] spark issue #17568: [SPARK-20254][SQL] Remove unnecessary data conversion fo...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17568 **[Test build #75807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75807/testReport)** for PR 17568 at commit

[GitHub] spark issue #17638: [SPARK-20338][CORE]Spaces in spark.eventLog.dir are not ...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17638 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17416: [SPARK-20075][CORE][WIP] Support classifier, packaging i...

2017-04-14 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17416 @sethah yeah it downloads the right models jar and copies it into the ivy cache. It just doesn't know that it's what belongs on the classpath. spark.jars doesn't get the memo and I can see why,

[GitHub] spark pull request #17638: [SPARK-20338][CORE]Spaces in spark.eventLog.dir a...

2017-04-14 Thread zuotingbing
GitHub user zuotingbing opened a pull request: https://github.com/apache/spark/pull/17638 [SPARK-20338][CORE]Spaces in spark.eventLog.dir are not correctly handled ## What changes were proposed in this pull request? Spaces in spark.eventLog.dir are not correctly handled

[GitHub] spark issue #17628: [SPARK-20316][SQL] Val and Var should strictly follow th...

2017-04-14 Thread ouyangxiaochen
Github user ouyangxiaochen commented on the issue: https://github.com/apache/spark/pull/17628 OK, I got it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17637: [SPARK-20337][CORE] Support upgrade a jar dependency and...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17637 **[Test build #75806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75806/testReport)** for PR 17637 at commit

[GitHub] spark issue #17533: [WIP][SPARK-20219] Schedule tasks based on size of input...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17533 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17533: [WIP][SPARK-20219] Schedule tasks based on size of input...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17533 **[Test build #75800 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75800/testReport)** for PR 17533 at commit

[GitHub] spark issue #17533: [WIP][SPARK-20219] Schedule tasks based on size of input...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17533 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75800/ Test FAILed. ---

[GitHub] spark pull request #17637: [SPARK-20337][CORE] Support upgrade a jar depende...

2017-04-14 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/17637 [SPARK-20337][CORE] Support upgrade a jar dependency and don't restart SparkContext ## What changes were proposed in this pull request? Support upgrade a jar dependency and don't restart

[GitHub] spark issue #17628: [SPARK-20316][SQL] Val and Var should strictly follow th...

2017-04-14 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17628 `"*"` does not mean what you intend -- you mean `".*"` at least, among other things. It's maybe not worth pursuing further, but that's the kind of quick check I'd expect when proposing to adjust one

[GitHub] spark issue #17530: [SPARK-5158] Access kerberized HDFS from Spark standalon...

2017-04-14 Thread themodernlife
Github user themodernlife commented on the issue: https://github.com/apache/spark/pull/17530 There is a spot in HadoopFSCredentialProvider where it looks for a Hadoop config key related to yarn to set the token renewer. In getTokenRenewer it calls

[GitHub] spark issue #17628: [SPARK-20316][SQL] Val and Var should strictly follow th...

2017-04-14 Thread ouyangxiaochen
Github user ouyangxiaochen commented on the issue: https://github.com/apache/spark/pull/17628 @srowen Do u mean that my regex can not match all variable name? because scala's variable name can be consisted with letter|digital|_|$? I serached the instances of `var foo="string" `with

[GitHub] spark issue #17636: [SPARK-20334][SQL] Return a better error message when co...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17636 **[Test build #75805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75805/testReport)** for PR 17636 at commit

[GitHub] spark pull request #17632: [SPARK-19946][TESTS][BACKPORT-2.1] DebugFilesyste...

2017-04-14 Thread bogdanrdc
Github user bogdanrdc closed the pull request at: https://github.com/apache/spark/pull/17632 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17636: [SPARK-20334][SQL] Return a better error message when co...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17636 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17636: [SPARK-20334][SQL] Return a better error message when co...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17636 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75798/ Test PASSed. ---

[GitHub] spark issue #17636: [SPARK-20334][SQL] Return a better error message when co...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17636 **[Test build #75798 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75798/testReport)** for PR 17636 at commit

[GitHub] spark issue #17568: [SPARK-20254][SQL] Remove unnecessary data conversion fo...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17568 **[Test build #75804 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75804/testReport)** for PR 17568 at commit

[GitHub] spark issue #17568: [SPARK-20254][SQL] Remove unnecessary data conversion fo...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17568 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75804/ Test FAILed. ---

[GitHub] spark issue #17568: [SPARK-20254][SQL] Remove unnecessary data conversion fo...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17568 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17630: [SPARK-20318][SQL] Use Catalyst type for min/max in Colu...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17630 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17630: [SPARK-20318][SQL] Use Catalyst type for min/max in Colu...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17630 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75797/ Test PASSed. ---

[GitHub] spark issue #17568: [SPARK-20254][SQL] Remove unnecessary data conversion fo...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17568 **[Test build #75804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75804/testReport)** for PR 17568 at commit

[GitHub] spark issue #17630: [SPARK-20318][SQL] Use Catalyst type for min/max in Colu...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17630 **[Test build #75797 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75797/testReport)** for PR 17630 at commit

[GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...

2017-04-14 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17568#discussion_r111553491 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/objects.scala --- @@ -96,3 +99,40 @@ object CombineTypedFilters extends

[GitHub] spark issue #17477: [SPARK-18692][BUILD][DOCS] Test Java 8 unidoc build on J...

2017-04-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17477 Is it okay to just explicitly override the dependency to Avro 1.7.7 in sbt? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...

2017-04-14 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17568#discussion_r111553495 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/objects.scala --- @@ -96,3 +99,40 @@ object CombineTypedFilters extends

[GitHub] spark issue #17623: [SPARK-20292][SQL][WIP] Clean up string representation o...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17623 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75799/ Test FAILed. ---

[GitHub] spark issue #17623: [SPARK-20292][SQL][WIP] Clean up string representation o...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17623 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17623: [SPARK-20292][SQL][WIP] Clean up string representation o...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17623 **[Test build #75799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75799/testReport)** for PR 17623 at commit

[GitHub] spark issue #17628: [SPARK-20316][SQL] Val and Var should strictly follow th...

2017-04-14 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17628 @ouyangxiaochen that still isn't the right regex. Maybe there are no other instances but I'd ask for a minimal effort to find similar instances --- If your project is set up for it, you can reply

[GitHub] spark pull request #17636: [SPARK-20334][SQL] Return a better error message ...

2017-04-14 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/17636#discussion_r111552007 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1219,7 +1241,8 @@ class Analyzer(

[GitHub] spark pull request #17636: [SPARK-20334][SQL] Return a better error message ...

2017-04-14 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/17636#discussion_r111551729 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1210,6 +1210,28 @@ class Analyzer(

[GitHub] spark pull request #17636: [SPARK-20334][SQL] Return a better error message ...

2017-04-14 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/17636#discussion_r111551674 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1219,7 +1241,8 @@ class Analyzer(

[GitHub] spark pull request #17636: [SPARK-20334][SQL] Return a better error message ...

2017-04-14 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/17636#discussion_r111551633 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1219,7 +1241,8 @@ class Analyzer(

[GitHub] spark issue #17586: [SPARK-20249][ML][PYSPARK] Add summary for LinearSVCMode...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17586 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17586: [SPARK-20249][ML][PYSPARK] Add summary for LinearSVCMode...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17586 **[Test build #75801 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75801/testReport)** for PR 17586 at commit

[GitHub] spark issue #17586: [SPARK-20249][ML][PYSPARK] Add summary for LinearSVCMode...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17586 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75801/ Test PASSed. ---

[GitHub] spark issue #17596: [SPARK-12837][CORE] Do not send the accumulator name to ...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17596 **[Test build #75803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75803/testReport)** for PR 17596 at commit

[GitHub] spark issue #17603: [SPARK-20288] Avoid generating the MapStatus by stageId ...

2017-04-14 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/17603 @squito Could you help comment on this ? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...

2017-04-14 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/17634 @squito @srowen Could you help comment on this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #17533: [WIP][SPARK-20219] Schedule tasks based on size of input...

2017-04-14 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/17533 @squito Thank you so much for reviewing thus far and sorry for the complexity I bring in. I tried to simplify the code according to your comment and please take another look when tests

[GitHub] spark issue #17533: [WIP][SPARK-20219] Schedule tasks based on size of input...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17533 **[Test build #75802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75802/testReport)** for PR 17533 at commit

[GitHub] spark pull request #17636: [SPARK-20334][SQL] Return a better error message ...

2017-04-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17636#discussion_r111546429 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1219,7 +1241,8 @@ class Analyzer( //

[GitHub] spark pull request #17533: [WIP][SPARK-20219] Schedule tasks based on size o...

2017-04-14 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/17533#discussion_r111546462 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -168,6 +169,8 @@ private[spark] class TaskSetManager(

[GitHub] spark issue #17636: [SPARK-20334][SQL] Return a better error message when co...

2017-04-14 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17636 LGTM except for few minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #17636: [SPARK-20334][SQL] Return a better error message ...

2017-04-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17636#discussion_r111546332 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1219,7 +1241,8 @@ class Analyzer( //

[GitHub] spark pull request #17636: [SPARK-20334][SQL] Return a better error message ...

2017-04-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17636#discussion_r111546049 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1219,7 +1241,8 @@ class Analyzer( //

[GitHub] spark pull request #17636: [SPARK-20334][SQL] Return a better error message ...

2017-04-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17636#discussion_r111545724 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1210,6 +1210,28 @@ class Analyzer( private def

[GitHub] spark pull request #17533: [WIP][SPARK-20219] Schedule tasks based on size o...

2017-04-14 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/17533#discussion_r111545406 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1080,6 +1122,25 @@ class DAGScheduler( } }

[GitHub] spark pull request #17636: [SPARK-20334][SQL] Return a better error message ...

2017-04-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17636#discussion_r111545425 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1219,7 +1241,8 @@ class Analyzer( //

[GitHub] spark pull request #17533: [WIP][SPARK-20219] Schedule tasks based on size o...

2017-04-14 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/17533#discussion_r111545327 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1080,6 +1122,25 @@ class DAGScheduler( } }

[GitHub] spark pull request #17533: [WIP][SPARK-20219] Schedule tasks based on size o...

2017-04-14 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/17533#discussion_r111545285 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -472,6 +472,47 @@ class DAGScheduler( } /** +

[GitHub] spark pull request #17533: [WIP][SPARK-20219] Schedule tasks based on size o...

2017-04-14 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/17533#discussion_r111545019 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -472,6 +472,47 @@ class DAGScheduler( } /** +

[GitHub] spark issue #17586: [SPARK-20249][ML][PYSPARK] Add summary for LinearSVCMode...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17586 **[Test build #75801 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75801/testReport)** for PR 17586 at commit

[GitHub] spark issue #17533: [WIP][SPARK-20219] Schedule tasks based on size of input...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17533 **[Test build #75800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75800/testReport)** for PR 17533 at commit

[GitHub] spark pull request #17636: [SPARK-20334][SQL] Return a better error message ...

2017-04-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17636#discussion_r111543587 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1219,7 +1241,8 @@ class Analyzer( //

[GitHub] spark pull request #17636: [SPARK-20334][SQL] Return a better error message ...

2017-04-14 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/17636#discussion_r111543471 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1219,7 +1241,8 @@ class Analyzer(

[GitHub] spark pull request #17636: [SPARK-20334][SQL] Return a better error message ...

2017-04-14 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/17636#discussion_r111543306 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1219,7 +1241,8 @@ class Analyzer(

[GitHub] spark pull request #17636: [SPARK-20334][SQL] Return a better error message ...

2017-04-14 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/17636#discussion_r111543112 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/negative-cases/invalid-correlation.sql --- @@ -1,42 +1,72 @@ -- The test file

[GitHub] spark pull request #17636: [SPARK-20334][SQL] Return a better error message ...

2017-04-14 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/17636#discussion_r111543062 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1219,7 +1241,8 @@ class Analyzer(

[GitHub] spark pull request #17636: [SPARK-20334][SQL] Return a better error message ...

2017-04-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17636#discussion_r111543015 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/negative-cases/invalid-correlation.sql --- @@ -1,42 +1,72 @@ -- The test file contains

[GitHub] spark pull request #17636: [SPARK-20334][SQL] Return a better error message ...

2017-04-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17636#discussion_r111542930 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1219,7 +1241,8 @@ class Analyzer( //

[GitHub] spark pull request #17636: [SPARK-20334][SQL] Return a better error message ...

2017-04-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17636#discussion_r111542688 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1219,7 +1241,8 @@ class Analyzer( //

[GitHub] spark issue #17623: [SPARK-20292][SQL][WIP] Clean up string representation o...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17623 **[Test build #75799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75799/testReport)** for PR 17623 at commit

[GitHub] spark issue #17623: [SPARK-20292][SQL][WIP] Clean up string representation o...

2017-04-14 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17623 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #17636: [SPARK-20334][SQL] Return a better error message when co...

2017-04-14 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17636 The error message `...Aggregate expression: min((t2.`t2a` + t3.`t3a`))...` shown in the description seems not from the example query. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #17635: [SPARK-20335] [SQL] Children expressions of Hive UDF imp...

2017-04-14 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17635 LGTM except a minor comment on the test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17635: [SPARK-20335] [SQL] Children expressions of Hive ...

2017-04-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17635#discussion_r111540615 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDAFSuite.scala --- @@ -84,6 +85,21 @@ class HiveUDAFSuite extends QueryTest with

[GitHub] spark issue #17636: [SPARK-20334][SQL] Return a better error message when co...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17636 **[Test build #75798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75798/testReport)** for PR 17636 at commit

[GitHub] spark issue #17630: [SPARK-20318][SQL] Use Catalyst type for min/max in Colu...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17630 **[Test build #75797 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75797/testReport)** for PR 17630 at commit

[GitHub] spark issue #17596: [SPARK-12837][CORE] Do not send the accumulator name to ...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17596 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17596: [SPARK-12837][CORE] Do not send the accumulator n...

2017-04-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17596#discussion_r111538657 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala --- @@ -490,7 +490,7 @@ class

[GitHub] spark issue #17596: [SPARK-12837][CORE] Do not send the accumulator name to ...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17596 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75790/ Test FAILed. ---

[GitHub] spark issue #17636: [SPARK-20334][SQL] Return a better error message when co...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17636 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17635: [SPARK-20335] [SQL] Children expressions of Hive UDF imp...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17635 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17636: [SPARK-20334][SQL] Return a better error message when co...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17636 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75792/ Test FAILed. ---

[GitHub] spark issue #17636: [SPARK-20334][SQL] Return a better error message when co...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17636 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75794/ Test FAILed. ---

[GitHub] spark issue #17636: [SPARK-20334][SQL] Return a better error message when co...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17636 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17635: [SPARK-20335] [SQL] Children expressions of Hive UDF imp...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17635 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75793/ Test FAILed. ---

[GitHub] spark issue #17623: [SPARK-20292][SQL][WIP] Clean up string representation o...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17623 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75795/ Test FAILed. ---

[GitHub] spark issue #17623: [SPARK-20292][SQL][WIP] Clean up string representation o...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17623 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75796/ Test FAILed. ---

[GitHub] spark issue #17623: [SPARK-20292][SQL][WIP] Clean up string representation o...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17623 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17623: [SPARK-20292][SQL][WIP] Clean up string representation o...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17623 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17634 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75788/ Test PASSed. ---

[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...

2017-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17634 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17634 **[Test build #75788 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75788/testReport)** for PR 17634 at commit

[GitHub] spark issue #17623: [SPARK-20292][SQL][WIP] Clean up string representation o...

2017-04-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17623 **[Test build #75796 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75796/testReport)** for PR 17623 at commit

<    1   2   3   >