Github user jinxing64 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17533#discussion_r111545019
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -472,6 +472,47 @@ class DAGScheduler(
       }
     
       /**
    +   * Get ancestor splits in ShuffledRDD.
    +   */
    +  private[spark] def parentSplitsInShuffledRDD(stageId: Int, pId: Int): 
Option[Map[Int, Set[Int]]] =
    --- End diff --
    
    Yes, this is confusing and I need to refine this.
    I'm a little bit hesitant to use `getShuffleDependencies`. I need to get 
the total size of input from `ShuffledRDD` for every child's partition. After 
transformations like `CoalescedRDD`, there may be not a consistent one-to-one 
match between ancestor's partition index and child's partition index. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to