[GitHub] spark pull request #18920: [SPARK-19471][SQL]AggregationIterator does not in...

2017-08-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18920#discussion_r133002116 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -449,6 +451,49 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #18887: [SPARK-20642][core] Store FsHistoryProvider listi...

2017-08-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18887#discussion_r133001818 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala --- @@ -76,6 +76,14 @@ private[history] case class

[GitHub] spark pull request #18887: [SPARK-20642][core] Store FsHistoryProvider listi...

2017-08-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18887#discussion_r133001417 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala --- @@ -31,6 +33,9 @@ class ApplicationInfo private[spark]( val

[GitHub] spark pull request #18887: [SPARK-20642][core] Store FsHistoryProvider listi...

2017-08-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18887#discussion_r133001335 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -742,53 +698,145 @@ private[history] object FsHistoryProvider {

[GitHub] spark pull request #18887: [SPARK-20642][core] Store FsHistoryProvider listi...

2017-08-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18887#discussion_r133000455 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala --- @@ -76,6 +76,14 @@ private[history] case class

[GitHub] spark issue #18918: [SPARK-21707][SQL]Improvement a special case for non-det...

2017-08-14 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18918 Yes. We should fix it in `object PhysicalOperation` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #18920: [SPARK-19471][SQL]AggregationIterator does not in...

2017-08-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18920 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18920: [SPARK-19471][SQL]AggregationIterator does not initializ...

2017-08-14 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18920 Thanks! Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18920: [SPARK-19471][SQL]AggregationIterator does not initializ...

2017-08-14 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18920 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #18914: [MINOR][SQL][TEST]no uncache table in joinsuite t...

2017-08-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18914 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18940: YSPARK-734 Change CacheLoader to limit entries based on ...

2017-08-14 Thread dbolshak
Github user dbolshak commented on the issue: https://github.com/apache/spark/pull/18940 LGTM, btw, no unit tests for the change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18929: [MINOR][LAUNCHER]Reuse EXECUTOR_MEMORY and EXECUTOR_CORE...

2017-08-14 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/18929 They're there mainly to declare the constant as a public API that must not change. (I'm not sure whether mima captures changes in constant values, since that's a binary breaking change, but that's

[GitHub] spark issue #18914: [MINOR][SQL][TEST]no uncache table in joinsuite test

2017-08-14 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18914 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #18700: [SPARK-21499] [SQL] Support creating persistent f...

2017-08-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18700#discussion_r132996396 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1096,8 +1099,42 @@ class SessionCatalog(

[GitHub] spark pull request #18700: [SPARK-21499] [SQL] Support creating persistent f...

2017-08-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18700#discussion_r132994080 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1096,8 +1099,42 @@ class SessionCatalog(

[GitHub] spark issue #18895: [SPARK-21658][SQL][PYSPARK] Add default None for value i...

2017-08-14 Thread byakuinss
Github user byakuinss commented on the issue: https://github.com/apache/spark/pull/18895 Okay, I leave a comment in the issue page. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #9518: [SPARK-11574][Core] Add metrics StatsD sink

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9518 **[Test build #80638 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80638/testReport)** for PR 9518 at commit

[GitHub] spark issue #18866: [WIP][SPARK-21649][SQL] Support writing data into hive b...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18866 **[Test build #80637 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80637/testReport)** for PR 18866 at commit

[GitHub] spark issue #18895: [SPARK-21658][SQL][PYSPARK] Add default None for value i...

2017-08-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18895 Can you maybe leave any comment saying.. like .. "here is my JIRA account." in https://issues.apache.org/jira/browse/SPARK-21658 if you don't mind? --- If your project is set up for it, you

[GitHub] spark issue #18895: [SPARK-21658][SQL][PYSPARK] Add default None for value i...

2017-08-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18895 Hm.. weird. I can't search your account on JIRA ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #18907: [SPARK-18464][SQL][followup] support old table which doe...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18907 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18907: [SPARK-18464][SQL][followup] support old table which doe...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18907 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80630/ Test FAILed. ---

[GitHub] spark issue #18895: [SPARK-21658][SQL][PYSPARK] Add default None for value i...

2017-08-14 Thread byakuinss
Github user byakuinss commented on the issue: https://github.com/apache/spark/pull/18895 @HyukjinKwon Oh, do you mean my jira full name? It's `Chin Han Yu`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18907: [SPARK-18464][SQL][followup] support old table which doe...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18907 **[Test build #80630 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80630/testReport)** for PR 18907 at commit

[GitHub] spark issue #18926: [SPARK-21712] [PySpark] Clarify type error for Column.su...

2017-08-14 Thread nchammas
Github user nchammas commented on the issue: https://github.com/apache/spark/pull/18926 To summarize the feedback from @HyukjinKwon and @gatorsmile, I think what I need to do is: * Add a test for the mixed type case. * Explicitly check for `long` in Python 2 and throw a

[GitHub] spark issue #18940: YSPARK-734 Change CacheLoader to limit entries based on ...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18940 **[Test build #80636 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80636/testReport)** for PR 18940 at commit

[GitHub] spark issue #18468: [SPARK-20783][SQL] Create CachedBatchColumnVector to abs...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18468 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80629/ Test PASSed. ---

[GitHub] spark issue #18468: [SPARK-20783][SQL] Create CachedBatchColumnVector to abs...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18468 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #18895: [SPARK-21658][SQL][PYSPARK] Add default None for ...

2017-08-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18895 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18895: [SPARK-21658][SQL][PYSPARK] Add default None for value i...

2017-08-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18895 @byakuinss, BTW, do you mind if I ask your JIRA id? I want to assign this to you as you resolved this but I can't find the ID.. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #18940: YSPARK-734 Change CacheLoader to limit entries based on ...

2017-08-14 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/18940 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #18895: [SPARK-21658][SQL][PYSPARK] Add default None for value i...

2017-08-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18895 Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18468: [SPARK-20783][SQL] Create CachedBatchColumnVector to abs...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18468 **[Test build #80629 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80629/testReport)** for PR 18468 at commit

[GitHub] spark issue #18938: [SPARK-21363][SQL] Prevent name duplication in (global/l...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18938 **[Test build #80635 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80635/testReport)** for PR 18938 at commit

[GitHub] spark pull request #18930: [SPARK-21677][SQL] json_tuple throws NullPointExc...

2017-08-14 Thread jmchung
Github user jmchung commented on a diff in the pull request: https://github.com/apache/spark/pull/18930#discussion_r132984129 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -361,10 +361,18 @@ case class

[GitHub] spark pull request #18488: [SPARK-21255][SQL][WIP] Fixed NPE when creating e...

2017-08-14 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18488#discussion_r132983668 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionInfo.java --- @@ -79,7 +79,7 @@ public ExpressionInfo(

[GitHub] spark pull request #18855: [SPARK-3151] [Block Manager] DiskStore.getBytes f...

2017-08-14 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18855#discussion_r132982799 --- Diff: project/SparkBuild.scala --- @@ -790,7 +790,7 @@ object TestSettings { javaOptions in Test ++=

[GitHub] spark issue #18930: [SPARK-21677][SQL] json_tuple throws NullPointException ...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18930 **[Test build #80634 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80634/testReport)** for PR 18930 at commit

[GitHub] spark issue #18940: YSPARK-734 Change CacheLoader to limit entries based on ...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18940 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #18940: YSPARK-734 Change CacheLoader to limit entries ba...

2017-08-14 Thread redsanket
GitHub user redsanket opened a pull request: https://github.com/apache/spark/pull/18940 YSPARK-734 Change CacheLoader to limit entries based on memory footprint Right now the spark shuffle service has a cache for index files. It is based on a # of files cached

[GitHub] spark pull request #18855: [SPARK-3151] [Block Manager] DiskStore.getBytes f...

2017-08-14 Thread eyalfa
Github user eyalfa commented on a diff in the pull request: https://github.com/apache/spark/pull/18855#discussion_r132978316 --- Diff: project/SparkBuild.scala --- @@ -790,7 +790,7 @@ object TestSettings { javaOptions in Test ++=

[GitHub] spark issue #18895: [SPARK-21658][SQL][PYSPARK] Add default None for value i...

2017-08-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18895 LGTM too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #18895: [SPARK-21658][SQL][PYSPARK] Add default None for value i...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18895 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18895: [SPARK-21658][SQL][PYSPARK] Add default None for value i...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18895 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80633/ Test PASSed. ---

[GitHub] spark issue #18895: [SPARK-21658][SQL][PYSPARK] Add default None for value i...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18895 **[Test build #80633 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80633/testReport)** for PR 18895 at commit

[GitHub] spark issue #18913: [SPARK-21563][CORE] Fix race condition when serializing ...

2017-08-14 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18913 LGTM, merging to master/2.2! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18895: [SPARK-21658][SQL][PYSPARK] Add default None for value i...

2017-08-14 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18895 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #18913: [SPARK-21563][CORE] Fix race condition when seria...

2017-08-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18913 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18488: [SPARK-21255][SQL][WIP] Fixed NPE when creating encoder ...

2017-08-14 Thread mike0sv
Github user mike0sv commented on the issue: https://github.com/apache/spark/pull/18488 @srowen @HyukjinKwon it seems like it's all ok now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18895: [SPARK-21658][SQL][PYSPARK] Add default None for value i...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18895 **[Test build #80633 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80633/testReport)** for PR 18895 at commit

[GitHub] spark pull request #18895: [SPARK-21658][SQL][PYSPARK] Add default None for ...

2017-08-14 Thread byakuinss
Github user byakuinss commented on a diff in the pull request: https://github.com/apache/spark/pull/18895#discussion_r132968529 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1403,6 +1403,16 @@ def replace(self, to_replace, value=None, subset=None): |null|

[GitHub] spark pull request #18895: [SPARK-21658][SQL][PYSPARK] Add default None for ...

2017-08-14 Thread byakuinss
Github user byakuinss commented on a diff in the pull request: https://github.com/apache/spark/pull/18895#discussion_r132968408 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1837,8 +1847,8 @@ def fill(self, value, subset=None): fill.__doc__ =

[GitHub] spark issue #18895: [SPARK-21658][SQL][PYSPARK] Add default None for value i...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18895 **[Test build #80632 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80632/testReport)** for PR 18895 at commit

[GitHub] spark issue #18895: [SPARK-21658][SQL][PYSPARK] Add default None for value i...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18895 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80632/ Test FAILed. ---

[GitHub] spark issue #18895: [SPARK-21658][SQL][PYSPARK] Add default None for value i...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18895 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18895: [SPARK-21658][SQL][PYSPARK] Add default None for value i...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18895 **[Test build #80632 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80632/testReport)** for PR 18895 at commit

[GitHub] spark issue #18939: [SPARK-21724][SQL][DOC] Adds since information in the do...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18939 **[Test build #80631 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80631/testReport)** for PR 18939 at commit

[GitHub] spark issue #18939: [WIP][SPARK-21724][SQL][DOC] Adds since information in t...

2017-08-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18939 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #18855: [SPARK-3151] [Block Manager] DiskStore.getBytes f...

2017-08-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18855#discussion_r132964212 --- Diff: project/SparkBuild.scala --- @@ -790,7 +790,7 @@ object TestSettings { javaOptions in Test ++=

[GitHub] spark issue #18907: [SPARK-18464][SQL][followup] support old table which doe...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18907 **[Test build #80630 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80630/testReport)** for PR 18907 at commit

[GitHub] spark pull request #18700: [SPARK-21499] [SQL] Support creating persistent f...

2017-08-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18700#discussion_r132961933 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1096,8 +1099,42 @@ class SessionCatalog(

[GitHub] spark pull request #18700: [SPARK-21499] [SQL] Support creating persistent f...

2017-08-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18700#discussion_r132961262 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1096,8 +1099,42 @@ class SessionCatalog(

[GitHub] spark issue #18939: [WIP][SPARK-21724][SQL][DOC] Adds since information in t...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18939 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80626/ Test FAILed. ---

[GitHub] spark issue #18939: [WIP][SPARK-21724][SQL][DOC] Adds since information in t...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18939 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18939: [WIP][SPARK-21724][SQL][DOC] Adds since information in t...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18939 **[Test build #80626 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80626/testReport)** for PR 18939 at commit

[GitHub] spark issue #18918: [SPARK-21707][SQL]Improvement a special case for non-det...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18918 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80628/ Test PASSed. ---

[GitHub] spark issue #18918: [SPARK-21707][SQL]Improvement a special case for non-det...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18918 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18918: [SPARK-21707][SQL]Improvement a special case for non-det...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18918 **[Test build #80628 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80628/testReport)** for PR 18918 at commit

[GitHub] spark issue #18920: [SPARK-19471][SQL]AggregationIterator does not initializ...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18920 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80625/ Test PASSed. ---

[GitHub] spark issue #18920: [SPARK-19471][SQL]AggregationIterator does not initializ...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18920 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18920: [SPARK-19471][SQL]AggregationIterator does not initializ...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18920 **[Test build #80625 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80625/testReport)** for PR 18920 at commit

[GitHub] spark issue #18934: [SPARK-21721][SQL] Clear FileSystem deleteOnExit cache w...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18934 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80627/ Test PASSed. ---

[GitHub] spark issue #18934: [SPARK-21721][SQL] Clear FileSystem deleteOnExit cache w...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18934 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18934: [SPARK-21721][SQL] Clear FileSystem deleteOnExit cache w...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18934 **[Test build #80627 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80627/testReport)** for PR 18934 at commit

[GitHub] spark issue #18468: [SPARK-20783][SQL] Create CachedBatchColumnVector to abs...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18468 **[Test build #80629 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80629/testReport)** for PR 18468 at commit

[GitHub] spark issue #18468: [SPARK-20783][SQL] Create CachedBatchColumnVector to abs...

2017-08-14 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18468 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #18938: [SPARK-21363][SQL] Prevent name duplication in (global/l...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18938 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80624/ Test FAILed. ---

[GitHub] spark issue #18938: [SPARK-21363][SQL] Prevent name duplication in (global/l...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18938 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18938: [SPARK-21363][SQL] Prevent name duplication in (global/l...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18938 **[Test build #80624 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80624/testReport)** for PR 18938 at commit

[GitHub] spark pull request #18902: [SPARK-21690][ML] one-pass imputer

2017-08-14 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/18902#discussion_r132939361 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala --- @@ -133,23 +134,29 @@ class Imputer @Since("2.2.0") (@Since("2.2.0") override

[GitHub] spark pull request #18902: [SPARK-21690][ML] one-pass imputer

2017-08-14 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/18902#discussion_r132939323 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala --- @@ -133,23 +134,29 @@ class Imputer @Since("2.2.0") (@Since("2.2.0") override

[GitHub] spark issue #18929: [MINOR][LAUNCHER]Reuse EXECUTOR_MEMORY and EXECUTOR_CORE...

2017-08-14 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18929 Maybe @vanzin can weigh in here, because the real question is whether these constants in the launcher module are meant to be _the_ single definition of them used throughout the code. core depends on

[GitHub] spark issue #18920: [SPARK-19471][SQL]AggregationIterator does not initializ...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18920 **[Test build #80625 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80625/testReport)** for PR 18920 at commit

[GitHub] spark issue #18939: [WIP][SPARK-21724][SQL][DOC] Adds since information in t...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18939 **[Test build #80626 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80626/testReport)** for PR 18939 at commit

[GitHub] spark issue #18918: [SPARK-21707][SQL]Improvement a special case for non-det...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18918 **[Test build #80628 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80628/testReport)** for PR 18918 at commit

[GitHub] spark issue #18934: [SPARK-21721][SQL] Clear FileSystem deleteOnExit cache w...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18934 **[Test build #80627 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80627/testReport)** for PR 18934 at commit

[GitHub] spark issue #18938: [SPARK-21363][SQL] Prevent name duplication in (global/l...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18938 **[Test build #80624 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80624/testReport)** for PR 18938 at commit

[GitHub] spark issue #18937: [MINOR] Remove false comment from planStreamingAggregati...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18937 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18937: [MINOR] Remove false comment from planStreamingAggregati...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18937 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80623/ Test PASSed. ---

[GitHub] spark issue #18937: [MINOR] Remove false comment from planStreamingAggregati...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18937 **[Test build #80623 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80623/testReport)** for PR 18937 at commit

[GitHub] spark issue #18933: [WIP][SPARK-21722][SQL][PYTHON] Enable timezone-aware ti...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18933 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18933: [WIP][SPARK-21722][SQL][PYTHON] Enable timezone-aware ti...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18933 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80622/ Test PASSed. ---

[GitHub] spark issue #18933: [WIP][SPARK-21722][SQL][PYTHON] Enable timezone-aware ti...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18933 **[Test build #80622 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80622/testReport)** for PR 18933 at commit

[GitHub] spark issue #18630: [SPARK-12559][SPARK SUBMIT] fix --packages for stand-alo...

2017-08-14 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/18630 @vanzin I dont forgot I didnt see agreement. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18935: [SPARK-9104][CORE] Expose Netty memory metrics in Spark

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18935 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18935: [SPARK-9104][CORE] Expose Netty memory metrics in Spark

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18935 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80618/ Test FAILed. ---

[GitHub] spark pull request #18918: [SPARK-21707][SQL]Improvement a special case for ...

2017-08-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18918#discussion_r132921051 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -522,6 +522,8 @@ object ColumnPruning extends

[GitHub] spark issue #18935: [SPARK-9104][CORE] Expose Netty memory metrics in Spark

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18935 **[Test build #80618 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80618/testReport)** for PR 18935 at commit

[GitHub] spark pull request #18918: [SPARK-21707][SQL]Improvement a special case for ...

2017-08-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18918#discussion_r132919858 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ColumnPruningSuite.scala --- @@ -360,5 +360,34 @@ class ColumnPruningSuite

[GitHub] spark issue #18929: [MINOR][LAUNCHER]Reuse EXECUTOR_MEMORY and EXECUTOR_CORE...

2017-08-14 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/18929 @srowen @jerryshao --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

<    1   2   3   4   5   >