[GitHub] spark pull request #19325: [SPARK-22106][PYSPARK][SQL] Disable 0-parameter p...

2017-09-25 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/19325#discussion_r140852903 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowEvalPythonExec.scala --- @@ -51,10 +51,12 @@ case class

[GitHub] spark issue #19295: [SPARK-22080][SQL] Adds support for allowing user to add...

2017-09-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19295 Sorry, we do not expect users to add rules before our internal optimizer rules finish, as I explained above. To avoid the potential issues, I suggest to close it. ---

[GitHub] spark issue #19327: [WIP] Implement stream-stream outer joins.

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19327 **[Test build #82157 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82157/testReport)** for PR 19327 at commit

[GitHub] spark pull request #19325: [SPARK-22106][PYSPARK][SQL] Disable 0-parameter p...

2017-09-25 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/19325#discussion_r140849264 --- Diff: python/pyspark/sql/tests.py --- @@ -3308,12 +3306,12 @@ def test_vectorized_udf_invalid_length(self): from pyspark.sql.functions

[GitHub] spark pull request #19325: [SPARK-22106][PYSPARK][SQL] Disable 0-parameter p...

2017-09-25 Thread shaneknapp
Github user shaneknapp commented on a diff in the pull request: https://github.com/apache/spark/pull/19325#discussion_r140848562 --- Diff: python/pyspark/sql/functions.py --- @@ -2183,14 +2183,29 @@ def pandas_udf(f=None, returnType=StringType()): :param f: python function

[GitHub] spark issue #19327: [WIP] Implement stream-stream outer joins.

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19327 **[Test build #82156 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82156/testReport)** for PR 19327 at commit

[GitHub] spark issue #19341: [SPARK-22120][SQL] TestHiveSparkSession.reset() should c...

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19341 **[Test build #3935 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3935/testReport)** for PR 19341 at commit

[GitHub] spark issue #19341: [SPARK-22120][SQL] TestHiveSparkSession.reset() should c...

2017-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19341 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19341: [SPARK-22120][SQL] TestHiveSparkSession.reset() s...

2017-09-25 Thread GregOwen
GitHub user GregOwen opened a pull request: https://github.com/apache/spark/pull/19341 [SPARK-22120][SQL] TestHiveSparkSession.reset() should clean out Hive warehouse directory ## What changes were proposed in this pull request? During TestHiveSparkSession.reset(), which is

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2017-09-25 Thread brad-kaiser
Github user brad-kaiser commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r140841617 --- Diff: core/src/main/scala/org/apache/spark/RecoverCacheShutdown.scala --- @@ -0,0 +1,234 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #18887: [SPARK-20642][core] Store FsHistoryProvider listing data...

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18887 **[Test build #82155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82155/testReport)** for PR 18887 at commit

[GitHub] spark pull request #19325: [SPARK-22106][PYSPARK][SQL] Disable 0-parameter p...

2017-09-25 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/19325#discussion_r140837024 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowEvalPythonExec.scala --- @@ -51,10 +51,12 @@ case class

[GitHub] spark pull request #19325: [SPARK-22106][PYSPARK][SQL] Disable 0-parameter p...

2017-09-25 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/19325#discussion_r140836046 --- Diff: python/pyspark/sql/tests.py --- @@ -3344,6 +3342,22 @@ def test_vectorized_udf_wrong_return_type(self):

[GitHub] spark pull request #19325: [SPARK-22106][PYSPARK][SQL] Disable 0-parameter p...

2017-09-25 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/19325#discussion_r140835837 --- Diff: python/pyspark/worker.py --- @@ -80,14 +77,12 @@ def wrap_pandas_udf(f, return_type): arrow_return_type = toArrowType(return_type)

[GitHub] spark pull request #19325: [SPARK-22106][PYSPARK][SQL] Disable 0-parameter p...

2017-09-25 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/19325#discussion_r140834562 --- Diff: python/pyspark/sql/functions.py --- @@ -2183,14 +2183,29 @@ def pandas_udf(f=None, returnType=StringType()): :param f: python

[GitHub] spark pull request #19325: [SPARK-22106][PYSPARK][SQL] Disable 0-parameter p...

2017-09-25 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/19325#discussion_r140834239 --- Diff: python/pyspark/sql/functions.py --- @@ -2183,14 +2183,29 @@ def pandas_udf(f=None, returnType=StringType()): :param f: python

[GitHub] spark pull request #19340: [SPARK-22119] Add cosine distance to KMeans

2017-09-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r140833485 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +574,88 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19340: [SPARK-22119] Add cosine distance to KMeans

2017-09-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r140832224 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -260,7 +269,8 @@ class KMeans @Since("1.5.0") ( maxIter -> 20,

[GitHub] spark pull request #19340: [SPARK-22119] Add cosine distance to KMeans

2017-09-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r14083 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +574,88 @@ object KMeans { .run(data) }

[GitHub] spark issue #19324: [SPARK-22103] Move HashAggregateExec parent consume to a...

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19324 **[Test build #82153 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82153/testReport)** for PR 19324 at commit

[GitHub] spark issue #18887: [SPARK-20642][core] Store FsHistoryProvider listing data...

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18887 **[Test build #82154 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82154/testReport)** for PR 18887 at commit

[GitHub] spark pull request #19340: [SPARK-22119] Add cosine distance to KMeans

2017-09-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r140833252 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +574,88 @@ object KMeans { .run(data) }

[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support date/...

2017-09-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19321 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19340: [SPARK-22119] Add cosine distance to KMeans

2017-09-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r140832619 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -40,20 +40,29 @@ import org.apache.spark.util.random.XORShiftRandom

[GitHub] spark pull request #19340: [SPARK-22119] Add cosine distance to KMeans

2017-09-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r140832427 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -71,6 +71,15 @@ private[clustering] trait KMeansParams extends Params

[GitHub] spark pull request #19325: [SPARK-22106][PYSPARK][SQL] Disable 0-parameter p...

2017-09-25 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/19325#discussion_r140833446 --- Diff: python/pyspark/serializers.py --- @@ -246,15 +243,9 @@ def cast_series(s, t): def loads(self, obj): """

[GitHub] spark pull request #19325: [SPARK-22106][PYSPARK][SQL] Disable 0-parameter p...

2017-09-25 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/19325#discussion_r140833242 --- Diff: python/pyspark/sql/functions.py --- @@ -2183,14 +2183,29 @@ def pandas_udf(f=None, returnType=StringType()): :param f: python

[GitHub] spark issue #19324: [SPARK-22103] Move HashAggregateExec parent consume to a...

2017-09-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19324 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #18887: [SPARK-20642][core] Store FsHistoryProvider listi...

2017-09-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18887#discussion_r140831910 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -742,53 +703,150 @@ private[history] object FsHistoryProvider {

[GitHub] spark issue #19020: [SPARK-3181] [ML] Implement huber loss for LinearRegress...

2017-09-25 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/19020 @yanboliang Yeah, I saw the discussion and it seems to me the reason was: there would be too much code duplication. Sure, it's true that there would be code duplication, but to me that's a reason to

[GitHub] spark pull request #18887: [SPARK-20642][core] Store FsHistoryProvider listi...

2017-09-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18887#discussion_r140831195 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -720,75 +634,218 @@ private[history] class

[GitHub] spark pull request #19272: [Spark-21842][Mesos] Support Kerberos ticket rene...

2017-09-25 Thread kalvinnchau
Github user kalvinnchau commented on a diff in the pull request: https://github.com/apache/spark/pull/19272#discussion_r140830852 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -194,6

[GitHub] spark pull request #18887: [SPARK-20642][core] Store FsHistoryProvider listi...

2017-09-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18887#discussion_r140830146 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -422,208 +457,101 @@ private[history] class

[GitHub] spark issue #18034: [SPARK-20797][MLLIB]fix LocalLDAModel.save() bug.

2017-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18034 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19340: [SPARK-22119] Add cosine distance to KMeans

2017-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19340 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19340: [SPARK-22119] Add cosine distance to KMeans

2017-09-25 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/19340 [SPARK-22119] Add cosine distance to KMeans ## What changes were proposed in this pull request? Currently, KMeans assumes the only possible distance measure to be used is the Euclidean.

[GitHub] spark pull request #18887: [SPARK-20642][core] Store FsHistoryProvider listi...

2017-09-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18887#discussion_r140828783 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -422,208 +457,101 @@ private[history] class

[GitHub] spark pull request #19321: [SPARK-22100] [SQL] Make percentile_approx suppor...

2017-09-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19321 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18887: [SPARK-20642][core] Store FsHistoryProvider listi...

2017-09-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18887#discussion_r140828412 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -422,208 +457,101 @@ private[history] class

[GitHub] spark pull request #18887: [SPARK-20642][core] Store FsHistoryProvider listi...

2017-09-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18887#discussion_r140828145 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala --- @@ -624,7 +639,9 @@ class FsHistoryProviderSuite extends

[GitHub] spark pull request #17902: [SPARK-20641][core] Add key-value store abstracti...

2017-09-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17902#discussion_r140827076 --- Diff: common/kvstore/src/main/java/org/apache/spark/kvstore/KVStoreSerializer.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support date/...

2017-09-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19321 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19339: [SPARK-22112][PYSPARK] Add an API to create a Dat...

2017-09-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19339#discussion_r140825203 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -456,6 +456,40 @@ class DataFrameReader

[GitHub] spark pull request #19338: [SPARK-21539][CORE] Add latest failure reason for...

2017-09-25 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19338#discussion_r140823560 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetBlacklist.scala --- @@ -94,7 +96,9 @@ private[scheduler] class TaskSetBlacklist(val conf:

[GitHub] spark pull request #19338: [SPARK-21539][CORE] Add latest failure reason for...

2017-09-25 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19338#discussion_r140823764 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -838,7 +840,7 @@ private[spark] class TaskSetManager( if

[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support date/...

2017-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19321 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support date/...

2017-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19321 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82149/ Test PASSed. ---

[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support date/...

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19321 **[Test build #82149 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82149/testReport)** for PR 19321 at commit

[GitHub] spark issue #19338: [SPARK-21539][CORE] Add latest failure reason for task s...

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19338 **[Test build #82152 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82152/testReport)** for PR 19338 at commit

[GitHub] spark issue #19338: [SPARK-21539][CORE] Add latest failure reason for task s...

2017-09-25 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/19338 @caneGuy thanks for working on this, looks very reasonable to me, I am going to take a closer look at a couple of details. But can you make a couple of updates in the meantime: 1) Can you

[GitHub] spark issue #19338: [SPARK-21539][CORE] Add latest failure reason for task s...

2017-09-25 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/19338 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #16548: [SPARK-19158][SPARKR][EXAMPLES] Fix ml.R example fails d...

2017-09-25 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/16548 @holdenk Could you let me know where we meet similar issue in the fulltests? AFAIK, we test functions in ```e1071``` only when it was installed on that node, like following: ``` if

[GitHub] spark issue #19339: [SPARK-22112][PYSPARK] Add an API to create a DataFrame ...

2017-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19339 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19339: [SPARK-22112][PYSPARK] Add an API to create a DataFrame ...

2017-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19339 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82148/ Test PASSed. ---

[GitHub] spark issue #19339: [SPARK-22112][PYSPARK] Add an API to create a DataFrame ...

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19339 **[Test build #82148 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82148/testReport)** for PR 19339 at commit

[GitHub] spark issue #19020: [SPARK-3181] [ML] Implement huber loss for LinearRegress...

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19020 **[Test build #82151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82151/testReport)** for PR 19020 at commit

[GitHub] spark issue #19020: [SPARK-3181] [ML] Implement huber loss for LinearRegress...

2017-09-25 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/19020 Jenkins, test this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19311: [SPARK-22083][CORE] Release locks in MemoryStore.evictBl...

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19311 **[Test build #82150 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82150/testReport)** for PR 19311 at commit

[GitHub] spark pull request #19311: [SPARK-22083][CORE] Release locks in MemoryStore....

2017-09-25 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19311#discussion_r140815961 --- Diff: core/src/test/scala/org/apache/spark/storage/MemoryStoreSuite.scala --- @@ -407,4 +407,119 @@ class MemoryStoreSuite })

[GitHub] spark pull request #19311: [SPARK-22083][CORE] Release locks in MemoryStore....

2017-09-25 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/19311#discussion_r140815652 --- Diff: core/src/test/scala/org/apache/spark/storage/MemoryStoreSuite.scala --- @@ -407,4 +407,119 @@ class MemoryStoreSuite })

[GitHub] spark pull request #19311: [SPARK-22083][CORE] Release locks in MemoryStore....

2017-09-25 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19311#discussion_r140813788 --- Diff: core/src/test/scala/org/apache/spark/storage/MemoryStoreSuite.scala --- @@ -407,4 +407,119 @@ class MemoryStoreSuite })

[GitHub] spark pull request #18853: [SPARK-21646][SQL] CommonType for binary comparis...

2017-09-25 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/18853#discussion_r140802924 --- Diff: docs/sql-programming-guide.md --- @@ -1460,6 +1460,13 @@ that these options will be deprecated in future release as more optimizations ar

[GitHub] spark pull request #18853: [SPARK-21646][SQL] CommonType for binary comparis...

2017-09-25 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/18853#discussion_r140799432 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -115,21 +115,46 @@ object TypeCoercion { *

[GitHub] spark pull request #18853: [SPARK-21646][SQL] CommonType for binary comparis...

2017-09-25 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/18853#discussion_r140801036 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2677,4 +2677,142 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request #18853: [SPARK-21646][SQL] CommonType for binary comparis...

2017-09-25 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/18853#discussion_r140797299 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2677,4 +2677,142 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark issue #18704: [SPARK-20783][SQL] Create ColumnVector to abstract exist...

2017-09-25 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18704 ping @cloud-fan & @michal-databricks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19287: [SPARK-22074][Core] Task killed by other attempt ...

2017-09-25 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/19287#discussion_r140788231 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala --- @@ -93,6 +104,8 @@ class TaskInfo( def running: Boolean =

[GitHub] spark pull request #19339: [SPARK-22112][PYSPARK] Add an API to create a Dat...

2017-09-25 Thread goldmedal
Github user goldmedal commented on a diff in the pull request: https://github.com/apache/spark/pull/19339#discussion_r140779203 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -456,6 +456,40 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark pull request #17902: [SPARK-20641][core] Add key-value store abstracti...

2017-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17902#discussion_r140776929 --- Diff: common/kvstore/src/main/java/org/apache/spark/kvstore/KVStoreSerializer.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #19287: [SPARK-22074][Core] Task killed by other attempt task sh...

2017-09-25 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19287 @jerryshao --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19287: [SPARK-22074][Core] Task killed by other attempt ...

2017-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19287#discussion_r140776344 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala --- @@ -93,6 +104,8 @@ class TaskInfo( def running: Boolean =

[GitHub] spark pull request #19287: [SPARK-22074][Core] Task killed by other attempt ...

2017-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19287#discussion_r140776152 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala --- @@ -66,6 +66,13 @@ class TaskInfo( */ var finishTime: Long = 0

[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support date/...

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19321 **[Test build #82149 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82149/testReport)** for PR 19321 at commit

[GitHub] spark issue #19339: [SPARK-22112][PYSPARK] Add an API to create a DataFrame ...

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19339 **[Test build #82148 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82148/testReport)** for PR 19339 at commit

[GitHub] spark issue #19339: [SPARK-22112][PYSPARK] Add an API to create a DataFrame ...

2017-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19339 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19339: [SPARK-22112][PYSPARK] Add an API to create a Dat...

2017-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19339#discussion_r140771519 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -456,6 +456,40 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark issue #19175: [SPARK-21964][SQL]Enable splitting the Aggregate (on Exp...

2017-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19175 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82146/ Test PASSed. ---

[GitHub] spark issue #19175: [SPARK-21964][SQL]Enable splitting the Aggregate (on Exp...

2017-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19175 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19175: [SPARK-21964][SQL]Enable splitting the Aggregate (on Exp...

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19175 **[Test build #82146 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82146/testReport)** for PR 19175 at commit

[GitHub] spark issue #19339: [SPARK-22112][PYSPARK] Add an API to create a DataFrame ...

2017-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19339 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19339: [SPARK-22112][PYSPARK] Add an API to create a DataFrame ...

2017-09-25 Thread goldmedal
Github user goldmedal commented on the issue: https://github.com/apache/spark/pull/19339 @HyukjinKwon @viirya Could you review this PR? Thanks! :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #19339: [SPARK-22112][PYSPARK] Add an API to create a Dat...

2017-09-25 Thread goldmedal
GitHub user goldmedal opened a pull request: https://github.com/apache/spark/pull/19339 [SPARK-22112][PYSPARK] Add an API to create a DataFrame from RDD[String] storing CSV ## What changes were proposed in this pull request? We added a method to the scala API for creating a

[GitHub] spark pull request #19321: [SPARK-22100] [SQL] Make percentile_approx suppor...

2017-09-25 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/19321#discussion_r140764796 --- Diff: docs/sql-programming-guide.md --- @@ -1553,6 +1553,7 @@ options. ## Upgrading From Spark SQL 2.2 to 2.3 - Since Spark 2.3, the

[GitHub] spark issue #19337: [SPARK-22114][ML][MLLIB]add epsilon for LDA

2017-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19337 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19337: [SPARK-22114][ML][MLLIB]add epsilon for LDA

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19337 **[Test build #82147 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82147/testReport)** for PR 19337 at commit

[GitHub] spark issue #19337: [SPARK-22114][ML][MLLIB]add epsilon for LDA

2017-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19337 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82147/ Test PASSed. ---

[GitHub] spark issue #19338: [SPARK-21539][CORE] Add latest failure reason for task s...

2017-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19338 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19338: [SPARK-21539][CORE] Add latest failure reason for task s...

2017-09-25 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/19338 @squito Could you help review this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19338: [SPARK-21539][CORE] Add latest failure reason for...

2017-09-25 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/19338 [SPARK-21539][CORE] Add latest failure reason for task set blacklist ## What changes were proposed in this pull request? This patch add latest failure reason for task set blacklist.Which can be

[GitHub] spark issue #19287: [SPARK-22074][Core] Task killed by other attempt task sh...

2017-09-25 Thread xuanyuanking
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/19287 ping @cloud-fan @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19337: [SPARK-22114][ML][MLLIB]add epsilon for LDA

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19337 **[Test build #82147 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82147/testReport)** for PR 19337 at commit

[GitHub] spark pull request #19175: [SPARK-21964][SQL]Enable splitting the Aggregate ...

2017-09-25 Thread DonnyZone
Github user DonnyZone commented on a diff in the pull request: https://github.com/apache/spark/pull/19175#discussion_r140741265 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1287,3 +1288,33 @@ object

[GitHub] spark pull request #19175: [SPARK-21964][SQL]Enable splitting the Aggregate ...

2017-09-25 Thread DonnyZone
Github user DonnyZone commented on a diff in the pull request: https://github.com/apache/spark/pull/19175#discussion_r140741053 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1287,3 +1288,33 @@ object

[GitHub] spark issue #19175: [SPARK-21964][SQL]Enable splitting the Aggregate (on Exp...

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19175 **[Test build #82146 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82146/testReport)** for PR 19175 at commit

[GitHub] spark issue #19337: [SPARK-22114][ML][MLLIB]add epsilon for LDA

2017-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19337 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19337: [SPARK-22114][ML][MLLIB]add epsilon for LDA

2017-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19337 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82144/ Test FAILed. ---

[GitHub] spark issue #19337: [SPARK-22114][ML][MLLIB]add epsilon for LDA

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19337 **[Test build #82144 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82144/testReport)** for PR 19337 at commit

[GitHub] spark issue #19175: [SPARK-21964][SQL]Enable splitting the Aggregate (on Exp...

2017-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19175 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19175: [SPARK-21964][SQL]Enable splitting the Aggregate (on Exp...

2017-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19175 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82145/ Test FAILed. ---

[GitHub] spark issue #19175: [SPARK-21964][SQL]Enable splitting the Aggregate (on Exp...

2017-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19175 **[Test build #82145 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82145/testReport)** for PR 19175 at commit

<    1   2   3   4   >